DGNum/gestioCOF
14
2
Fork 1
Code Issues 78 Pull requests 14 Projects Releases 12 Packages Wiki Activity

Thubrecht/daphne #815

Merged
thubrecht merged 39 commits from thubrecht/daphne into master 2024-07-30 18:40:56 +02:00
Conversation 32 Commits 39 Files changed 89 +753 -376
thubrecht commented 2022-06-29 09:21:41 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Passage à django 3.2 et channels 3.x

Closes #300

Passage à django 3.2 et channels 3.x Closes #300
thubrecht commented 2022-06-29 09:21:42 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

assigned to @thubrecht

assigned to @thubrecht
thubrecht commented 2022-06-29 11:12:09 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 15 commits

  • 69de48f2 - 1 commit from branch master
  • a664a81b - Fix vagrant setup w/ daphne
  • 493600d3 - Fix black complaints
  • f5e5babf - Update to django channels 2
  • 87deb0f3 - Update daphne version
  • fbd31d0c - Add default http router
  • c0e2a96d - Update base consumers
  • 215c5a4e - Update django version
  • 2126a19d - Update django-redis-cache and fix vagrant setup
  • 0fb6e0ec - keyOrder is deprecated, using a list in Meta gives the correct order
  • 2bef0167 - Fix app import
  • 9939233d - Add default django asgi handler
  • 6d035a33 - Channels 3
  • a2837842 - Simplify group_send for kpsul
  • 980e91ab - Fix kpsul tests

Compare with previous version

added 15 commits <ul><li>69de48f2 - 1 commit from branch <code>master</code></li><li>a664a81b - Fix vagrant setup w/ daphne</li><li>493600d3 - Fix black complaints</li><li>f5e5babf - Update to django channels 2</li><li>87deb0f3 - Update daphne version</li><li>fbd31d0c - Add default http router</li><li>c0e2a96d - Update base consumers</li><li>215c5a4e - Update django version</li><li>2126a19d - Update django-redis-cache and fix vagrant setup</li><li>0fb6e0ec - keyOrder is deprecated, using a list in Meta gives the correct order</li><li>2bef0167 - Fix app import</li><li>9939233d - Add default django asgi handler</li><li>6d035a33 - Channels 3</li><li>a2837842 - Simplify group_send for kpsul</li><li>980e91ab - Fix kpsul tests</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4010&start_sha=74c370520e5e852dc8d43dd52971c377707a4d60)
thubrecht commented 2022-06-29 13:34:56 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 6d37d435 - Fix kfet.ope tests

Compare with previous version

added 1 commit <ul><li>6d37d435 - Fix kfet.ope tests</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4012&start_sha=980e91abfc8448f5a842c55b852d505b2404ee45)
thubrecht commented 2022-06-29 14:37:33 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 1f5f7ce0 - Update redis, and implement a custom channel layer to send datetime/decimal objects

Compare with previous version

added 1 commit <ul><li>1f5f7ce0 - Update redis, and implement a custom channel layer to send datetime/decimal objects</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4014&start_sha=6d37d435347d84bf35fc3fc24cfd298ce6a0fd63)
thubrecht commented 2022-06-29 16:17:23 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 4 commits

  • 9f64f0a7 - ugettext -> gettext
  • 9d55fc14 - Change backend name as the old one is deprecated
  • fd33fb53 - Update django-djconfig
  • 9be3f9ab - Remove default_app_config

Compare with previous version

added 4 commits <ul><li>9f64f0a7 - ugettext -&gt; gettext</li><li>9d55fc14 - Change backend name as the old one is deprecated</li><li>fd33fb53 - Update django-djconfig</li><li>9be3f9ab - Remove default_app_config</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4016&start_sha=1f5f7ce0e9af64a2cf36e4c4658a64b24a5f1462)
thubrecht commented 2022-06-30 09:18:21 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • c978446d - Update kfet.open tests

Compare with previous version

added 1 commit <ul><li>c978446d - Update kfet.open tests</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4018&start_sha=9be3f9abb79bee74cadce933bef1fe718744d04e)
thubrecht commented 2022-06-30 09:39:11 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • fd8d11ad - Try to flush old messages in tests

Compare with previous version

added 1 commit <ul><li>fd8d11ad - Try to flush old messages in tests</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4020&start_sha=c978446db02f67868f62a5b88c351a722f80bf4b)
thubrecht commented 2022-06-30 09:54:35 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • c6309d05 - Try not running tests in parallel

Compare with previous version

added 1 commit <ul><li>c6309d05 - Try not running tests in parallel</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4022&start_sha=fd8d11adbdab7bdca8891ef4fa1e39062e45a5cf)
thubrecht commented 2022-06-30 10:02:36 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 9b177e62 - Only run kf tests in sequential mode (to fix issues with channels)

Compare with previous version

added 1 commit <ul><li>9b177e62 - Only run kf tests in sequential mode (to fix issues with channels)</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4024&start_sha=c6309d0591ab94348adaf3c29fecd99a11078d4d)
thubrecht commented 2022-06-30 10:05:58 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • a19cb356 - Fix typo

Compare with previous version

added 1 commit <ul><li>a19cb356 - Fix typo</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4025&start_sha=9b177e62c135160cd744fbee7d1a84f569348628)
thubrecht commented 2022-06-30 10:18:28 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 2 commits

  • 26d80e00 - cof has been renamed to gestioasso
  • e2dcb479 - Update changelog

Compare with previous version

added 2 commits <ul><li>26d80e00 - cof has been renamed to gestioasso</li><li>e2dcb479 - Update changelog</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4027&start_sha=a19cb356f01402fe6f6c8749e12a6a0c25707a74)
thubrecht commented 2022-06-30 12:15:16 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 6 commits

  • fd7c9a5d - Replace unique_together by UniqueConstraint
  • 182287b1 - url -> re_path
  • f773dd74 - Use AutoField instead of BigAutoField
  • f6b813cd - assertEquals is deprecated
  • a6f9a989 - Explicitely set transform=repr in assertQuerysetEquals
  • 2ac22804 - assertDictContainsSubset is deprecated

Compare with previous version

added 6 commits <ul><li>fd7c9a5d - Replace unique_together by UniqueConstraint</li><li>182287b1 - url -&gt; re_path</li><li>f773dd74 - Use AutoField instead of BigAutoField</li><li>f6b813cd - assertEquals is deprecated</li><li>a6f9a989 - Explicitely set transform=repr in assertQuerysetEquals</li><li>2ac22804 - assertDictContainsSubset is deprecated</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4029&start_sha=e2dcb4797c96a2926bbcf9500cec91fd9becd409)
thubrecht commented 2022-06-30 12:29:23 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 49f5e9ef - Update django-hCaptcha

Compare with previous version

added 1 commit <ul><li>49f5e9ef - Update django-hCaptcha</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4031&start_sha=2ac228040e899a960bfa22813b34a051fe9e43eb)
thubrecht commented 2022-06-30 12:29:56 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

marked this merge request as ready

marked this merge request as **ready**
thubrecht commented 2022-06-30 12:31:03 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed the description

changed the description
thubrecht commented 2022-06-30 12:46:22 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • d1e35b30 - Remove useless migrations

Compare with previous version

added 1 commit <ul><li>d1e35b30 - Remove useless migrations</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4033&start_sha=49f5e9ef632b14844ec7388844185c3110cbd51b)
thubrecht commented 2022-06-30 17:42:54 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in merge request !512

mentioned in merge request !512
bclement commented 2022-07-19 15:02:00 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

On load deux fois static

On load deux fois `static`
bclement commented 2022-07-19 15:10:04 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

D'après gestioasso.settings.local: "Settings utilisés lors d'un développement en local (dans un virtualenv)."
Ça ne me parait pas approprié d'avoir ça commme valeur par défaut de DJANGO_SETTINGS_MODULE?

D'après `gestioasso.settings.local`: "Settings utilisés lors d'un développement en local (dans un virtualenv)." Ça ne me parait pas approprié d'avoir ça commme valeur par défaut de `DJANGO_SETTINGS_MODULE`?
bclement commented 2022-07-19 15:10:23 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

(Cela dit la version précédente pointe vers un __init__.py vide)

(Cela dit la version précédente pointe vers un `__init__.py` vide)
bclement commented 2022-07-19 15:15:20 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Pourquoi on n'a plus besoin de ça ?

Pourquoi on n'a plus besoin de ça ?
bclement commented 2022-07-19 15:27:59 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

C'est supprimé

C'est supprimé
bclement commented 2022-07-19 15:37:39 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

C'est appelé à juste 3 endroits on peut peut-être inliner le get_channel_layer().group_send?

C'est appelé à juste 3 endroits on peut peut-être inliner le `get_channel_layer().group_send`?
bclement commented 2022-07-19 16:04:46 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Ça mérite un commentaire pour expliquer qu'on peut pas créer des utilisateurs à cause des pbs d'async et pgsql

Ça mérite un commentaire pour expliquer qu'on peut pas créer des utilisateurs à cause des pbs d'async et pgsql
bclement commented 2022-07-19 16:05:26 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

LGTM avec les quelques commentaires ci-dessus

C'est bien touffu, j'espère qu'ils vont pas encore rechanger leur API du tout au tout avant un bout de temps

LGTM avec les quelques commentaires ci-dessus C'est bien touffu, j'espère qu'ils vont pas encore rechanger leur API du tout au tout avant un bout de temps
thubrecht commented 2022-10-03 13:08:19 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 40 commits

  • d1e35b30...1be5dcb6 - 5 commits from branch master
  • 965ba074 - Fix vagrant setup w/ daphne
  • f026e0b5 - Update to django channels 2
  • 654848c4 - Update daphne version
  • e1d942a7 - Add default http router
  • d120a2bb - Update base consumers
  • 6db3ed60 - Update django version
  • 65ea5d21 - Update django-redis-cache and fix vagrant setup
  • 3411bc8a - keyOrder is deprecated, using a list in Meta gives the correct order
  • a01e11e4 - Fix app import
  • 1ae5c80f - Add default django asgi handler
  • 2b712dd0 - Channels 3
  • 5a28aab7 - Simplify group_send for kpsul
  • c9158c8e - Fix kpsul tests
  • 9a7deb5e - Fix kfet.ope tests
  • 95e658d0 - Update redis, and implement a custom channel layer to send datetime/decimal objects
  • 8a1c39e4 - ugettext -> gettext
  • b512ba2d - Change backend name as the old one is deprecated
  • 6e4895fb - Update django-djconfig
  • aeb90f72 - Remove default_app_config
  • 9e1e13d3 - Update kfet.open tests
  • 67e921a4 - Try to flush old messages in tests
  • 16f50083 - Try not running tests in parallel
  • 48dd2571 - Only run kf tests in sequential mode (to fix issues with channels)
  • 14eb7401 - Fix typo
  • 8d655f8b - cof has been renamed to gestioasso
  • 1e5d3073 - Update changelog
  • 6be970b2 - Replace unique_together by UniqueConstraint
  • 29726486 - url -> re_path
  • e51951b1 - Use AutoField instead of BigAutoField
  • 75bf5c9b - assertEquals is deprecated
  • 0b03a42a - Explicitely set transform=repr in assertQuerysetEquals
  • 2b2fcb8d - assertDictContainsSubset is deprecated
  • ef68e469 - Update django-hCaptcha
  • d756cb1f - Remove useless migrations
  • e2d7bba8 - dev: update requirements

Compare with previous version

added 40 commits <ul><li>d1e35b30...1be5dcb6 - 5 commits from branch <code>master</code></li><li>965ba074 - Fix vagrant setup w/ daphne</li><li>f026e0b5 - Update to django channels 2</li><li>654848c4 - Update daphne version</li><li>e1d942a7 - Add default http router</li><li>d120a2bb - Update base consumers</li><li>6db3ed60 - Update django version</li><li>65ea5d21 - Update django-redis-cache and fix vagrant setup</li><li>3411bc8a - keyOrder is deprecated, using a list in Meta gives the correct order</li><li>a01e11e4 - Fix app import</li><li>1ae5c80f - Add default django asgi handler</li><li>2b712dd0 - Channels 3</li><li>5a28aab7 - Simplify group_send for kpsul</li><li>c9158c8e - Fix kpsul tests</li><li>9a7deb5e - Fix kfet.ope tests</li><li>95e658d0 - Update redis, and implement a custom channel layer to send datetime/decimal objects</li><li>8a1c39e4 - ugettext -&gt; gettext</li><li>b512ba2d - Change backend name as the old one is deprecated</li><li>6e4895fb - Update django-djconfig</li><li>aeb90f72 - Remove default_app_config</li><li>9e1e13d3 - Update kfet.open tests</li><li>67e921a4 - Try to flush old messages in tests</li><li>16f50083 - Try not running tests in parallel</li><li>48dd2571 - Only run kf tests in sequential mode (to fix issues with channels)</li><li>14eb7401 - Fix typo</li><li>8d655f8b - cof has been renamed to gestioasso</li><li>1e5d3073 - Update changelog</li><li>6be970b2 - Replace unique_together by UniqueConstraint</li><li>29726486 - url -&gt; re_path</li><li>e51951b1 - Use AutoField instead of BigAutoField</li><li>75bf5c9b - assertEquals is deprecated</li><li>0b03a42a - Explicitely set transform=repr in assertQuerysetEquals</li><li>2b2fcb8d - assertDictContainsSubset is deprecated</li><li>ef68e469 - Update django-hCaptcha</li><li>d756cb1f - Remove useless migrations</li><li>e2d7bba8 - dev: update requirements</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4222&start_sha=d1e35b30e18a8b8950ebdba7c65da332bb21e111)
thubrecht commented 2022-10-03 13:24:05 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

changed this line in version 16 of the diff

changed this line in [version 16 of the diff](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4224&start_sha=e2d7bba816dc489311ce0691d457fd8dc947fc1e#6217f352d34785b4a9cf67afc2718828e9e88768_2_2)
thubrecht commented 2022-10-03 13:24:06 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 3 commits

  • 192b9d1e - kfet: remove redundant static tag
  • 74241e22 - dev: set explicitely DJANGO_SETTINGS_MODULE
  • 7968a702 - kfet/open: Add comment to test

Compare with previous version

added 3 commits <ul><li>192b9d1e - kfet: remove redundant static tag</li><li>74241e22 - dev: set explicitely DJANGO_SETTINGS_MODULE</li><li>7968a702 - kfet/open: Add comment to test</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4224&start_sha=e2d7bba816dc489311ce0691d457fd8dc947fc1e)
thubrecht commented 2022-10-03 13:25:19 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

Si on fait pointer les settings vers un __init__.py vide au moins ça fait tout planter quand on essaie de lancer le serveur sans rien vérifier, ce qui est préférable imo

Si on fait pointer les settings vers un `__init__.py` vide au moins ça fait tout planter quand on essaie de lancer le serveur sans rien vérifier, ce qui est préférable imo
thubrecht commented 2022-10-03 13:27:57 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

resolved all threads

resolved all threads
thubrecht commented 2022-10-03 15:47:38 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 157165a7 - dev: update requirements and directly read the files

Compare with previous version

added 1 commit <ul><li>157165a7 - dev: update requirements and directly read the files</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4227&start_sha=7968a70236da144c8131a029ca1f4f01ea8e8dae)
thubrecht commented 2023-05-19 15:25:14 +02:00 (Migrated from git.eleves.ens.fr)
Copy link

added 58 commits

  • 157165a7...30e842ce - 18 commits from branch master
  • 30e842ce...e8143856 - 30 earlier commits
  • 42bd1cde - assertEquals is deprecated
  • 68065c94 - Explicitely set transform=repr in assertQuerysetEquals
  • b37c9dae - assertDictContainsSubset is deprecated
  • 59683ec5 - Update django-hCaptcha
  • 1fea8ed4 - Remove useless migrations
  • 0568daca - dev: update requirements
  • 50e59167 - kfet: remove redundant static tag
  • 533d4fdb - dev: set explicitely DJANGO_SETTINGS_MODULE
  • 8c391469 - kfet/open: Add comment to test
  • 2e5ecdf6 - dev: update requirements and directly read the files

Compare with previous version

added 58 commits <ul><li>157165a7...30e842ce - 18 commits from branch <code>master</code></li><li>30e842ce...e8143856 - 30 earlier commits</li><li>42bd1cde - assertEquals is deprecated</li><li>68065c94 - Explicitely set transform=repr in assertQuerysetEquals</li><li>b37c9dae - assertDictContainsSubset is deprecated</li><li>59683ec5 - Update django-hCaptcha</li><li>1fea8ed4 - Remove useless migrations</li><li>0568daca - dev: update requirements</li><li>50e59167 - kfet: remove redundant static tag</li><li>533d4fdb - dev: set explicitely DJANGO_SETTINGS_MODULE</li><li>8c391469 - kfet/open: Add comment to test</li><li>2e5ecdf6 - dev: update requirements and directly read the files</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/-/merge_requests/511/diffs?diff_id=4480&start_sha=157165a7c95086aaef6e63ba81f19c3c6efff9cb)
thubrecht force-pushed thubrecht/daphne from 2e5ecdf636 to d6109a9312 2024-07-12 14:54:17 +02:00 Compare
thubrecht merged commit 2126224e15 into master 2024-07-30 18:40:56 +02:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
devtype -- backend

Au programme : du Python, du Django...

  
devtype -- docs

   
devtype -- frontend

   
devtype -- user interface

Au programme : templating, JS, CSS...

  
difficulty -- easy

   
difficulty -- hard

Difficile et/ou risqué

  
difficulty -- normal

   
Doing

   
domain -- bda

Concerne l'application BdA

  
domain -- bds

   
domain -- cof

Concerne l'application COF

  
domain -- core

Dépendances externes, CI, linting...

  
domain -- kfet

Concerne l'application K-Fêt

  
Good first issue

   
priority -- high

Urgent quoi

  
priority -- low

   
priority -- medium

   
priority -- staff-wanted

L'équipe dirigeante du domaine en question souhaite cette fonctionnalité.

  
status -- development

En cours de développement

  
status -- discussion

Avant de coder, c'est bien de discuter

  
status -- need review

En attente de code review

  
status -- production

L'ajout/la modification est présente en production

  
status -- ready to merge

Plus qu'à merger !

  
status -- todo

Le développement devrait bientôt commencer

  
To Do

   
type -- bug

Signalement ou correction de bug

  
type -- hygiene

Tout ce qui amène à du code plus propre et un repo mieux organisé.

  
type -- improvement

Ajout/Demande d'évolution mineure d'une fonctionnalité existante

  
type -- new feature

Ajout/Demande d'une nouvelle fonctionnalité

No labels
devtype -- backend
devtype -- docs
devtype -- frontend
devtype -- user interface
difficulty -- easy
difficulty -- hard
difficulty -- normal
Doing
domain -- bda
domain -- bds
domain -- cof
domain -- core
domain -- kfet
Good first issue
priority -- high
priority -- low
priority -- medium
priority -- staff-wanted
status -- development
status -- discussion
status -- need review
status -- production
status -- ready to merge
status -- todo
To Do
type -- bug
type -- hygiene
type -- improvement
type -- new feature
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/gestioCOF#815
No description provided.
Delete branch "thubrecht/daphne"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?