DGNum/gestioCOF
13
2
Fork 1
Code Issues 77 Pull requests 14 Packages Projects Releases 12 Wiki Activity

Disambiguation in kfet's permission handling #701

Merged
mpepin merged 0 commits from kerl/permission_disambiguation into master 2019-12-25 17:45:04 +01:00
Conversation 13 Commits - Files changed -
mpepin commented 2019-12-21 16:52:26 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

In some places we used to refer to permissions based on their codename
only (the part after the dot "." in the following examples) which can be
ambiguous. Typically, we might define permissions like "bds.is_team" or
"cof.is_team" in the near future ;)

In some places we used to refer to permissions based on their codename only (the part after the dot "." in the following examples) which can be ambiguous. Typically, we might define permissions like "bds.is_team" or "cof.is_team" in the near future ;)
mpepin commented 2019-12-21 16:52:27 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

changed milestone to %1

changed milestone to %1
mpepin commented 2019-12-21 16:53:04 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in merge request !396

mentioned in merge request !396
mpepin commented 2019-12-21 17:09:54 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 705f93ba - Disambiguation in kfet's permission handling

Compare with previous version

added 1 commit <ul><li>705f93ba - Disambiguation in kfet&#39;s permission handling</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/merge_requests/397/diffs?diff_id=1414&start_sha=20d6ba740448606d576c4bfacae51ce9ec9df3e6)
lstephan commented 2019-12-23 00:12:11 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

T'as de la doc là dessus ? J'arrive pas à trouver...

T'as de la doc là dessus ? J'arrive pas à trouver...
mpepin commented 2019-12-23 00:18:32 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

C'est une feature utilisée pour la serialization : https://docs.djangoproject.com/en/3.0/topics/serialization/#natural-keys.

C'est pas hyper bien documenté mais c'est quand même pratique comme helper…

C'est une feature utilisée pour la serialization : https://docs.djangoproject.com/en/3.0/topics/serialization/#natural-keys. C'est pas hyper bien documenté mais c'est quand même pratique comme helper…
mpepin commented 2019-12-24 17:14:47 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

changed this line in version 3 of the diff

changed this line in [version 3 of the diff](/klub-dev-ens/gestioCOF/merge_requests/397/diffs?diff_id=1431&start_sha=705f93ba07615560f6232f53dcc933c3813034a3#37d31cd6996aa6d0e0908e60508b885a692bc8d3_207_209)
mpepin commented 2019-12-24 17:14:48 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

added 1 commit

  • 4a89f766 - Avoid using `get_by_natural_key`

Compare with previous version

added 1 commit <ul><li>4a89f766 - Avoid using `get_by_natural_key`</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/merge_requests/397/diffs?diff_id=1431&start_sha=705f93ba07615560f6232f53dcc933c3813034a3)
mpepin commented 2019-12-24 17:16:25 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

Finalement j'ai remplacé par des vrais get.

Finalement j'ai remplacé par des vrais `get`.
mpepin commented 2019-12-24 17:16:25 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

resolved all discussions

resolved all discussions
mpepin commented 2019-12-24 17:16:37 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

added 7 commits

  • 4a89f766...67e28c70 - 5 commits from branch master
  • 64c792b1 - Disambiguation in kfet's permission handling
  • 1f945d1a - Avoid using `get_by_natural_key`

Compare with previous version

added 7 commits <ul><li>4a89f766...67e28c70 - 5 commits from branch <code>master</code></li><li>64c792b1 - Disambiguation in kfet&#39;s permission handling</li><li>1f945d1a - Avoid using `get_by_natural_key`</li></ul> [Compare with previous version](/klub-dev-ens/gestioCOF/merge_requests/397/diffs?diff_id=1432&start_sha=4a89f7664e0fd7cb8d69980ed2179125a528b28b)
mpepin commented 2019-12-24 17:46:25 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

La CI semble en PLS à cause du force push… Mais les tests normaux passent et vous pouvez tester à la main que les linter et le test de migration aussi

La CI semble en PLS à cause du force push… Mais les tests normaux passent et vous pouvez tester à la main que les linter et le test de migration aussi
lstephan commented 2019-12-25 17:45:04 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

merged

merged
lstephan commented 2019-12-25 17:45:04 +01:00 (Migrated from git.eleves.ens.fr)
Copy link

mentioned in commit d2ba9471da

mentioned in commit d2ba9471dadce4e4cc1c735c45e9b0b62d90e3b1
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
devtype -- backend

Au programme : du Python, du Django...

  
devtype -- docs

   
devtype -- frontend

   
devtype -- user interface

Au programme : templating, JS, CSS...

  
difficulty -- easy

   
difficulty -- hard

Difficile et/ou risqué

  
difficulty -- normal

   
Doing

   
domain -- bda

Concerne l'application BdA

  
domain -- bds

   
domain -- cof

Concerne l'application COF

  
domain -- core

Dépendances externes, CI, linting...

  
domain -- kfet

Concerne l'application K-Fêt

  
Good first issue

   
priority -- high

Urgent quoi

  
priority -- low

   
priority -- medium

   
priority -- staff-wanted

L'équipe dirigeante du domaine en question souhaite cette fonctionnalité.

  
status -- development

En cours de développement

  
status -- discussion

Avant de coder, c'est bien de discuter

  
status -- need review

En attente de code review

  
status -- production

L'ajout/la modification est présente en production

  
status -- ready to merge

Plus qu'à merger !

  
status -- todo

Le développement devrait bientôt commencer

  
To Do

   
type -- bug

Signalement ou correction de bug

  
type -- hygiene

Tout ce qui amène à du code plus propre et un repo mieux organisé.

  
type -- improvement

Ajout/Demande d'évolution mineure d'une fonctionnalité existante

  
type -- new feature

Ajout/Demande d'une nouvelle fonctionnalité

No labels
devtype -- backend
devtype -- docs
devtype -- frontend
devtype -- user interface
difficulty -- easy
difficulty -- hard
difficulty -- normal
Doing
domain -- bda
domain -- bds
domain -- cof
domain -- core
domain -- kfet
Good first issue
priority -- high
priority -- low
priority -- medium
priority -- staff-wanted
status -- development
status -- discussion
status -- need review
status -- production
status -- ready to merge
status -- todo
To Do
type -- bug
type -- hygiene
type -- improvement
type -- new feature
Milestone
Clear milestone
No items
No milestone
Intégration du BDS
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: DGNum/gestioCOF#701
No description provided.
Delete branch "kerl/permission_disambiguation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?