core -- Add and apply black, flake8, isort to CI and pre-commit #621
No reviewers
Labels
No labels
devtype -- backend
devtype -- docs
devtype -- frontend
devtype -- user interface
difficulty -- easy
difficulty -- hard
difficulty -- normal
Doing
domain -- bda
domain -- bds
domain -- cof
domain -- core
domain -- kfet
Good first issue
priority -- high
priority -- low
priority -- medium
priority -- staff-wanted
status -- development
status -- discussion
status -- need review
status -- production
status -- ready to merge
status -- todo
To Do
type -- bug
type -- hygiene
type -- improvement
type -- new feature
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: DGNum/gestioCOF#621
Loading…
Reference in a new issue
No description provided.
Delete branch "aureplop/linters"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Description
À savoir
Pour installer le hook (dans le README):
et installer les dépendances
pip install black isort flake8
(ajouté àrequirements-devel.txt
).Todos
Puis retirer --exit-zero de la CI.
-> En fait non, flake8 a tendance à un peu trop l'ouvrir (déjà 2 ignore dans setup.cfg dus à des conflits avec pep8/black).
Va rester en check-only.
.pre-commit.sh
.Fixes #200.
restored source branch
aureplop/linters
added 2 commits
Compare with previous version
deleted source branch
aureplop/linters
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 1 commit
Compare with previous version
added 3 commits
Compare with previous version
added 2 commits
Compare with previous version
added 12 commits
master
b2381091
- core -- Remove not working cache of py installed packages...Compare with previous version
added 2 commits
Compare with previous version
added 3 commits
104e71dc
- core -- Add black,isort,flake8 to CI and pre-commit hookCompare with previous version
added 2 commits
fdd2b352
- core -- Apply black + isort to all files402b5443
- core -- Fix flake8 errorsCompare with previous version
changed the description
added ~59 and removed ~30 labels
marked the checklist item Fix les erreurs flake8 (ou ajouter à setup.cfg > [flake8] > ignore), cf. logs du build de cette MR. as completed
unmarked as a Work In Progress
changed the description
marked the checklist item Le wiki devrait être mis à jour. as completed
changed the description
added 3 commits
61fbf0bc
- typo9bc3355a
- pre-commit hook: fix shellcheck's SC2086 & SC2181fc4b852b
- Merge branch 'Kerl/linters' into 'aureplop/linters'Compare with previous version
Ce serait effectivement mieux de ne tester que les fichiers qui ont changé… Mais on peut laisser une issue ouverte et remettre ça à plus tard si ça permet d'avancer
enabled an automatic merge when the pipeline for
fc4b852bde
succeedsmentioned in commit
ec287c8a3b
merged
Ça ne teste que les fichiers changés mais ça "foire" si tu fais des git add partiels et/ou que t'oublies d'ajouter les modifs de black/isort à l'index...
Mais bon : "itérons"