Complete !1 #13

Closed

delobell wants to merge 1 commit from aureplop/fix-mr1 into master

delobell commented

2018-05-15 10:22:02 +02:00

(Migrated from git.eleves.ens.fr)

Tests are failing on master. It fixes that.

Force python-ldap >= 3 to get proper bytes/string management.
Replace common['name'] with common['first_name'] because the name is
already broken by get_names. Actually, allauth breaks down
common['name'] in 'first_name + last_name'.
Decrease timeout of LDAP requests to 5s.
Fix get_names in case the LDAP returned a string without any space
character.
Fix get_names in case the LDAP doesn't return any cn, which was
failing with Py3.
Add tests about populating user data from LDAP.

Tests are failing on master. It fixes that. - Force python-ldap >= 3 to get proper bytes/string management. - Replace common['name'] with common['first_name'] because the name is already broken by get_names. Actually, allauth breaks down common['name'] in 'first_name + last_name'. - Decrease timeout of LDAP requests to 5s. - Fix get_names in case the LDAP returned a string without any space character. - Fix get_names in case the LDAP doesn't return any cn, which was failing with Py3. - Add tests about populating user data from LDAP.

delobell commented

2018-09-29 22:47:24 +02:00

(Migrated from git.eleves.ens.fr)

added 6 commits

7d9d22e9...fdafd407 - 5 commits from branch master
ce1e7d10 - Complete !1

Compare with previous version

added 6 commits * 7d9d22e9...fdafd407 - 5 commits from branch `master` * ce1e7d10 - Complete !1 [Compare with previous version](https://git.eleves.ens.fr/cof-geek/django-allauth-ens/merge_requests/7/diffs?diff_id=921&start_sha=7d9d22e981d6e254247946fe08a359acfeb29dee)

delobell commented

2018-09-30 00:41:21 +02:00

(Migrated from git.eleves.ens.fr)

Devenue inutile

delobell commented

2018-09-30 00:41:26 +02:00

(Migrated from git.eleves.ens.fr)

closed