DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
11120 commits 2 branches 1166 tags 85 MiB
Commit graph

11120 commits

This branch
This branch
All branches
Author SHA1 Message Date
Pierre de La Morinerie
fbbcd97463 config: flip config.active_record.collection_cache_versioning 
This is related to internal cache implementation, and doesn't affect us.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
4a9f081cfc config: flip config.action_mailer.delivery_job 
This is safe in all cases – except that it prevents a downgrade to
Rails 5. We don't intend to downgrade now, so this is fine.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
b556e2a99a config: flip config.active_storage.replace_on_assign_to_many 
We don't have any `has_many_attached` relations in the code base, so
this is safe.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
54a4db1c47 config: flip config.active_storage.queues 
ActiveStorage jobs are now moved to their own queue.

For consistency, we also move our own analysis jobs (VirusScannerJob)
on the same `:active_storage_analysis` queue.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
c6cdd08373 config: flip config.active_job.return_false_on_aborted_enqueue 
We don't have any instance of aborting inside a job in the code base,
so this setting is safe to flip.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
65809f8ea0 config: flip action_dispatch_return_only_media_type_on_content_type 
This makes `ActionDispatch::Controller#content_type` return not only
the MIME type, but also in some circumstances the charset.

Example:

```ruby
reponse.content_type == 'text/html; charset=utf-8'
```

The MIME type-only fragment can now be accessed using `#media_type`.

Changes to the tests are not stricly necessary (because no charset is
present in the actual value), but represent the intent better.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
8427f0eb75 config: flip config.action_dispatch.use_cookies_with_metadata 
This makes cookies more secure, by adding an automatic "purpose" field
to each cookie.

Cookies generated by Rails 5 are still forward-compatible. However
from now on the generated cookies will not be backward-compatible with
Rails 6.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
e8fa65f79d config: flip config.action_view.default_enforce_utf8 
This prevents charset workaround on IE 8 and lower. We don't support
these browsers anyway, so we can flip the feature off.
 2020-08-05 16:48:36 +02:00
Pierre de La Morinerie
a1be888f7c config: use Rails 5.2 config defaults 2020-08-05 16:48:29 +02:00
Pierre de La Morinerie
31cc9de498
Merge pull request #5446 from betagouv/rails-5.1-config 
Utilisation de la configuration Rails 5.1 par défaut
 2020-08-05 13:51:07 +02:00
Pierre de La Morinerie
0d55919fab config: use Rails 5.1 defaults 
New or changed defaults are:

- config.assets.unknown_asset_fallback: false
- config.action_view.form_with_generates_remote_forms: true
 2020-08-05 13:02:56 +02:00
Pierre de La Morinerie
7708dbbc71 views: explicitely marks form_with as non-remote forms 
Starting from Rails 5.1, `form_with` behavior is to generate remote
forms by default.

However with Turbolinks disabled, the form gets sent, but nothing is set
up to handle the server response (like replacing the content of the
page).

So we have two choices: either enable a global config option that makes
`form_with` generate non-remote forms, or do it explicitely on each
form. I chose the explicit way, so that developers expecting the usual
remote behavior of `form_with` are not surprised.
 2020-08-05 13:02:56 +02:00
Pierre de La Morinerie
1e9da059d3
Merge pull request #5445 from betagouv/fix-attestation-rendering 
Attestations : correction du rendu des PDFs
 2020-08-05 12:25:30 +02:00
Pierre de La Morinerie
8962db38cc models: render attestations in a simpler way 
The older method of instanciating an entire new rendering stack can be
made simpler using Rails >= 5.0 methods.

See https://api.rubyonrails.org/classes/ActionController/Renderer.html#method-i-render
 2020-08-04 16:53:46 +02:00
Pierre de La Morinerie
a088b240e0
Merge pull request #5317 from betagouv/confirm-token 
Usager : amélioration de l'accessibilité de la page de confirmation de l'adresse email
 2020-08-04 15:57:10 +02:00
clemkeirua
21221a7c49 fix missing alt 2020-08-04 13:41:10 +00:00
clemkeirua
101acafb65 fix hidden label 2020-08-04 13:41:10 +00:00
clemkeirua
cc9341a83c fix missing header for account creation 2020-08-04 13:41:10 +00:00
Pierre de La Morinerie
bc3e0eb76c
Merge pull request #5438 from betagouv/dependabot/npm_and_yarn/elliptic-6.5.3 
Mise à jour d'elliptic de la version 6.5.2 à la version 6.5.3
 2020-08-04 15:40:32 +02:00
dependabot[bot]
502d2b5606
Bump elliptic from 6.5.2 to 6.5.3 
Bumps [elliptic](https://github.com/indutny/elliptic) from 6.5.2 to 6.5.3.
- [Release notes](https://github.com/indutny/elliptic/releases)
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.2...v6.5.3)

Signed-off-by: dependabot[bot] <support@github.com>
 2020-08-04 13:30:26 +00:00
Kara Diaby
4da6213f96
Merge pull request #5444 from betagouv/fix-new-design-attestation 
Fixe l'affichage  concernant l'affichage des attestations sur l'interface administrateur (détail d'une démarche)
 2020-08-04 11:15:03 +02:00
kara Diaby
c983622805 fix attestation template boolean on procedure detail page (new admin interface) 2020-08-04 10:56:48 +02:00
Kara Diaby
4afc07c677
Merge pull request #5403 from tchak/add-carte-ign 
Add carte ign
 2020-08-03 11:04:32 +02:00
jpoulvel
bf94cc021b
Merge pull request #5424 from betagouv/new_design_edit_attestation 
New design page admin/attestation_templates/edit
 2020-07-31 11:18:22 +02:00
Paul Chavard
4c87e547b3 Put IGN map behind a feature flag 2020-07-30 17:22:28 +02:00
Paul Chavard
f1cbc9846e Add carte ign 2020-07-30 16:58:20 +02:00
Kara Diaby
c83a085d6a
Merge pull request #5436 from betagouv/fix/5402 
fix/5402 - clone button to closed procedures
 2020-07-30 14:00:36 +02:00
kara Diaby
db3e40ebf8 Fixe la non possibilité de cloner une démarche pour une procédure archivée (nouvelle interface administrateur) 2020-07-30 12:00:43 +02:00
Keirua
efca6745d6
Merge pull request #5435 from betagouv/fix-5288-commentaires 
last_commentaire_updated_at does not take system email into account
 2020-07-30 11:59:47 +02:00
clemkeirua
952a43058f last_commentaire_updated_at does not take system email into account 2020-07-30 11:52:41 +02:00
Keirua
808e2fb53f
Merge pull request #5426 from betagouv/5288-optim-instructeur-dashboard 
5288 optim instructeur dashboard
 2020-07-30 10:42:48 +02:00
Keirua
b3e98048f9
Merge pull request #5418 from betagouv/mise-en-avant-france-connect 
#5428 - France connect avant les boutons de login/signup
 2020-07-30 10:32:12 +02:00
clemkeirua
153c6aebd7 add temp job to set last_updated_at_* values for dossier 
Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>
 2020-07-30 10:31:14 +02:00
Christophe Robillard
03e3e8fb1c rename Dossier#modifier_annotations! 
give a more accurate name to the method

Co-authored-by: clemkeirua <clement@keiruaprod.fr>
 2020-07-30 10:18:44 +02:00
clemkeirua
c772c3454c update dossier after saving champ 
update last_champ_updated_at without hook
update last_champ_private_updated_at without hook

Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>
 2020-07-30 10:18:44 +02:00
Christophe Robillard
b940d2e1b0 update dossier after saving avis 
update last_avis_updated_at without hook

Co-authored-by: clemkeirua <clement@keiruaprod.fr>
 2020-07-30 10:18:44 +02:00
clemkeirua
f3a675c3bc update dossier after saving commentaire 
update last_commentaire_updated_at without hook

Co-authored-by: Christophe Robillard <christophe.robillard@beta.gouv.fr>
 2020-07-30 10:18:44 +02:00
Christophe Robillard
667b7d9876 add migration 
Co-authored-by: clemkeirua <clement@keiruaprod.fr>
 2020-07-30 10:18:44 +02:00
jpoulvel
62e04a6ca9
Merge branch 'dev' into new_design_edit_attestation 2020-07-30 09:53:09 +02:00
krichtof
19e6cfc5ff
Merge pull request #5432 from betagouv/fix_mail_footer 
fix footer for mail notifications
 2020-07-29 17:49:46 +02:00
Kara Diaby
5894a86bd8
Merge pull request #5423 from betagouv/feat/5402 
Feat/5402 - [Admin] new UI for procedures listing
 2020-07-29 17:38:49 +02:00
Kara Diaby
db1df32976
Merge pull request #5431 from betagouv/add-procedure-copy-to-admin-interface 
fix - Ajoute un bouton envoyer une copie à la nouvelle interface admin
 2020-07-29 17:37:54 +02:00
Christophe Robillard
e3fe16462c fix footer for mail notifications 2020-07-29 17:37:33 +02:00
Paul Chavard
c803b02368
Merge pull request #5430 from betagouv/graphql-filter-dossier 
graphql: possibility to filter dossiers by archived
 2020-07-29 17:11:46 +02:00
kara Diaby
d73cff2ccb Ajoute un bouton envoyer une copie à la nouvelle interface administrateurs 2020-07-29 17:07:17 +02:00
clemkeirua
c404f92107 graphql: possibility to filter dossiers by archived 2020-07-29 16:59:34 +02:00
jpoulvel
eff6f9c09c
Merge pull request #5415 from betagouv/scroll-padding 
Added scroll-padding property for pages with sticky-bottoms
 2020-07-29 15:47:17 +02:00
kara Diaby
d4c6e501c6 Ajoute la liste des démarches de l'interface administrateur sur la nouvelle UI 2020-07-29 15:35:52 +02:00
Judith
c1f13d4392 scroll-paggind property added to the linter 2020-07-29 15:28:03 +02:00
Judith
69fbd7903b use of scroll-margins-for-sticky-footer where we have sticky-footers 2020-07-29 15:28:03 +02:00