LeSim
d32124d732
Merge pull request #10807 from demarches-simplifiees/slow_drop_down_cleaning
...
Tech: simplification de la logique des champs listes
2024-09-18 12:46:15 +00:00
Lisa Durand
3d50f9363f
Merge pull request #10741 from demarches-simplifiees/secu-improve-complexity-password-ldu
...
[sécu] Améliorer la complexité des mots de passe pour tous les users
2024-09-18 12:40:17 +00:00
LeSim
c89e60d5fa
Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code
...
Tech: retire la protection contre les colonnes virtuelles
2024-09-18 08:38:20 +00:00
simon lehericey
061c9cc6f3
remove default empty value in drop_down_list
2024-09-18 10:26:00 +02:00
simon lehericey
b3ad237fa1
simplify drop_down_list_value
2024-09-18 10:08:12 +02:00
simon lehericey
2f64fe5e4c
one less indirection
2024-09-18 10:08:12 +02:00
simon lehericey
f046f31dcc
remove_disabled_options
2024-09-18 10:08:11 +02:00
Mathieu Magnin
bfb7b59033
[ #10813 ] When value_json of champ SIRET is nil do not crash
2024-09-17 19:05:36 +02:00
mfo
1e0391c9dc
Merge pull request #10806 from mfo/US/fix-number-not-number-in-filters
...
Correctif: ETQ instructeur, la recherche par numéro de dossier ne doit accepter que des numero
2024-09-17 14:39:08 +00:00
mfo
ebb51e8128
fix(filters): filter by dossier should only accept number
2024-09-17 15:18:23 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids
2024-09-17 10:29:34 +02:00
Paul Chavard
f02ec3da82
cleanup in spec
2024-09-17 10:29:34 +02:00
Paul Chavard
54926db89b
refactor(champ): more concistent champ_for_update usage
2024-09-17 10:29:34 +02:00
Paul Chavard
988025ba69
refactor(champs): validate only champs in current revision
2024-09-17 10:29:34 +02:00
Paul Chavard
3817f334c9
refactor(repetition): use less champs and public_id methods
2024-09-17 10:29:34 +02:00
Lisa Durand
fdb2ebd5d1
inject more french dictionnaries to zxcvbn lib
2024-09-17 09:31:47 +02:00
Paul Chavard
9924b2d640
Merge pull request #10804 from tchak/better_drop_down_other_option
...
Drop down other label set to 'Enter another option' instead of 'Other'
2024-09-16 15:12:14 +00:00
Paul Chavard
34a05d0bf0
Merge pull request #10462 from demarches-simplifiees/can-filter-from-repetition-content
...
ETQ instructeur je peux filtrer à partir du contenu d'un bloc répétable
2024-09-16 14:59:05 +00:00
Paul Chavard
e7bc7c4783
feat(procedure): can filter from repetion content
2024-09-16 16:46:49 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
...
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
Christian Lautier
17bbc474ff
Drop down other label set to 'Enter another option' instead of 'Other'
2024-09-16 16:41:46 +02:00
mfo
6af07dd721
data(fix): backfill invalid procedure presentation filters having a value greater than pg max integer
2024-09-16 16:36:02 +02:00
Lisa Durand
1a75e27097
change min_length password from 8 to 12
2024-09-16 15:28:14 +02:00
Lisa Durand
0b0e47b7cd
change passwords in specs
2024-09-16 15:28:11 +02:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db
2024-09-16 12:55:59 +02:00
simon lehericey
bc7d91751d
Revert "fix: ignore virtual data in column initialization"
...
This reverts commit 4289aa2cf5
2024-09-13 11:00:08 +02:00
Colin Darie
8dfddba433
Merge pull request #10584 from colinux/attestation-render-list
...
ETQ admin, améliore l'affichage de champ choix multiple et répétitions dans les attestations v2
2024-09-12 14:40:32 +00:00
mfo
02bbf26d3f
feat(ProcedurePresentation): validates that ProcedurePresentation.filters using a value casted as an integer [search by id] is not out of pg integer range
2024-09-10 17:47:50 +02:00
mfo
8ebb076a29
bug(ProcedurePresentation.filtered_ids): using numbers bigger than pg limit should not raise an error
2024-09-10 17:15:35 +02:00
simon lehericey
4289aa2cf5
fix: ignore virtual data in column initialization
2024-09-09 16:37:22 +02:00
mfo
5ab57a32ce
Merge pull request #10762 from mfo/US/export-when-tdc-change
...
Correctif, ETQ instructeur exportant mes dossiers, je souhaite retrouver la valeur saisie par les usagers quand les types de champ ont changés de type mais que les données restent compatible
2024-09-09 09:26:42 +00:00
mfo
7ec17ff7f5
fix(dossier.export): should not use default value when types_de_champ changed to a similar one
2024-09-09 11:00:01 +02:00
Colin Darie
977e47fa74
Merge pull request #10757 from mfo/US/fix-required-dossier-link-with-missing-dossier
...
correct: ETQ administrateur, je souhaite que les types de champ liens vers un dossier pointent vers un dossier valide si ils sont obligatoire
2024-09-09 07:28:48 +00:00
mfo
ad33934059
bug(dossier.export): lose value of champ when updating the type de champ from integer_number -> decimal_number
2024-09-06 16:25:56 +02:00
mfo
fcc2b10198
tech(state): define initial state reported by Patrick, cf: https://mattermost.incubateur.net/betagouv/pl/9epn7spg4tg3pbh8jgakafhnmh
2024-09-06 16:25:14 +02:00
mfo
915779c9b0
Merge pull request #10749 from mfo/US/commune-without-insee
...
correctif: ETQ administrateur/instructeur, je souhaite que les champs de type commune aient tjr un code insee afin de router de maniere fiable
2024-09-06 11:44:00 +00:00
mfo
eb8b9a13ca
fix(Champs::DossierLinkChamp): when required, should point to existing dossier
2024-09-06 11:23:12 +02:00
mfo
5abba5a166
feat(Champs::CommuneChamp): ensure presence of external_id since some of Champs::CommuneChamp.external_id are missing while .value is present 🔥
2024-09-06 08:37:08 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
...
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Colin Darie
247bb6f8c6
refactor(attestation): hide libelle of empty repetitions
2024-09-04 17:42:04 +02:00
Kara Diaby
9cebac1d99
Supprime la vérification par feature flag et utilise la vérif par booléen au booléen
2024-09-04 15:00:03 +00:00
simon lehericey
eaef5c7e39
readapt name and logic
2024-09-04 08:08:01 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review
2024-09-04 08:05:54 +00:00
Kara Diaby
a4b8d816de
Tests
2024-09-04 08:05:53 +00:00
Lisa Durand
27c8abfb4b
Merge pull request #10734 from demarches-simplifiees/cannot-publish-with-test-service-ldu
...
ETQ Admin, je ne dois pas pouvoir publier une démarche avec les informations du service de test
2024-09-03 15:00:30 +00:00
Lisa Durand
0da8d9449d
use other siret for factory
2024-09-02 17:13:43 +02:00
Colin Darie
c9956c4881
feat(attestation): better presentation of repetition champs
2024-09-02 16:11:02 +02:00
Colin Darie
09581ad028
feat(attestation): render multiple drop down list as list
2024-09-02 15:23:11 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
...
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring"
2024-08-30 16:43:30 +02:00
Paul Chavard
32bf3ec9db
cleanup in spec
2024-08-26 14:53:56 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage
2024-08-26 14:53:56 +02:00
Paul Chavard
f7cd7e615d
refactor(champs): validate only champs in current revision
2024-08-26 14:53:56 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods
2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
8b4b4d7cb7
feat(conditional): can condition and route on address champ
2024-08-26 11:16:46 +02:00
Lisa Durand
8722a10d63
fix specs
2024-08-22 17:54:24 +02:00
Lisa Durand
b586f23009
remove hidden at column from dossiers
2024-08-22 17:36:41 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
...
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
Lisa Durand
fae81d0a58
fix test
2024-08-22 12:09:29 +02:00
Colin Darie
659d35e11f
test: fix for mutable string
2024-08-22 09:26:49 +02:00
Colin Darie
6d9a7648e2
fix(test): disable frozen string in siret concern because it's a literal string in spec
2024-08-22 09:26:49 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment
2024-08-22 09:26:48 +02:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
...
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
...
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable
2024-08-20 18:46:19 +02:00
Paul Chavard
686000d6cb
fix spec
2024-08-20 15:26:15 +02:00
Lisa Durand
ab483a8959
simplifie tabs supprimes and reduce to one
2024-08-20 15:26:09 +02:00
Colin Darie
e4d460965f
Merge pull request #10690 from mfo/US/normalize-addresses-for-rnf-rna-siret
...
ETQ Tech, les adresses des champs siret / rna / rnf sont normalisées pour une recherche homogène via les filtres
2024-08-20 10:11:48 +00:00
Colin Darie
1e53e3bfef
Merge pull request #10661 from demarches-simplifiees/feat/10460
...
ETQ admin, je veux que l'email du déposant ne puisse pas être similaire à l'email du mandataire
2024-08-20 09:34:03 +00:00
LeSim
befe74b801
Merge pull request #9758 from demarches-simplifiees/purge_supprimer_dol
...
Tech: quand un dossier est définitivement supprimé, on ne garde que le log (DOL) concernant sa suppression
2024-08-20 09:26:33 +00:00
simon lehericey
28b338452a
feat(dossier_purge): when the dols are purged, only keep supprimer dol but destroy its data
...
Note, the only remaining data are dossier_id, automatic_operation, digest and bill_id, created_at
2024-08-20 10:55:32 +02:00
simon lehericey
92da869662
spec: Dossier.purge_discarded
2024-08-20 10:55:32 +02:00
mfo
4bf5725d6d
data(backfill): Champs::RnfChamp.value_json [±400 occurences]
2024-08-20 10:31:23 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json
2024-08-20 10:31:23 +02:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀
2024-08-19 15:46:14 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields
2024-08-19 15:30:08 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select
2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options
2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets
2024-08-19 15:29:59 +02:00
simon lehericey
c5c2d5782d
lets keep it private
2024-08-19 15:29:59 +02:00
simon lehericey
772424ff5e
move field_enum to instructeur filter component
2024-08-19 15:28:36 +02:00
simon lehericey
305b8c13c7
! BREAKING : break previous filter by type_de_champ_private
...
simplify type_de_champ_private -> type_de_champ, fix spec, add facet_spec
2024-08-19 15:28:36 +02:00
mfo
b3cb3e974e
refactor(Facet): extract Facet from ProcedurePresentation
...
Co-Authored-By: LeSim <mail@simon.lehericey.net>
clean(code): no comment 🎶
2024-08-19 15:27:39 +02:00
Kara Diaby
61525b6c2b
test
2024-08-19 12:51:39 +00:00
Colin Darie
720a312b00
fix(rnf): really normalize spaces
...
Fix #10653
2024-08-01 18:54:50 +02:00
Paul Chavard
25d4e7dfee
fix(rnf): no crash on identifiers with spaces
2024-08-01 18:00:46 +02:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
...
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
Paul Chavard
b81f69580b
fix(sva/svr): fix spec with arbitrary date
2024-07-30 09:35:15 +02:00
simon lehericey
8906a59635
simplify export_template model and spec
2024-07-26 13:34:49 +02:00
simon lehericey
977cfc87ce
Add export_item type
2024-07-26 13:31:06 +02:00
simon lehericey
24109a0128
add exportables_pieces_jointes_for_all_versions and outdated to pj_list_concern
2024-07-26 13:31:06 +02:00
simon lehericey
53a48f963d
tdc: add libelle_as_filename
2024-07-26 13:31:05 +02:00
Corinne Durrmeyer
190addd317
Merge pull request #10647 from demarches-simplifiees/a11y-authentification-page
...
Améliore l'accessibilité de la page d'authentification
2024-07-26 09:38:18 +00:00
Paul Chavard
223317fb5a
fix(rebase): avoid errors when adding pj champs to a new revision
2024-07-25 18:29:01 +02:00
Corinne Durrmeyer
c4afbfcbf1
Update spec files
2024-07-25 12:24:25 +02:00
Lisa Durand
b820577461
create a method to extend and restore
2024-07-24 17:07:48 +02:00
Lisa Durand
94e1f048ce
fix tabs count
2024-07-24 17:07:47 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at
2024-07-24 17:07:41 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories
2024-07-22 13:53:45 +02:00
Paul Chavard
d640ab8428
fix(combobox): dispatch change event on multiple combo changes
2024-07-16 15:10:45 +02:00
mfo
1cd539297f
feat(dossier.passer_en_construction!): clean up PJ for champs that are not visible [condition is false]
2024-07-15 11:28:59 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types
2024-07-11 12:17:46 +02:00
Paul Chavard
96e49d54cd
reafctor(logic): remove tests and accept unspecified behaviour
2024-07-08 15:44:30 +02:00
mfo
75a6c8b4b6
Merge pull request #10555 from mfo/US/normalize-number-cahmp
...
tech: Normalisation des champs de type number/decimal pr enlever les espace blanc à la saisi
2024-07-08 07:31:29 +00:00
Paul Chavard
9f9243499c
refactor(combobox): fix specs
2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune
2024-07-05 09:36:33 +02:00
mfo
c50f949acd
feat(Champs::number*): normalize values by stripping spaces.
2024-07-04 09:56:23 +02:00
Colin Darie
b3ccfc16c4
Merge pull request #10547 from colinux/mandatory-by-default
...
ETQ admin, un nouveau champ est obligatoire par défaut
2024-07-02 14:26:29 +00:00
Colin Darie
eee6e5e651
Merge pull request #10483 from colinux/fast-tests
...
Tech (tests): default administrateur fixtures
2024-07-01 21:35:11 +00:00
Colin Darie
2041623ded
test: merge similar examples
2024-07-01 22:36:31 +02:00
Colin Darie
9e80962ea5
test: default administrateur as fixtures
2024-07-01 22:36:31 +02:00
Colin Darie
f40b71f450
test(type_de_champ): mandatory by default, like schema
2024-07-01 17:00:49 +02:00
Lisa Durand
159cc942f6
Merge pull request #10549 from demarches-simplifiees/new-instructeur-need-mail-confirmation-ldu
...
ETQ nouvel instructeur, je dois confirmer mon mail
2024-07-01 08:45:57 +00:00
Lisa Durand
75403ba949
add specs
2024-06-26 10:57:40 +02:00
mfo
cfda807b66
fix(data): decimal number having spaces are no more exportable
2024-06-25 21:17:46 +02:00
mfo
476c7df160
bug(Champs::DecimalNumberChamp.for_export): should be able to cast a number wrapped with a string having leading/trailing spaces
2024-06-25 17:05:33 +02:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation
2024-06-25 15:14:26 +02:00
Colin Darie
f2669fbca8
fix(attestation): fix unspecified_attestation_champs for v2
2024-06-20 14:15:06 +02:00
Colin Darie
a540f8dccb
feat(attestation): can render & attach attestations v2
2024-06-20 14:15:05 +02:00
Colin Darie
4af6957237
fix(attestation): dup keep all attributes
2024-06-20 11:08:15 +02:00
Colin Darie
c5c24c01d8
chore(attestation): procedure#attestation_template always returns the published attestation
2024-06-20 11:08:15 +02:00
mfo
8cb902821f
bug(draft_types_de_champ_private.condition): condition must be validated with upper_tdcs. considering that types_de_champ_private can have a condition using a types_de_champ_public, we have to include all types_de_champs_public plus only types_de_champs_private.upper_tdcs
2024-06-11 16:05:45 +02:00
mfo
f819da8921
tech(clean): simplify implementation of eligibilite rules, code, enhance wording and test coverage
2024-06-11 09:57:36 +02:00
mfo
e3a24d53ea
tech(refactor): procedure::error_summary and dossier::ErrorsFullMessagesComponent use same behaviour to compact/expand errors
2024-06-11 09:39:20 +02:00
mfo
5644692448
feat(Logic.computable?): add computable? to know if a ineligibilite_rules set is computable
2024-06-11 09:32:53 +02:00
mfo
5de4ce889f
feat(ProcedureRevision.ineligibilites_rules): keep track of changes and show it to admin for republication
2024-06-11 09:32:53 +02:00
mfo
ab522a3e40
Merge pull request #10503 from mfo/US/fix-condition-validator-on-private-champ-using-public-tdc
...
Correctif: ETQ admin, je souhaite pouvoir utiliser des champs public pour conditionner une annotation privée
2024-06-10 09:33:22 +00:00
mfo
27b86f9848
fix(TypesDeChamp::ConditionValidator): allow to use types_de_champ_public on condition for types_de_champ_private
2024-06-10 11:26:01 +02:00
mfo
d2ccea700b
bug(TypesDeChamp::ConditionValidator): should allow to use types_de_champ_public on condition for types_de_champ_private
2024-06-10 09:35:29 +02:00
Kara Diaby
cb5ba455eb
Fixe bug sur toutes les démarches
2024-06-05 14:13:44 +00:00
mfo
ef3ca9839b
feat(procedure.validation): extract validation context: types_de_champ_public_editor, types_de_champ_private_editor and publication [combining both contextes]. validate conditions, headers_sections, regexp on type_de_champ_private too. dry validation
2024-06-04 18:25:24 +02:00
mfo
f14c88a54a
clean(spec): speed, avoid using with_all_champs factory. takes too much time when not needed
2024-06-04 15:34:34 +02:00
krichtof
45814fdbfb
Merge pull request #10454 from demarches-simplifiees/9827-add-specs
...
corrige quelques bugs de la feature export template (renommage dans le zip)
2024-06-04 13:18:12 +00:00
Christophe Robillard
ac23d5fb41
convert date with dash for export renaming
2024-06-04 10:32:14 +02:00
Paul Chavard
68c15ba99f
feat(champ): add updated_by column
2024-06-03 18:45:16 +02:00
mfo
a278aac92f
fix(spec): maj broken spec on main
2024-05-31 08:24:55 +02:00
Christophe Robillard
acf6579aa4
add missing specs to export template
2024-05-29 14:38:05 +02:00
Paul Chavard
de209954e1
Merge pull request #10466 from tchak/fix-supprimes_recemment-should-include-archived
...
fix(instructeur): supprimes_recemment should include archived dossiers
2024-05-29 11:09:41 +00:00
Paul Chavard
5154231ccf
fix(dossier): batch operations to termine dossier should send emails
2024-05-29 11:31:58 +02:00
Paul Chavard
b06934b8d3
fix(instructeur): supprimes_recemment should include archived dossiers
2024-05-29 11:03:46 +02:00
Christophe Robillard
06cbb65d4e
spec: simplify export template factory
2024-05-28 18:25:37 +02:00
simon lehericey
fa06d17169
Feat(user): set email_verified_at when setting confirmed_at
2024-05-27 17:24:56 +02:00
simon lehericey
841c1cc845
Feat(user): verify user email during devise confirmation
2024-05-27 17:24:55 +02:00
Paul Chavard
1bca3c123b
chore(dossier): remove legacy update attributes
2024-05-27 10:33:37 +02:00
simon lehericey
d3b700326d
spec: fix
2024-05-23 10:01:29 +02:00
simon lehericey
fa7d5cfa33
fix test
2024-05-23 10:00:41 +02:00
simon lehericey
c8b3b4b45a
refactor: renaming
2024-05-23 10:00:38 +02:00
simon lehericey
6445337be7
refactor(pj_list): extract pj list in a concern and simplify
2024-05-23 10:00:38 +02:00
Christophe Robillard
aeb4bd2ff1
add original-filename tag
2024-05-23 10:00:36 +02:00
Christophe Robillard
8e8057ddd3
add some specs to export template
2024-05-23 10:00:36 +02:00
