Paul Chavard
29e3b3f831
Merge pull request #7653 from tchak/feat-other-with-condition
...
feat(champ): can condition on other option
2022-08-04 16:35:44 +02:00
Paul Chavard
a24885c2ee
feat(champ): can condition on other option
2022-08-04 15:28:54 +02:00
Paul Chavard
a53688ce23
Merge pull request #7662 from tchak/fix-mandatory-conditions
...
fix(conditional): mandatory champs inside hidden repetition should not be validated
2022-08-04 15:27:21 +02:00
Paul Chavard
bbca7344e5
fix(conditional): mandatory champs inside hidden repetition should not be validated
2022-08-04 14:48:40 +02:00
Paul Chavard
8e8d8d4f55
Merge pull request #7660 from tchak/use-new-factory
...
refactor(spec): use new procedure.types_de_champ factory
2022-08-04 14:41:31 +02:00
Paul Chavard
65e96002b1
refactor(spec): raise if old style factory is used
2022-08-04 12:10:32 +02:00
Paul Chavard
2d7803cd48
refactor(spec): use new procedure.types_de_champ factory
2022-08-04 12:10:32 +02:00
Paul Chavard
5e890cdb36
fix(factory): fix options handling on drop_down_list
2022-08-04 11:37:56 +02:00
Paul Chavard
21637da8ab
Merge pull request #7659 from betagouv/fix-random-tests
...
Fix random tests errors
2022-08-04 10:01:22 +02:00
Colin Darie
adced0f33a
fix(revision): fix stable siblings order when there are multiple identical position
...
Ça arrive parfois dans les tests, et potentiellement en prod :
après avoir créé un nouveau `revision_type_de_champ`,
on se retrouve très momentanément avec 2
RTDC ayant le même position en attendant le renumérotation peu près.
https://github.com/betagouv/demarches-simplifiees.fr/blob/main/app/models/procedure_revision.rb#L55
Ceci conduisait à une renumérotation erronnée quand la db renvoyait
le nouveau RTDC créé *avant* les précédents.
2022-08-03 18:29:48 +02:00
Colin Darie
1601a18c34
test(combobox): increase wait time because component may be slow to render
...
Fix erreur type 'Unable to find css "li[role=\"option\"]'
Ce problème peut-être reproduit en local, en diminuant le wait à 0.001 ;
avec une plus grande valuer il disparaît.
2022-08-03 16:15:40 +02:00
Colin Darie
9ebcbbbd67
test(brouillon_spec): fix random errors due to db champs not yet updated
2022-08-03 16:15:40 +02:00
Colin Darie
e8b088c2c5
test(brouillon_spec): remove unecessary manual sleep, improve "brouillon" feedback testing
2022-08-03 16:15:39 +02:00
Colin Darie
81a9258c8a
test(brouillon_spec): use capybara wait matchers
2022-08-03 16:15:39 +02:00
Colin Darie
983815bfe8
test(brouillon_spec): fix frequent dossier_link error by using an existing dossier
2022-08-03 16:15:39 +02:00
Colin Darie
9e9b429100
test: fix frequent too many open files with webmock & capybara
2022-08-03 16:15:39 +02:00
Colin Darie
3ce699eef3
chore(bundle): updata capybara 3.35.3 => 3.37.1 + capybara-screenshot
2022-08-03 16:15:38 +02:00
Paul Chavard
18a2419b96
Merge pull request #7658 from tchak/update-dependencies
...
chore(npm): update dependencies
2022-08-03 14:49:04 +02:00
Paul Chavard
7024c4c551
chore(npm): update dependencies
2022-08-03 14:31:42 +02:00
Paul Chavard
e764aade13
fix(db): types_de_champ migration is too long
2022-08-03 14:22:34 +02:00
Paul Chavard
cc3568df00
Merge pull request #7651 from tchak/fix-autosave-en-construction
...
fix(autosave): on check condition requests do not send file inputs
2022-08-03 12:29:21 +02:00
Paul Chavard
cf315b7246
fix(autosave): on check condition requests do not send file inputs
2022-08-03 12:04:39 +02:00
Paul Chavard
fdbcdfd043
fix(utils): explicitly exclude file type from text inputs
2022-08-03 12:04:39 +02:00
Colin Darie
b446e4867f
Merge pull request #7643 from betagouv/fix-contact-captcha
...
fix: contact captcha invisibility, view_component update
2022-08-03 12:03:17 +02:00
Colin Darie
4a1325eadf
fix(view_component): replace form_with with unaffected buffer form_tag helper
...
form_with/form_for have buffer issues (at least with turbo).
form_tag seems not affected.
2022-08-03 11:57:26 +02:00
Colin Darie
76150c4bf5
chore(bundle): update again view_component for a nester helper fix
2022-08-03 11:57:26 +02:00
Colin Darie
bc7cdb6b8e
fix(contact): translate captcha honeypot label
2022-08-03 11:57:26 +02:00
Colin Darie
0641069d0b
chore(bundle): update view_component, no need for use_global_output_buffer anymore
...
This fix contact form and captcha invisibility due to buffer issues.
Closes #7627
2022-08-03 11:57:26 +02:00
Colin Darie
d397fa742b
Merge pull request #7647 from betagouv/fix-dossier-transfer-without-email
...
fix: dossier_transfer requires a valid email
2022-08-03 11:51:19 +02:00
Colin Darie
db968a1ffc
fix(db): remove DossierTransfer without email
2022-08-03 11:44:54 +02:00
Colin Darie
11a9a6f53f
feat(dossier_transfer/email): require email in browser side
2022-08-03 11:44:54 +02:00
Colin Darie
d53aba4d24
fix(dossier_transfer): require a valid email
...
Cf #7621
2022-08-03 11:44:54 +02:00
Colin Darie
a5d5f4307f
fix(dossier_transfer): avoid all transfers without valid email
...
Cf #7621
2022-08-03 11:44:54 +02:00
Colin Darie
8dc966feb4
fix(dossier_transfer): requires an actual email
...
Closes #7621
2022-08-03 11:44:54 +02:00
Colin Darie
c5fef621e4
Merge pull request #7655 from betagouv/sentry-tag-procedure-dossier
...
chore(sentry): tag dossier & procedure ids on dossier endpoints
2022-08-03 11:03:33 +02:00
Colin Darie
707ea37b33
chore(sentry): tag dossier & procedure ids on dossier endpoints
2022-08-03 10:34:10 +02:00
Colin Darie
8b962b4624
Merge pull request #7654 from betagouv/fix-agent-connect-service
...
fix(agent_connect): constant path
2022-08-03 10:27:38 +02:00
Colin Darie
e8210e6c2b
fix(agent_connect): constant path
...
https://sentry.io/organizations/demarches-simplifiees/issues/3248516694/?project=1429550&query=is%3Aunresolved&statsPeriod=14d
2022-08-03 10:19:45 +02:00
Paul Chavard
6625f30fc3
Merge pull request #7652 from tchak/fix-conditionel-activation-by-procedure
...
fix(conditional): enable conditional per procedure
2022-08-03 09:21:10 +02:00
Paul Chavard
f48048179c
fix(conditional): enable conditional per procedure
2022-08-03 09:16:10 +02:00
Colin Darie
e78254a7c8
Merge pull request #7650 from betagouv/dev-add-pry-rails
...
chore(dev): add more pry features with pry-rails gem
2022-08-02 19:12:38 +02:00
Colin Darie
6b95ce5ecc
chore(dev): add more pry features with pry-rails gem
2022-08-02 18:47:58 +02:00
Paul Chavard
5110077587
Merge pull request #7608 from tchak/test-better-factories
...
Amelioration des factories de procedure/types_de_champ
2022-08-02 18:03:31 +02:00
Paul Chavard
a88390c6d3
refactor(types_de_champ): use new types_de_champ factory
2022-08-02 16:21:33 +02:00
Paul Chavard
21d47fa875
test(factory): spec new procedure.types_de_champ factory
2022-08-02 16:21:33 +02:00
Paul Chavard
ee9851091f
test(factory): add a new way to build/create types_de_champ
2022-08-02 16:21:33 +02:00
Paul Chavard
2487cb47c0
Merge pull request #7641 from tchak/chore-remove-ignored-columns
...
chore(db): remove ignored columns
2022-08-02 15:30:35 +02:00
Paul Chavard
435a635b3d
fix(procedure_presentation): find last instance of type_de_champ through coordinates
2022-08-02 15:24:52 +02:00
Paul Chavard
48a4e8bec5
chore(db): remove already dropped ignored columns
2022-08-02 15:24:52 +02:00
Paul Chavard
10ef4a4be5
chore(db): remove ignored columns
2022-08-02 15:24:52 +02:00
