Commit graph

4160 commits

Author SHA1 Message Date
gregoirenovel
efaa99c489
Merge pull request #1763 from betagouv/pipedrive-refactor
Pipedrive refactor
2018-04-09 10:54:48 +02:00
gregoirenovel
26b66aac96 Improve a method name 2018-04-09 09:54:11 +02:00
gregoirenovel
136f15b89c Improve some variable names 2018-04-09 09:54:11 +02:00
gregoirenovel
4c24c8346a Use better names for PipedriveService methods 2018-04-09 09:54:11 +02:00
gregoirenovel
71e9a6056d Structure the helpers methods the same way 2018-04-09 09:54:10 +02:00
gregoirenovel
c5953f8aef Use .join to generate urls (unification) 2018-04-09 09:54:10 +02:00
gregoirenovel
298d7d050c Mutualize some code in Pipedrive::API#put 2018-04-09 09:54:10 +02:00
gregoirenovel
e688fc4212 Mutualize some code in Pipedrive::API#get 2018-04-09 09:54:10 +02:00
gregoirenovel
d202e0173e Mutualize some code in Pipedrive::API#get 2018-04-09 09:54:10 +02:00
gregoirenovel
d287eb0e5f Create Pipedrive::API get helpers 2018-04-09 09:54:10 +02:00
gregoirenovel
4ff07f2b93 Mutualize a call Pipedrive::API.put 2018-04-09 09:54:10 +02:00
gregoirenovel
e31b839e0c Create Pipedrive::API put helpers 2018-04-09 09:54:10 +02:00
gregoirenovel
1f226d882c Dont use the class << self pattern 2018-04-09 09:54:10 +02:00
gregoirenovel
e71d3a76fa Refactor Pipedrive: create adapters and an API files 2018-04-09 09:54:10 +02:00
gregoirenovel
82d6f0b8a8 Add a method name to better separate responsabilities
Also rename a method to better reflect what it does
2018-04-09 09:54:10 +02:00
LeSim
ca3e73440b
Merge pull request #1810 from betagouv/frederic/fix_1809-attestation_champ_special_empeche_instruction
[Fix #1809] Handle non-champ tags in attestation
2018-04-06 20:54:16 +02:00
Frederic Merizen
6ed7ae4b53 [Fix #1809] Handle non-champ tags in attestation 2018-04-06 19:22:42 +02:00
gregoirenovel
2f2e26470d
Merge pull request #1807 from betagouv/fred-comments
Fix issues spotted by @fredZen in #1802
2018-04-06 16:44:40 +02:00
gregoirenovel
c60c58ff8b Fix issues spotted by @fredZen in #1802 2018-04-06 16:39:54 +02:00
gregoirenovel
f2f7fae6c9
Merge pull request #1802 from SocialGouv/issue-1494
Warn a user before accepting a dossier if fields of the attestation are empty
2018-04-06 16:19:21 +02:00
kemar
b42e410da0 [Fix #1494] Display a warning when accepting a dossier if needed
Show the accompagnateur the unspecified demande
champs and attestations privées needed for the
attestation
2018-04-06 16:15:09 +02:00
LeSim
23bc67214a
Merge pull request #1806 from betagouv/fix_1805_notice
[fix #1805] Notice: display notice only if needed
2018-04-06 12:37:11 +02:00
simon lehericey
2e3f72bc56 [fix #1805] Notice: display notice only if needed 2018-04-06 12:32:22 +02:00
Frederic Merizen
498b01541d
Merge pull request #1785 from betagouv/frederic/fix_1563/mail_admins_for_existing_procedures
#1563 – mail admins for existing procedures
2018-04-06 10:29:54 +02:00
Frederic Merizen
7b80936991 [#1563] Notify administrators when they need to edit the accusé d’acceptation 2018-04-06 10:24:38 +02:00
Frederic Merizen
fd194bd667
Merge pull request #1782 from betagouv/frederic/fix_1563/warn_on_mail_attestation_discrepancy
#1563 – warn on mail attestation discrepancy
2018-04-06 10:23:55 +02:00
Frederic Merizen
b27218c7c4 [#1563] Display attestation / closed mail discrepancy alert in admin interface
- When changing emails
- When changing attestation
- As a safety net, on summary page
2018-04-06 10:18:56 +02:00
Frederic Merizen
a2ffc4357d [#1563] Generate a helpful alert on attestation / closed mail mismatch 2018-04-06 10:18:56 +02:00
Frederic Merizen
809638df79 [#1563] Determine if Attestation and Closed mail are out of sync 2018-04-06 10:18:56 +02:00
Paul Chavard
c7f5cab71a
Merge pull request #1796 from tchak/api-entreprise-job
Job to fetch missing établissements
2018-04-05 18:55:40 +02:00
Paul Chavard
ea43784376 Task to enque jobs to fetch missing etablissements 2018-04-05 14:52:54 +02:00
Paul Chavard
d71aabd291 Job to fetch missing etablissement 2018-04-05 14:52:29 +02:00
Paul Chavard
92c195ad51
Merge pull request #1512 from tchak/siret-type-de-champ
SIRET Type De Champ
2018-04-05 10:38:02 +02:00
Paul Chavard
45ef32e6d9 Add SIRET Type De Champ 2018-04-05 10:29:29 +02:00
Paul Chavard
0b79a3d79d Add Siret(TypeDe)Champ STI model 2018-04-04 18:44:08 +02:00
Paul Chavard
3cd80af6cb Add sign and verify to etablissement 2018-04-04 18:44:08 +02:00
Paul Chavard
714ebda2fe Add SignatureService 2018-04-04 18:44:08 +02:00
LeSim
d1b5bc6835
Merge pull request #1798 from betagouv/fix_broken_notice
[fix #1797][fix #1063] Add notice link to dossier modifier
2018-04-04 18:38:30 +02:00
simon lehericey
b15be89e0c [fix #1797][fix #1063] Add notice link to dossier modifier 2018-04-04 18:05:55 +02:00
gregoirenovel
62b9eb3bc7
Merge pull request #1795 from betagouv/carto-empty-state
Add an empty state for carto
2018-04-04 16:45:55 +02:00
gregoirenovel
616e0041a5 Add an empty state for carto
Avoids parsing errors
2018-04-04 16:35:30 +02:00
LeSim
1bbf1fc86b
Merge pull request #1794 from betagouv/change_individual_birthdate_type
Individual: change birthdate column type
2018-04-04 16:05:52 +02:00
simon lehericey
3c8d1f13b6 Individual: remove birthdate proxy 2018-04-04 15:27:30 +02:00
simon lehericey
155ffcb4ba Individual: change birthdate column type 2018-04-04 15:26:51 +02:00
Mathieu Magnin
235dfc0ab1
Merge pull request #1790 from betagouv/fix-1724
[Fix #1724] Fix carto
2018-04-04 14:05:44 +02:00
Mathieu Magnin
8c1c2f32ca [Fix #1724] Ensure that printed json is safe 2018-04-04 14:00:50 +02:00
LeSim
c670c0fbea
Merge pull request #1792 from betagouv/improve_individual_date_second_part
Individual: use birthdate as a  ... date :)
2018-04-04 13:52:18 +02:00
simon lehericey
c019cb623a Individual: use birthdate as a ... date :) 2018-04-04 13:19:39 +02:00
LeSim
b67b13aac8
Merge pull request #1791 from betagouv/missing_individual_part_in_old_controller
Individual: missing individual part in old controller
2018-04-04 13:15:35 +02:00
simon lehericey
1f536c94ab Individual: missing individual part in old controller 2018-04-04 12:25:54 +02:00