Merge pull request #1782 from betagouv/frederic/fix_1563/warn_on_mail_attestation_discrepancy

#1563 – warn on mail attestation discrepancy

app/models/procedure.rb

@@ -265,6 +265,18 @@ class Procedure < ApplicationRecord
     update_attribute('whitelisted_at', DateTime.now)
   end
 
+  def closed_mail_template_attestation_inconsistency_state
+    # As an optimization, don’t check the predefined templates (they are presumed correct)
+    if closed_mail.present?
+      tag_present = closed_mail.body.include?("--lien attestation--")
+      if attestation_template&.activated? && !tag_present
+        :missing_tag
+      elsif !attestation_template&.activated? && tag_present
+        :extraneous_tag
+      end
+    end
+  end
+
   private
 
   def field_hash(label, table, column)

app/views/admin/_closed_mail_template_attestation_inconsistency_alert.html.haml

@@ -0,0 +1,22 @@
+- case @procedure.closed_mail_template_attestation_inconsistency_state
+- when :missing_tag
+  .center
+    .alert{ class: flash_class('alert') }
+      Cette procédure comporte une attestation, mais l’accusé d’acceptation ne la mentionne pas :
+      - if !@procedure.locked?
+        = link_to('désactivez l’attestation', edit_admin_procedure_attestation_template_path(@procedure))
+        ou
+      = link_to('ajoutez la balise', edit_admin_procedure_mail_template_path(@procedure, Mails::ClosedMail::SLUG))
+      %code{ style: "white-space: pre-wrap;" }
+        \--lien attestation--
+      à l’accusé d’acceptation
+- when :extraneous_tag
+  .center
+    .alert{ class: flash_class('alert') }
+      Cette procédure ne comporte pas d’attestation, mais l’accusé d’acceptation en mentionne une :
+      = link_to('activez l’attestation', edit_admin_procedure_attestation_template_path(@procedure))
+      ou
+      = link_to('enlevez la balise', edit_admin_procedure_mail_template_path(@procedure, Mails::ClosedMail::SLUG))
+      %code{ style: "white-space: pre-wrap;" }
+        \--lien attestation--
+      de l’accusé d’acceptation

app/views/admin/attestation_templates/edit.html.haml

@@ -1,3 +1,4 @@
+= render partial: 'admin/closed_mail_template_attestation_inconsistency_alert'
 #attestation-template-edit.row.white-back
   = form_for @attestation_template, url: admin_procedure_attestation_template_path do |f|
     .row

app/views/admin/mail_templates/edit.html.haml

@@ -1,3 +1,5 @@
+- if params[:id] == 'closed_mail'
+  = render partial: 'admin/closed_mail_template_attestation_inconsistency_alert'
 .white-back
   %h3
     = @mail_template.class.const_get(:DISPLAYED_NAME)

app/views/admin/mail_templates/index.html.haml

@@ -1,3 +1,4 @@
+= render partial: 'admin/closed_mail_template_attestation_inconsistency_alert'
 #custom-mails
   .wrapper
     %h1 E-mails personnalisables

app/views/admin/procedures/show.html.haml

@@ -1,3 +1,4 @@
+= render partial: 'admin/closed_mail_template_attestation_inconsistency_alert'
 .row.white-back
   #procedure_show
     - if @facade.procedure.brouillon?

spec/models/procedure_spec.rb

@@ -67,6 +67,90 @@ describe Procedure do
     end
   end
 
+  describe '#closed_mail_template_attestation_inconsistency_state' do
+    let(:procedure_without_attestation) { create(:procedure, closed_mail: closed_mail) }
+    let(:procedure_with_active_attestation) do
+      procedure = create(:procedure, closed_mail: closed_mail)
+      create(:attestation_template, procedure: procedure, activated: true)
+      procedure
+    end
+    let(:procedure_with_inactive_attestation) do
+      procedure = create(:procedure, closed_mail: closed_mail)
+      create(:attestation_template, procedure: procedure, activated: false)
+      procedure
+    end
+
+    subject { procedure.closed_mail_template_attestation_inconsistency_state }
+
+    context 'with a custom mail template' do
+      context 'that contains a lien attestation tag' do
+        let(:closed_mail) { create(:closed_mail, body: '--lien attestation--') }
+
+        context 'when the procedure doesn’t have an attestation' do
+          let(:procedure) { procedure_without_attestation }
+
+          it { is_expected.to eq(:extraneous_tag) }
+        end
+
+        context 'when the procedure has an active attestation' do
+          let(:procedure) { procedure_with_active_attestation }
+
+          it { is_expected.to be(nil) }
+        end
+
+        context 'when the procedure has an inactive attestation' do
+          let(:procedure) { procedure_with_inactive_attestation }
+
+          it { is_expected.to eq(:extraneous_tag) }
+        end
+      end
+
+      context 'that doesn’t contain a lien attestation tag' do
+        let(:closed_mail) { create(:closed_mail) }
+
+        context 'when the procedure doesn’t have an attestation' do
+          let(:procedure) { procedure_without_attestation }
+
+          it { is_expected.to be(nil) }
+        end
+
+        context 'when the procedure has an active attestation' do
+          let(:procedure) { procedure_with_active_attestation }
+
+          it { is_expected.to eq(:missing_tag) }
+        end
+
+        context 'when the procedure has an inactive attestation' do
+          let(:procedure) { procedure_with_inactive_attestation }
+
+          it { is_expected.to be(nil) }
+        end
+      end
+    end
+
+    context 'with the default mail template' do
+      let(:closed_mail) { nil }
+
+      context 'when the procedure doesn’t have an attestation' do
+        let(:procedure) { procedure_without_attestation }
+
+        it { is_expected.to be(nil) }
+      end
+
+      context 'when the procedure has an active attestation' do
+        let(:procedure) { procedure_with_active_attestation }
+
+        it { is_expected.to be(nil) }
+      end
+
+      context 'when the procedure has an inactive attestation' do
+        let(:procedure) { procedure_with_inactive_attestation }
+
+        it { is_expected.to be(nil) }
+      end
+    end
+  end
+
   describe 'validation' do
     context 'libelle' do
       it { is_expected.not_to allow_value(nil).for(:libelle) }

spec/views/admin/_closed_mail_template_attestation_inconsistency_alert.html.haml_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+describe 'admin/_closed_mail_template_attestation_inconsistency_alert.html.haml', type: :view do
+  let(:procedure) { create(:procedure, closed_mail: closed_mail, published_at: published_at) }
+  let(:published_at) { nil }
+
+  def alert
+    assign(:procedure, procedure)
+    render
+    rendered
+  end
+
+  context 'when there is no inconsistency' do
+    let(:closed_mail) { nil }
+
+    it { expect(alert).to be_empty }
+  end
+
+  context 'when there is no active attestation but the closed mail template mentions one' do
+    let(:closed_mail) { create(:closed_mail, body: '--lien attestation--') }
+
+    it { expect(alert).to include("Cette procédure ne comporte pas d’attestation, mais l’accusé d’acceptation en mentionne une") }
+    it { expect(alert).to include(edit_admin_procedure_attestation_template_path(procedure)) }
+    it { expect(alert).to include(edit_admin_procedure_mail_template_path(procedure, Mails::ClosedMail::SLUG)) }
+  end
+
+  context 'when there is an active attestation but the closed mail template does not mention it' do
+    let(:closed_mail) { create(:closed_mail) }
+    let!(:attestation_template) { create(:attestation_template, procedure: procedure, activated: true) }
+
+    it { expect(alert).to include("Cette procédure comporte une attestation, mais l’accusé d’acceptation ne la mentionne pas") }
+    it { expect(alert).to include(edit_admin_procedure_mail_template_path(procedure, Mails::ClosedMail::SLUG)) }
+
+    context 'when the procedure has been published, the attestation cannot be deactivated' do
+      let(:published_at) { Time.now }
+
+      it { expect(procedure.locked?).to be_truthy }
+      it { expect(alert).not_to include(edit_admin_procedure_attestation_template_path(procedure)) }
+    end
+
+    context 'when the procedure is still a draft' do
+      it { expect(procedure.locked?).to be_falsey }
+      it { expect(alert).to include(edit_admin_procedure_attestation_template_path(procedure)) }
+    end
+  end
+end