Commit graph

12884 commits

Author SHA1 Message Date
simon lehericey
1706feec3d
feature(agent_connect_2fa): do not log AC/MonComptePro agent without 2fa 2024-09-18 14:40:10 +02:00
simon lehericey
5f25756ae2
ask for amr (Authentication Methods References) 2024-09-18 14:40:10 +02:00
simon lehericey
1e9982927a
add identity_provider id scope 2024-09-18 14:40:10 +02:00
simon lehericey
c0fe06ceb7
refactor: simplify ZxcvbnService 2024-09-18 12:57:58 +02:00
Lisa Durand
214a0daca1
small wording adjustment 2024-09-18 12:57:51 +02:00
LeSim
c89e60d5fa
Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code
Tech: retire la protection contre les colonnes virtuelles
2024-09-18 08:38:20 +00:00
simon lehericey
061c9cc6f3
remove default empty value in drop_down_list 2024-09-18 10:26:00 +02:00
simon lehericey
51e192939c
pack drop_down stuff together 2024-09-18 10:08:12 +02:00
simon lehericey
85684e3bea
homogenize render? if not options 2024-09-18 10:08:12 +02:00
simon lehericey
f1a606da6d
one less indirection 2024-09-18 10:08:12 +02:00
simon lehericey
b3ad237fa1
simplify drop_down_list_value 2024-09-18 10:08:12 +02:00
simon lehericey
2f64fe5e4c
one less indirection 2024-09-18 10:08:12 +02:00
simon lehericey
f046f31dcc
remove_disabled_options 2024-09-18 10:08:11 +02:00
Mathieu Magnin
bfb7b59033
[#10813] When value_json of champ SIRET is nil do not crash 2024-09-17 19:05:36 +02:00
Colin Darie
39ebaadf03
Merge pull request #10811 from colinux/fix-stats-nav-bar
ETQ usager, pas d'erreur sur la page stats quand je viens de la page commencer (à cause de la navbar)
2024-09-17 16:05:24 +00:00
mfo
1e0391c9dc
Merge pull request #10806 from mfo/US/fix-number-not-number-in-filters
Correctif: ETQ instructeur, la recherche par numéro de dossier ne doit accepter que des numero
2024-09-17 14:39:08 +00:00
Colin Darie
79a1d9b99d
fix(navbar): never fail request on broken navbar logic 2024-09-17 16:18:16 +02:00
Colin Darie
b68b340d81
fix(stats): nav bar profile logic when fallbacking on referer context without request 2024-09-17 15:59:24 +02:00
Lisa Durand
1d0be04f2a
Merge pull request #10809 from demarches-simplifiees/design-improve-fc-email-page-ldu
[Design] Amelioration du design de la page de confirmation du mail de France Connect
2024-09-17 13:47:02 +00:00
Eric Leroy-Terquem
969706163b
Merge pull request #10641 from demarches-simplifiees/move-image-treatment-to-jobs
Technique : déplace les traitements d‘images côté jobs
2024-09-17 13:43:51 +00:00
mfo
ebb51e8128
fix(filters): filter by dossier should only accept number 2024-09-17 15:18:23 +02:00
Lisa Durand
edc4f826f2
small design improvement for FC email page 2024-09-17 15:01:01 +02:00
Mathieu Magnin
8384be12a0
Fix missing expiration after refacto 2024-09-17 14:26:06 +02:00
Paul Chavard
3fef831524
move child? method for clarity 2024-09-17 10:29:34 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids 2024-09-17 10:29:34 +02:00
Paul Chavard
33e502234e
refactor(dossier loader): simplify all the things 2024-09-17 10:29:34 +02:00
Paul Chavard
2ba356bc68
cleanup(prefill): remove unused validation 2024-09-17 10:29:34 +02:00
Paul Chavard
c94d1b7eea
cleanup: more concistent methods usage 2024-09-17 10:29:34 +02:00
Paul Chavard
a474cf4590
refactor(attestation): unspecified_champs_for_dossier based on types_de_champ 2024-09-17 10:29:34 +02:00
Paul Chavard
54926db89b
refactor(champ): more concistent champ_for_update usage 2024-09-17 10:29:34 +02:00
Paul Chavard
988025ba69
refactor(champs): validate only champs in current revision 2024-09-17 10:29:34 +02:00
Paul Chavard
df83322f0c
refactor(apiv1): use dossier preloader on api v1 2024-09-17 10:29:34 +02:00
Paul Chavard
ed4fbc887a
refactor(dossier): remove unused scopes 2024-09-17 10:29:34 +02:00
Paul Chavard
3817f334c9
refactor(repetition): use less champs and public_id methods 2024-09-17 10:29:34 +02:00
Mathieu Magnin
b4ed11c788
Merge pull request #10800 from demarches-simplifiees/fix-10798
[#10798] ETQ Superadmin, je veux savoir sur le Manager si une démarche a un jeton d'api entreprise configuré
2024-09-17 07:59:59 +00:00
Mathieu Magnin
7ace670010
[#10798] fix tests 2024-09-17 09:47:46 +02:00
mfo
36247a4b6d
Merge pull request #10770 from demarches-simplifiees/US/fix-timeouting-task-fixing-champs-commune
ETQ operateur DS, je souhaite pouvoir corriger les champs de type commune ayant de la bad data
2024-09-17 07:17:47 +00:00
Paul Chavard
9924b2d640
Merge pull request #10804 from tchak/better_drop_down_other_option
Drop down other label set to 'Enter another option' instead of 'Other'
2024-09-16 15:12:14 +00:00
Paul Chavard
34a05d0bf0
Merge pull request #10462 from demarches-simplifiees/can-filter-from-repetition-content
ETQ instructeur je peux filtrer à partir du contenu d'un bloc répétable
2024-09-16 14:59:05 +00:00
Paul Chavard
e7bc7c4783
feat(procedure): can filter from repetion content 2024-09-16 16:46:49 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
Christian Lautier
17bbc474ff
Drop down other label set to 'Enter another option' instead of 'Other' 2024-09-16 16:41:46 +02:00
mfo
18137b176c
fix(fix_champs_commune_having_value_but_not_external_id_task): timeouting despite classic pattern to find all champs for a specific type. lighten request by selecting only :id and processing batches 2024-09-16 16:38:46 +02:00
mfo
6af07dd721
data(fix): backfill invalid procedure presentation filters having a value greater than pg max integer 2024-09-16 16:36:02 +02:00
mfo
4bd518f85e
Merge pull request #10802 from mfo/US/fix-rnf-with-removed-fondation
Correctif: ETQ usager/instructeur, je souhaite pouvoir visualiser les dossiers ayant un champ fondation dont celle ci a ete supprimé du registre
2024-09-16 13:48:05 +00:00
Paul Chavard
e9009025f6
Merge pull request #10736 from demarches-simplifiees/fix-notif-to-instructeurs-when-import
Correctif: lors de l‘import en masse d'instructeurs, les nouveaux instructeurs reçoivent un lien pour vérifier leur email
2024-09-16 13:31:33 +00:00
Lisa Durand
030bfa6651
disable submit button on page loading 2024-09-16 15:28:15 +02:00
Lisa Durand
22e06bc5eb
change password complexity library and setup 2024-09-16 15:28:14 +02:00
Lisa Durand
71e03203aa
add password complexity for expert 2024-09-16 15:23:43 +02:00
Lisa Durand
766a5608bb
remove unused views 2024-09-16 15:23:43 +02:00
Lisa Durand
00a155b896
add password complexity for instructeur, user and password change 2024-09-16 15:23:43 +02:00
mfo
e2ec5118f4
fix(champs.rnf): some foundations was removed from the registry. lucky us [or good archi ? :D], we kept api data 2024-09-16 14:24:40 +02:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db 2024-09-16 12:55:59 +02:00
Colin Darie
58037f21cd
Merge pull request #10778 from colinux/sharerd-controller-nav-bar-profile
UX: améliore la détection du type de profile utilisé pour la nav bar
2024-09-16 08:01:03 +00:00
Mathieu Magnin
539853255d
Missing frozen_string_literal 2024-09-13 16:52:42 +02:00
Mathieu Magnin
ce22adf811
[#10798] Indicate in manager if api_entreprise_token is present / valid / expired 2024-09-13 16:47:31 +02:00
Paul Chavard
f00ba04fb9
graphql(playground): fix acl 2024-09-13 14:28:13 +02:00
mfo
7a78fdc913
fix(normalized_address): should not raise an error for addresses without code postal 2024-09-13 11:19:05 +02:00
simon lehericey
bc7d91751d
Revert "fix: ignore virtual data in column initialization"
This reverts commit 4289aa2cf5.
2024-09-13 11:00:08 +02:00
Mathieu Magnin
d8a0adc6ed
Merge pull request #10772 from demarches-simplifiees/fix-10751
ETQ Instructeur, jamais connecté, je ne veux pas recevoir 10 mails si j'ai été ajouté à 10 groupes
2024-09-13 08:08:16 +00:00
Colin Darie
8dfddba433
Merge pull request #10584 from colinux/attestation-render-list
ETQ admin, améliore l'affichage de champ choix multiple et répétitions dans les attestations v2
2024-09-12 14:40:32 +00:00
Lisa Durand
697e2328e3
Merge pull request #10777 from demarches-simplifiees/improve-wording-reset-link-pwd-ldu
ETQ usager, améliore la page après envoi du mot de passe oublié
2024-09-12 14:37:48 +00:00
Colin Darie
f6744adbde
fix: never show 'guest' profile name
it's just a hack to tell we don't known the actual profile
2024-09-12 10:00:19 +02:00
Colin Darie
d566186954
fix: coherent nav bar profile for super admins 2024-09-12 10:00:19 +02:00
Colin Darie
16e1daac9b
fix(recherche): respects nav bar profile context 2024-09-12 10:00:18 +02:00
Colin Darie
0309e0f6b2
refactor(profile): generalize profile from referrer or for user 2024-09-12 10:00:18 +02:00
Mathieu Magnin
a99fae168c
[#10751] Allow sending a new invitation if the user's previous one has expired 2024-09-11 18:45:15 +02:00
Mathieu Magnin
790177c758
[#10751] Only send the first invitation mail to the instructeur if email is not verified (from admin controller) 2024-09-11 18:45:15 +02:00
Mathieu Magnin
d7811fca40
[#10751] Only send the first invitation mail to the instructeur if email is not verified 2024-09-11 18:45:15 +02:00
Colin Darie
b5c024cca5
Merge pull request #10768 from colinux/disable-admin-hide-instructeur-toggle
ETQ tech c'est finalement par le manager qui définit si le flag pour masquer l'email des instructeurs
2024-09-11 15:29:06 +00:00
Colin Darie
0201feec65
feat(manager): can hide instructeurs email from procedure 2024-09-11 17:20:58 +02:00
Colin Darie
b987688d19
refactor: disable auto hide instructeurs toggle by admin 2024-09-11 17:20:57 +02:00
Colin Darie
09cafdb15f
Merge pull request #10745 from colinux/helpscout-delete-old-customers
ETQ opérateur, je supprime les contacts HS > 2 ans
2024-09-11 15:19:33 +00:00
Lisa Durand
966c110df8
add strong tags to highlight email and application name 2024-09-11 15:26:58 +02:00
Lisa Durand
abbbb09180
make reset link page clearer 2024-09-11 11:41:11 +02:00
mfo
02bbf26d3f
feat(ProcedurePresentation): validates that ProcedurePresentation.filters using a value casted as an integer [search by id] is not out of pg integer range 2024-09-10 17:47:50 +02:00
Colin Darie
6240d54fd4
fix: unbreakable space for better look in filters 2024-09-10 12:36:13 +02:00
Colin Darie
40b5eb5ea7
fix: typo region => région 2024-09-10 12:29:53 +02:00
simon lehericey
4289aa2cf5
fix: ignore virtual data in column initialization 2024-09-09 16:37:22 +02:00
Colin Darie
ab3139c2ed
Merge pull request #10680 from demarches-simplifiees/a11y-fix-demarche-header
Refonte du menu d'aide
2024-09-09 14:17:50 +00:00
mfo
5ab57a32ce
Merge pull request #10762 from mfo/US/export-when-tdc-change
Correctif, ETQ instructeur exportant mes dossiers, je souhaite retrouver la valeur saisie par les usagers quand les types de champ ont changés de type mais que les données restent compatible
2024-09-09 09:26:42 +00:00
mfo
7ec17ff7f5
fix(dossier.export): should not use default value when types_de_champ changed to a similar one 2024-09-09 11:00:01 +02:00
Colin Darie
7c30ab87bc
Merge pull request #10712 from colinux/rails-7-finalize-defaults
Rails 7.0 : finalise la migration des defaults
2024-09-09 08:08:27 +00:00
Colin Darie
977e47fa74
Merge pull request #10757 from mfo/US/fix-required-dossier-link-with-missing-dossier
correct: ETQ administrateur, je souhaite que les types de champ liens vers un dossier pointent vers un dossier valide si ils sont obligatoire
2024-09-09 07:28:48 +00:00
Colin Darie
6e9fb7f247
Merge pull request #10740 from colinux/debug-email-verified
ETQ tech et super-admin, je veux voir rapidement si un user a son email verifié
2024-09-09 07:23:32 +00:00
Colin Darie
5d4cafc18f
Merge pull request #10722 from colinux/migrates-otp-secrets
Tech: task pour copier les secrets OTP vers les encrypted attributes
2024-09-09 07:08:30 +00:00
Colin Darie
1515e67651
Merge pull request #10760 from demarches-simplifiees/fix_unverified_admin_email
ETQ Administrateur, je peux recevoir des mails lorsque je valide mon compte depuis le mail d'invitation
2024-09-09 07:07:26 +00:00
Mathieu Magnin
71d43078ee
Merge pull request #10743 from demarches-simplifiees/fix-10742
ETQ instructeur mon adresse email est automatiquement vérifiée quand je me connecte par AgentConnect
2024-09-06 14:26:54 +00:00
Mathieu Magnin
628be7c703
update => update! 2024-09-06 16:18:25 +02:00
Mathieu Magnin
22473adec7
[#10742] Set email as verified when instructeur signs in with Agent Connect 2024-09-06 16:18:11 +02:00
Mathieu Magnin
8d68bebaed
Merge pull request #10761 from demarches-simplifiees/fix-10754
ETQ Instructeur, si je n'ai pas vérifié mon email je dois quand même recevoir un email avec login token
2024-09-06 14:14:54 +00:00
LeSim
723ea310ba
Merge pull request #10758 from demarches-simplifiees/fix-10752
ETQ Instructeur je veux avoir mon email vérifié si je reset mon mdp
2024-09-06 13:36:29 +00:00
Eric Leroy-Terquem
41ee00ebc3
Merge pull request #10755 from demarches-simplifiees/remove_gallery_demande_feature_flag
Technique : retire le feature flag gallery_demande
2024-09-06 13:00:54 +00:00
Mathieu Magnin
d1749c2baf
[#10754] verify email when using login token 2024-09-06 14:56:44 +02:00
simon lehericey
277c1a17c6
set verified_email when admin set its password from email link 2024-09-06 14:51:48 +02:00
Mathieu Magnin
95eb9ef9d4
[#10754] bypass unverified mail protection for login token emails 2024-09-06 14:15:06 +02:00
mfo
915779c9b0
Merge pull request #10749 from mfo/US/commune-without-insee
correctif: ETQ administrateur/instructeur, je souhaite que les champs de type commune aient tjr un code insee afin de router de maniere fiable
2024-09-06 11:44:00 +00:00
Mathieu Magnin
9e843a3df4
[#10752] set email verified after password reset 2024-09-06 12:06:05 +02:00
mfo
eb8b9a13ca
fix(Champs::DossierLinkChamp): when required, should point to existing dossier 2024-09-06 11:23:12 +02:00
Eric Leroy-Terquem
765281e1c3
chore(flipper): remove gallery_demande feature flag 2024-09-06 10:46:28 +02:00
Eric Leroy-Terquem
7dc853ad1c
refactor(instructeurs import): extract notify_instructeurs method 2024-09-06 10:00:17 +02:00
Eric Leroy-Terquem
d361ce2e38
fix(instructeurs import): send confirmation link if new instructeurs 2024-09-06 10:00:17 +02:00
mfo
657fb0ebf4
feat(Maintenance.communes): backfill missing external_id for communes champs in error 2024-09-06 09:29:28 +02:00
mfo
ace2f4382f
tech(refactor): DataSources::CommuneController, move request methods to fetch and format commune searched by postal_code or name 2024-09-06 08:37:08 +02:00
mfo
5abba5a166
feat(Champs::CommuneChamp): ensure presence of external_id since some of Champs::CommuneChamp.external_id are missing while .value is present 🔥 2024-09-06 08:37:08 +02:00
Colin Darie
328844dabf
feat(task): delete contacts without activity since 2 years 2024-09-05 10:50:42 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Colin Darie
247bb6f8c6
refactor(attestation): hide libelle of empty repetitions 2024-09-04 17:42:04 +02:00
Kara Diaby
9cebac1d99
Supprime la vérification par feature flag et utilise la vérif par booléen au booléen 2024-09-04 15:00:03 +00:00
Kara Diaby
c86ad15b8c
Ajoute hide_instructeurs_identity sur Procedures et dans l'interface admin 2024-09-04 15:00:03 +00:00
Colin Darie
9f9720d65b
fix(attestation): delete empty paragraphs 2024-09-04 15:04:07 +02:00
Kara Diaby
07ea31fc4c
Add aria accessibility regarding the hidden class on partial choose email 2024-09-04 08:08:02 +00:00
Kara Diaby
ff88a0a2a6
Fix add requested_email column to france_connect_information table Lint error 2024-09-04 08:08:01 +00:00
Kara Diaby
08fb6c856e
Fix choose email screen 2024-09-04 08:08:01 +00:00
simon lehericey
ce095479b7
fix password reset with bad password scenario 2024-09-04 08:08:01 +00:00
simon lehericey
eaef5c7e39
readapt name and logic 2024-09-04 08:08:01 +00:00
mfo
c0970693f3
fix(associate_user.with_existing_one): does not leak existing email when trying to choose an alternative email with france connect 2024-09-04 08:05:54 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review 2024-09-04 08:05:54 +00:00
mfo
3cd5d778ca
a11y(particulier/merge): no empty legend, ensure to link fieldset with legend 2024-09-04 08:05:54 +00:00
mfo
03d425859d
feat(particulier#confirm_email): nicer 2024-09-04 08:05:54 +00:00
mfo
88a4619dcb
feat(particulier#associate_user): catch email already taken and redirect to reset password 2024-09-04 08:05:53 +00:00
mfo
828f491c14
feat(france_connect#choose_email): prevent bad email 2024-09-04 08:05:53 +00:00
mfo
fe69ada7d9
a11y(particulier/choose_email): no empty legend, ensure to link fieldset with legend 2024-09-04 08:05:53 +00:00
Kara Diaby
337f88575d
Modifications sur la méthode after_confirmation dans le modèle user 2024-09-04 08:05:53 +00:00
Kara Diaby
d6defce137
Ajoute un mailer pour l'envoi du lien de confirmation de mail customisé 2024-09-04 08:05:52 +00:00
Kara Diaby
9c41c9a08f
Model FC : au lieu de valider le mail on envoie une demande de confirmation par mail 2024-09-04 08:05:52 +00:00
Kara Diaby
c51cf7e048
Layout : ajoute les vues pour confirmer le mail fc ou en choisir un autre 2024-09-04 08:05:52 +00:00
Kara Diaby
fb5968bf25
France connect particulier controller : permet de gérer le cas ou le mail n'est pas connu de DS
Signed-off-by: Kara Diaby <kdiaby.pro@gmail.com>
2024-09-04 08:05:51 +00:00
Colin Darie
1524f5ba16
feat(maintenance): add task to copy super admin OTP secrets to Rails 7 encrypted attributes 2024-09-03 19:25:32 +02:00
mfo
0b8212f151
Merge pull request #10738 from mfo/US/fix-not-expanded-type-de-champ-textarea
ETQ usager, j'aimerais avoir les champs de type texte long d'une hauteur differente des champs de type texte court
2024-09-03 15:24:25 +00:00
Lisa Durand
27c8abfb4b
Merge pull request #10734 from demarches-simplifiees/cannot-publish-with-test-service-ldu
ETQ Admin, je ne dois pas pouvoir publier une démarche avec les informations du service de test
2024-09-03 15:00:30 +00:00
Colin Darie
bd1a888c5b
feat(manager): list email verified at 2024-09-03 16:51:17 +02:00
Colin Darie
d29cf3d222
refactor(activation): more readable condition 2024-09-03 16:51:00 +02:00
mfo
a3050348e2
fix(autoresize_controller.ts): ensure to bind autoresize-textarea when element is visible, otherwise it is not expanded by 5 rows as expected by default
cleaner ts implementation

Co-authored-by: Colin Darie <colin@darie.eu>
2024-09-03 16:41:08 +02:00
simon lehericey
e0daf1032d
rename virtual_dates by non_displayable_dates 2024-09-02 17:27:35 +02:00
simon lehericey
245f7bb975
remove column.virtual params 2024-09-02 17:25:46 +02:00
simon lehericey
3c7c58623f
replace virtual: true by displayable: false 2024-09-02 17:25:22 +02:00
Lisa Durand
b5051a25d9
it displays an alert if using test service before publishing a procedure 2024-09-02 16:52:21 +02:00
Colin Darie
4db4cf1513
fix(attestation): don't render block levels presentation elements into a p 2024-09-02 16:11:02 +02:00
Colin Darie
c9956c4881
feat(attestation): better presentation of repetition champs 2024-09-02 16:11:02 +02:00
Colin Darie
09581ad028
feat(attestation): render multiple drop down list as list 2024-09-02 15:23:11 +02:00
Colin Darie
ae207ac2e6
chore(attestation): link to new test dossier 2024-09-02 15:23:11 +02:00
Colin Darie
8e1cfd50dd
feat(procedure): improve dossier_for_preview with last dossier, excluding hidden by user 2024-09-02 15:23:10 +02:00
Colin Darie
31cc6578aa
Merge pull request #10725 from colinux/admin-minor-renaming
ETQ admin, renomme *Pour aller plus loin* en *Autres paramètres*
2024-09-02 13:20:52 +00:00
Colin Darie
8f60909155
chore(admin): rename 'Pour aller plus loin' => 'Autres paramètres'
Closes #9844
2024-09-02 15:12:41 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
mfo
f171727140
Merge pull request #10703 from mfo/US/dry-rna-rnf-siret-addresses-view
ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET
2024-09-02 12:25:54 +00:00
Colin Darie
46547cb2cd
Merge pull request #10729 from mfo/US/fix-errored-data
ETQ usager, je souhaite que me dossier soit debloqué
2024-08-30 17:45:04 +02:00
mfo
3a33d8af45
fix(data): unlock broken dossier due to bad release 2024-08-30 17:37:05 +02:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring" 2024-08-30 16:43:30 +02:00