LeSim
c89e60d5fa
Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code
...
Tech: retire la protection contre les colonnes virtuelles
2024-09-18 08:38:20 +00:00
simon lehericey
d3667bbd6c
remove empty value in drop_down_list in db
2024-09-18 10:26:01 +02:00
simon lehericey
061c9cc6f3
remove default empty value in drop_down_list
2024-09-18 10:26:00 +02:00
simon lehericey
b3ad237fa1
simplify drop_down_list_value
2024-09-18 10:08:12 +02:00
simon lehericey
2f64fe5e4c
one less indirection
2024-09-18 10:08:12 +02:00
simon lehericey
f046f31dcc
remove_disabled_options
2024-09-18 10:08:11 +02:00
Mathieu Magnin
bfb7b59033
[ #10813 ] When value_json of champ SIRET is nil do not crash
2024-09-17 19:05:36 +02:00
Mathieu Magnin
3a7faeaa5e
Merge pull request #10810 from demarches-simplifiees/add-test-for-jwt-field
...
Add a spec file for the JWT Administrate Field
2024-09-17 15:01:53 +00:00
Mathieu Magnin
587b79ce54
Add a spec file for the JWT Administrate Field
2024-09-17 16:45:45 +02:00
mfo
1e0391c9dc
Merge pull request #10806 from mfo/US/fix-number-not-number-in-filters
...
Correctif: ETQ instructeur, la recherche par numéro de dossier ne doit accepter que des numero
2024-09-17 14:39:08 +00:00
Eric Leroy-Terquem
969706163b
Merge pull request #10641 from demarches-simplifiees/move-image-treatment-to-jobs
...
Technique : déplace les traitements d‘images côté jobs
2024-09-17 13:43:51 +00:00
mfo
ebb51e8128
fix(filters): filter by dossier should only accept number
2024-09-17 15:18:23 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids
2024-09-17 10:29:34 +02:00
Paul Chavard
f02ec3da82
cleanup in spec
2024-09-17 10:29:34 +02:00
Paul Chavard
54926db89b
refactor(champ): more concistent champ_for_update usage
2024-09-17 10:29:34 +02:00
Paul Chavard
988025ba69
refactor(champs): validate only champs in current revision
2024-09-17 10:29:34 +02:00
Paul Chavard
3817f334c9
refactor(repetition): use less champs and public_id methods
2024-09-17 10:29:34 +02:00
Mathieu Magnin
910f0db7ba
[ #10753 ] fix missing condition on created at
2024-09-17 09:35:35 +02:00
Lisa Durand
fdb2ebd5d1
inject more french dictionnaries to zxcvbn lib
2024-09-17 09:31:47 +02:00
mfo
36247a4b6d
Merge pull request #10770 from demarches-simplifiees/US/fix-timeouting-task-fixing-champs-commune
...
ETQ operateur DS, je souhaite pouvoir corriger les champs de type commune ayant de la bad data
2024-09-17 07:17:47 +00:00
Paul Chavard
9924b2d640
Merge pull request #10804 from tchak/better_drop_down_other_option
...
Drop down other label set to 'Enter another option' instead of 'Other'
2024-09-16 15:12:14 +00:00
Paul Chavard
34a05d0bf0
Merge pull request #10462 from demarches-simplifiees/can-filter-from-repetition-content
...
ETQ instructeur je peux filtrer à partir du contenu d'un bloc répétable
2024-09-16 14:59:05 +00:00
Paul Chavard
e7bc7c4783
feat(procedure): can filter from repetion content
2024-09-16 16:46:49 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
...
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
Christian Lautier
17bbc474ff
Drop down other label set to 'Enter another option' instead of 'Other'
2024-09-16 16:41:46 +02:00
mfo
18137b176c
fix(fix_champs_commune_having_value_but_not_external_id_task): timeouting despite classic pattern to find all champs for a specific type. lighten request by selecting only :id and processing batches
2024-09-16 16:38:46 +02:00
mfo
6af07dd721
data(fix): backfill invalid procedure presentation filters having a value greater than pg max integer
2024-09-16 16:36:02 +02:00
mfo
4bd518f85e
Merge pull request #10802 from mfo/US/fix-rnf-with-removed-fondation
...
Correctif: ETQ usager/instructeur, je souhaite pouvoir visualiser les dossiers ayant un champ fondation dont celle ci a ete supprimé du registre
2024-09-16 13:48:05 +00:00
Paul Chavard
e9009025f6
Merge pull request #10736 from demarches-simplifiees/fix-notif-to-instructeurs-when-import
...
Correctif: lors de l‘import en masse d'instructeurs, les nouveaux instructeurs reçoivent un lien pour vérifier leur email
2024-09-16 13:31:33 +00:00
Lisa Durand
1a75e27097
change min_length password from 8 to 12
2024-09-16 15:28:14 +02:00
Lisa Durand
22e06bc5eb
change password complexity library and setup
2024-09-16 15:28:14 +02:00
Lisa Durand
0b0e47b7cd
change passwords in specs
2024-09-16 15:28:11 +02:00
Paul Chavard
dd199eb02d
Merge pull request #10791 from demarches-simplifiees/clean_virtual_column
...
Tech: suppression de l'attribut maintenant obsolète `virtual` des données des procédures présentations
2024-09-16 13:22:38 +00:00
mfo
e2ec5118f4
fix(champs.rnf): some foundations was removed from the registry. lucky us [or good archi ? :D], we kept api data
2024-09-16 14:24:40 +02:00
Paul Chavard
ae7971bdea
Merge pull request #10801 from tchak/api-entreprise-get-foreign-address
...
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db
2024-09-16 11:04:27 +00:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db
2024-09-16 12:55:59 +02:00
Paul Chavard
20af103bf5
run some tests in selenium
2024-09-16 12:31:10 +02:00
Paul Chavard
a57d8f2df8
fix failing spec
2024-09-16 12:31:10 +02:00
Paul Chavard
1577fdd6af
add playwright debug helper
2024-09-16 12:31:10 +02:00
Paul Chavard
6d752fa0d1
spec(js): run axe specs in chrome for now
2024-09-16 12:31:10 +02:00
Paul Chavard
142c789e76
use playwright driver
2024-09-16 12:31:10 +02:00
Paul Chavard
7b1c882498
spec(js): cleanup js tags
2024-09-16 12:31:10 +02:00
Colin Darie
58037f21cd
Merge pull request #10778 from colinux/sharerd-controller-nav-bar-profile
...
UX: améliore la détection du type de profile utilisé pour la nav bar
2024-09-16 08:01:03 +00:00
Paul Chavard
f00ba04fb9
graphql(playground): fix acl
2024-09-13 14:28:13 +02:00
mfo
52610010b7
Merge pull request #10794 from mfo/US/fix-normalized-international-adresse
...
correctif: ETQ usager une adresse internationnale ne fait pas planter la page
2024-09-13 12:13:11 +00:00
mfo
eb3d2cb20c
bug(normalized_address): should not raise an error for addresses without code postal
2024-09-13 11:17:16 +02:00
simon lehericey
bc7d91751d
Revert "fix: ignore virtual data in column initialization"
...
This reverts commit 4289aa2cf5
2024-09-13 11:00:08 +02:00
simon lehericey
317c4344fc
clean: tdc.drop_down_options
2024-09-13 10:39:48 +02:00
simon lehericey
eddbe77c09
remove virtual column attribute from procedure_presentation data
2024-09-13 10:26:52 +02:00
Mathieu Magnin
d8a0adc6ed
Merge pull request #10772 from demarches-simplifiees/fix-10751
...
ETQ Instructeur, jamais connecté, je ne veux pas recevoir 10 mails si j'ai été ajouté à 10 groupes
2024-09-13 08:08:16 +00:00
Paul Chavard
7286fb9ef2
Merge pull request #10775 from tchak/improuve-chromedriver-config
...
spec(selenium): improve chromedriver config
2024-09-12 18:46:11 +00:00
Colin Darie
8dfddba433
Merge pull request #10584 from colinux/attestation-render-list
...
ETQ admin, améliore l'affichage de champ choix multiple et répétitions dans les attestations v2
2024-09-12 14:40:32 +00:00
Colin Darie
16e1daac9b
fix(recherche): respects nav bar profile context
2024-09-12 10:00:18 +02:00
Mathieu Magnin
dfbc132911
[ #10753 ] fix test that fails on CI
2024-09-11 20:22:38 +02:00
Mathieu Magnin
a99fae168c
[ #10751 ] Allow sending a new invitation if the user's previous one has expired
2024-09-11 18:45:15 +02:00
Mathieu Magnin
790177c758
[ #10751 ] Only send the first invitation mail to the instructeur if email is not verified (from admin controller)
2024-09-11 18:45:15 +02:00
Mathieu Magnin
d7811fca40
[ #10751 ] Only send the first invitation mail to the instructeur if email is not verified
2024-09-11 18:45:15 +02:00
Mathieu Magnin
678c9ea6bc
[ #10753 ] Mark email as verified for users who signed in at least once in the last 5 months.
2024-09-11 18:43:33 +02:00
Colin Darie
b5c024cca5
Merge pull request #10768 from colinux/disable-admin-hide-instructeur-toggle
...
ETQ tech c'est finalement par le manager qui définit si le flag pour masquer l'email des instructeurs
2024-09-11 15:29:06 +00:00
Colin Darie
b987688d19
refactor: disable auto hide instructeurs toggle by admin
2024-09-11 17:20:57 +02:00
Colin Darie
09cafdb15f
Merge pull request #10745 from colinux/helpscout-delete-old-customers
...
ETQ opérateur, je supprime les contacts HS > 2 ans
2024-09-11 15:19:33 +00:00
Paul Chavard
701e71cbbf
spec(selenium): improve chromedriver config
2024-09-10 21:31:30 +02:00
mfo
02bbf26d3f
feat(ProcedurePresentation): validates that ProcedurePresentation.filters using a value casted as an integer [search by id] is not out of pg integer range
2024-09-10 17:47:50 +02:00
mfo
8ebb076a29
bug(ProcedurePresentation.filtered_ids): using numbers bigger than pg limit should not raise an error
2024-09-10 17:15:35 +02:00
simon lehericey
4289aa2cf5
fix: ignore virtual data in column initialization
2024-09-09 16:37:22 +02:00
Colin Darie
ab3139c2ed
Merge pull request #10680 from demarches-simplifiees/a11y-fix-demarche-header
...
Refonte du menu d'aide
2024-09-09 14:17:50 +00:00
mfo
5ab57a32ce
Merge pull request #10762 from mfo/US/export-when-tdc-change
...
Correctif, ETQ instructeur exportant mes dossiers, je souhaite retrouver la valeur saisie par les usagers quand les types de champ ont changés de type mais que les données restent compatible
2024-09-09 09:26:42 +00:00
mfo
7ec17ff7f5
fix(dossier.export): should not use default value when types_de_champ changed to a similar one
2024-09-09 11:00:01 +02:00
Colin Darie
7c30ab87bc
Merge pull request #10712 from colinux/rails-7-finalize-defaults
...
Rails 7.0 : finalise la migration des defaults
2024-09-09 08:08:27 +00:00
Colin Darie
977e47fa74
Merge pull request #10757 from mfo/US/fix-required-dossier-link-with-missing-dossier
...
correct: ETQ administrateur, je souhaite que les types de champ liens vers un dossier pointent vers un dossier valide si ils sont obligatoire
2024-09-09 07:28:48 +00:00
Colin Darie
5d4cafc18f
Merge pull request #10722 from colinux/migrates-otp-secrets
...
Tech: task pour copier les secrets OTP vers les encrypted attributes
2024-09-09 07:08:30 +00:00
Colin Darie
1515e67651
Merge pull request #10760 from demarches-simplifiees/fix_unverified_admin_email
...
ETQ Administrateur, je peux recevoir des mails lorsque je valide mon compte depuis le mail d'invitation
2024-09-09 07:07:26 +00:00
Mathieu Magnin
71d43078ee
Merge pull request #10743 from demarches-simplifiees/fix-10742
...
ETQ instructeur mon adresse email est automatiquement vérifiée quand je me connecte par AgentConnect
2024-09-06 14:26:54 +00:00
mfo
ad33934059
bug(dossier.export): lose value of champ when updating the type de champ from integer_number -> decimal_number
2024-09-06 16:25:56 +02:00
mfo
fcc2b10198
tech(state): define initial state reported by Patrick, cf: https://mattermost.incubateur.net/betagouv/pl/9epn7spg4tg3pbh8jgakafhnmh
2024-09-06 16:25:14 +02:00
Mathieu Magnin
22473adec7
[ #10742 ] Set email as verified when instructeur signs in with Agent Connect
2024-09-06 16:18:11 +02:00
Mathieu Magnin
8d68bebaed
Merge pull request #10761 from demarches-simplifiees/fix-10754
...
ETQ Instructeur, si je n'ai pas vérifié mon email je dois quand même recevoir un email avec login token
2024-09-06 14:14:54 +00:00
LeSim
723ea310ba
Merge pull request #10758 from demarches-simplifiees/fix-10752
...
ETQ Instructeur je veux avoir mon email vérifié si je reset mon mdp
2024-09-06 13:36:29 +00:00
Mathieu Magnin
ced80bf23d
rewrite test with "expect to change" syntax
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-09-06 15:12:15 +02:00
Mathieu Magnin
d1749c2baf
[ #10754 ] verify email when using login token
2024-09-06 14:56:44 +02:00
simon lehericey
277c1a17c6
set verified_email when admin set its password from email link
2024-09-06 14:51:48 +02:00
Mathieu Magnin
95eb9ef9d4
[ #10754 ] bypass unverified mail protection for login token emails
2024-09-06 14:15:06 +02:00
mfo
915779c9b0
Merge pull request #10749 from mfo/US/commune-without-insee
...
correctif: ETQ administrateur/instructeur, je souhaite que les champs de type commune aient tjr un code insee afin de router de maniere fiable
2024-09-06 11:44:00 +00:00
Mathieu Magnin
9e843a3df4
[ #10752 ] set email verified after password reset
2024-09-06 12:06:05 +02:00
mfo
eb8b9a13ca
fix(Champs::DossierLinkChamp): when required, should point to existing dossier
2024-09-06 11:23:12 +02:00
Eric Leroy-Terquem
d361ce2e38
fix(instructeurs import): send confirmation link if new instructeurs
2024-09-06 10:00:17 +02:00
mfo
657fb0ebf4
feat(Maintenance.communes): backfill missing external_id for communes champs in error
2024-09-06 09:29:28 +02:00
mfo
5abba5a166
feat(Champs::CommuneChamp): ensure presence of external_id since some of Champs::CommuneChamp.external_id are missing while .value is present 🔥
2024-09-06 08:37:08 +02:00
Colin Darie
328844dabf
feat(task): delete contacts without activity since 2 years
2024-09-05 10:50:42 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
...
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Colin Darie
247bb6f8c6
refactor(attestation): hide libelle of empty repetitions
2024-09-04 17:42:04 +02:00
Kara Diaby
9cebac1d99
Supprime la vérification par feature flag et utilise la vérif par booléen au booléen
2024-09-04 15:00:03 +00:00
Kara Diaby
c86ad15b8c
Ajoute hide_instructeurs_identity sur Procedures et dans l'interface admin
2024-09-04 15:00:03 +00:00
Colin Darie
9f9720d65b
fix(attestation): delete empty paragraphs
2024-09-04 15:04:07 +02:00
Kara Diaby
0b4a9bb3bb
fixe les tests suite au changement de wording sur les layouts
2024-09-04 08:08:01 +00:00
simon lehericey
eaef5c7e39
readapt name and logic
2024-09-04 08:08:01 +00:00
mfo
c0970693f3
fix(associate_user.with_existing_one): does not leak existing email when trying to choose an alternative email with france connect
2024-09-04 08:05:54 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review
2024-09-04 08:05:54 +00:00
mfo
88a4619dcb
feat(particulier#associate_user): catch email already taken and redirect to reset password
2024-09-04 08:05:53 +00:00
Kara Diaby
a4b8d816de
Tests
2024-09-04 08:05:53 +00:00
Colin Darie
1524f5ba16
feat(maintenance): add task to copy super admin OTP secrets to Rails 7 encrypted attributes
2024-09-03 19:25:32 +02:00
Lisa Durand
27c8abfb4b
Merge pull request #10734 from demarches-simplifiees/cannot-publish-with-test-service-ldu
...
ETQ Admin, je ne dois pas pouvoir publier une démarche avec les informations du service de test
2024-09-03 15:00:30 +00:00
Lisa Durand
0da8d9449d
use other siret for factory
2024-09-02 17:13:43 +02:00
simon lehericey
523e4fff41
spec: fix flaky
2024-09-02 16:52:25 +02:00
Colin Darie
4db4cf1513
fix(attestation): don't render block levels presentation elements into a p
2024-09-02 16:11:02 +02:00
Colin Darie
c9956c4881
feat(attestation): better presentation of repetition champs
2024-09-02 16:11:02 +02:00
Colin Darie
09581ad028
feat(attestation): render multiple drop down list as list
2024-09-02 15:23:11 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
...
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
mfo
f171727140
Merge pull request #10703 from mfo/US/dry-rna-rnf-siret-addresses-view
...
ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET
2024-09-02 12:25:54 +00:00
mfo
622b3d0ff2
Merge pull request #10732 from mfo/US/unflack_expert_spec
...
Tech : corrige un test qui bagotait (expert_spec:141)
2024-09-02 12:25:34 +00:00
mfo
810068e5a8
fix(spec): no more flackyness on ./spec/system/experts/expert_spec.rb:141
2024-09-02 11:14:32 +02:00
mfo
7c3dd84e9f
fix(spec): broken
2024-09-02 09:55:17 +02:00
Colin Darie
46547cb2cd
Merge pull request #10729 from mfo/US/fix-errored-data
...
ETQ usager, je souhaite que me dossier soit debloqué
2024-08-30 17:45:04 +02:00
mfo
3a33d8af45
fix(data): unlock broken dossier due to bad release
2024-08-30 17:37:05 +02:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring"
2024-08-30 16:43:30 +02:00
Eric Leroy-Terquem
4d0961d3ec
chore: remove uninterlacing from web machines
2024-08-30 14:28:43 +02:00
Eric Leroy-Terquem
0511a84abf
chore: move uninterlace to image processor job
2024-08-30 14:28:43 +02:00
simon lehericey
6677f31652
use path_rewrite in commencer controller
2024-08-29 17:01:40 +02:00
Colin Darie
ca7100c7af
chore(encryption): task rotating api particulier token encrypted attributes
2024-08-28 13:58:59 +02:00
Colin Darie
3ac671576b
chore(encryption): rotate key with new default digest (SHA256)
2024-08-28 13:58:59 +02:00
mfo
bab8fc2d29
fix(delete_orphaned_champs): maintenance tasks with custom PG_STATEMENT_TIMEOUT is not a good fit. change implementation to after_party
2024-08-27 13:43:28 +02:00
mfo
0771d207f3
Merge pull request #10716 from mfo/US/fix-bad-data
...
ETQ instance DS, je souhaite que l'intégrité des données entre les champs et les dossiers soient garantie par une contrainte en base de donnée
2024-08-26 14:23:25 +00:00
mfo
1d84c0f55b
fix(champs.orphaned): add maintenance task to clean orphaned champs where dossier is missing
2024-08-26 16:00:59 +02:00
Paul Chavard
32bf3ec9db
cleanup in spec
2024-08-26 14:53:56 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage
2024-08-26 14:53:56 +02:00
Paul Chavard
f7cd7e615d
refactor(champs): validate only champs in current revision
2024-08-26 14:53:56 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods
2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
fade633828
feat(routing): can create simple routing with address tdc
2024-08-26 11:16:47 +02:00
Eric Leroy-Terquem
8b4b4d7cb7
feat(conditional): can condition and route on address champ
2024-08-26 11:16:46 +02:00
Lisa Durand
8722a10d63
fix specs
2024-08-22 17:54:24 +02:00
Lisa Durand
b586f23009
remove hidden at column from dossiers
2024-08-22 17:36:41 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
...
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
Lisa Durand
fae81d0a58
fix test
2024-08-22 12:09:29 +02:00
mfo
70983c50f9
spec(normalized_address): add simple spec
2024-08-22 10:37:31 +02:00
mfo
8a42c6a7ad
Merge pull request #10708 from mfo/US/format-rna
...
ETQ tech je souhaite que les champs RNA ne puissent pas contenir d'espace sans quoi nos appels d'API remontent un URI::InvalidURIError
2024-08-22 08:36:38 +00:00
mfo
22e50d4c9e
fix(data): normalize invalid Champs::RNAChamp.values in db
2024-08-22 10:24:03 +02:00
Colin Darie
2b9fe12079
test(dolist): add some specs and remove unsupported email sent with attachments
2024-08-22 09:26:49 +02:00
Colin Darie
659d35e11f
test: fix for mutable string
2024-08-22 09:26:49 +02:00
Colin Darie
6d9a7648e2
fix(test): disable frozen string in siret concern because it's a literal string in spec
2024-08-22 09:26:49 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment
2024-08-22 09:26:48 +02:00
Colin Darie
eccfde848f
feat(admin): disable publish button when there are errors
2024-08-21 17:38:07 +02:00
Colin Darie
d0837c58f5
fix(admin): publish modifications button must be PUT
2024-08-21 17:38:07 +02:00
Kara Diaby
4a93579e71
Ajoute une sticky navbar si il y a une modification de démarche déjà publiée
2024-08-21 10:23:02 +00:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
...
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
mfo
42b9ac1737
spec(filter): with rna enum
2024-08-21 10:23:56 +02:00
mfo
575c4cbdff
clean(spec): procedure_filters_spec.rb, less tdc by default
2024-08-21 10:23:56 +02:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
...
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable
2024-08-20 18:46:19 +02:00
Colin Darie
8cdd7ef4df
Merge pull request #10699 from mfo/US/hotfix-pp
...
Correctif: rattrape les données inconsistantes pour la présentation des tableaux instructeurs qui se font detruire a la 1ere connection
2024-08-20 16:16:26 +00:00
mfo
3662e38366
hotfix(ProcedurePresentation): backfill invalid procedure presentation private tabel name for type de champs private
2024-08-20 17:58:55 +02:00
