Commit graph

12395 commits

Author SHA1 Message Date
simon lehericey
e0959cda1e constantize hot strings
- 1131 objects over 4220 (-25%) created in app/
2021-04-16 13:13:22 +02:00
simon lehericey
47f13219ed Avoid useless TypeDeChamp deserialization
- 520 objects overs 4720 (10%) created in app/ (using ?pp=profile-memory&memory_profiler_allow_files=app/)
2021-04-16 13:13:22 +02:00
simon lehericey
e728a3fcb7 include type_de_champ
Avoid n+1 when matching champ.stable_id in procedure.presentation.displayed_fields_values
win 2s in the worst 3s scenario
2021-04-16 13:13:22 +02:00
Paul Chavard
f6c704d44d
Merge pull request #6095 from tchak/improuve-user-destruction
Users that are experts should not be deletable
2021-04-15 18:23:34 +01:00
Paul Chavard
ea484b879e Prevent expert users to be deleted 2021-04-15 16:17:36 +01:00
Pierre de La Morinerie
3104b4bf17
Merge pull request #6103 from tchak/fix-api-doc-link
Correction du lien vers la documentation de l'API (#6103)
2021-04-15 17:16:02 +02:00
Paul Chavard
f08d704d5f Fix api docs URL 2021-04-15 17:06:23 +02:00
Pierre de La Morinerie
b9e949b481
Merge pull request #6104 from betagouv/update-devise-two-factor
Mise à jour de la gem `devise-two-factor` (#6104)
2021-04-15 17:05:29 +02:00
Pierre de La Morinerie
f7d71ba698 gems: update devise-two-factor to a released version
This is the first official release compatible with Rails 6.1.
2021-04-15 16:54:14 +02:00
Pierre de La Morinerie
727bc4a2ce
Merge pull request #6101 from betagouv/check-zeitwerk
CI : teste automatiquement la conformité des classes avec Zeitwerk (#6101)
2021-04-15 16:51:16 +02:00
Pierre de La Morinerie
f8757ea053
Merge pull request #6098 from adullact/6094_enable_rspec_only-failures_support
Développeur : documente l'option de rspec pour ne faire passer que les tests échoués précédemment
2021-04-15 14:26:20 +02:00
Fabrice Gangler
92ccff785a Doc(test): add rspec only-failures example 2021-04-15 14:17:39 +02:00
François Vantomme
f747b0a46a Chore(test): enable rspec only-failures support 2021-04-15 14:17:39 +02:00
Pierre de La Morinerie
c96a2550d8 ci: check for zeitwerk errors
If a zeitwerk-incompatible class is introduced, it won't break
any test before reaching production.
2021-04-15 13:17:46 +02:00
Kara Diaby
d415257111
Merge branch 'production' into main 2021-04-15 12:32:30 +02:00
Pierre de La Morinerie
776ca5a048
Merge pull request #6099 from betagouv/fix-expert-mailer
Corrige `AvisMailerPreview` en `ExpertMailerPreview` (#6099)
2021-04-15 12:31:19 +02:00
kara Diaby
198e3ed3b8 expert mailer instead of avis mailer 2021-04-15 12:22:40 +02:00
Kara Diaby
f2f85f0d8f
Merge pull request #6097 from betagouv/main
2021-04-15-01
2021-04-15 11:52:23 +02:00
Kara Diaby
22a14701a4
Merge pull request #6078 from betagouv/feat/5815
ETQ instructeur, lorsque je termine un dossier, les experts notifiable recoivent un mail leur indiquant qu'une nouveauté est présente
2021-04-15 11:42:29 +02:00
kara Diaby
f4aa29a799 add expert mailer preview 2021-04-15 11:29:55 +02:00
kara Diaby
663fa50f02 notify expert when a decision is taken on a dossier 2021-04-15 11:29:55 +02:00
krichtof
c2dbb55a88
Merge pull request #6090 from betagouv/6088-superadmin-manager
Manager : affichage et suppression des SuperAdmin
2021-04-15 10:20:54 +02:00
Christophe Robillard
54f2b9dc7e [manager] remove super admin 2021-04-15 10:12:11 +02:00
Christophe Robillard
db48ea02aa [manager] list superadmins 2021-04-15 10:12:11 +02:00
Pierre de La Morinerie
2c50fb29e2
Merge pull request #6091 from tchak/fix-discarded-destruction
Correction des données liées aux dossiers qui doivent être effacées lors de la suppression (#6091)
2021-04-15 09:13:07 +02:00
Paul Chavard
6d37e1d133 Fix discarded procedures destruction 2021-04-14 12:24:16 +01:00
Paul Chavard
5b56ec425b Fix discarded dossiers destruction 2021-04-14 12:24:16 +01:00
Paul Chavard
6e32117497
Merge pull request #6093 from adullact/6092_Test_use_APPLICATION_NAME_to_deal_nicely_with_custom_config
#6092 - Test: use APPLICATION_NAME to deal nicely with custom configuration
2021-04-14 12:08:06 +01:00
François Vantomme
a596df9a4a Test: use APPLICATION_NAME to deal nicely with custom configuration 2021-04-13 22:46:33 +02:00
Pierre de La Morinerie
12024a14f7
Merge pull request #6058 from betagouv/add-unique-constraints-1
Ajout d'utilitaires pour faciliter l'écriture de migrations de base de donnée (#6058)
2021-04-13 18:20:27 +02:00
Pierre de La Morinerie
872f6b0153 lib: add migration helpers for making a column unique 2021-04-13 18:09:59 +02:00
Pierre de La Morinerie
2fbfe1e300
Merge pull request #6074 from tchak/remove-ignored-columns
Les colonnes supprimées ne sont plus mentionnées dans le code (#6074)
2021-04-13 18:09:50 +02:00
Paul Chavard
f152c51d12 Remove ignored_columns 2021-04-13 17:00:07 +01:00
LeSim
499905ee83
Merge pull request #6087 from betagouv/main
2021-04-13-01
2021-04-13 12:44:37 +02:00
LeSim
b294566f2a
Merge pull request #6083 from betagouv/fix_missing_dossier_for_avis
ne demande pas un avis si le dossier a été supprimé
2021-04-13 12:19:32 +02:00
simon lehericey
fde433a7cf do not ask for avis if the dossier is absent 2021-04-13 12:04:45 +02:00
Pierre de La Morinerie
2730fac40d
Merge pull request #6076 from betagouv/refactor-sib-api
Manager : corrige l'affichage des emails envoyés (#6076)
2021-04-13 11:15:03 +02:00
Pierre de La Morinerie
16f695031b manager: add Mailjet emails to the sent emails list 2021-04-13 10:58:30 +02:00
Pierre de La Morinerie
773c18babf manager: improve clarity of emails page 2021-04-13 10:57:26 +02:00
Pierre de La Morinerie
5e8327ff09 manager: refactor SendInBlue unblock action 2021-04-13 10:57:26 +02:00
Pierre de La Morinerie
76e74003ad manager: fix SendInBlue emails 2021-04-13 10:57:26 +02:00
LeSim
eb8d5b711f
Merge pull request #6085 from betagouv/fill_missing_date_of_france_connect_informations
[#6084] rempli des dates manquantes dans france_connect_informations
2021-04-13 10:08:18 +02:00
simon lehericey
c683fad3f3 [#6084] add after_party task to fill missing data 2021-04-13 09:59:28 +02:00
simon lehericey
76e261691a add data column to france_connect_infromations 2021-04-13 09:59:28 +02:00
LeSim
89f1cff796
Merge pull request #6082 from betagouv/do_not_use_flipper_for_bypass_email_login
n'utilise plus flipper pour passer outre le login par jeton (1er partie)
2021-04-13 09:54:16 +02:00
simon lehericey
dbb1acbd75 add after_party task to populate bypass_email 2021-04-13 09:43:38 +02:00
simon lehericey
cd6cb99c3c add bypass_email_login_token to instructeur 2021-04-13 09:43:38 +02:00
LeSim
2fc0ceb884
Merge pull request #6079 from betagouv/optimize_a_bit_of_instructeur_show
Optimisation de la page instructeur show procedure
2021-04-13 09:41:33 +02:00
simon lehericey
52c8b60419 This is why you need to add a COUNT(DISTINCT dossiers.id) to make it work 2021-04-13 09:32:48 +02:00
simon lehericey
594cda3ee3 Remove previous attempt but steal its spec 2021-04-13 09:32:48 +02:00