Commit graph

6047 commits

Author SHA1 Message Date
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context 2024-04-01 07:07:11 +02:00
mfo
b07bbfa455
bug(instructeurs/dossiers#update_annotations): should works if a champ_public is invalid 2024-04-01 07:07:10 +02:00
Martin
2944a0c2c3
fix(expert.attestation.url): was pointing to attestation_instructeur_dossier_path, so did not worked when expert was not instructeur. use active_storage_link, secured enough because served to authenticated users as well as expiring link 2024-03-30 06:20:11 +01:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257 add validation on decimal max 3 digits after coma 2024-03-27 10:55:10 +01:00
mfo
465de75e6b
Merge pull request #10215 from demarches-simplifiees/US/catch-oomed-jobs
tech(export_job): sometimes ExportJob are OOMed, in those cases jobs are stuck and never retried. release lock and increase attempts
2024-03-27 09:34:46 +00:00
Martin
be47152096 tech(export_job): sometimes ExportJob are OOMed, in those cases jobs are stuck and never retried. release lock and increase attemps 2024-03-26 15:29:04 +01:00
Colin Darie
d161589e2f fix(api-entreprise): Context is not defined in jobs 2024-03-26 12:45:28 +01:00
Paul Chavard
06d81dcfaf
Merge pull request #10169 from tchak/refactor-champ-public_id
fix(champ): use public_id in views
2024-03-26 10:31:13 +00:00
Paul Chavard
6ad0b901b6 fix(champ): use public_id in views 2024-03-26 11:23:23 +01:00
Paul Chavard
b02ba1e909 feat(textarea): autoresize textareas 2024-03-25 19:53:29 +01:00
Paul Chavard
f589129ef5 chore(attachment): remove unused replace code 2024-03-25 15:13:14 +01:00
Eric Leroy-Terquem
536a03bbb4
Merge pull request #10180 from demarches-simplifiees/update-bulk-messages-associations
Technique : Mise à jour de l'association bulk messages - procédures
2024-03-25 13:35:23 +00:00
Eric Leroy-Terquem
e712cf5f23 task(procedure): fix open procedures with closing reason 2024-03-22 16:00:36 +01:00
Eric Leroy-Terquem
773de2dbf2 chore(groupe_instructeurs): do not reaffect bulk messages anymore 2024-03-22 14:56:54 +01:00
Eric Leroy-Terquem
60f7e02429 fix : remove test including previous association 2024-03-22 14:52:34 +01:00
Eric Leroy-Terquem
30f96a79c2 chore(bulk messages): update associations 2024-03-22 14:52:34 +01:00
Martin
2281e3de4b fixup! feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Martin
44cdb14fb9 feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Martin
b8a155a7ee feat(type_de_champ_editor): show tdc position indexed starting at 1 not 0 2024-03-22 10:10:28 +01:00
Martin
015e606f50 fix(dossier.has_many.france_connect_informations): wip 2024-03-22 07:47:02 +01:00
simon lehericey
46087e4577 raise Error if generation fail 2024-03-21 21:03:21 +01:00
Colin Darie
17f9992722
Merge pull request #10040 from colinux/cross-domain-component
Prépare la bannière informant du changement de nom de domaine, avec redirection automatique le cas échéant
2024-03-21 14:58:29 +00:00
Eric Leroy-Terquem
058350df53 fix(administrateur): can delete administrateur with a discarded procedure with no dossier 2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
9139bfbf48 clean(administrateur): remove dead code 2024-03-21 14:27:53 +01:00
Colin Darie
f768801b7d
feat(registration): set preferred host on signup/signin 2024-03-21 13:15:36 +01:00
Colin Darie
4dd24f0925
chore: cross domain banner between APP_HOST_LEGACY and APP_HOST 2024-03-21 12:21:16 +01:00
simon lehericey
2ea6a5d25c remove now useless biz_dev module 2024-03-21 11:54:03 +01:00
simon lehericey
a42f85ef05 remove useless administration_id in invite_admin and invite_administrateur! 2024-03-21 11:54:02 +01:00
simon lehericey
5288ee4ab9 fix spec 2024-03-21 10:06:09 +01:00
Eric Leroy-Terquem
a89b471b5c
Merge pull request #10163 from demarches-simplifiees/fix-bulk-message-maintenance-task
fix(maintenance task): fix query and add a test
2024-03-21 08:26:09 +00:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Eric Leroy-Terquem
dd7a407187 fix(maintenance task): fix query and add a test 2024-03-20 15:24:21 +01:00
Eric Leroy-Terquem
73d6609eb3
Merge pull request #10158 from demarches-simplifiees/fix-closing-reason-form
Correctif : ETQ admin je ne peux pas fermer une démarche en redirigeant sans choisir la nouvelle démarche
2024-03-20 13:28:40 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Eric Leroy-Terquem
234f0d7a75 fix(data): update closing_reason to other if no replaced_by_procedure_id 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
e55531c6f4 fix(procedure): validates presence of replaced_by_id if procedure redirected 2024-03-20 14:04:59 +01:00
Paul Chavard
eff03aaf23 refactor(dossier): label indexes based on type_de_champ not champ 2024-03-20 09:58:47 +01:00
simon lehericey
ca17524559 Allow instructeur to have multiple agent_connect_information
AC will return two different sub depending of the domain demarches.gouv.fr or ds.
Both agent_connect_information are stored and the corresponding instructeur is found by its email.
We do not store anymore the agent_connect_id on the instructeur as the are many.
2024-03-19 21:17:45 +01:00
simon lehericey
759d729bf3 use AC autoconf discovery end_session_endpoint 2024-03-19 21:17:44 +01:00
Colin Darie
455086c1d7
fix(champs): don't fail on updated_at comparison when champ is not persisted 2024-03-19 11:46:08 +01:00
mfo
aafe6a7bb6
Merge pull request #10139 from mfo/US/fix-missing-champs-task
fix(data): apply fix missing champ via task. FV dossiers are poping way too much at helpdesk
2024-03-18 17:26:45 +00:00
Martin
2dac74916f fix(data): apply fix missing champ via task. FV dossiers are poping way too much at helpdesk
Co-authored-by: Colin Darie <colin@darie.eu>
2024-03-18 17:53:21 +01:00
Paul Chavard
f21192bb06
Merge pull request #10123 from tchak/fix-multiple-champ-copies-bug
fix(champ): fix multiple champ copies bug
2024-03-18 16:46:17 +00:00
Lisa Durand
72c4b23821 add last_champ_updated_at in export 2024-03-18 16:10:26 +01:00
simon lehericey
dca3727253 proper agent connect logout mechanism 2024-03-18 14:02:53 +01:00
simon lehericey
31b84fd770 store id_token 2024-03-18 14:02:53 +01:00
Kara Diaby
e73318e3bb
Merge pull request #10127 from demarches-simplifiees/feat/10005
ETQ expert, je veux pouvoir gérer les notifications que je reçois depuis mon interface
2024-03-18 12:27:37 +00:00
Kara Diaby
30df608a99 tests 2024-03-18 11:50:29 +00:00
Lisa Durand
b8cf19337f
Merge pull request #10131 from demarches-simplifiees/wording-page-stats-ldu
ETQ instructeur je souhaite mieux comprendre le graph "avancée des dossiers" en changeant le terme "démarrés"
2024-03-18 11:49:20 +00:00
Paul Chavard
1b2315cd45 fix(champ): fix multiple champ copies bug 2024-03-18 12:13:22 +01:00
Paul Chavard
8abe3fce79 add stable_id and stream 2024-03-18 11:34:55 +01:00
Lisa Durand
6b916493cb change wording on page stats 2024-03-18 10:39:11 +01:00
Eric Leroy-Terquem
94f37b6708
Merge pull request #10125 from demarches-simplifiees/destroy-procedure-without-administrateur-and-without-dossier
Correctif : supprime les démarches sans administrateur ni dossier
2024-03-18 08:48:52 +00:00
Paul Chavard
900db5624f refactor(champs): if champ not found - build it 2024-03-17 23:51:45 +01:00
Paul Chavard
fd2e253ebc refactor(champs): use ViewableChamp::SectionComponent 2024-03-17 23:51:45 +01:00
Paul Chavard
378e15e083 fix(api_geo): include Paris, Lyon and Marseille code INSEE in local data 2024-03-15 22:33:26 +01:00
Eric Leroy-Terquem
6322532805 fix(data): destroy procedure if no administrateur and no dossier 2024-03-15 16:30:03 +01:00
simon lehericey
ce3a156a46 refactor(file retrieval): use ciphered query params instead of cookie to move email 2024-03-15 14:42:28 +01:00
simon lehericey
7e6792c616 feat(file retrieval): add dossier_transfer_log 2024-03-15 14:35:15 +01:00
simon lehericey
96a8e7888e feat(file retrieval): select procedure to recover 2024-03-15 14:35:14 +01:00
simon lehericey
e91eeadccb feat(file retrieval): add recovery_service 2024-03-15 14:35:14 +01:00
simon lehericey
cd7fd5832c feat(file retrieval): post targeted email 2024-03-15 14:35:14 +01:00
simon lehericey
d86bebdd03 feat(file retrieval): ensure collectivite territoriale 2024-03-15 14:35:14 +01:00
simon lehericey
fac365e01d feat(file retrieval): ensure agent connect is used 2024-03-15 14:35:14 +01:00
simon lehericey
d3955d48ee feat(file retrieval): contact support if not col ter 2024-03-15 14:35:14 +01:00
simon lehericey
a60a082ec5 feat(file retrieval): add api_recherche_entreprises_service 2024-03-15 14:35:14 +01:00
simon lehericey
277ac1259a feat(file retrieval): create agent connect information 2024-03-15 14:35:14 +01:00
Lisa Durand
e757eefd37 add message when path is already taken when publishing a procedure 2024-03-14 17:17:47 +01:00
Paul Chavard
4e023ebed0
Merge pull request #10106 from colinux/limit-service-geocoding-to-insee-code
Super-Admins: évite que le géocodage des services tombe sur une mauvaise commune
2024-03-14 16:16:03 +00:00
Colin Darie
8fa6e04c53
fix(export): turbo poll when creating an export 2024-03-14 14:04:25 +01:00
Eric Leroy-Terquem
237b21025a fix(data): update procedure with duree_conservation greater than max_duree 2024-03-13 11:09:36 +01:00
Colin Darie
578f19b000 chore(service): limit geocoding area to INSEE code commune 2024-03-13 10:40:39 +01:00
Lisa Durand
1ce4d17ad5
Merge pull request #9961 from demarches-simplifiees/amelioration-wording-co-construction-ldu
ETQ usager: Mentionne d'autres acteurs possibles dans la description de la co-construction
2024-03-12 16:55:21 +00:00
mfo
5dda05d710
Merge pull request #10100 from mfo/US/cleanup-champs-after-passer-en-construction
fix(email_validation): allow email with specific format
2024-03-12 17:09:39 +01:00
Colin Darie
fc1c6bb412
Merge pull request #10103 from tchak/dossier-vide-from-procedure
refactor(dossier_vide): use types_de_champ instead of empty dossier
2024-03-12 15:29:24 +00:00
Colin Darie
ee92668611
Merge pull request #9930 from demarches-simplifiees/add-external-link-to-procedure
ETQ admin lorsque je clos une démarche je peux alerter les usagers et je crée une page de fermeture si la démarche n'est pas redirigée dans DS
2024-03-12 15:03:30 +00:00
Colin Darie
0d2f5547e0
Merge pull request #10076 from mfo/US/fix-expert-dossier-export
correctif(Export.export): ETQ expert téléchargeant un dossier et toutes ses PJs, la messagerie n'est pas dans l'export quand la procedure ne l'autorise pas. L'export ne contient pas les annotations privées
2024-03-12 14:09:48 +00:00
Paul Chavard
aa0aea1543 refactor(dossier_vide): use types_de_champ instead of empty dossier 2024-03-12 14:23:07 +01:00
Colin Darie
5f826cfd88
Merge pull request #10095 from demarches-simplifiees/fix_multiple_error_message_on_regexp
Admin: corrige un bug ou un message d'erreur d expression regulière apparaissait plusieurs fois
2024-03-12 13:07:25 +00:00
Colin Darie
745d7d62b5
Merge pull request #10096 from colinux/fix-add-instructeur-without-valid-email
ETQ instructeur je ne dois pas pouvoir inviter un instructeur avec une adresse email invalide
2024-03-12 11:11:36 +00:00
Martin
2468d528fd fix(email_validation): use truemail regexp 2024-03-12 11:29:31 +01:00
Colin Darie
00d023184d
chore(sentry): don't report every InvalidAuthenticityToken 2024-03-11 17:06:38 +01:00
Eric Leroy-Terquem
5a098df525 test(procedure): add a system spec to test closing 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
d800213920 feat(procedure): add closing details page 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
facb38b539 db(procedure): add a maintenance task to backfill closed procedures with closing reason 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
c95f0f1cad feat(procedure): send notifications after closing 2024-03-11 15:48:28 +01:00
Eric Leroy-Terquem
74903d79bf feat(procedure): update archiving to add closing reason and closing details 2024-03-11 15:48:28 +01:00
Colin Darie
bfba80a5ce fix(instructeur): don't try to create instructeur with an invalid email 2024-03-11 12:29:06 +01:00
simon lehericey
2bec15b78f fix multiple error message on regexp 2024-03-11 11:41:31 +01:00
Paul Chavard
9afe71529e fix(addresse): lookup for city, departement and region name in local db 2024-03-11 10:49:56 +01:00
mfo
14266232a4
Merge pull request #10084 from mfo/US/fix-rebase-when-repetition-was-removed
fix(rebase): rebase a dossier when its repetition had been removed on newer version of published_revision crashes
2024-03-08 16:15:00 +01:00
Martin
0e54ca314d bug(rebase): rebase a dossier when its repetition had been removed on newer version of published_revision crashes 2024-03-08 15:46:11 +01:00
Paul Chavard
6ec7a87bcb
Merge pull request #10080 from demarches-simplifiees/add-dependent-destroy-on-contact-information
Correctif : supprime l'information de contact à la suppression du groupe instructeur
2024-03-08 12:15:27 +00:00
mfo
0013528deb
Merge pull request #10065 from mfo/US/secu-email
fix(email.validation): some nasty tests
2024-03-08 09:05:03 +00:00
Martin
9425f2cc58 fix(user.france_connect_informations): has_many, not has_one 2024-03-08 09:44:21 +01:00
krichtof
1024557081
Merge pull request #10041 from demarches-simplifiees/10029-filter-kind-usager
ETQ admin, je peux filtrer toutes les démarches par type d'usager
2024-03-08 08:23:26 +00:00
Eric Leroy-Terquem
6651b36fe4 db(migration): add closing_reason and closing_details to procedure 2024-03-07 19:00:46 +01:00
Eric Leroy-Terquem
877e1f79cc fix(groupe instructeur): add a dependent destroy on contact information 2024-03-07 16:33:17 +01:00
Martin
f4d2f1ddf5 fix(export.pdf): expert should not have access to messagerie when it was disabled 2024-03-07 08:39:32 +01:00
Christophe Robillard
c01914bc24 update zones for new government 2024-03-06 21:18:09 +01:00
Christophe Robillard
05a7198442 remove useless spec 2024-03-06 21:18:09 +01:00
Paul Chavard
a9bf809ea3
Merge pull request #10069 from mfo/US/fix-spread-dossier-deletion-task
tech(spread_dossier_deletion_task): query on date time range not on date
2024-03-05 15:27:09 +00:00
Martin
0ea90e036e fix(email.validation): some nasty tests 2024-03-05 16:27:07 +01:00
Paul Chavard
1243cfefeb fix(entreprise): graphql effectif 2024-03-05 16:00:28 +01:00
Martin
4f85082034 fix(spread_dossier_deletion_task): query on date time range not on date 2024-03-05 14:25:16 +01:00
Martin
b468da9964 bug(user.fcis): users using more than one FranceConnect identity provider can not be destroyed 2024-03-05 14:03:02 +01:00
Paul Chavard
a247ec6c12
Merge pull request #9695 from tchak/use-types-de-champ-as-source-of-truth
refactor(dossier): use revision as source of truth to diplay champs
2024-03-04 15:03:02 +00:00
Paul Chavard
7a727e2bd2
Merge pull request #10051 from demarches-simplifiees/fix-france-connect-warning
Correction : etq usager je ne vois pas le bandeau indiquant que je suis connecté avec France Connect
2024-03-04 11:44:25 +00:00
Paul Chavard
124466a6a2
Merge pull request #10060 from tchak/fix-improuve-municipalities-handling-by-ban-api
fix(adress): show postal code on municipalities
2024-03-04 11:11:38 +00:00
Eric Leroy-Terquem
125724d416 feat(dossier): display france connect information notice only to instructeur 2024-03-04 11:30:19 +01:00
Paul Chavard
f3a97876bd fix(champ): champs are not ordered anymore 2024-03-04 10:59:11 +01:00
Paul Chavard
2eb1f54aa1 refactor(dossier_loader): ignore champs from old revisions 2024-03-04 10:59:11 +01:00
Paul Chavard
8687d73a73 refactor(dossier): clone only current revision champs 2024-03-04 10:59:11 +01:00
Paul Chavard
deb19177f7 refactor(test): update tests 2024-03-04 10:59:11 +01:00
Martin
eb6b23347b fix(data): avoid destroying 2M dossiers in one day due to error in Cron::ExpiredDossiersTermineDeletionJob 2024-03-04 10:52:49 +01:00
Paul Chavard
e6d15172a0 fix(spec): update vcr cassette 2024-03-04 10:42:19 +01:00
Colin Darie
f342bcb58b
test(flipper): instance reset is now out-of-box 2024-03-03 00:13:03 +01:00
Colin Darie
dbf04c63a4
fix(flipper): don't clone features globally enabled 2024-03-03 00:13:01 +01:00
Eric Leroy-Terquem
e94ae3498c
Merge pull request #10048 from demarches-simplifiees/etq-admin-je-vois-les-messages-envoyes-aux-brouillons
ETQ instructeur je vois les messages envoyés aux usagers avec un dossier en brouillon
2024-03-01 13:27:36 +00:00
Paul Chavard
178f1a0c26 fix(test): fail on last month day 2024-02-29 15:44:42 +01:00
Eric Leroy-Terquem
6be57d9ea4 fix(bulk messages): display previous bulk messages 2024-02-28 16:07:27 +01:00
Eric Leroy-Terquem
efa19926e4
Merge pull request #9966 from demarches-simplifiees/etq-admin-je-peux-coller-une-liste-d-emails-d-experts
ETQ admin ou instructeur je peux copier une liste d'emails pour inviter des experts
2024-02-28 14:49:04 +00:00
mfo
43a9ee0ca4
Merge pull request #10049 from colinux/fix-params-i18n-sanitization
Tech: chiffre le param email réaffiché dans la vue pour éviter de construire des pages de phishing
2024-02-28 14:17:47 +01:00
mfo
c0d120545e
Merge pull request #10042 from mfo/US/vers-demarches-gouv-et-lau-dela
tech(redirect): ETQ usager non connecté, je suis automatiquement redirigé de demarches-simplifiees vers le nouvel host
2024-02-28 10:30:42 +00:00
Martin
a13594792a feat(cross-domain-redirect): redirect to APP_HOST when user is on APP_HOST_LEGACY 2024-02-28 06:23:55 +01:00
Colin Darie
0a07c9cd72
fix: encode reset link email in param because it's rendered in view later 2024-02-27 18:59:52 +01:00
Colin Darie
9db7b5b864
fix: encode reset password email in param because it's rendered in view later 2024-02-27 18:53:07 +01:00
Christophe Robillard
26a86d8003 filter all demarches by kind usager 2024-02-23 16:04:27 +01:00
Martin
8ca853c79c feat(application_controller): add method to check if request is on app_host_legacy? 2024-02-23 10:42:23 +01:00
Colin Darie
3cf2e3ecde
Merge pull request #10031 from colinux/fix-typo-tiers
ETQ instructeur: corrige une typo tier => tiers dans les exports
2024-02-23 09:13:19 +00:00
Colin Darie
f04420812b
fix(export): typo tier => tiers 2024-02-22 15:58:29 +01:00
Colin Darie
a8166f43d6
Revert "test: fix graphql syntax error output since JSON parser is now yajl-ruby"
This reverts commit eb41f7e85e.
2024-02-22 15:18:35 +01:00
Colin Darie
7143c7e8e2
Merge pull request #9995 from colinux/attestation-v2-improvements
ETQ admin, quelques améliorations sur l'éditeur v2
2024-02-22 11:30:41 +00:00
Colin Darie
3c22f4ea48
fix(attestation): always return v1 template when exists, otherwise it's a v2 2024-02-22 12:19:07 +01:00
Colin Darie
8ba1c0e481
feat(attestation): can toggle optional champs tags visibility 2024-02-22 12:19:06 +01:00
Colin Darie
0f0c7d83f9
Merge pull request #9998 from colinux/bundle-update-phase-2
Tech: massive gem updates, phase 2
2024-02-22 10:33:37 +00:00
Colin Darie
bacfc0c5d1
Merge pull request #10015 from mfo/US/feat-export-include-mandataire
ETQ instructeur, ETQ API les exports contiennent plus de donnée (mandataire & info de france connection france connect)
2024-02-22 10:33:15 +00:00
Colin Darie
ff8c0e6c69
Merge pull request #10012 from colinux/doc-STRICT_EMAIL_VALIDATION_STARTS_ON
Tech: document STRICT_EMAIL_VALIDATION_STARTS_ON env var
2024-02-21 17:09:00 +00:00
mfo
8579736c03
Merge pull request #10025 from colinux/fix-filter-too-long-error
ETQ instructeur, message d'erreur plutôt que crash lorsqu'on ajoute un filtre trop long (plus de 100 caractères)
2024-02-21 14:51:26 +00:00
Martin
31168f9602 perf(spec): build not create some variables, & fix specs 2024-02-21 14:44:49 +01:00
Martin
c2675dfb4d feat(export.user): add when user passthru FranceConnect or not 2024-02-21 14:44:49 +01:00
Martin
c9235c8a3d feat(export.for_tier): add to export 2024-02-21 14:44:49 +01:00
Colin Darie
5f5756a034
Merge pull request #10017 from mfo/US/a11y-after-signup
ETQ usager utilisant un lecteur d'écran: la page de demande de confirmation de compte ne concentre pas le lecteur d'écran sur le champ pour renvoyer un mail de confirmation
2024-02-21 12:25:35 +00:00
Colin Darie
41a27fbad2
Merge pull request #10014 from mfo/US/better-expert-exports
ETQ expert: je retrouve mes avis confidentiel dans les exports. ETQ instructeur, je retrouve les fichiers joint a une demande d'avis expert
2024-02-21 11:25:58 +00:00
Colin Darie
5ab1d45b8a fix(instructeur): don't crash when adding a filter too long 2024-02-21 12:13:47 +01:00
Paul Chavard
5a8859cd28
Merge pull request #10018 from tchak/fix-address-champ
fix(champ): do not reset data on champs without fetch_external_data
2024-02-21 09:06:24 +00:00
Colin Darie
1671a783a2
Merge pull request #10021 from colinux/fix-email-subject-double-encode
ETQ usager je dois voir de vraies apostrophes à la place de `&#39;` dans les sujets d'email
2024-02-21 08:33:44 +00:00
Paul Chavard
702b9dd8b3 fix(champ): do not reset data on champs without fetch_external_data 2024-02-21 08:54:08 +01:00
Martin
48336f0ca4 a11y(users/confirmations#new): avoid autofocus on input to resend the mail, otherwise screen reader goes straight to the input 2024-02-21 07:56:00 +01:00
Colin Darie
c05aaa5f35 fix(email): dynamic subject should be escaped, cf RFC 2047 which have its own encoding 2024-02-20 18:29:41 +01:00
Colin Darie
560d50f52d fix(dropdown-multiple): a valid option starting by [ may not be a JSON value 2024-02-20 17:41:53 +01:00
Martin
ba3fda1928 bug(monavisvalidator): what any domain could be used ?! 2024-02-20 11:51:00 +01:00
mfo
de4369db29
Merge pull request #10010 from mfo/US/fix-expert-signup
amelioration(expert.signup): passe la page de creation de compte expert au dsfr
2024-02-19 16:43:31 +00:00
Martin
a151a304e2 feat(pj_service): add expert's avis (even when confidential) to exports asked by same expert 2024-02-19 16:22:08 +01:00
Martin
dd39ac313b feat(pj_service): add introduction_file to exports 2024-02-19 16:21:26 +01:00
Colin Darie
1626a71f93
test: fix invalid emails 2024-02-19 15:16:18 +01:00
Martin
8dc3103ac1 fix(champs.email): allow nil 2024-02-19 15:13:20 +01:00
Martin
e788846894 feat(expert.signup): dsfrize 2024-02-19 11:28:38 +01:00
Colin Darie
eb41f7e85e
test: fix graphql syntax error output since JSON parser is now yajl-ruby 2024-02-19 09:28:39 +01:00
Paul Chavard
46b12c0c3d
Merge pull request #9990 from tchak/refactor-adresse-champ
refactor(address): use directly BAN data
2024-02-16 16:42:17 +00:00
Martin
1a424beb6f fix(tags): libelle with double dash, becomes double underscore. no worries it was already broken 2024-02-16 14:00:18 +01:00
Martin
0fbbe4d97c bug(tags): libelle with double dash, double dash also known as tag delimiter 2024-02-16 14:00:18 +01:00
Paul Chavard
20307f1d21 refactor(address): use directly BAN data 2024-02-16 12:15:14 +01:00
Martin
32e8f34511 refactor(PiecesJustificativesService): stop passing flags, pass user_profile and manage ACL from the service itself 2024-02-16 11:23:39 +01:00
Martin
56ed901703 tech(clean): remove dead code 2024-02-16 11:23:39 +01:00
Martin
72a3f6e89c refactor(export/archives): holds user profile asking for the archive or export 2024-02-16 11:23:38 +01:00
mfo
4dfb3b86ef
Merge pull request #10000 from mfo/US/groupe-instructeur-manageable-for-routee-procedure
ETQ administrateur, je peux gerer la liste des instructeurs même si le routage est activé sur ma démarche
2024-02-16 09:26:06 +00:00
mfo
cc53946d22
Merge pull request #9978 from mfo/US/enforce-real-email-validation
feat(email): stricter validation
2024-02-16 09:25:58 +00:00
Colin Darie
fc482c1607
Merge pull request #10008 from colinux/fix-draft-procedure-description-cache
ETQ admin: correction du cache de la liste des PJ d'une démarche en brouillon
2024-02-16 07:22:22 +00:00
mfo
3e9abd73e4
Merge pull request #10004 from mfo/add_missing_acl_on_instructeurs_self_management_enabled
secu(instructeurs/groupes_instructeurs): s'assure que seul les instructeurs d'une demarche ayant la gestion activé puisse acceder aux ecrans
2024-02-16 06:37:45 +00:00
Colin Darie
a783c50026 fix(commencer): cache on description of draft procedure
Des changements dans le formulaire d'une démarche en brouillon
ne mettent pas à jour la cache_key de la procedure, donc au fait au plus
simple pour éviter un cache stale dans ces cas là.
2024-02-15 18:45:13 +01:00
Martin
a274629719 fix(instructeurs/groupes_instructeurs#*): add some ACL here 2024-02-15 17:11:25 +01:00
Martin
b6c2742cda bug(instructeurs/groupes_instructeurs#*): any ACL here ? 2024-02-15 17:11:25 +01:00
Martin
8488e74bbb review(suggestion): better code with reviews, normalize Champs::EmailChamp.value, simplier default strict validation activation
Co-authored-by: Colin Darie <colin@darie.eu>
2024-02-15 16:41:00 +01:00
Martin
5f77c0cd06 feat(email.validation): expand email validation to Avis, ContactInformation, Invite, DossierTransfert 2024-02-15 16:41:00 +01:00
Martin
05193e1d1e feat(User.validation): validates email when env var is present 2024-02-15 16:41:00 +01:00
Martin
25f92a7760 feat(email.validator): define a strict email validator, validates Champs::EmailChamp.value only on validation context
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-02-15 16:41:00 +01:00
Martin
5407011668 feat(procedure.routing): allow admin to manage instructeur even when procedure has some routing 2024-02-15 13:40:48 +01:00
Colin Darie
a650114671
test: fix flaky match_array test 2024-02-15 11:00:53 +01:00
seb-by-ouidou
9ddd55d5cd feat: remove commentaire_component and replace it by message_component + replace commentaires/_form by messages/_form + few fixes 2024-02-15 07:50:20 +00:00
Colin Darie
bd3c2c070a
Merge pull request #9957 from demarches-simplifiees/finalize-rna-rnf-ldu
ETQ instructeur et consommateur API, la vue du champ RNA est harmonisée avec le champ RNF
2024-02-14 15:30:54 +00:00
Colin Darie
a9b24b897e
Merge pull request #9971 from demarches-simplifiees/harmonize-merci-message-from-admin-apercu-to-user-ldu
ETQ admin, je veux que le message de fin de dépot d'une démarche déclarative soit correct
2024-02-14 15:14:20 +00:00
Colin Darie
48644ae407
Merge pull request #9846 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_contact_parent_gestionnaires
Délégation de compte: ETQ gestionnaire je peux contacter les gestionnaires des groupes parents
2024-02-13 14:42:03 +00:00
Paul Chavard
7d9cb4d497
Merge pull request #9988 from tchak/refactor-logic-compute-sub-values
refactor(logic): compute sub champ values
2024-02-13 14:22:09 +00:00
Paul Chavard
ff95a812e2 fix(combobox): always sort on the client 2024-02-13 12:26:43 +01:00
Paul Chavard
93635b3516 refactor(logic): compute sub champ values 2024-02-13 11:57:31 +01:00
seb-by-ouidou
fba3cbe331 feat: as gestionnaire, contact gestionnaire of parent groupe 2024-02-13 11:19:52 +01:00
Paul Chavard
641a33e1e0
Merge pull request #9985 from tchak/fix-update-dossier-en-construction
ETQ Usager, je ne veux pas voir un message d'alerte indiquant que la démarche est close lorsque je modifie un dossier en construction
2024-02-13 09:38:08 +00:00
Colin Darie
c0f9b8c1cd test: fix flaky test due to passing time 2024-02-13 09:54:23 +01:00
Eric Leroy-Terquem
7b539c72b1
Merge pull request #9955 from demarches-simplifiees/fix-simple-routing
ETQ admin je peux faire un routage simple à partir d'un type de champ communes ou epci
2024-02-13 07:56:42 +00:00
Paul Chavard
034015384b fix(dossier): do not warn about closed demarche when updating a fork 2024-02-13 08:19:19 +01:00
Colin Darie
5e859bd41f
test(rna): add test against RNA type 2024-02-12 17:20:08 +01:00
Lisa Durand
f09ab62620
add rna type de champ to harmonize api with rnf 2024-02-12 17:20:07 +01:00
Colin Darie
7251a5ca01
Merge pull request #9983 from colinux/fix-address-champ
ETQ instructeur: fix génération d'attestation avec une balise "nom de la commune" depuis un champ adresse
2024-02-12 15:48:11 +00:00
Colin Darie
bfb98554ff
fix(active-storage): don't fail on analyzing a blob derivated by watermark
Quand l'analyse du job se produit après le watermark, elle doit comparer
le checksum avec celui du fichier filigrané.
2024-02-12 16:30:58 +01:00
Colin Darie
ea89c2e8dd
fix(attestation): tag commune_name from address 2024-02-12 15:08:05 +01:00
Colin Darie
c4110c35bf
fix(graphql): json error is not anymore prefixed by unknown line number 2024-02-12 09:33:28 +01:00
Colin Darie
18e5e13eba
test: fix devise-i18n change courriel => email 2024-02-12 09:33:27 +01:00
Colin Darie
e0d5dc84d5
fix(rubocop): Rails/TimeZone 2024-02-12 09:33:20 +01:00
Colin Darie
6ab3fa1cf4
fix(rubocop): Rails/RedundantActiveRecordAllMethod 2024-02-12 09:33:18 +01:00
Paul Chavard
23592087ae refactor(instructeur): use precomputed timestamps 2024-02-08 18:36:04 +01:00
Eric Leroy-Terquem
79ff2ba779 feat(combobox): can paste many terms separated by semicolons 2024-02-08 11:53:47 +01:00
Colin Darie
fb14afc530 fix(rna): real RNA identifier could contain at least 1 letter, despite of specs 2024-02-06 15:02:57 +01:00
Colin Darie
70e92f7c6b
Merge pull request #9903 from colinux/attestation-ux
ETQ admin, je peux tester l'attestation v2
2024-02-06 08:09:53 +00:00
Lisa Durand
0a8e8ebd05 change wording for co-constructing dossier 2024-02-05 12:08:10 +01:00
seb-by-ouidou
c2c54083e8
feat: display tree structure of a group 2024-02-05 09:30:24 +01:00
Colin Darie
eb55abebfc style(attestation): fix for headings style and spacing following charte 2024-02-02 13:49:22 +01:00
Colin Darie
f7484eb0e5
feat(attestation): list tags errors and substitute missing tag by libelle 2024-02-02 13:05:09 +01:00
seb-by-ouidou
46c19014f9 feat: notify administrateur and gestionnaire by email when new commentaire + for administrateur highlight card and commentaires if any unread 2024-02-02 12:52:36 +01:00
Colin Darie
6f49dd892d
fix(attestation): multiple tags improvements
- no menu when no matching tags
- insert a space after clicking a button
- allow no space before mention
2024-02-02 09:47:20 +01:00
Colin Darie
7e02342518
feat(attestation): tiptap default attestation 2024-02-01 18:55:58 +01:00
Colin Darie
475406f3f2
style(attestation): improve editor UI & style 2024-02-01 18:55:55 +01:00
Colin Darie
16478651a9
test(attestation): more tests for v2 2024-02-01 18:55:53 +01:00
Colin Darie
443e41a6ed
style(attestation): group tags by section 2024-02-01 18:55:52 +01:00
Colin Darie
40353fee04
feat(attestation): replace tags in preview for v2 2024-02-01 18:55:50 +01:00
Colin Darie
16cdff8425
feat(tiptap): detect first body paragraph for spacing, handle empty nodes 2024-01-31 17:03:47 +01:00
Colin Darie
45071b7bb6
fix(tiptap): don't fail on node without content 2024-01-31 17:03:40 +01:00
Eric Leroy-Terquem
b04f152733 fix(routing): can create simple routing with communes and epci tdc 2024-01-31 15:27:45 +01:00
Kara Diaby
17a471e880
Merge pull request #9939 from demarches-simplifiees/feat/9937
ETQ Super-Admin, je souhaite marquer une démarche comme modèle
2024-01-31 10:21:30 +00:00
Kara Diaby
46748091a6 Permet au Support de marquer une démarche comme modèle et de filtrer dans toutes les démarches 2024-01-31 09:30:14 +00:00
Colin Darie
88e62323b6
Merge pull request #9949 from mfo/US/fix-device-locale
correctif: ETQ usager naviguant sur le site en anglais, je m'attends a recevoir des messages d'erreur de connexion en anglais
2024-01-31 09:28:15 +00:00
Colin Darie
3ea718a3f5
Merge pull request #9664 from adullact/feature-ouidou/admin_creation_delegation_follow_commentaire
ETQ gestionnaire, j'ai un suivi des messages au sein de mes groupes
2024-01-31 08:56:29 +00:00
Martin
672b341279 bug(auth.error_message): should be i18n 2024-01-30 10:03:00 +01:00
Colin Darie
df1dd19eac
Merge pull request #9946 from colinux/fix-procedure-external-url
Tech: fix le job de vérification des liens externes des procédures lorsqu'un autre attribut est en erreur
2024-01-29 17:31:38 +00:00
seb-by-ouidou
f3cba9331d fix: improvement after review 2024-01-29 18:23:39 +01:00
seb-by-ouidou
6cd8b6d2df feat: for gestionnaire highlight card and commentaires if any unread 2024-01-29 18:23:39 +01:00
seb-by-ouidou
a5d95b2d9d fix: fix activate gestionnaire and activate administrateur 2024-01-29 18:23:39 +01:00
Colin Darie
533ce8d7ba fix(procedure-url-check): don't fail when other attribute have an error 2024-01-29 15:42:35 +01:00
Eric Leroy-Terquem
6203b1fd05
Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code
Tech : nettoyage du code conditionnel et routage
2024-01-29 13:43:52 +00:00
mfo
77ca3dd28a
Merge pull request #9922 from mfo/US/nplus_one_in_summary
perf(TypeDeChampEditor): faster
2024-01-29 10:58:05 +00:00
Colin Darie
a582fef1e5
Merge pull request #9934 from colinux/fix-export-link-witout-file
ETQ instructeur, n'affiche pas encore de lien vers un export quand le fichier n'est pas encore disponible
2024-01-29 10:11:33 +00:00
LeSim
e12c663d21
Merge pull request #9940 from demarches-simplifiees/can_edit_again_a_token
Admin: je peux modifier le nom et les réseaux d'un jeton d'API
2024-01-29 09:21:21 +00:00
simon lehericey
5eaa957c31 can edit api_token to change networks and name 2024-01-29 10:09:55 +01:00
Colin Darie
c02171ede7
Merge pull request #9936 from colinux/badge-corrige
ETQ instructeur, je vois un badge Corrigé lorsque le dossier a été corrigé
2024-01-29 08:57:54 +00:00
Colin Darie
b64a32444c
Merge pull request #9935 from colinux/transfer-empty-no-fail
Tech: plus d'erreur lorsque l'email de transfert n'a plus de dossier associé
2024-01-29 08:43:50 +00:00
Martin
01752bc2e8 perf(ProcedureRevisionPreloader): preload revision quickly 2024-01-26 14:47:44 +01:00
Martin
ecc83edf4f wip 2024-01-26 13:43:10 +01:00
simon lehericey
97f335c36a add a cron job to send expiration notice 2024-01-26 10:18:16 +01:00
simon lehericey
6353c10955 add APIToken expiration mailer 2024-01-26 10:18:16 +01:00
simon lehericey
d909e2c8ea add various expiring scopes to APIToken 2024-01-26 10:15:37 +01:00
Martin
0e5768ec5b fixup! perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-26 09:45:59 +01:00
Colin Darie
50b9813b4d
Merge pull request #9932 from colinux/lock-submit-fork
Correctif: ETQ usager, je ne peux pas soumettre 2x mes modifications en parallèle
2024-01-25 11:37:56 +00:00
Colin Darie
4aa1306536
feat(transfer): make it silent in case dossier had been destroyed between queuing and processing
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-01-25 11:31:12 +01:00
simon lehericey
588e58195c move api_tokens to admin module 2024-01-25 11:27:15 +01:00
simon lehericey
49f0caba7e fix(spec): flaky test 2024-01-25 11:17:44 +01:00
simon lehericey
9a0dd45385 feat(api): add invalid ip addr error 2024-01-25 11:17:44 +01:00
simon lehericey
852eedbc50 refactor(api): create api_token with validity and network filtering 2024-01-25 11:17:44 +01:00
simon lehericey
7e8555923f feature(api): add ensure_token_is_not_expired to api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
d8bc38bc69 feature(api): add ensure_authorized_network for api_controller v1 and v2 2024-01-25 10:51:58 +01:00