Paul Chavard
7970de640f
Merge pull request #6669 from tchak/fix-add-depose-at-to-dossiers
...
Fix add depose_at to dossiers
2021-11-25 13:30:32 +03:00
Paul Chavard
68f6c01548
task(traitements): add depose_at to existing dossiers
2021-11-25 12:57:55 +03:00
Paul Chavard
d847775c68
feat(traitements): add depose_at to dossiers
2021-11-25 12:57:55 +03:00
Paul Chavard
1f1dd9fce5
fix(traitements): add missing traitements to dossiers when reverting a decision
2021-11-25 12:57:55 +03:00
Pierre de La Morinerie
4ba7f43354
Merge pull request #6664 from betagouv/save-new-procedure-revision
2021-11-25 08:53:03 +01:00
Pierre de La Morinerie
e5f5440663
models: explicitely save procedure's new revision
...
Deep-cloned objects have all their relationships stale. Thus, for a
newly deep-cloned revision, `revision.types_de_champs` returns `[]`,
even when it actually has associated types de champ.
This causes consecutive champs creations and re-ordering to fail in
subtle ways, like:
```
procedure.draft_revision.add_type_de_champ(…)
procedure.publish_revision!
procedure.draft_revision.add_type_de_champ(…)
procedure.draft_revision.move_type_de_champ(…) # this will fail
```
As `publish_revision!` created a new stale revision, moving the type
de champ fails because not all existing champs are found until the
object is refreshed.
We don't hit this path in production, because usually only a single
operation is made in a request.
To fix this, save the new revision before associating it as the draft
procedure.
(Another option would be to `reload` the revision after creation, but
this seems better contained and matches the name of the method.)
2021-11-25 08:49:17 +01:00
mfo
73faa569e8
Merge pull request #6656 from betagouv/6649-etq-usager-instructeur-rendre-la-suppression-plus-visible
...
6649 ETQ usager instructeur rendre la suppression plus visible
2021-11-24 14:24:24 +01:00
mfo
e7d9d047fe
Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible
2021-11-24 14:07:32 +01:00
LeSim
618fec575f
Merge pull request #6670 from betagouv/nicer_agent_connect
...
Ajoute une variable d'env manquante a AgentConnect
2021-11-24 13:28:13 +01:00
simon lehericey
6e7d2e057a
typo
2021-11-24 12:50:52 +01:00
simon lehericey
bd4a5c419b
add title to agentconnect page
2021-11-24 12:50:47 +01:00
simon lehericey
f60055637a
add missing redirect_uri env
2021-11-24 12:47:01 +01:00
Paul Chavard
bf66346f6a
Merge pull request #6631 from tchak/fix-graphql-log-parse
...
fix(graphql): fix and improve query parsing for logs
2021-11-24 13:27:59 +03:00
Paul Chavard
758e7d68e6
fix(graphql): fix and improuve query parsing for logs
2021-11-24 13:23:05 +03:00
Paul Chavard
71c54a226d
Merge pull request #6667 from betagouv/active-storage-validations-max-size
...
Simplification des messages d’erreur en cas de fichier trop volumineux
2021-11-24 13:10:14 +03:00
Pierre de La Morinerie
60c2718f29
models: remove custom code for file size validation message
...
With active_storage_validations 0.9.6, we can use the %{max_size}
variable directly in the error message.
2021-11-24 10:06:45 +01:00
Pierre de La Morinerie
4b557a4f18
gems: update active_storage_validation to 0.9.6
...
This allows us to have the %{file_max_size} variable defined in the
error message.
See https://github.com/igorkasyanchuk/active_storage_validations/pull/134
2021-11-24 08:18:18 +01:00
LeSim
d4cbcaf768
Merge pull request #6663 from betagouv/remove-procedure-autocomplete-leftovers
...
Suppression du code obsolète pour l'auto-validation du chemin des démarches
2021-11-23 17:44:31 +01:00
Martin
0fd9e15cc1
i18n(expiration_banner): extract test in i18n files
2021-11-23 15:23:22 +01:00
Pierre de La Morinerie
2227dcc1e7
app: remove leftovers of procedure path autocomplete
...
We used to pre-validate the procedure, to display in advance if the path
could be used.
Now that the path autocomplete is long gone, we can remove this kludgy
code.
2021-11-23 14:30:21 +01:00
LeSim
4fc224490e
Merge pull request #6660 from betagouv/agent_connect
...
Prise en charge d'agent connect (#6027 )
2021-11-23 14:26:05 +01:00
simon lehericey
4efd15377c
spec
2021-11-23 14:17:59 +01:00
simon lehericey
c5097451ef
add redirect
2021-11-23 14:17:59 +01:00
simon lehericey
5234a1854c
manage AgentConnect callback
2021-11-23 14:17:59 +01:00
simon lehericey
1926a630f9
add agent_connect_id to instructeur
2021-11-23 14:17:59 +01:00
simon lehericey
3316dfc866
reopen openid_connect gem to support AC encrypted jwt response
2021-11-23 14:17:59 +01:00
simon lehericey
898df449d4
redirect to AgentConnect
2021-11-23 14:17:59 +01:00
simon lehericey
45ce274721
add agent connect secrets
2021-11-23 14:17:59 +01:00
simon lehericey
d2432e34eb
AgentConnect UI
2021-11-23 14:17:59 +01:00
simon lehericey
ed7d776727
Bump jwt dep to decrypt ES256 FCA response
2021-11-23 14:17:59 +01:00
simon lehericey
91109dc944
bump openid connect (mandatory to avoid lets encrypt certs pb)
2021-11-23 14:17:59 +01:00
Pierre de La Morinerie
a82ce9a13c
Merge pull request #6633 from betagouv/improve-procedure-factory
2021-11-23 14:04:15 +01:00
mfo
49bb12a70e
Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible
2021-11-23 11:05:51 +01:00
Pierre de La Morinerie
997c197980
specs: simplify the syntax of some factories
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
2203a7762f
specs: create dossier revision and individual declaratively
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
f2233300b6
specs: assign the default groupe instructeur declaratively
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
0e809ac1a2
specs: build the default groupe instructeur before the create callback
...
This allows for better ergonomics, by having the default groupe
instructeur available even before the procedure is saved.
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
032e3e2cb1
specs: create the procedure administrateur declaratively
...
It seems better to create associations in an declarative fashion, rather
than using imperative code. This also makes the attribute compatible
with build_stubbed.
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
970c3e4b2b
specs: avoid executing business logic in Procedure factory
...
Calling business logic in a factory is a code-smell, because it
usually requires the object to be saved into database, and may have
unintended consequences when the business logic is changed.
Also, this allows to just build a published procedure, without saving it
to the database.
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
d8fbcfe2e2
specs: explicitely pass the dossier to champs factories
...
Otherwise the factory will not know in avance which procedure this
champs belongs to.
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
ef2d9a3e86
specs: fix :champ_siret factory not using the procedure
...
Unlike all other champs factories, :champ_siret would attempt to build
a champ with a `nil` procedure (instead of using the dossier's one).
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
774ef00f8e
specs: improve dossier_spec#build_default_individual
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
8d89ae366b
specs: minor cleanups
2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
09ca70eef0
specs: improve search controller specs
2021-11-23 08:07:07 +01:00
Martin
b6adf5fc72
feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states
...
fix(spec): broken due to last refactoring
spec(dossier.extend_conservation): add system spec
lint(ruby): still not yet ready for auto lint in IDE...
2021-11-23 05:50:25 +01:00
Paul Chavard
e934d6ea30
Merge pull request #6657 from betagouv/sentry-ignore-parse-errors
...
GraphQL : affiche la cause des erreurs de syntaxe des requêtes
2021-11-22 17:05:24 +03:00
Martin
2a87b9bf89
feat(users/dossiers/*): rework header for consistent design, add some utils spacers
2021-11-22 14:46:10 +01:00
Martin
8368d62ed3
fix(spec): broken due to new view var
2021-11-19 15:53:15 +01:00
Pierre de La Morinerie
859a147c49
api: return error cause on parse error
...
Currently, when a query can't be parsed, the error is:
- logged to Sentry (which is useless to us),
- returned as a generic 'Internal Server Error' (which is useless to the
user who made the query).
With this commit, the error is instead ignored from our logs (because it
is a user error), but the parse error details are returned to the user,
with the following format:
> {'errors': [{'message': 'Parse error on ")" (RPAREN) at [3, 23]'}]}
2021-11-19 15:15:10 +01:00
Martin
3d1533dee9
feat(users/dossiers?statut=dossiers-expirant): add dossiers-expirant tab
2021-11-19 15:14:39 +01:00
