Commit graph

9006 commits

Author SHA1 Message Date
Pierre de La Morinerie
cbaa584bd0 lint: improve Rubocop detection
Instead on relying on the environment, we try to load the Rubocop cop
only if Rubocop is currently loaded.
2020-02-03 11:09:11 +01:00
Keirua
a6b337c436
Merge pull request #4735 from betagouv/fix/rubocop-custom-rule
Only load rubocop's custom rule in development
2020-01-30 15:30:24 +01:00
clemkeirua
eb20dd9153 only load unscoped custom rule in development 2020-01-30 15:23:21 +01:00
Paul Chavard
ab93a75b6d
Merge pull request #4726 from tchak/auto-watch-exports
Poll for export readiness updates
2020-01-30 11:07:05 +01:00
Paul Chavard
08400cdd4c Poll for export readiness updates 2020-01-29 22:52:03 +01:00
Keirua
a7e1137eeb
Merge pull request #4728 from betagouv/revert-4656-cleanup-js
Revert "Update javascript dependencies and add webpack-bundle-analyzer"
2020-01-29 14:58:32 +01:00
Keirua
eddd59e554
Revert "Update javascript dependencies and add webpack-bundle-analyzer" 2020-01-29 14:51:55 +01:00
Keirua
d4dbc44dac
Merge pull request #4723 from betagouv/fix-double-render
fix: les demandes de PDF pour les brouillons génèrent des DoubleRender
2020-01-29 14:33:33 +01:00
clemkeirua
1c3573c7db fix DoubleRender error for brouillon pdf 2020-01-29 14:24:23 +01:00
Paul Chavard
5bd4c16de8
Merge pull request #4725 from betagouv/fix-export-excel-invalid-worksheet
Fix - Suppression des caractères invalides pour feuilles excel
2020-01-29 11:21:00 +00:00
clemkeirua
fcea7c4f85 remove invalid excel worksheet characters 2020-01-29 11:45:56 +01:00
Paul Chavard
ea4bb93bba
Merge pull request #4720 from tchak/graphql-big-int
[GraphQL] Use GraphQL::Types::BigInt instead of Int
2020-01-29 10:10:46 +00:00
Paul Chavard
6030409b2f [GraphQL] Use GraphQL::Types::BigInt instead of Int 2020-01-28 21:48:00 +01:00
Paul Chavard
42fd2a4774
Merge pull request #4721 from betagouv/rubocop-unscoped
Ajout d'une règle Rubocop pour interdire `unscoped`
2020-01-28 21:47:39 +01:00
Pierre de La Morinerie
cf101d64d8 lint: add a Rubocop rule to forbid the use of unscoped
`unscoped` often has an effect broader than intended. For instance:

```
user.dossiers.unscoped.destroy_all
```

will not destroy all the user's dossier, including the hidden ones,
but **all the dossiers of all users**.

Instead, narrower unscoping should be used:

```
user.dossiers.unscope(where: :hidden).destroy_all
```

(Or even better, use the new `Dossier.with_hidden` scope).
2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
96932faa3f models: add a Dossier#with_hidden scope, and remove unscoped usages 2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
1448d5b098 models: add a Procedure#with_hidden scope, and remove unscoped usages
This avoids the broad use of `unscoped` to remove the `hidden_at`
clause.
2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
4efea77280 specs: regroup dossier scope specs together 2020-01-28 17:32:38 +01:00
Pierre de La Morinerie
780cb965a5
Update javascript dependencies and add webpack-bundle-analyzer (#4656)
Mise à jour des dépendances Javascript ; ajout de webpack-bundle-analyzer
2020-01-28 17:29:18 +01:00
Paul Chavard
4982039086 Fix fontawesome not tree shaking properly 2020-01-28 16:37:44 +01:00
Paul Chavard
7ebebf2e80 Refactor leaflet code for better loading 2020-01-28 16:37:44 +01:00
Paul Chavard
a223eb05da Update javascript dependencies and add webpack-bundle-analyzer 2020-01-28 16:37:44 +01:00
Keirua
f2179979fe
Merge pull request #4684 from betagouv/feat/admin-edit-email
Modification d'un email d'un utilisateur dans le manager
2020-01-28 16:23:01 +01:00
clemkeirua
5f65665b07 added a method for modifying a user email 2020-01-28 16:15:46 +01:00
Pierre de La Morinerie
4eb7d854a9 workflows: fix trailing whitespace 2020-01-28 15:48:02 +01:00
Pierre de La Morinerie
897cdf6632
[GraphQL] use Execution::Interpreter (+ update Skylight) (#4626)
GraphQL : mise à jour de l'analyse des performances
2020-01-28 15:47:34 +01:00
Paul Chavard
f7c59cffc0 Fix tests for skylight 2020-01-28 15:39:37 +01:00
Paul Chavard
0a928b2d6b [GraphQL] use Execution::Interpreter
GraphQL-Ruby 1.9.0 includes a new runtime module which you may use for your schema. Eventually, it will become the default.
2020-01-28 15:39:37 +01:00
Paul Chavard
7478a51846 [GraphQL] use official skylight support 2020-01-28 15:39:37 +01:00
Pierre de La Morinerie
f7128e81da
workflows: update auto-rebase bot
Update to latest version of the auto-rebase bot
2020-01-28 15:38:32 +01:00
Pierre de La Morinerie
9993b8ca86
Rend l'indicateur d'autosave tout le temps visible sous IE 11 (#4570)
Usager : rend l'indicateur de sauvegarde automatique visible sous IE 11
2020-01-28 15:30:43 +01:00
Pierre de La Morinerie
6eaf0f7804 dossiers: fix the sticky bar on IE 11
This allows IE 11 users to see the draft autosave indicator.

The layout on IE 11 is still buggy though - but it's better than
nothing.
2020-01-28 15:20:30 +01:00
Pierre de La Morinerie
2c795a5ff4
Revert "app: hide IE11 deprecation banner during the strike" (#4713)
Le bandeau indiquant qu'Internet Explorer 11 est très ancien est à nouveau affiché
2020-01-28 15:19:01 +01:00
Paul Chavard
df8b35a9e0
Merge pull request #4716 from tchak/add-more-info-to-avis-export
Ajouter les informations de l’instructeur et de l’expert dans l’export des avis
2020-01-28 15:18:28 +01:00
Pierre de La Morinerie
745b00366f Revert "app: hide IE11 deprecation banner during the strike"
This reverts commit c2882b6cc3.
2020-01-28 15:18:18 +01:00
Paul Chavard
eec38bad73 Ajouter les informations de l’instructeur et de l’expert dans l’export des avis
fix #4667
2020-01-28 15:09:41 +01:00
Pierre de La Morinerie
d73dbc5056
Fix empty value in routing dropdown (#4718)
Usager : empêche l'usager de sélectionner un groupe de routage vide
2020-01-28 15:08:32 +01:00
Pierre de La Morinerie
9da4fa9f4d dossier: ensure the dossier groupe_instructeur is always present
Otherwise we loose the link to the dossier's procedure, which is
definitely a bad thing.
2020-01-28 14:58:34 +01:00
Pierre de La Morinerie
eb9388d59f dossier: ensure the routing dropdown must be selected
A blank routing dropdown nullify the groupe_instructeur – which
also removes the link between the dossier and the procedure.

Fix #4717
2020-01-28 14:58:34 +01:00
Keirua
0f88409f4a
Merge pull request #4710 from betagouv/4703-fix-menu-deroulant-liee
#4703 - fix menu déroulant lié obligatoire
2020-01-28 14:35:50 +01:00
clemkeirua
696e39761f deal with secondary_options that can be nil 2020-01-28 14:30:26 +01:00
clemkeirua
65b4bcf3a1 Permet de déposer un dossier lorsqu'un menu déroulant lié obligatoire n'a pas de valeur (car la liste est légitimement vide) dans le second champ. 2020-01-28 14:30:26 +01:00
Paul Chavard
81fd91ce41
Merge pull request #4619 from tchak/add-canonical-procedure
Register canonical procedure when démarche republished under existing path
2020-01-28 13:00:06 +01:00
Paul Chavard
67dea1ee50 Update spec/models/procedure_spec.rb
Co-Authored-By: Pierre de La Morinerie <kemenaran@gmail.com>
2020-01-28 12:49:53 +01:00
Paul Chavard
517ab25783 Register canonical procedure when demarche republished under existing path 2020-01-28 12:49:53 +01:00
Paul Chavard
04ad829e3f Add canonical_procedure_id to procedures 2020-01-28 12:49:53 +01:00
Paul Chavard
4a600a5514
Merge pull request #4715 from tchak/update-rspec
Update rspec
2020-01-28 12:49:12 +01:00
Paul Chavard
12c02a602f Update rspec 2020-01-28 12:43:07 +01:00
Paul Chavard
926b092d05
Merge pull request #4714 from betagouv/add-exercice-spec
specs: add an actual test case to the Exercice spec
2020-01-28 12:34:43 +01:00
Pierre de La Morinerie
aaaf6f393b specs: add an actual test case to the Exercice spec
This fixes the "No timing found for 'spec/models/exercice_spec.rb'"
warning message during specs.
2020-01-28 12:00:34 +01:00