gregoirenovel
9a2341c56c
Remove the useless #for_display proxy method
2019-01-08 12:32:26 +01:00
Pierre de La Morinerie
be1567ecbd
messages: improve wording of the "Send" button
2019-01-07 16:20:23 +01:00
Pierre de La Morinerie
e25bd7139f
layouts: use a common procedure_context layout for the demarche overview
2019-01-07 15:39:58 +01:00
simon lehericey
7b935a6486
login_token: lets constantize
2019-01-07 08:18:29 +01:00
simon lehericey
5daa565a80
login_token: add missing tests
2019-01-07 08:18:29 +01:00
gregoirenovel
5fa5f2aa37
Bump development gems
...
- rubocop (0.61.1 → 0.62.0)
2019-01-05 11:47:55 +01:00
Pierre de La Morinerie
98127b6778
signature: refactor specs
2019-01-03 17:48:53 +01:00
Pierre de La Morinerie
2c0108190c
spec: fix specs failing randomly
...
This is because creating a procedure attempts to create an admin from
scratch, and fails to do so.
Broken by 802f2086d6
2019-01-03 17:42:43 +01:00
Pierre de La Morinerie
86b9e2d092
stats: fix exception when HelpScout env vars are missing
...
This fixes the stats page, which used to raise an exception when
HelpScout env vars are not present.
2019-01-03 17:27:56 +01:00
Pierre de La Morinerie
d77530c461
Make Procedure state consistent after switching types de champ order
...
Fixes an issue where, after clicking the "move champ up" button,
the new form is rendered with an incoherent order.
2019-01-03 15:13:14 +01:00
gregoirenovel
9466442aff
Remove the TypeDeChamp decorators
2019-01-03 12:08:25 +01:00
gregoirenovel
9c130c41da
Remove ProcedureDecorator
2019-01-03 12:08:25 +01:00
gregoirenovel
b41764ec03
Remove ChampDecorator
2019-01-03 12:08:25 +01:00
gregoirenovel
b8f57415cd
Remove the unused decorator DossierDecorator
2019-01-03 12:08:25 +01:00
gregoirenovel
559df6b82a
Remove the unused decorator ProceduresDecorator
2019-01-03 12:08:24 +01:00
gregoirenovel
4f30e30a08
Remove the unused decorator FranceConnectInformationDecorator
2019-01-03 12:08:24 +01:00
gregoirenovel
0336ecf639
Remove useless arguments from some methods
2019-01-03 10:53:50 +01:00
gregoirenovel
0596d53ac2
Enable the Lint/UnusedBlockArgument cop
2019-01-03 10:53:50 +01:00
gregoirenovel
ddc71cbacf
Enable the Lint/UnderscorePrefixedVariableName cop
2019-01-03 10:53:50 +01:00
gregoirenovel
baf7977786
Enable the Lint/StringConversionInInterpolation cop
2019-01-03 10:53:50 +01:00
gregoirenovel
186e362701
Enable the Layout/SpaceInsideArrayLiteralBrackets
2019-01-03 10:53:50 +01:00
gregoirenovel
386fbce776
Enable the Layout/SpaceBeforeBlockBraces cop
2019-01-03 10:53:50 +01:00
gregoirenovel
8b0b8162f0
Enable the Layout/SpaceAfterComma cop
2019-01-03 10:53:50 +01:00
Chaïb Martinez
802f2086d6
Redirect admins with no démarches to the new demarche page
2018-12-28 18:57:51 +01:00
maatinito
4ad3a60e25
[ Fix #2575 ] Créer automatiquement un compte instructeur aux administrateurs
2018-12-26 09:44:20 -10:00
gregoirenovel
03eb47016c
Fix a gestionnaire sign in bug
2018-12-26 18:14:04 +01:00
maatinito
8304ce12e1
Make some email previews database-independent
2018-12-20 17:07:03 +01:00
maatinito
e1b97b3303
Make more emails previewable
2018-12-20 17:06:57 +01:00
maatinito
e37372d261
Fix a typo
2018-12-20 16:21:27 +01:00
maatinito
9842142a9a
Add InviteMailerPreview
2018-12-20 16:21:27 +01:00
maatinito
a1a11adb83
[ #325 ] Make the notification layout inherit from the general layout
2018-12-20 16:21:27 +01:00
Mathieu Magnin
904d8d208b
[ Fix #3192 ] Fix data
2018-12-20 15:45:48 +01:00
Mathieu Magnin
b40c706d98
[ Fix #3192 ] Clone service if procedure is transferred
2018-12-20 15:45:48 +01:00
Paul Chavard
eb9edc1cee
Order types de champ in scope
2018-12-20 14:14:15 +01:00
Paul Chavard
5d1c24f3d8
Add type de champ repetition models (with row)
2018-12-19 15:31:11 +01:00
gregoirenovel
df7e0a9881
Remove dead code
2018-12-19 14:59:15 +01:00
Frederic Merizen
d1cfe4468d
Encourager la création de champs PJ plutôt que de vieilles PJS
2018-12-19 11:57:23 +01:00
Frederic Merizen
832b4a61bc
Drop CleverCloud Service for ActiveStorage
2018-12-19 10:36:02 +01:00
Frederic Merizen
57a136c861
Make champ PJ generally available
2018-12-18 11:11:23 +01:00
Pierre de La Morinerie
d614ea6bd5
stats: display contact rate
2018-12-18 10:38:59 +01:00
maatinito
af8eee25ad
[ Fix #249 ] added test for too short passwords
2018-12-17 11:14:35 -10:00
Mathieu Magnin
edf3eefa87
Fix Sentry 114, Instructeur can delete pj in private champs
2018-12-13 17:27:05 +01:00
simon lehericey
5a87fad02e
[ fix #3154 ] order export
2018-12-10 16:41:37 +01:00
Pierre de La Morinerie
a0ae1afb45
typhoeus: add a cache store for successful requests
2018-12-10 11:41:07 +01:00
Frederic Merizen
270c7568fa
[ #2180 ] Avoid fetching old PJ modification times separately
...
Speeds up transfer
2018-12-08 15:55:40 +01:00
Frederic Merizen
907e87809b
[ #2180 ] Iterate over storage keys rather than blobs
...
To create less confusion on dev
2018-12-07 15:30:10 +01:00
pedong
f70f276ae9
[ fix #2813 ] set lien_notice nil when clone a procedure
2018-12-06 21:28:08 +01:00
simon lehericey
db6c86b242
DossierController: user can destroy pjs
2018-12-06 10:45:10 +01:00
Frederic Merizen
4699e515ed
[ Fix #2999 ] Send gestionnaire back to what they were doing after email verification
2018-12-06 10:03:21 +01:00
Paul Chavard
ee93b4e33d
Revert legacy carte API to parsed json
2018-12-05 18:19:15 +01:00
Paul Chavard
35494df78e
Procedure export dossiers with champs siret
2018-12-05 17:09:39 +01:00
Pierre de La Morinerie
e206f3d4d4
gestionnaire: display draft procedures in the list
...
Fix #3088
2018-12-05 15:38:20 +01:00
Pierre de La Morinerie
421f125c45
gestionnaire_spec: factorize a assign helper
2018-12-05 15:38:20 +01:00
Paul Chavard
a08f170dbd
Assign users and gestionnaires to commentaires
...
fix #2052
2018-12-05 13:40:57 +01:00
gregoirenovel
121086eedd
Bump rails
2018-12-04 11:16:42 +01:00
gregoirenovel
873bf2fc0f
Tell puma to STFU
2018-12-04 10:35:13 +01:00
gregoirenovel
478fb88618
Bump capybara (2.18.0 → 3.11.0)
2018-12-04 10:35:13 +01:00
gregoirenovel
94b6783a65
Slightly change some tests to comply with puma
2018-12-03 16:28:18 +01:00
gregoirenovel
b3d0a113eb
Use non-breaking spaces in tests
2018-12-03 16:28:18 +01:00
Paul Chavard
e873b6a9c4
Expose selection utilisateur size on champ carte
2018-12-03 12:49:03 +01:00
Paul Chavard
d77a5c9f15
More tests and fixes on carte champ
2018-11-30 13:28:30 +01:00
Paul Chavard
097a15d624
Test and fix all possible cases of champ carte serialization
2018-11-30 12:02:27 +01:00
Paul Chavard
35d2bc36fc
cleanup selection_utilisateur geo_json
2018-11-29 17:10:14 +01:00
Paul Chavard
ca147969ab
Fix number champs validation
2018-11-29 15:12:31 +01:00
Paul Chavard
1883c57c87
Add stable ids to types_de_champ after every update
2018-11-29 11:41:13 +01:00
Paul Chavard
b9af07b845
Add admin support contact form
2018-11-28 16:50:37 +01:00
Paul Chavard
575a437f97
Remove carto from admin/procedure controller
2018-11-27 16:11:25 +01:00
Paul Chavard
1897b2775c
Remove old migration task
2018-11-27 16:11:25 +01:00
Paul Chavard
c6ef30f3e1
Remove unused carto from instructeur interface
2018-11-27 16:11:25 +01:00
Paul Chavard
9ff65efea8
Remove deprecated carto from dossiers controller
2018-11-27 16:11:25 +01:00
Paul Chavard
d988638c58
Simplify API carte serializer
2018-11-27 16:11:25 +01:00
Paul Chavard
36f6f54337
Remove unused carto models
2018-11-27 16:11:25 +01:00
Paul Chavard
5632929d3d
Remove old caro editor
2018-11-27 16:11:25 +01:00
Paul Chavard
37a7e26fc3
Remove unused users/carte_controller
2018-11-27 16:11:25 +01:00
Pierre de La Morinerie
ea8bc0c961
mailers: improve notification layout
2018-11-27 15:51:26 +01:00
Pierre de La Morinerie
4e801b188c
tasks: remove outdated footers in mail templates
...
Fix #1863
2018-11-27 15:32:02 +01:00
Paul Chavard
98d388b64d
Use state change methods on dossier in dossier auto archive job
2018-11-27 12:49:40 +01:00
Paul Chavard
b5b6832be8
Use state change methods on dossier in dossier auto recieve job
2018-11-27 12:49:40 +01:00
Paul Chavard
febf625dd9
Make difference between error and empty geo json
2018-11-27 12:36:10 +01:00
Paul Chavard
f2e7feec1d
Do not send error json to backend - it doesn’t need it and it creates bad data
2018-11-27 11:45:24 +01:00
Mathieu Magnin
718a30639f
[ Fix #2929 ] Improve readability of invitation for avis
2018-11-23 13:18:36 +01:00
pedong
0d02f5896e
[ Fix #1339 ] properly display avis confidentiality to experts
2018-11-22 18:38:31 +01:00
Chaïb Martinez
0e8d235800
Add some params to track forms submissions
2018-11-21 18:25:47 +01:00
Mathieu Magnin
7c1768e5bb
[ Fix #3016 ] Do not crash if PJ has no extension
2018-11-21 14:15:45 +01:00
Paul Chavard
c99ef811b6
Do not save error json in database
2018-11-21 13:03:01 +01:00
Pierre de La Morinerie
f983bc68e2
mailers: fix dossier mailer spec
2018-11-20 17:45:50 +01:00
Pierre de La Morinerie
a5f9be00e0
mailers: add preview URL to all previewable mailers
2018-11-20 14:46:31 +01:00
Pierre de La Morinerie
f2eaf66a9a
mailers: add missing previews for notification emails
2018-11-20 14:46:31 +01:00
Pierre de La Morinerie
e5303fd986
mailers: streamline the NotificationMailer
...
Notifications are now only for demarche-templated emails.
2018-11-20 14:46:31 +01:00
Paul Chavard
d43068ace5
Disable carto for new procedures
2018-11-20 12:14:10 +01:00
Paul Chavard
864d1df413
Test carto migration task
2018-11-20 10:58:22 +01:00
Paul Chavard
e374a5c726
Refactor ChampSerializer
2018-11-20 10:53:14 +01:00
Paul Chavard
0b017580c5
Expose migrated legacy carto champs on api
2018-11-20 10:53:14 +01:00
Paul Chavard
fe630847e9
Refactor legacy carto serializer
2018-11-20 10:53:14 +01:00
Paul Chavard
2462e42b53
Stop using legacy api carto after migration
2018-11-20 10:53:14 +01:00
Frederic Merizen
101e8e2588
[ #2999 ] Rediriger vers la bonne page apres login
...
(ne corrige pas le cas ou l'utilisateur est passe par le mail de confirmation)
2018-11-16 15:44:20 +01:00
Paul Chavard
2eb61bd6ed
Move dossier invites handler to invites controller
2018-11-14 15:16:49 +01:00
Pierre de La Morinerie
b6521625e4
procedure_spec: add missing Timecop.return statement
...
Fix order-dependant test.
2018-11-14 14:49:41 +01:00
Pierre de La Morinerie
35613992fe
rspec: by default use the safer bisect runner for bisecting
2018-11-14 14:49:41 +01:00
Pierre de La Morinerie
acc6df2662
spec: fix Mina enabling Rails traces during tests
...
When requiring mina files, it automatically enables Rails traces. But
we don't want Rails traces during tests.
Fix this by disabling Rails traces before running tests.
Fix #2989
2018-11-14 11:55:21 +01:00
Pierre de La Morinerie
83031b5cdd
procedure: compute the usual instruction time only for the last month
2018-11-13 17:23:31 +01:00
Pierre de La Morinerie
b693e055b7
procedure: make usual_instruction_time spec more robust
2018-11-13 17:23:31 +01:00
Pierre de La Morinerie
b1296df4c3
procedure: refactor usual_instruction_time spec
2018-11-13 17:23:31 +01:00
simon lehericey
fb76197404
SessionController: flipflop trusted device
2018-11-13 10:41:45 +01:00
simon lehericey
0d8d2de5a6
Session: add trusted_device cookie
2018-11-13 10:41:45 +01:00
simon lehericey
5690599289
Session: send a mail to confirm gestionnaire login
2018-11-13 10:41:45 +01:00
simon lehericey
2613d05a4f
An admin has always a gestionnaire role
2018-11-13 10:41:45 +01:00
Pierre de La Morinerie
7635aede98
dossier: improve wording of estimated time
...
Ref #2970
2018-11-12 10:21:57 +01:00
Pierre de La Morinerie
e59bec51ef
procedure: use 90th percentile to estimate the completion delay
2018-11-08 18:29:17 +01:00
Pierre de La Morinerie
5c921182ea
procedure: rename mean_instruction_time to usual_instruction_time
...
Ref #2970
2018-11-08 17:20:06 +01:00
Pierre de La Morinerie
c7ac43cfe7
confirmation: add a dedicated page with confirmation instructions
...
Fix #2586
2018-11-08 16:20:05 +01:00
Paul Chavard
33c6ddc452
Remove dead code related to dossier state
2018-11-08 14:56:45 +01:00
Paul Chavard
0fe59a7c65
Add dossier_legacy_state helper
2018-11-08 14:56:45 +01:00
Paul Chavard
f09a7a01c8
Add dossier_display_state helper
2018-11-08 14:56:45 +01:00
Paul Chavard
80189def98
Remove n+1 calls from API queries
2018-11-08 14:45:09 +01:00
Paul Chavard
a7de2e68ed
Refactor types_de_champ views to use service instead of facade
2018-11-07 11:36:10 +01:00
Paul Chavard
1c87eda6e1
Move types_de_champ helper to service
2018-11-07 11:36:10 +01:00
Paul Chavard
2d647f9fa7
Move types_de_champ facade to service
2018-11-07 11:36:10 +01:00
Pierre de La Morinerie
8355b690f0
users: add integration tests for sign-up
2018-11-06 18:24:34 +01:00
Pierre de La Morinerie
b0541fba79
users: sign-in after confirming an account within a short time
2018-11-06 18:24:34 +01:00
Pierre de La Morinerie
0fb9c123c9
invite: mutualize feature helper for signing in
2018-11-06 17:26:20 +01:00
Pierre de La Morinerie
d4b2b04875
spec: clear deliveries before every example
2018-11-06 17:26:20 +01:00
simon lehericey
9d406770a8
[ fix #2956 ] YesNo: fixing to_s
2018-11-06 16:59:47 +01:00
Frederic Merizen
d564eb1225
[ #835 ] Report failed and successful invitations
2018-11-06 16:40:42 +01:00
Frederic Merizen
8cf235f2fd
[ #835 ] Enable html5 validation of multiple mails
2018-11-06 15:44:43 +01:00
Frederic Merizen
c7358a8f53
[ Fix #835 ] Enable asking for multiple avis at the same time
2018-11-06 15:44:43 +01:00
Paul Chavard
9ac85295c6
Do not serialize properties on carte champs
2018-11-06 14:26:32 +01:00
Paul Chavard
074050a91a
Add IntegerNumberChamp
2018-11-06 11:28:44 +01:00
Paul Chavard
45bfb2fd47
Add DecimalNumberChamp
2018-11-06 11:28:44 +01:00
Paul Chavard
cfd1950e17
Migrate commencer to new_user
2018-11-01 13:10:41 +01:00
Paul Chavard
8ff45c7978
Fix commentaire file_url generator
2018-10-31 12:53:14 +01:00
simon lehericey
2f2f1e1321
Let the API return times in UTC for now
2018-10-31 11:43:48 +01:00
Paul Chavard
e391fe6bec
Clarify procedure path availability code
2018-10-30 15:59:37 +01:00
Mathieu Magnin
c656e36ec2
[ Fix #2276 ] Test to ensure form is not cleared if service creation failed
2018-10-30 15:49:18 +01:00
Paul Chavard
fcdc0114fd
Add id to geo areas
2018-10-30 12:16:09 +01:00
Paul Chavard
725e88a89a
Rename :procedure_path -> :path
2018-10-30 12:01:45 +01:00
Paul Chavard
f1fd1b38ec
Refactor procedures_controller
2018-10-30 12:01:45 +01:00
Paul Chavard
78dc582588
Remove ProcedurePath
2018-10-30 12:01:45 +01:00
Frederic Merizen
cf9024d36f
Fix test that doesn't work just after daylight saving time changes
...
If I submit a request on Friday at 8am, and get a response on
Monday at 8am, the response time is 72h...
except if there was a daylight saving time change on Sunday, in
which case the response time is either 71h or 73h, making the test
fail
2018-10-30 10:58:20 +01:00
Frederic Merizen
aff93ecd6a
Simplify test syntax
2018-10-26 17:53:36 +02:00
Frederic Merizen
f6207bee26
Do not take time of day into account when searching dates
2018-10-26 17:53:26 +02:00
simon lehericey
a06f872a4b
ProcedurePresentation: rescue big int as a datetime value
2018-10-26 14:39:17 +02:00
simon lehericey
63db387984
ProcedurePresentation: display dossier date in d/m/Y
2018-10-26 10:10:20 +00:00
simon lehericey
3685c65fb7
[ fix #2905 ] fix DATE_TRUNC usage
...
DATE_TRUNC is played on the db where the timestamp are stored in utc.
So if a user search for 12/12/2012 in Paris timezone and that we truncate it should do something similar to :
SELECT DATE_TRUNC('day', foo.timezone) from (SELECT timestamp '2012-12-12 00:00:00' AT TIME ZONE 'Europe/Paris') as foo;
=> 2012-12-11
To avoid such pb, I suggest avoiding DATE_TRUNC when exact results are needed
2018-10-26 10:10:20 +00:00
simon lehericey
9475795143
fix spec
2018-10-26 10:10:20 +00:00
simon lehericey
26ae29ea52
Time.local => Time.zone.local
2018-10-26 10:10:20 +00:00
simon lehericey
3078b377c7
Time.new => Time.zone.local
2018-10-26 10:10:20 +00:00
simon lehericey
e684cec516
DateTime.new => Time.zone.local
2018-10-26 10:10:20 +00:00
simon lehericey
f620e4aee2
DateTime.parse => Time.zone.parse
2018-10-26 10:10:20 +00:00
simon lehericey
2238e5bd9f
Time.now => Time.zone.now
2018-10-26 10:10:20 +00:00
