2123 commits

Author	SHA1	Message	Date
Paul Chavard	dfc004d7bb	Unarchive dossier when repasser_en_instruction	2020-05-12 19:05:18 +02:00
Christophe Robillard	10a21f9010	expose attestationSocialeAttachment and attestationFiscaleAttachment	2020-05-06 17:25:04 +02:00
Christophe Robillard	f587e6600a	extract class ApiEntrepriseToken ... and check if token is expired	2020-05-06 10:57:45 +02:00
Paul Chavard	6556df2a85	Fix a crash in case of invalid geometry	2020-05-05 15:56:05 +02:00
Christophe Robillard	9de2c7c85a	improve csv generation for bilans bdf	2020-04-30 16:15:16 +02:00
Christophe Robillard	9873826dd4	remove date computed column ... we will add it when more info of business	2020-04-30 16:15:16 +02:00
Christophe Robillard	22e2c2e133	render csv bidf bilans	2020-04-30 16:15:16 +02:00
Paul Chavard	843e033c38	Allow instructeurs to download a GeoJSON document for a given dossier	2020-04-30 15:49:43 +02:00
Paul Chavard	ef2d9e1138	Expose stable_id on champ	2020-04-30 15:49:31 +02:00
Christophe Robillard	3ddb5a4cb4	store attestation fiscale and display	2020-04-30 11:39:54 +02:00
Paul Chavard	b516cbc179	Enable republish on démarches dépubliée	2020-04-29 18:04:35 +02:00
Christophe Robillard	ddd3e6bb02	don't copy api_entreprise_token when cloning ... except for an admin who owns the parent procedure	2020-04-29 17:17:20 +02:00
Christophe Robillard	158b4802ab	store attestation sociale and display	2020-04-29 16:25:47 +02:00
Christophe Robillard	d74b14c205	fetch attestation sociale url	2020-04-29 14:25:55 +02:00
Paul Chavard	2a3530738d	Do not crash on boot if geos is not installed	2020-04-23 20:12:31 +02:00
Paul Chavard	9cb612bb3d	Show area and length on champ carto selections utilisateur	2020-04-23 10:21:18 +02:00
Christophe Robillard	792e755af9	expose effectif_annuel dans api graphql	2020-04-23 09:53:27 +02:00
Paul Chavard	bdbee38ff1	Add expired termine scopes to dossier	2020-04-22 15:39:10 +02:00
Pierre de La Morinerie	1cb18e51ac	champ: return the parent dossier even when discarded ... Dossier has a `default_scope { kept }`. Because of that, when the parent dossier is discarded, `champ.dossier` will return nil. We should kill the default scope. But meanwhile, ensure that `champ.dossier` returns even a discarded dossier.	2020-04-22 11:46:42 +02:00
Christophe Robillard	149b98007f	add effectif mensuel to graphql api	2020-04-21 21:13:07 +02:00
Paul Chavard	e512870fd2	Cleanup procedure duree_conservation_dossiers_dans_ds validations	2020-04-16 19:40:19 +02:00
Paul Chavard	bc8217e030	Carte Editor sends FeatureCollection to the server	2020-04-16 18:29:19 +02:00
Paul Chavard	ee3ff78b12	Create constants for default map location	2020-04-16 10:22:07 +02:00
Paul Chavard	22604013d0	Expose multiple user selections on champ carte	2020-04-15 18:07:09 +02:00
clemkeirua	8c2f589cbf	fix admin deletion of empty service with archived procedures	2020-04-10 20:01:40 +02:00
Christophe Robillard	f683b850c3	Notifie instructeurs le souhaitant lors depot dossier ... Notifie par mail uniquement les instructeurs qui le souhaitent à chaque dépôt de dossier	2020-04-09 15:02:05 +02:00
Christophe Robillard	ae18ff6627	Notifie tous les instructeurs lors dépôt dossier ... - envoie un mail à tous les instructeurs d'une procédure après le dépôt d'un nouveau dossier	2020-04-09 14:33:56 +02:00
Christophe Robillard	969478b706	Envoie une notif aux followers_instructeurs le souhaitant ... après chaque message déposé par l'usager	2020-04-09 14:17:07 +02:00
Paul Chavard	61eaca928f	remove WarnExpiringDossiersJob	2020-04-09 11:11:51 +02:00
Paul Chavard	32f783142c	[GraphQL] allow to query dossiers by groupe instructeur	2020-04-09 09:29:28 +02:00
clemkeirua	ed45c88bdf	do not clone groups instructeurs for admin outside the procedure	2020-04-07 09:25:40 +02:00
pedong	7806a26e2c	copy groupe_instructeurs when clone	2020-04-07 09:22:33 +02:00
Christophe Robillard	5b6044803b	forbid to create champ with same type_de_champ and same row	2020-04-06 17:39:51 +02:00
Paul Chavard	725cfa45d3	Do not set processed_at if already defined	2020-04-02 15:23:53 +02:00
Paul Chavard	413abccd3c	Add default order to dossier.dossier_operation_logs	2020-04-02 14:05:40 +02:00
Paul Chavard	c0bbfa42b7	Reassign discarded dossiers on group_instructeur ... fix #4851	2020-04-01 18:10:12 +02:00
Paul Chavard	288ace2f34	Dossier on discarded procedure should have access to discarded procedure	2020-03-31 17:08:29 +02:00
Paul Chavard	bd81970f67	DeletedDossier should have access to discarded demarche	2020-03-31 17:08:29 +02:00
Paul Chavard	e4ab2574ce	Démarches discarded by administrateur can be reactivated in manager	2020-03-31 17:08:28 +02:00
Paul Chavard	58c126308c	Add DiscardedProceduresDeletionJob job	2020-03-31 17:08:28 +02:00
Paul Chavard	da52ec30bd	Undo discard dossiers and demarches from manager	2020-03-31 17:08:28 +02:00
Paul Chavard	876e05aed3	Discard demarches from manager	2020-03-31 17:08:28 +02:00
Paul Chavard	aa066bc20a	Validate deleted dossiers dossier_id uniqueness	2020-03-31 16:54:33 +02:00
Pierre de La Morinerie	fe13043efd	dossier: prepare validations to piece_justificative champs ... We can't yet enable the validations, because of an issue that will (hopefully) be solved with Rails 6. See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926	2020-03-30 11:12:25 +02:00
Pierre de La Morinerie	f3c210e875	dossier: remove dead validation code ... This code used to be called by CarrierWave, but is unused since the migration to ActiveStorage. This means that these validations are currently disabled though. See https://github.com/betagouv/demarches-simplifiees.fr/issues/4926	2020-03-30 11:12:25 +02:00
Paul Chavard	c763679b54	Remove non-existant columns from manager dashboards	2020-03-26 16:17:07 +01:00
Paul Chavard	c707a21f97	Rename delete_and_keep_track -> discard_and_keep_track	2020-03-26 14:23:23 +01:00
Paul Chavard	08a5dd6a27	User should not be deleted if they have hidden dossiers with state_instruction_commencee ... fix #4933	2020-03-25 18:15:14 +01:00
Paul Chavard	51224fad49	Refactor scopes with intervals and use Time.zone.now	2020-03-25 17:42:03 +01:00
Paul Chavard	c086f6d580	Add a job to remove discarded dossiers	2020-03-25 17:28:25 +01:00
Paul Chavard	5b5ae5a7a5	Do not send notifications or create operation logs on brouillon demarches	2020-03-25 15:04:52 +01:00
Pierre de La Morinerie	f895570b00	dossier: make the upload label a real label	2020-03-25 14:43:09 +01:00
maatinito	1af32b29fd	#4807 Use now() instead of Date.time.today (better code homogeneity)	2020-03-24 17:09:14 -10:00
maatinito	f5c2dc03c5	#4807 better method/variable naming	2020-03-24 16:46:23 -10:00
Christian Lautier	e61c53f267	Fix #4807 48h before closing a procedure, notify users their draft is not submitted	2020-03-24 16:46:23 -10:00
clemkeirua	5896aedeeb	added extension bouton to en_construction dossiers bound to expire	2020-03-24 18:10:51 +01:00
clemkeirua	6d02e6e9e8	replaced helper has_html_label? with inheritance	2020-03-24 16:54:36 +00:00
simon lehericey	378443eb5b	Fix admin/new manager page	2020-03-24 15:52:37 +01:00
Pierre de La Morinerie	a716713ed6	locales: fix translation of champ value ... Due to the extra 's', the names of Champs attributes were never translated.	2020-03-24 15:42:02 +01:00
Paul Chavard	5c2eba1dd1	Always add a reason to dossier deletion	2020-03-24 09:30:11 +01:00
Paul Chavard	9243ae69df	Add reason to DeletedDossier ... # Conflicts: # db/schema.rb	2020-03-24 09:30:11 +01:00
Paul Chavard	903cf0cef5	Keep operation logs after dossier removal	2020-03-24 09:18:45 +01:00
kara Diaby	1f27652cd3	add files validations to models	2020-03-23 11:28:13 +01:00
kara Diaby	eb8df80c18	fix the email notifications data bug	2020-03-20 16:38:57 +01:00
Paul Chavard	77018b9e2b	Add expiration scopes to dossier	2020-03-18 15:25:02 +01:00
Paul Chavard	f35ccc9d92	Move process_expired_dossiers_brouillon to a service	2020-03-18 15:25:02 +01:00
kara Diaby	395af2fbb0	instructors : receive daily emails for declarative folders	2020-03-17 15:54:50 +01:00
clemkeirua	ca7f81b6ed	add a feature-flip for procedure PDF export	2020-03-17 15:00:03 +01:00
Paul Chavard	3cd4597006	Update rubocop roules	2020-03-17 11:25:21 +01:00
Christophe Robillard	d8d9b0922d	remove orphan services when destroying admin	2020-03-16 21:40:05 +01:00
Christophe Robillard	b5030b8972	highlight demandes when groupe instructeur updated on procedure list	2020-03-04 14:56:59 +01:00
Christophe Robillard	50007b2aac	highlight demande tab when groupe instructeur updated	2020-03-04 14:56:59 +01:00
Christophe Robillard	924702699f	highlight routing criteria label when updated	2020-03-04 14:56:59 +01:00
kara Diaby	b32ed88f9b	add attachment when instructor asking for a review	2020-03-04 13:35:29 +00:00
Paul Chavard	c46e012c10	Use dossier.assign_to_groupe_instructeur	2020-03-03 10:30:49 +01:00
kara Diaby	4a70a7fcc8	remove email_notifications_enabled column because of the new daily_email_notifications_enabled	2020-02-27 11:09:19 +01:00
clemkeirua	cfc584f496	suppression des preconditions sur sorted_ids et filtered_ids ... Ces preconditions induisent un probleme de n+1. On peut résoudre le problème en supprimant la précondition, ou en incluant les procedures dans les dossiers J'ai opté pour la suppression de la précondition, qui avait fait débat lors de son introduction: 667deae5cc (diff-b6be6196cd739f8b31e0b195677e46d6R176)	2020-02-26 15:21:42 +01:00
Christophe Robillard	2bd6f01009	log changer_groupe_instructeur	2020-02-26 11:25:07 +01:00
Christophe Robillard	e0f4957dfd	notify instructeur after groupe_instructeur changed	2020-02-26 11:25:07 +01:00
Christophe Robillard	fb3d7e45ba	unfollow stale instructeurs ... when the group instructeur of a dossier is changed, unfollow the instructeurs who don't belong to the new groupe instructeur	2020-02-26 11:25:07 +01:00
kara Diaby	6102ba6039	Do not permit to upload a GIF file via javascript	2020-02-25 23:33:15 +01:00
Paul Chavard	24d237de9e	A cloned procedure should not have canonical relationship	2020-02-25 15:26:43 +01:00
Pierre de La Morinerie	8eb6dd78a1	mailers: fix procedure_after_confirmation in the confirmation email ... As mailers are run asynchronously, they don't have access to the CurrentConfirmation defined in an earlier request. For the procedure_after_confirmation to be serialized to the Mailer, we need to pass it at creation time.	2020-02-25 15:17:09 +01:00
Pierre de La Morinerie	6664965961	mailers: add procedure context to the confirmation link ... This allows to redirect the user to the procedure they signed up for even when the browser session is not available (like if they changed of browser). Fix #4738	2020-02-25 11:45:36 +00:00
Paul Chavard	be66a8986c	Activate champ integer number on all the new procedures	2020-02-25 11:26:37 +01:00
clemkeirua	ae14599245	#4700: export files are antivirus-safe	2020-02-24 16:14:58 +00:00
kara Diaby	5dc5230791	Step1 : add new column to Assign_tos and make sure that the data is saved on form submit	2020-02-20 16:14:56 +01:00
clemkeirua	48d2093577	tag 'groupe instructeur' uniquement si la procedure est routee	2020-02-20 14:48:14 +00:00
clemkeirua	059d80ea34	#4785 ajout d'une balise 'groupe instructeur'	2020-02-20 14:48:14 +00:00
Paul Chavard	b7051da278	Remove old export code	2020-02-19 18:19:17 +01:00
Christophe Robillard	9f7b78ff8b	supprime les colonnes ignorées	2020-02-17 19:03:43 +01:00
Pierre de La Morinerie	d6a9318d05	champ: fix siblings for repetition champs ... Fix a crash when requesting the `section_index` of a section header in a repetition champ.	2020-02-17 17:11:17 +01:00
Christophe Robillard	6e0d1eaee3	remove email ignored column for admin and instructeur	2020-02-17 15:01:40 +01:00
Paul Chavard	1ce1c1e6d0	use discard	2020-02-13 12:31:59 +01:00
Pierre de La Morinerie	f8ed7ec051	form: display index of section in header	2020-02-13 11:18:46 +01:00
kara Diaby	0b8a59d5e9	Add the possibility to disable weekly email notifications (instructeur) && rename the column email_notifications_enabled to daily_email_notification_enabled	2020-02-12 13:02:31 +00:00
Pierre de La Morinerie	e3ba2ed96c	Revert "form: add number to section headers" ... This reverts commit f42977e40a.	2020-02-12 13:54:44 +01:00
Paul Chavard	7afeae1408	remove dossier.linked_dossiers	2020-02-11 17:49:22 +01:00
Paul Chavard	0d55743d9f	linked_dossiers_for should include dossiers_from_avis	2020-02-11 17:38:58 +01:00
Paul Chavard	f0ea96772d	Only invite experts to dossiers instructeur have access to	2020-02-11 17:38:57 +01:00
Pierre de La Morinerie	f42977e40a	form: add number to section headers	2020-02-11 17:36:50 +01:00
Christophe Robillard	91f1722088	admin: always eager load the user relationship ... Now that `Administrateur.email` is merely an alias to `administrateur.user.email`, and we changed every occurence of `administrateurs.pluck(:email)` to `administrateurs.map(&:email)`, the new version using `map` may cause N+1 queries if the users have not been preloaded. It makes sense to always preload the user when fetching an Administrateur: - Administrateur and User have a strongly coupled relationship - It avoids N+1 queries everywhere in the app Of course fetching an administrateur without needing its user will now do an unecessary fetch of the associated user. But it seems better than leaving a risk of N+1 queries in many places.	2020-02-04 16:21:42 +01:00
Christophe Robillard	4a1980e95a	admin: disable the email column	2020-02-04 16:21:42 +01:00
Christophe Robillard	ed970d3f3c	admin: create without providing email	2020-02-04 16:21:42 +01:00
Christophe Robillard	2bb161c3cb	admin: alias Administrateur.email	2020-02-04 16:21:42 +01:00
Christophe Robillard	055918aabc	admin: replace calls to Administrateur.find_by(email: ...)	2020-02-04 16:21:42 +01:00
Christophe Robillard	c137917396	fix typo	2020-02-04 16:07:01 +01:00
Christophe Robillard	deb11f281f	remove useless relation between administrateur and dossiers	2020-02-04 16:07:01 +01:00
Christophe Robillard	5a46effcbc	remove useless condition to admin that can be deleted ... administrateur can be deleted only if he/she has a procedure where he/she is the only admin	2020-02-04 16:07:01 +01:00
Christophe Robillard	6fc8a27bd7	destroys not all dossiers ... but only dossiers for a specific user	2020-02-04 16:07:01 +01:00
Christophe Robillard	cee4c5b8fb	Revert "Revert "4127 fix superadmin supprime compte usager"" ... This reverts commit 751f24f7bb.	2020-02-04 16:07:01 +01:00
clemkeirua	fcea7c4f85	remove invalid excel worksheet characters	2020-01-29 11:45:56 +01:00
Pierre de La Morinerie	96932faa3f	models: add a Dossier#with_hidden scope, and remove unscoped usages	2020-01-28 17:32:38 +01:00
Pierre de La Morinerie	1448d5b098	models: add a Procedure#with_hidden scope, and remove unscoped usages ... This avoids the broad use of `unscoped` to remove the `hidden_at` clause.	2020-01-28 17:32:38 +01:00
Paul Chavard	eec38bad73	Ajouter les informations de l’instructeur et de l’expert dans l’export des avis ... fix #4667	2020-01-28 15:09:41 +01:00
Pierre de La Morinerie	9da4fa9f4d	dossier: ensure the dossier groupe_instructeur is always present ... Otherwise we loose the link to the dossier's procedure, which is definitely a bad thing.	2020-01-28 14:58:34 +01:00
clemkeirua	696e39761f	deal with secondary_options that can be nil	2020-01-28 14:30:26 +01:00
clemkeirua	65b4bcf3a1	Permet de déposer un dossier lorsqu'un menu déroulant lié obligatoire n'a pas de valeur (car la liste est légitimement vide) dans le second champ.	2020-01-28 14:30:26 +01:00
Paul Chavard	517ab25783	Register canonical procedure when demarche republished under existing path	2020-01-28 12:49:53 +01:00
Pierre de La Morinerie	751f24f7bb	Revert "4127 fix superadmin supprime compte usager"	2020-01-21 18:57:54 +01:00
Christophe Robillard	88e73d4039	raise exception if problem with destroy	2020-01-21 15:05:33 +01:00
Christophe Robillard	675bbdad15	transfere les services lors de suppression admin ... Lorsqu'un administrateur est supprimé, ses services sont transférés à un autre administrateur pour chacune de ses procédures	2020-01-21 15:05:33 +01:00
Christophe Robillard	d9570eedc6	empêche suppression d'un user qui est instructeur	2020-01-21 15:05:33 +01:00
Christophe Robillard	a6d007dbd3	supprime un instructeur	2020-01-21 15:05:33 +01:00
Christophe Robillard	d4de5769ee	empêche la suppression d'un user qui est admin	2020-01-21 15:05:33 +01:00
Christophe Robillard	d8a51f986f	supprime un utilisateur qui a des dossiers cachés	2020-01-21 15:05:33 +01:00
clemkeirua	12430a8068	ajout d'un écran intermediaire pour gérer la reaffectation des dossiers	2020-01-20 16:15:02 +01:00
clemkeirua	d6e7799370	removed routing condition in weekly summary	2020-01-20 14:23:19 +01:00
clemkeirua	7e15c6a4a4	add filtering by group in procedure_overview ... The weekly overview do not work for instructeurs in procedures with multiples groups ; they see dossiers that they do not have access to. Now the correct filter is added	2020-01-20 14:23:19 +01:00
Paul Chavard	4edc7b00cf	Use geocoder	2020-01-15 15:04:04 +01:00
Paul Chavard	14295db9ad	Revert "Revert "Merge pull request #4552 from tchak/champ-communes"" ... This reverts commit 4373cb22cb.	2020-01-14 18:46:07 +01:00
clemkeirua	4373cb22cb	Revert "Merge pull request #4552 from tchak/champ-communes" ... This reverts commit 4cec26f73a, reversing changes made to 0ef25ef36c.	2020-01-13 16:26:27 +01:00
Christophe Robillard	0f881f942b	raise if trying to del a user who can't be deleted	2020-01-13 10:06:43 +01:00
Christophe Robillard	696a058280	delete adminis with procs managed by other admins	2020-01-13 10:06:43 +01:00
Christophe Robillard	9a62d3fe0c	delete a user	2020-01-13 10:06:43 +01:00
Christophe Robillard	58ef36ff57	tells if a user can be deleted	2020-01-13 10:06:43 +01:00
Paul Chavard	785a09b326	Use service_url instead of blob_url on secure attachments	2020-01-08 14:43:05 +01:00
Paul Chavard	cccb04d725	ActiveStorage url should expire after an hour	2020-01-08 14:43:05 +01:00
Pierre de La Morinerie	b3558c497d	dossiers: make build_default_individual explicit ... It avoid the use of callbacks, and may avoid situations where an empty individual is implicitely created.	2020-01-08 10:48:22 +01:00
Pierre de La Morinerie	5e05556ee8	dossiers: add a validation on dossier individual ... Validate that a dossier on a `for_individual?` procedure always has an `individual` associated record. For this, the individual needs to be built before the record is validated (i.e. even before the `before_create` callback is run). This should help with #4596: now if a dossier is created without an `individual`, or if the `invividual` record is later removed, the validation will fail.	2020-01-08 10:48:22 +01:00
Paul Chavard	4bbd16576b	Add champ communes	2020-01-07 11:52:51 +01:00
Paul Chavard	22aa2d4ee0	Make all location champs autocomplete	2020-01-07 11:52:51 +01:00
Paul Chavard	fa2eea81aa	Cleanup demarche archivee state	2020-01-07 11:13:42 +01:00
simon lehericey	d0939ae1a4	Add Export Model	2019-12-18 13:13:15 +01:00
Paul Chavard	2f060fc30a	Add depubliee state to procedures	2019-12-04 16:52:41 +01:00
Paul Chavard	e429c79eb1	Allow administrators to set themselves démarches as déclaratives	2019-12-04 12:30:26 +01:00
Christophe Robillard	4e7c779116	refuse les numéros de tel invalides ... rend facultatif les numéros de téléphone	2019-12-04 05:34:43 +01:00
simon lehericey	006e426a11	Work on deletion mail	2019-12-03 17:18:53 +01:00
simon lehericey	79bfb8b143	Delete expired dossiers	2019-12-03 17:18:53 +01:00
simon lehericey	03b7e81ca4	Send deletion notice for near expired brouillon	2019-12-03 17:18:53 +01:00
Paul Chavard	7b947feae4	Rename demarche archivée to demarche close	2019-11-28 15:07:16 +01:00
Paul Chavard	c1c8ab7ac6	Disable transition from publiée to brouillon	2019-11-28 14:17:47 +01:00
Paul Chavard	3e334a3306	Drop test_started_at ... # Conflicts: # spec/models/procedure_spec.rb	2019-11-28 14:17:47 +01:00
maatinito	9de9a1fd71	Use time.zone functions instead of server time functions ... (Time.zone.today vs Date.today)	2019-11-26 14:26:36 +01:00
simon lehericey	f45ede7f44	href should not contain space	2019-11-21 15:34:59 +01:00
Paul Chavard	0c6705f7fd	Drop old export service	2019-11-21 10:25:40 +01:00
Paul Chavard	ba03dbf8dd	[GraphQL] Add dossierEnvoyerMessage mutation	2019-11-13 19:54:27 +01:00
Pierre de La Morinerie	88373ddf20	individual: raise when the individual object cannot be created ... Currently, a number of dossiers in production are for procedures for individuals, but don't have a `individual` object. This is probably because creating the Individual from France Connect infos fails – but fails quietly, and nullify the relationship. As a first step, we now raise an exception when the creation from FC infos fails. We will then identify the issue, and see if we can fix it – or if we should be resilient to this kind of issues.	2019-11-12 18:29:37 +01:00
Paul Chavard	990c867c2e	[GraphQL] Add more filters to dossiers	2019-11-07 22:07:42 +01:00
Paul Chavard	f22b39b7c5	Handle non unique champ repetable labels ... fix #4466	2019-11-07 14:27:52 +01:00
Paul Chavard	2a61ed5b1c	Export etablissement information in csv ... fix #4440	2019-11-07 14:27:52 +01:00
clemkeirua	04c13190c3	introduce smtp_key in order to use 2 different sendinblue keys ... client_key is exposed to the client via gon, so if we use it for sending email too we are exposing a key so anybody could send an email. The current client_key has a different level of right and can't send emails so it's ok to expose it.	2019-11-06 13:34:36 +01:00
clemkeirua	959aacdea5	Sendinblue email balancing using proper credentials ... This reverts commit c61981e795.	2019-11-06 13:34:36 +01:00
Paul Chavard	0562e2728f	Fix type_de_champ validation error	2019-11-06 12:54:07 +01:00
Paul Chavard	ee62d6fca4	Fix move type de champs	2019-11-06 12:54:07 +01:00
simon lehericey	9f5169eb7d	Remove unused Administrateur.reset_password method	2019-11-05 14:10:39 +01:00
simon lehericey	395aba8bbc	Remove administrateur active notion	2019-11-05 14:10:39 +01:00
simon lehericey	5643e671a0	Code use user.active?	2019-11-05 14:10:39 +01:00
simon lehericey	b193dd1465	User get the active notion	2019-11-05 14:10:39 +01:00
simon lehericey	e3d7688e66	[fix #4473] Invite_administrateur!: do not reset password if the user is active	2019-11-05 10:29:39 +01:00
simon lehericey	243bc2887f	Invite_administrateur!: remove unused return	2019-11-05 10:29:39 +01:00
clemkeirua	c61981e795	Revert "Sendinblue email balancing using interceptor" ... This reverts commit b2135b6576.	2019-11-04 15:55:08 +01:00
Chaïb Martinez	b2135b6576	Sendinblue email balancing using interceptor ... Signed-off-by: Chaïb Martinez <chaibax@gmail.com>	2019-11-04 15:30:44 +01:00
Pierre de La Morinerie	2e8d365b93	instructeurs: disable the email column	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	f8358b3ae9	instructeurs: create without providing the email	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	8e6930d257	instructeurs: fix ProcedurePresentation to use instructeur.user.email ... The `joins` are declared explicitely in order to associate a predictable name to the joined table. Otherwise, when the query is joined with `:users`, ActiveRecord will alias the join automatically to solve the conflict. Unfortunately, the automatic resolution means that the table name becomes unpredictable, and thus unsuitable to perform queries on.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	8b8213c301	instructeurs: always eager load the user relationship ... Now that `Instructeur.email` is merely an alias to `instructeur.user.email`, and we changed every occurence of `instructeurs.pluck(:email)` to `instructeurs.map(&:email)`, the new version using `map` may cause N+1 queries if the users have not been preloaded. It makes sense to always preload the user when fetching an Instructeur: - Instructeur and User have a strongly coupled relationship - It avoids N+1 queries everywhere in the app Of course fetching an instructeur without needing its user will now do an unecessary fetch of the associated user. But it seems better than leaving a risk of N+1 queries in many places.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	a462edb9bc	instructeurs: alias instructeur.email ... This also means we need to replace instances of `pluck` on the email column.	2019-11-04 10:44:24 +01:00
Pierre de La Morinerie	cd478b489e	instructeurs: replace calls to Instructeur.find_by(email: …)	2019-11-04 10:44:23 +01:00
Paul Chavard	839b0d7e6d	Add Entreprise raison sociale to dossier export ... fix #4422	2019-10-31 17:11:46 +01:00
simon lehericey	4febf1851f	notifications_for_procedure is now based on instructeur.groupe_instructeurs	2019-10-25 09:42:17 +02:00
simon lehericey	e290fc3674	No need to update column as the sign_up process activates the user	2019-10-24 18:32:48 +02:00
simon lehericey	8ae592fe25	[fix #4361] administrateur active	2019-10-24 18:32:48 +02:00
clemkeirua	d9e993571c	add a warning during export generation	2019-10-24 16:27:10 +02:00
clemkeirua	da590cc73a	sequence async file generation so that the queue flag is cleared	2019-10-24 16:27:10 +02:00
simon lehericey	1fa149575c	Add constraints to GroupeInstructeur	2019-10-23 21:47:20 +02:00
Paul Chavard	86b271997b	Invite experts to linked dossiers ... closes #3669	2019-10-23 13:10:09 +02:00
clemkeirua	87741f4b49	introduce constant for exports	2019-10-22 09:51:14 +02:00
clemkeirua	cdab08b198	UI work	2019-10-22 09:51:14 +02:00
clemkeirua	43424e4f4e	merge with the work of paul, using 3 links	2019-10-22 09:51:14 +02:00
clemkeirua	70ea5e167e	procedure download is performed through a controller in order not to leak the URL	2019-10-22 09:50:58 +02:00
simon lehericey	6b8cefa551	Procedure: defaut_groupe_instructeur is the first group ... Especially useful when the defaut groupe is renamed ...	2019-10-17 15:48:14 +02:00
simon lehericey	5897464224	Build Dossier champ only once	2019-10-17 15:48:14 +02:00
simon lehericey	0c15326df6	User: inactive user have never signed_in	2019-10-08 10:09:16 +02:00
simon lehericey	3e0f1b9c66	User: eager load instructeur and administrateur to remove 2 db requests per http request	2019-10-08 09:53:40 +02:00
simon lehericey	451387d32d	Dossier: add conditions on joins for with_notifications scope	2019-09-26 15:46:20 +02:00
Nicolas Bouilleaud	03c950ea97	Move followed_dossiers_with_notifications to a Dossier scope ... Instead of instructeur.followed_dossiers_with_notifications, we can now write instructeur.followed_dossiers.with_notifications. Yay composition!	2019-09-25 14:10:00 +02:00
Nicolas Bouilleaud	a4166d3c57	Refactor Instructeur.notifications_* methods ... - rename `dossiers_id_with_notifications` to `followed_dossiers_with_notifications`, - rename `notifications_per_procedure` to `procedures_with_notifications`, - return an ActiveRecord::Relation instead of the result of the query, so that the call place can compose it, - `merge` with the wanted Dossier scope in the call places, don’t bother passing it as a parameter, - use the “state” (now “scope”) parameter as a scope method that can be just applied on `Dossier`.	2019-09-25 14:10:00 +02:00
Paul Chavard	eb7aba18e6	Add dossier champs and annotations types	2019-09-24 10:47:21 +02:00
Paul Chavard	8928eaba11	Add demarche champs and annotations types	2019-09-24 10:47:21 +02:00
Paul Chavard	a7fc4df09b	Resolve models and types	2019-09-24 10:47:21 +02:00
Paul Chavard	2e854f2ac3	Add graph loading scopes to Dossier and Procedure	2019-09-24 10:47:21 +02:00
Nicolas Bouilleaud	f74fde3f80	Avoid sending notification emails about archived dossiers	2019-09-20 11:06:33 +02:00
Nicolas Bouilleaud	769621de46	Explicitly pass the “state” param in notifications_*_procedure methods	2019-09-20 11:06:33 +02:00
Nicolas Bouilleaud	8a06c01f13	Reorder methods in instructeur.rb ... Move token stuff together, out of notification-related stuff.	2019-09-20 10:48:08 +02:00
Nicolas Bouilleaud	4f0871dab0	Use a single query in dossiers_id_with_notifications (instead of four) ... This is used in /procedures#show and /procedures#index, to display badges on the “suivis” and “traités” tabs of each procedure. Rails cache helps when it’s the exact same query, but it’s not the case for different tabs. I’m not certain it’ll be a visible performance improvement but it shouldn’t hurt.	2019-09-20 09:45:59 +02:00
simon lehericey	faddbc23ef	Eager load procedure: :groupe_instructeurs for export	2019-09-19 12:30:12 +02:00
simon lehericey	a2f82ab8be	Add groupe_instructeur_label to export v2	2019-09-19 12:30:12 +02:00
simon lehericey	3bc20bdb06	Procedure.routee?	2019-09-19 12:30:12 +02:00
simon lehericey	8660d4af30	Instructeur: only export its dossiers	2019-09-19 12:24:40 +02:00
simon lehericey	e2acb0a946	ProcedurePresentation: can use groupe instructeur	2019-09-18 15:51:02 +02:00
simon lehericey	9b16bd2037	Dossier: retrieve all dossiers for a procedure	2019-09-18 15:51:02 +02:00
simon lehericey	21577a0f0b	Instructeur: dedup procedures with multiple gi	2019-09-18 15:51:02 +02:00
Paul Chavard	8fcf1353f3	Remove duplicated attachments	2019-09-17 18:12:53 +02:00
Nicolas Bouilleaud	0c98f29d59	Move the cached procedure stats queries to a ProcedureStatsConcern	2019-09-17 16:43:48 +02:00
Nicolas Bouilleaud	c26a701a17	Refactor and redesign publish modal ... * remove the autocomplete menu * use ujs to pre-validate the procedure * tweak the UI	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	bd1e0aba38	Add Procedure path suggestion	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	8806eab8d6	Properly validate Procedure.lien_site_web is set when publishing	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	00c37eccb3	Simplify procedure.path and publish event ... * Get rid of the “reopen” event, merge it with “publish” (it’s the same code) * Remove the “availability” states; “available with brouillon” makes no sense since the brouillons path are always uuids * Instead of checking if publish can happen, just try it and handle the errors	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	b9968b76b0	Remove “avec_lien” helpers now that Procedure.path cannot be nil	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	8fa630d2bb	Remove Gestionnaire.visible_procedures ... It is actually the same thing as Gestionnaire.procedures. It already included the procedures with paths as well as the archived procedures, and in production, there were no Gestionnaire for who procedures was returning a different result than visible_procedures (expect for two baddata brouillon procedures with a nil path). In addition, Procedure.path is now nonnull, which means the Procedure.avec_lien scope is pointless. Finally, the current spec showed that the only procedure not visible to the gestion was the one he was not assigned to.	2019-09-17 16:30:48 +02:00
Nicolas Bouilleaud	e9c6ed80e4	Migration: Index and make Procedure.path nonnull	2019-09-17 16:30:48 +02:00
Paul Chavard	88842918f9	Prepare to drop columns	2019-09-17 12:37:37 +02:00
simon lehericey	acb99609ba	Move defaut_groupe_instructeur as has_one and eager_load	2019-09-16 15:57:07 +02:00
Paul Chavard	b97cbd3402	Serialize champ repetition for tags ... closes #4272	2019-09-12 17:23:18 +02:00
Paul Chavard	3b8d3b7967	Add Style/CollectionMethods to rubocop	2019-09-12 14:48:18 +02:00
Paul Chavard	c370c2f475	Cleanup FlipFlop	2019-09-10 23:52:44 +02:00
Paul Chavard	65e227c44b	Migrate to flipper	2019-09-10 16:10:14 +02:00
Paul Chavard	3eb3ae001e	Rename “Passé en construction le” to 'Déposé le' for clarity	2019-09-10 14:59:10 +02:00
Paul Chavard	434210de2e	Ignore to be removed columns	2019-09-10 10:49:12 +02:00
Paul Chavard	7ffb98e616	Remove carrierwave uploaders	2019-09-10 10:49:12 +02:00
Pierre de La Morinerie	2724f4667b	groupe_instructeur: unsassign instructeurs on group destroy ... Fix #4282	2019-09-09 17:29:29 +02:00
simon lehericey	ad7ef6c739	Link assign_to and procedure by groupe_instructeur	2019-09-03 06:47:02 +02:00
simon lehericey	d0bfb62fec	Procedure Factory: use procedure.new_dossier	2019-09-03 06:47:02 +02:00
simon lehericey	3cc8f0c792	Link Dossier and GroupeInstructeur	2019-09-03 06:47:02 +02:00
simon lehericey	a82d49aa60	Procedure: save procedure while cloning ... This is required to be able to assign the administrateur.instructeur to the defaut_groupe_instructeur of the new procedure	2019-09-02 11:41:12 +02:00
simon lehericey	31cb056351	Procedure: remove direct instructeurs access ... Add shortcut for the spec to assign instructeurs directly to the defaut groupe	2019-09-02 11:41:12 +02:00
simon lehericey	ba24958035	Procedure add missing_instructeurs?	2019-09-02 11:41:12 +02:00
simon lehericey	85499365a0	Instructeur has_many procedures through groupe_instructeur	2019-09-02 11:41:12 +02:00
simon lehericey	25991c2892	Assign a procedure assign a group as well	2019-09-02 11:41:12 +02:00
simon lehericey	97884c4349	Link AssignTo et GroupeInstructeur	2019-09-02 11:41:12 +02:00
simon lehericey	115d91387c	A procedure has a default groupe instructeur	2019-09-02 11:41:12 +02:00
simon lehericey	f296318072	Create GroupeInstructeur	2019-09-02 11:41:12 +02:00
Paul Chavard	3c6b35d720	Fix attestation preview	2019-08-28 16:33:51 +02:00
Paul Chavard	a19b10b118	Migrate attestation files to active_storage	2019-08-27 17:42:52 +02:00
clemkeirua	188e0fd6b2	removed ask_birthday for new procedures & dossiers	2019-08-27 15:32:17 +02:00
Paul Chavard	d02e0fc556	Fix and test migrate_procedure_logo task	2019-08-22 11:28:03 +02:00
Paul Chavard	cc35a04e26	Migrate procedure logo to active_storage	2019-08-21 11:15:00 +02:00
Paul Chavard	b7b46e9a82	Improve clone of procedure attachements	2019-08-20 17:30:44 +02:00
simon lehericey	c1a622efa1	Add User.create_or_promote_to_administrateur	2019-08-20 12:20:12 +02:00
simon lehericey	97d0855d47	add User.create_or_promote_to_instructeur	2019-08-20 12:20:12 +02:00
simon lehericey	e913b01c52	fix_manager_reset_password	2019-08-20 12:12:20 +02:00
simon lehericey	ebe871819d	Fix admin deletion by an administration	2019-08-20 12:01:36 +02:00
Paul Chavard	e9ba7700d4	Remove commentaire file uploader	2019-08-20 10:24:13 +02:00
simon lehericey	dab1519b8c	Remove credenticals synchronisation logic	2019-08-16 11:35:19 +02:00
simon lehericey	e3e6bc7689	! NEED JOB REBOOT Move remind activation logic to user	2019-08-14 16:34:50 +02:00
simon lehericey	d0ac1c3301	Fix manager invite administrateur	2019-08-14 16:34:50 +02:00
simon lehericey	1b38d4071d	temporary remove password complexity check	2019-08-14 15:06:16 +02:00
simon lehericey	840be2408e	Remove administrateur devise methods	2019-08-14 15:06:15 +02:00
simon lehericey	81f44fa76b	Link user and administrateur	2019-08-14 15:06:15 +02:00
simon lehericey	5fdac38cb2	Fix instructeur invitation	2019-08-13 15:15:16 +02:00
simon lehericey	47b7dc368b	Remove or fix now nonsense code	2019-08-13 15:15:16 +02:00
simon lehericey	a84e07a376	Remove instructeur devise methods	2019-08-13 15:15:16 +02:00
simon lehericey	dd4ffb926c	Link user and instructeur	2019-08-13 15:15:16 +02:00
simon lehericey	3fde2a6f70	Rename gestionnaire in code to instructeur	2019-08-12 13:47:01 +02:00
simon lehericey	6902f84b85	Brutally rename gestionnaire filename to instructeur	2019-08-12 13:47:01 +02:00
clemkeirua	1e6847bc6f	introduce constants for M./Mme	2019-08-01 17:42:32 +02:00
clemkeirua	d7105cb6f8	added spec for dossier#update_with_france_connect	2019-08-01 17:42:32 +02:00
clemkeirua	707e8a0004	dossier_controller#new uses info from FC if any	2019-08-01 17:42:32 +02:00
maatinito	0b0ef8a318	#3928 Zxcvbn service to compute password complexity	2019-08-01 17:12:14 +02:00
Paul Chavard	02904f55b1	Fix champ policy	2019-08-01 16:41:53 +02:00
Paul Chavard	c75e39884e	Save selection utilisateur as geo area	2019-08-01 11:38:09 +02:00
clemkeirua	f5d3818e3c	remove unnecessary retransition methods	2019-08-01 10:40:08 +02:00
clemkeirua	38b48f4217	transition from accepte to instruction as superadmin	2019-08-01 10:29:51 +02:00
Paul Chavard	b266915892	Add repetitions to api	2019-08-01 10:04:35 +02:00
Paul Chavard	fba195c0b5	Add attestation url to dossier on api	2019-07-31 18:30:40 +02:00
Paul Chavard	25db21467d	Stop using Flipflop as switch for Fog	2019-07-31 15:15:09 +02:00
Paul Chavard	fc75580a3c	Start using pundit	2019-07-30 18:09:28 +02:00
Paul Chavard	8c72470a6c	Add default etablissement champ name	2019-07-30 17:17:36 +02:00
Paul Chavard	ab1170bcfc	Fix export dossier n+1 query	2019-07-30 17:17:36 +02:00
Pierre de La Morinerie	95e24392f9	models: remove old pieces justificatives	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	ea1c8ea7e3	models: remove associations to old pieces justificatives	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	0da0a2b446	model: remove support for cloning procedures with old pj	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	f69f325236	api: remove export of old pieces justificatives	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	e975fe4ade	tasks: remove task to migrate old pieces justificatives	2019-07-30 16:11:17 +02:00
Pierre de La Morinerie	0018f36b44	gestionnaire: remove UI for filtering pieces justificatives	2019-07-30 16:11:16 +02:00
Pierre de La Morinerie	0c4cb3b498	admin: remove UI for managing old pj	2019-07-30 16:11:16 +02:00
pedong	8d03a6747c	add lockable to User, Gestionnaire, administration, Administrateur	2019-07-29 17:48:44 +02:00
Nicolas Bouilleaud	b066ccbc89	Make sure Procedure.path is not null in our data	2019-07-29 13:53:33 +02:00
clemkeirua	6f47655301	rendu lien_site_web obligatoire au moment de la publication	2019-07-25 15:46:04 +02:00
Pierre de La Morinerie	1c837eb901	mailers: improve wording of transactional emails and default templates	2019-07-25 12:25:50 +02:00
Pierre de La Morinerie	8313752663	mailers: add CTA to templated emails	2019-07-25 12:25:50 +02:00
clemkeirua	f166077f5e	ajout d'un bouton de suppression des admin dans le manager	2019-07-23 16:11:15 +02:00
Pierre de La Morinerie	45abb6ebc2	mailers: move default templates to a specific subdirectory ... It makes more understandable that they are templates (and not views rendered directly by Rails).	2019-07-22 16:22:20 +02:00
clemkeirua	d62740c198	extraction de la taille max des fichiers dans une constante	2019-07-18 17:19:39 +02:00
clemkeirua	ee8a1092e4	extracted MonAvisEmbedValidator	2019-07-17 18:04:32 +02:00
clemkeirua	6d43465ee5	renammed into monavis_embed	2019-07-17 18:04:32 +02:00
clemkeirua	8d2c5cfa14	validation par regex	2019-07-17 18:04:32 +02:00
Pierre de La Morinerie	727702ad4b	emails: mention the procedure name in the email title	2019-07-17 15:01:19 +02:00
clemkeirua	7eeddc0b79	using a shared example + scoped to state TERMINE	2019-07-17 11:53:16 +02:00
clemkeirua	b8fa567c81	ajout du tag 'lien document justificatif'	2019-07-17 11:53:16 +02:00
Pierre de La Morinerie	a8354bd103	dossiers: unify deletion of dossiers between manager and user ... The code paths for deleting a dossier were different, depending on whether the dossier was deleted by the user, or from the Manager. This commit unifies the two code paths into one. This has the effect of: - An operation log is now recorded when an user deletes its own dossier; - Gestionnaires are now notified even when the dossier is deleted from the Manager; - The `support:delete_user_account` task now requires the email address of the author.	2019-07-16 16:22:20 +02:00
clemkeirua	25f81f1d3c	download a dossier as zip with all attachments	2019-07-16 09:11:25 +02:00
Pierre de La Morinerie	d5f360c85f	manager: fix the deletion email not being sent ... When deleting a dossier from the manager, the deletion notification email was not being sent. This is because the returned object from `Dossier#hide!` was invalid.	2019-07-15 10:01:16 +02:00
Pierre de La Morinerie	619f663e1a	procedure: remove individual_with_siret column	2019-07-11 15:57:46 +02:00
Pierre de La Morinerie	a047ee356b	procedure: remove expects_multiple_submissions column	2019-07-11 15:57:46 +02:00
Pierre de La Morinerie	35c3795f56	dossier: make messagerie available on archived procedures ... An Admin may archive a procedure to make it unavailable to the general public, but before all dossiers are handled. In this case, the messagerie needs to be available. Fix #4089	2019-07-11 15:37:04 +02:00
Pierre de La Morinerie	10065df8ce	champs: put champ label in numeric fields validation messages ... Replaces > La valeur du champ doit être un nombre entier (sans chiffres après > la virgule) by > La valeur du champ « Nombre de parents » doit être un nombre entier > (sans chiffres après la virgule)	2019-07-11 15:12:48 +02:00
Pierre de La Morinerie	fdca7c025a	procedure: ignore :expects_multiple_submissions on the correct model	2019-07-11 12:14:25 +02:00
Pierre de La Morinerie	c2c9b19b3b	procedure: remove individual_with_siret ... It isn't used anymore (see #3077)	2019-07-11 11:58:21 +02:00
Paul Chavard	3cb39c2840	Refactor message attachements to use active_storage	2019-07-10 15:35:29 +02:00
Pierre de La Morinerie	ecfccae6f0	dossiers: remove support for Dossier#expects_multiple_submissions	2019-07-09 14:50:11 +02:00
Paul Chavard	ad0a74ea7c	Fix dates in dossiers export	2019-07-09 10:02:08 +02:00
Nicolas Bouilleaud	930fd345de	Validate messagerie_available? when creating a new Commentaire ... Commentaires bu Users and Gestionnaire need the messagerie to be available; Automatic system Commentaires can be created anytime. This reintroduces Commentaire validation that was introduced in #3979 and disabled in #4018	2019-07-08 16:13:43 +02:00
Nicolas Bouilleaud	3f439ac07a	Add Commentaire.is_sent_by_system? and .is_sent_by(someone) ... And use it in CommentaireHelper and in the _message_icon and _message_issuer partials	2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud	2abd93d360	Display the full User email in Commentaires ... * Only redact gestionnaires’ emails * Also, rename Commentaire.sender to Commentaire.redacted_email	2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud	3bf19de124	Remove Commentaire::columns override ... It was used for a cleanup migration a long time ago (see #233, #3033, #3043)	2019-07-08 16:06:44 +02:00
Nicolas Bouilleaud	4d73275bab	Drop Procedure.administrateur_id	2019-07-04 17:01:12 +02:00
Paul Chavard	e582ff729c	Add aasm to dossiers state	2019-07-03 13:37:27 +02:00
Mathieu Magnin	10d3ba10f2	Before save copy body in rich_body	2019-07-03 13:15:49 +02:00
Mathieu Magnin	d13b7f953f	Migrate mail body to ActionText	2019-07-03 13:15:49 +02:00
simon lehericey	b2c987ff0d	[fix #3683] Dossier: add repasser_en_instruction!	2019-07-02 18:40:20 +02:00
Paul Chavard	fb0ef15e3c	Export dossiers v2	2019-07-02 14:20:29 +02:00
Paul Chavard	46c1bbbc6f	Official support for declarative demarches	2019-07-02 14:12:26 +02:00
Nicolas Bouilleaud	bd47bf2691	Disable Messagerie in archived Dossiers and procedures ... * Use the existing Dossier#messagerie_available? method * Raise when attempting to build a Commentaire if not messagerie_available? * Disable the Messagerie form if not messagerie_available? * Add tests :) * Tweak the Horaires formatting while we’re here.	2019-07-01 09:39:39 +02:00
Paul Chavard	0d80c48b7e	Add avis to api	2019-06-27 14:40:17 +02:00
Paul Chavard	c5704fa22f	Remove unused code from Commentaire	2019-06-25 17:04:29 +02:00
Nicolas Bouilleaud	f355f849a6	Add BillSignature Model	2019-06-17 16:16:28 +02:00
Nicolas Bouilleaud	7e80b8a4dc	Enable the Rails/InverseOf cop and add missing inverse_of	2019-06-17 13:44:07 +02:00
Pierre de La Morinerie	51aacabf13	models: fix touch not propagating when using nested attributes ... Sometimes, when using nested attributes, touch doesn’t propagate to parent relationships. (see https://github.com/rails/rails/issues/26726) Specifically, this happens in our app when updating a dossier with only new attachements (but without changing the value of any fields). To work around this, we need to define the parent relationship explicitely. This is good practice anyway. Fix #3906	2019-06-17 13:44:07 +02:00
simon lehericey	ee296f2b44	Use default format for date and datetime champ	2019-06-12 17:48:12 +02:00
Nicolas Bouilleaud	5acb7a3f1b	Make rubocop happy ... I did make some changes some lines above this 🤷.	2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud	6b90bc1ea1	Add “previously followed” dossiers and gestionnaires ... Using an “inactive” Follow scope, similar to the “active” scope. (I was tempted to use a default_scope, but this breaks when trying to `unscope` it in associations.)	2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud	be4c575622	Add Follow.unfollowed_at ... The active scopes is used indirectly in the dossier<->gestionnaire associations: the existing tests in dossier and gestionnaire just work™.	2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud	d417907f36	Just rely on the constraints to avoid duplicate Follows ... Don’t check manually in advance: just try to create the new Follow and silently fail. Since we have both Rails validation and DB constraints in place, we have two types of errors to check. I’m not actually sure this change improves the legibility of the code.	2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud	ba48a1da6e	Ensure Follow dates can not be not null ... * Add Follow.unfollowed_at * Change the unicity constraint to gestionnaire/dossier AND unfollowed_at	2019-06-12 17:33:53 +02:00
Paul Chavard	d5911071f8	Return dossiers on api with stable order	2019-06-04 15:34:49 +02:00
Pierre de La Morinerie	d410e31344	active_storage: document the virus scan hooks	2019-05-28 11:39:22 +02:00
Paul Chavard	4a9ef5d12e	Always use purge_later	2019-05-21 14:05:33 +02:00
Paul Chavard	42235e81b1	Use active storage load hook to extend blob	2019-05-16 20:43:01 +02:00
Paul Chavard	9ce1f0d0a6	Set keep_until on operation_log if available on procedure	2019-05-14 14:31:03 +02:00
Paul Chavard	b8bf662c6d	Track dossier demander un avis	2019-05-14 14:31:03 +02:00
Paul Chavard	9c472e6524	Track dossier private annotations modifications	2019-05-14 14:31:03 +02:00
Paul Chavard	dba8d65137	Track dossier operations with author and subject	2019-05-14 14:31:03 +02:00
clemkeirua	afa6711564	refacto suite à simplification virusscan	2019-05-07 08:54:29 +02:00
clemkeirua	d0794f42d1	fix tag_substitution_concern links for lien attestation	2019-05-07 08:54:29 +02:00
clemkeirua	0e26bda186	cleanup the tag substitution concern & uniformization	2019-05-07 08:54:29 +02:00
clemkeirua	e4259466b4	nettoyage du tag_substitution_concern	2019-05-07 08:54:29 +02:00
clemkeirua	b3956bc072	introduce virus scans	2019-05-07 08:54:29 +02:00
clemkeirua	f8a2598647	ajout du lien vers le justificatif dans la balise --lien attestation--	2019-05-07 08:54:29 +02:00
clemkeirua	4aab72be68	implementation du systeme de PJ de motivation	2019-05-07 08:54:29 +02:00
Nicolas Bouilleaud	0590cc1e28	Ignore the Procedure.administrateur_id column again ... following #3822	2019-05-06 16:19:08 +02:00
Nicolas Bouilleaud	df865e71dc	Make sure that there always is at least one administrator per Procedure	2019-05-06 16:19:08 +02:00
maatinito	2308b3bc5c	[Fix 3827] Champ Pays: la ligne de tirets ne devrait pas être selectionnable	2019-05-06 14:55:29 +02:00
Paul Chavard	91f2d7d706	Remove deprecated virus_scan model	2019-05-03 11:07:19 +02:00
Paul Chavard	f113d108c9	Save virus scan status to blob metadata	2019-05-02 15:58:09 +02:00
Pierre de La Morinerie	d855468cb6	dossiers: display the estimate of the entire processing time ... Displaying separate estimations for en_construction and en_instruction doesn't really make sense for the users: they want to know how long it is going to take overall, not the petty details of our workflow.	2019-04-30 15:56:27 +02:00
Pierre de La Morinerie	8bd1064532	tasks: populate Procedure.administrateurs even for hidden procedures ... The previous procedure migration (created in f7af01e0dc) worked fine, but didn't run on hidden procedures (due to the default scope).	2019-04-29 16:35:34 +02:00
Paul Chavard	8d093bd9ba	Fix missing dossier_id on champs inside repetition	2019-04-18 16:55:35 +02:00
simon lehericey	e65e21a72f	Email notification: use the right method for procedures	2019-04-18 15:07:01 +02:00
Pierre de La Morinerie	1f955db2c7	gestionnaire: ignore when the gestionnaire already follows the dossier ... Fix #3720	2019-04-18 11:41:24 +02:00
Paul Chavard	9beff5ee9a	Always create menu deroulant champs with a value	2019-04-11 14:38:21 +02:00
Nicolas Bouilleaud	c5122ee7f5	Allow filtering ProcedurePresentation by followers_gestionnaires ... fixes #3464	2019-04-10 14:32:51 +02:00
Nicolas Bouilleaud	988df15c6b	Refactor ProcedurePresentation::sanitize_columns to use model reflection ... The passed “table” is actually an association, and may not match the table name. Use model reflection instead of manually pluralizing.	2019-04-10 14:32:51 +02:00
Paul Chavard	639facaf2a	Add new types_de_champ#move api	2019-04-03 14:38:07 +02:00
Mathieu Magnin	71e0969bc0	[Fix #3692] Ensure SIRET is correct on server	2019-03-28 18:03:53 +01:00
Mathieu Magnin	27c8e9dcb8	Use the same clone_attachment method for all attributes on procedure.clone	2019-03-28 17:17:29 +01:00
clemkeirua	0d71120f98	[fix #306] Possibilité de joindre un document à un avis	2019-03-28 15:45:14 +01:00
Pierre de La Morinerie	abeb58caa5	dossiers: displays an "Start an other dossier" item in action dropdown	2019-03-28 15:26:15 +01:00
pedong	c0a928ac7a	[fix #3440] use attachment.download for get attachment file	2019-03-26 17:11:59 +01:00
Mathieu Magnin	4e27872a25	[Fix #3650] when cloning a procedure, do not forget pj_templates	2019-03-26 15:31:09 +01:00
Pierre de La Morinerie	b1a7018d30	procedure: ignore bad data when computing usual_instruction_time ... Fix #3655	2019-03-20 17:48:54 +01:00
Mathieu Magnin	6570bed09c	[Fix #3641] Do not change PJ value in API if PJ is safe	2019-03-20 11:37:31 +01:00
Pierre de La Morinerie	ce9c5da6e1	dossier: add a messagerie_available? method	2019-03-20 10:42:57 +01:00
Paul Chavard	69a51e3296	Save SIRET data on search	2019-03-19 16:22:42 +01:00
Pierre de La Morinerie	ed1f6ec38d	procedure: fix verification delay ... The verification delay was ignoring all dossiers not closed yet.	2019-03-19 15:51:51 +01:00
simon lehericey	6607de4827	Notification: add service to send notifications	2019-03-18 16:37:51 +01:00
simon lehericey	1644fd9059	Notification: add gestionnaire.procedures_with_email_notifications scope	2019-03-18 16:19:36 +01:00
Paul Chavard	4a9ff29391	Fix administration page	2019-03-12 15:34:30 +01:00
Paul Chavard	48701e80bd	Enable flipflop for instructeurs	2019-03-12 12:14:34 +01:00
Paul Chavard	bb8ba75d22	Explicitly pass current_administrateur on publish	2019-03-12 11:59:01 +01:00
Paul Chavard	01b966ff66	Check demarche ownership on multiple administrateurs	2019-03-12 11:59:01 +01:00
Mathieu Magnin	44f28ec565	Remove feature flag for publish draft	2019-03-12 11:26:07 +01:00
Frederic Merizen	d08b478cfd	Now that we don't have the type column anymore, we don't need to neuter it	2019-03-11 19:00:47 +01:00
Frederic Merizen	02f35e655d	[#3477] Minor simplification	2019-03-11 17:14:17 +01:00
Frederic Merizen	b4790e5009	[#3477] Slightly more compact	2019-03-11 17:14:17 +01:00
Frederic Merizen	e8747f7c38	[#3477] Extract helper method	2019-03-11 17:14:17 +01:00
Frederic Merizen	656f0df377	[#3477] Remove clunky extra method	2019-03-11 17:14:17 +01:00
Frederic Merizen	f64ade355f	[#3477] Fix a copy-paste mistake	2019-03-11 17:14:17 +01:00
Frederic Merizen	7d09624bbe	[#3477] We only use the table anyway	2019-03-11 17:14:17 +01:00
Frederic Merizen	c9ad2995f1	[#3477] Remove extraneous variable	2019-03-11 17:14:17 +01:00
Frederic Merizen	4646e10864	[#3477] The where clause doesn't do what it's supposed to do	2019-03-11 17:14:17 +01:00
Frederic Merizen	cf3f2409dd	[#3477] Clarify what the previous code of eager_load_displayed_fields does	2019-03-11 17:14:17 +01:00
Frederic Merizen	f0d83b1de8	[#3477] ignore invalid dates for now	2019-03-11 17:14:17 +01:00
Frederic Merizen	0ba3515d41	[#3477] Filter by 'column ilike values' as a scope	2019-03-11 17:14:17 +01:00
Frederic Merizen	a87e3ac697	[#3477] Make filtering by datetimes a proper scope	2019-03-11 17:14:17 +01:00
Frederic Merizen	9096f923b1	[#3477] Cleaner way to return no dossiers	2019-03-11 17:14:17 +01:00
Frederic Merizen	d24fb5d186	[#3477] Let where_ilike take care of necessary sanitizing	2019-03-11 17:14:17 +01:00
Frederic Merizen	e098779c5e	[#3477] Accept symbol arguments to sanitized_column	2019-03-11 17:14:17 +01:00
Frederic Merizen	f34e65c207	[#3477] Make sanitized_column a class method	2019-03-11 17:14:17 +01:00
Frederic Merizen	7241e43a7c	[#3477] Allow calling sanitized_column with individual fields ... rather than a hash	2019-03-11 17:14:17 +01:00
Frederic Merizen	00ca2e0cbb	[#3477] Make sanitized_column dryer	2019-03-11 17:14:17 +01:00
Frederic Merizen	1f34d971d1	[#3477] where_equals is trivial, inline it	2019-03-11 17:14:17 +01:00
Frederic Merizen	91e6671cfb	[#3477] Do not use string interpolation for where_equals	2019-03-11 17:14:17 +01:00
Frederic Merizen	3c96c2e83d	[#3477] Do not use string interpolation for where_datetime_matches	2019-03-11 17:14:17 +01:00
Frederic Merizen	664956d8c6	[#3477] Move compact nearer to the nil-generating place	2019-03-11 17:14:17 +01:00
Frederic Merizen	55d4dcc174	[#3477] Introduce column variable	2019-03-11 17:14:17 +01:00
Frederic Merizen	35d5322a9b	[#3477] Clarify variable name	2019-03-11 17:14:17 +01:00
Frederic Merizen	cf2b40f6a0	[#3477] Extract all variables from sort hash	2019-03-11 17:14:17 +01:00
Frederic Merizen	21128d94b6	[#3477] Inline only use of variable	2019-03-11 17:14:17 +01:00
Frederic Merizen	43243e73d4	[#3477] Merge two ordering cases	2019-03-11 17:14:17 +01:00
Frederic Merizen	71f766c434	[#3477] Prefer pluck over map	2019-03-11 17:14:17 +01:00
Frederic Merizen	c53370e14c	[#3477] Reuse existing filtering facility	2019-03-11 17:14:17 +01:00
Frederic Merizen	393f1b1971	[#3477] Move eager_load_displayed_fields to model	2019-03-11 17:14:17 +01:00
Frederic Merizen	70bf6aecf6	[#3477] Filter by mutliple values	2019-03-11 17:14:17 +01:00
Frederic Merizen	1431de5cc2	[#3477] Handle multiply-valued filters	2019-03-11 17:14:17 +01:00
Frederic Merizen	54cb65b8a7	[#3477] Extract helper	2019-03-11 17:14:17 +01:00
Frederic Merizen	02a72507b9	Remove compatibility code for legacy values in database column ... They were fixed by a data migration long ago	2019-03-11 11:41:28 +01:00
Frederic Merizen	c75983710c	Force stable order on champ fields	2019-03-11 11:32:17 +01:00
Frederic Merizen	b428406fc7	[Fix #3578] No tags for champs that cannot have user input anyway	2019-03-11 10:26:27 +01:00
Frederic Merizen	610d2e7e2b	[Fix #3572] Use champ with correct type for balise	2019-03-08 18:32:35 +01:00
Mathieu Magnin	fed1f3e921	Use query filter instead of array.reject	2019-02-26 12:05:49 +01:00
clemkeirua	236f73f838	ajout d'une balise pour le nom du service	2019-02-21 12:18:44 +01:00
Paul Chavard	84383fc3c1	Assigne admins to procedure.administrateurs	2019-02-20 17:10:57 +01:00
Mathieu Magnin	f7650135f4	[Fix #3375] on the API display safe files only	2019-02-19 18:10:35 +01:00
simon lehericey	2f66625f18	Manager: improve dossier view	2019-02-19 14:30:14 +01:00
Mathieu Magnin	cf610bbd91	Merge branch 'dev' into enforce-rubocop-timezone	2019-02-18 17:41:41 +01:00
simon lehericey	0b8619be77	Gestionnaire: login_token! -> create_trusted_device_token	2019-02-18 17:21:46 +01:00
simon lehericey	47e3b57e81	TrustedDeviceToken: valid for one week	2019-02-18 17:20:49 +01:00
simon lehericey	7de3a18fd1	valid period depend on trusted_device_token.created_at	2019-02-18 17:20:49 +01:00
simon lehericey	d664f130fd	trustedDeviceToken: move token youth	2019-02-18 17:20:49 +01:00
simon lehericey	23db8a160c	move token validity to trusted_device_token	2019-02-18 17:20:49 +01:00
simon lehericey	b9b83cca3a	use multiple trusted_device_token	2019-02-18 17:20:42 +01:00
simon lehericey	bee9a108c5	split login and trusted_device logic	2019-02-18 17:20:00 +01:00
simon lehericey	9d92e43d8d	[fix #3315] Migrate service organisme	2019-02-18 16:50:44 +01:00
Mathieu Magnin	dd27167c5d	Enforce Timezone rule in Rubocop	2019-02-18 16:19:42 +01:00
simon lehericey	a7e068003a	[fix #3427] Administration can soft delete a dossier	2019-02-14 18:09:08 +01:00
Frederic Merizen	eb7cd28504	Fix undefined method for nil:NilClass	2019-02-13 19:22:38 +01:00
Frederic Merizen	41ab7246cf	[#3424] Improve formatting of addresses with missing components	2019-02-13 09:57:33 +01:00
Paul Chavard	5da5f75c5f	[Types de Champ Editeur] Save on change and only edited model	2019-02-07 17:05:55 +01:00
Paul Chavard	a0a1ce11c8	Add repetition to apercu	2019-02-07 12:29:27 +01:00
Pierre de La Morinerie	a6704c4cd6	dossiers: allow users to delete "en construction" dossiers	2019-02-07 11:07:07 +01:00
Pierre de La Morinerie	d251ebc2f4	dossiers: shorten method name	2019-02-06 18:20:35 +01:00
Paul Chavard	6b39128be3	Clone nested types_de_champ	2019-02-06 10:05:27 +01:00
simon lehericey	5715cdaa4c	[fix #3363] use organisation_name in dossier summary	2019-02-05 17:41:51 +01:00
Frederic Merizen	a255e61556	[#3356] Improve formatting for menus that only have a primary value	2019-02-05 17:35:30 +01:00
Frederic Merizen	a3d7c8de55	[Fix #3356] Add tags for primary menu only / secondary menu only	2019-02-05 17:35:30 +01:00
Frederic Merizen	d3498e10bd	[#3356] Let dynamic type handle tag generation	2019-02-05 17:35:30 +01:00
Frederic Merizen	4a3d402a32	[#3356] No need for special treatment	2019-02-05 17:35:30 +01:00
Frederic Merizen	a8b9da9d3b	[#3356] Remove redundant method	2019-02-05 17:35:30 +01:00
Frederic Merizen	5bc8bbbaa2	[#3356] Let tags handle their own substitution	2019-02-05 17:35:30 +01:00
Frederic Merizen	656061b21a	[#3356] Clarify naming	2019-02-05 17:35:30 +01:00
Frederic Merizen	140a65cb36	[#3356] Simplify detection of handling champ	2019-02-05 17:35:30 +01:00
Frederic Merizen	bcfc0f2535	[#3356] Let types de champ decide their tags	2019-02-05 17:35:30 +01:00
Frederic Merizen	d67af741d5	[#3356] Prepare for multiples tags per type de champ	2019-02-05 17:35:30 +01:00
Paul Chavard	071448e1d9	Champ Repetition dossier editor	2019-02-04 16:19:07 +01:00
Paul Chavard	a4a421a91a	Champ Repetition dossier display	2019-02-04 15:46:39 +01:00
Paul Chavard	9b7b59f67e	Champs editor should handle repetition type	2019-02-04 11:58:26 +01:00
simon lehericey	41ae1f46f4	Trusted_device: cleaner time comparison	2019-02-01 10:54:20 +01:00
Paul Chavard	7678d8eb0b	Revert for_api value on yes_no champs	2019-01-29 15:23:09 +01:00
Pierre de La Morinerie	db8289a19d	procedure: ensure a procedure can't be deleted while it has dossiers	2019-01-23 17:19:36 +01:00
Frederic Merizen	5e37400834	[#2180] Only retain old PJ API when cloning for same admin	2019-01-17 17:40:40 +01:00
Frederic Merizen	d1c0418c89	[#2180] Refactor - extract local variable	2019-01-17 17:40:40 +01:00
Frederic Merizen	8cb509d192	[#2180] Keep information that this type de champ was cloned from a PJ	2019-01-17 17:40:40 +01:00
Frederic Merizen	651fd6149b	[#2180] When cloning a procedure, convert types de PJ to types de champ PJ	2019-01-17 17:40:40 +01:00
Mathieu Magnin	2ce6d01aec	Procedure has a default generated path when created	2019-01-17 14:04:58 +01:00
Paul Chavard	41c9b21509	Use new editor	2019-01-17 11:20:31 +01:00
Paul Chavard	e1a1a2b2ad	Add new admin procedure update action	2019-01-17 11:20:31 +01:00
simon lehericey	99bfd19b41	[fix #3268] Jobs: use automatic_operation	2019-01-16 17:20:12 +01:00
simon lehericey	6ab2d124f9	Dossier: #accepter_automatiquement!	2019-01-16 17:20:12 +01:00
simon lehericey	0f3dedb0b6	Dossier: #passer_automatiquement_en_instruction!	2019-01-16 17:12:32 +01:00
Mathieu Magnin	31c45fe2e5	Fix Sentry 161	2019-01-10 15:21:40 +01:00
simon lehericey	eb6ef1eb46	Gestionnaire: increase validity token to 45 minutes	2019-01-10 12:06:35 +01:00
simon lehericey	29fff9ee68	[fix #3269] bufferize login token email	2019-01-10 12:06:35 +01:00
simon lehericey	a197285742	[fix #2612] Admin: add missing steps to admin UI	2019-01-09 16:25:00 +01:00
simon lehericey	8ca7eb1c54	Procedure: cloning set the current admin gestionnaire of the procedure	2019-01-09 16:25:00 +01:00
simon lehericey	f0139c5962	Spec Factory: an administrateur always has a gestionnaire	2019-01-09 13:49:47 +01:00
Paul Chavard	1beefe4469	Fix champ repetition belongs_to associations	2019-01-08 11:56:33 +00:00
gregoirenovel	55419b92a8	Simplify code	2019-01-08 12:32:27 +01:00
gregoirenovel	864bb38d8a	Add #for_api methods to CheckboxChamp and YesNoChamp ... Otherwise, we return nil instead of “off” / “non”, so we don’t expose the data properly	2019-01-08 12:32:27 +01:00
gregoirenovel	0846bad1c8	Mutualize code in methods ... As done in YesNoChamp	2019-01-08 12:32:27 +01:00
gregoirenovel	866c74ce63	Add Champ#for_api	2019-01-08 12:32:27 +01:00
gregoirenovel	c00aac2f80	We can now replace processing in #formatted_value by #to_s calls	2019-01-08 12:32:26 +01:00
gregoirenovel	f27717ab23	Make the CheckboxChamp export similar to YesNoChamp ... Previously, nil values would be returned as nil and not as off	2019-01-08 12:32:26 +01:00
gregoirenovel	4a6930b60a	Remove from EngagementChamp a method it’s inheriting	2019-01-08 12:32:26 +01:00
gregoirenovel	66d1b7ba10	Use ternary conditions	2019-01-08 12:32:26 +01:00
gregoirenovel	9e42190148	Remove the proxy value_for_export method ... Overload for_export instead	2019-01-08 12:32:26 +01:00
gregoirenovel	7cd50531cf	Remove the proxy string_value method ... Overload to_s instead	2019-01-08 12:32:26 +01:00
gregoirenovel	9a2341c56c	Remove the useless #for_display proxy method	2019-01-08 12:32:26 +01:00
gregoirenovel	2e6c91e9b0	Move #selected_options to the only relevant model	2019-01-08 12:32:26 +01:00
gregoirenovel	c4b9a0b79e	Rename DropDownList#selected_options_without_decorator	2019-01-08 12:32:26 +01:00
simon lehericey	7b935a6486	login_token: lets constantize	2019-01-07 08:18:29 +01:00
gregoirenovel	5fa5f2aa37	Bump development gems ... - rubocop (0.61.1 → 0.62.0)	2019-01-05 11:47:55 +01:00
Pierre de La Morinerie	d77530c461	Make Procedure state consistent after switching types de champ order ... Fixes an issue where, after clicking the "move champ up" button, the new form is rendered with an incoherent order.	2019-01-03 15:13:14 +01:00
gregoirenovel	b41764ec03	Remove ChampDecorator	2019-01-03 12:08:25 +01:00
gregoirenovel	0596d53ac2	Enable the Lint/UnusedBlockArgument cop	2019-01-03 10:53:50 +01:00
gregoirenovel	baf7977786	Enable the Lint/StringConversionInInterpolation cop	2019-01-03 10:53:50 +01:00
gregoirenovel	186e362701	Enable the Layout/SpaceInsideArrayLiteralBrackets	2019-01-03 10:53:50 +01:00
gregoirenovel	386fbce776	Enable the Layout/SpaceBeforeBlockBraces cop	2019-01-03 10:53:50 +01:00
gregoirenovel	8b0b8162f0	Enable the Layout/SpaceAfterComma cop	2019-01-03 10:53:50 +01:00
gregoirenovel	03eb47016c	Fix a gestionnaire sign in bug	2018-12-26 18:14:04 +01:00
Mathieu Magnin	b40c706d98	[Fix #3192] Clone service if procedure is transferred	2018-12-20 15:45:48 +01:00
Paul Chavard	eb9edc1cee	Order types de champ in scope	2018-12-20 14:14:15 +01:00
Frederic Merizen	2a758d0759	[Fix #3196] Convert YAML to JSON	2018-12-19 23:17:55 +01:00
Frederic Merizen	36d6a43084	[#3196] Make TypeDeChamp#options compatible with raw JSON ... instead of YAML inside a JSON string. We still need to support the YAML form until the data has been migrated	2018-12-19 18:43:56 +01:00
Paul Chavard	5d1c24f3d8	Add type de champ repetition models (with row)	2018-12-19 15:31:11 +01:00
gregoirenovel	df7e0a9881	Remove dead code	2018-12-19 14:59:15 +01:00
gregoirenovel	4b0e632abb	Enable the Style/ColonMethodCall cop	2018-12-19 13:56:10 +01:00
gregoirenovel	fba8d97256	Enable the Stlye/BlockDelimiters cop	2018-12-19 13:56:10 +01:00
Frederic Merizen	d1cfe4468d	Encourager la création de champs PJ plutôt que de vieilles PJS	2018-12-19 11:57:23 +01:00
gregoirenovel	129df93fb1	Add a blank line to ease readability	2018-12-18 22:49:27 +01:00
gregoirenovel	3ce3d203d4	Simplify some code	2018-12-18 22:49:27 +01:00
pedong	f70f276ae9	[fix #2813] set lien_notice nil when clone a procedure	2018-12-06 21:28:08 +01:00
Paul Chavard	35494df78e	Procedure export dossiers with champs siret	2018-12-05 17:09:39 +01:00
Pierre de La Morinerie	e206f3d4d4	gestionnaire: display draft procedures in the list ... Fix #3088	2018-12-05 15:38:20 +01:00
Paul Chavard	a08f170dbd	Assign users and gestionnaires to commentaires ... fix #2052	2018-12-05 13:40:57 +01:00
Paul Chavard	e873b6a9c4	Expose selection utilisateur size on champ carte	2018-12-03 12:49:03 +01:00
Paul Chavard	d77a5c9f15	More tests and fixes on carte champ	2018-11-30 13:28:30 +01:00
Paul Chavard	097a15d624	Test and fix all possible cases of champ carte serialization	2018-11-30 12:02:27 +01:00
Paul Chavard	35d2bc36fc	cleanup selection_utilisateur geo_json	2018-11-29 17:10:14 +01:00
Paul Chavard	ca147969ab	Fix number champs validation	2018-11-29 15:12:31 +01:00
Paul Chavard	1883c57c87	Add stable ids to types_de_champ after every update	2018-11-29 11:41:13 +01:00
Paul Chavard	c18796d02a	Fix geojson exposed on legacy carto API	2018-11-29 08:43:51 +01:00
Paul Chavard	9b39934e8b	Destroy dossier_operation_logs when dossier is destroyed	2018-11-28 17:06:54 +01:00
Mathieu Magnin	b51bf759b1	[Fix #3081] If a dossier is destroyed, then destroy the attestation	2018-11-28 16:33:12 +01:00
Paul Chavard	36f6f54337	Remove unused carto models	2018-11-27 16:11:25 +01:00
Paul Chavard	0f0ca2ec65	Lod dossier operations	2018-11-27 12:49:40 +01:00
Paul Chavard	85e3eb04f4	Add DossierOperationLog model	2018-11-27 12:49:40 +01:00
Paul Chavard	a079eaea5c	Add procedure gestionnaire_for_cron_job method	2018-11-27 12:49:40 +01:00
Paul Chavard	9843666bdc	Implement state change methods on dossier	2018-11-27 12:49:40 +01:00
gregoirenovel	251bd635c2	Prepare for champ_id deletion	2018-11-22 12:27:48 +01:00
Pierre de La Morinerie	e5303fd986	mailers: streamline the NotificationMailer ... Notifications are now only for demarche-templated emails.	2018-11-20 14:46:31 +01:00
Paul Chavard	0b017580c5	Expose migrated legacy carto champs on api	2018-11-20 10:53:14 +01:00
Paul Chavard	d92364b90b	Add user_geo_area do champ carte	2018-11-20 10:53:14 +01:00
Paul Chavard	971a08c92a	Add expose legacy carto api flag	2018-11-20 10:53:14 +01:00
Paul Chavard	18815e88a3	Rename champ.zones to champ.geo_json	2018-11-20 10:53:14 +01:00
Paul Chavard	2462e42b53	Stop using legacy api carto after migration	2018-11-20 10:53:14 +01:00
Pierre de La Morinerie	83031b5cdd	procedure: compute the usual instruction time only for the last month	2018-11-13 17:23:31 +01:00
simon lehericey	36621bffeb	FlipFlop: enable for gestionnaire	2018-11-13 10:41:45 +01:00
simon lehericey	0d8d2de5a6	Session: add trusted_device cookie	2018-11-13 10:41:45 +01:00
simon lehericey	5690599289	Session: send a mail to confirm gestionnaire login	2018-11-13 10:41:45 +01:00
simon lehericey	2613d05a4f	An admin has always a gestionnaire role	2018-11-13 10:41:45 +01:00
Pierre de La Morinerie	e59bec51ef	procedure: use 90th percentile to estimate the completion delay	2018-11-08 18:29:17 +01:00
Pierre de La Morinerie	5c921182ea	procedure: rename mean_instruction_time to usual_instruction_time ... Ref #2970	2018-11-08 17:20:06 +01:00
Paul Chavard	33c6ddc452	Remove dead code related to dossier state	2018-11-08 14:56:45 +01:00
Paul Chavard	6706b9004f	Fix includes on api queries	2018-11-08 14:45:09 +01:00
Paul Chavard	80189def98	Remove n+1 calls from API queries	2018-11-08 14:45:09 +01:00
simon lehericey	9d406770a8	[fix #2956] YesNo: fixing to_s	2018-11-06 16:59:47 +01:00
Frederic Merizen	c7358a8f53	[Fix #835] Enable asking for multiple avis at the same time	2018-11-06 15:44:43 +01:00
gregoirenovel	9833564863	[#835] Add a missing validation to avis	2018-11-06 15:44:43 +01:00
Paul Chavard	074050a91a	Add IntegerNumberChamp	2018-11-06 11:28:44 +01:00
Paul Chavard	45bfb2fd47	Add DecimalNumberChamp	2018-11-06 11:28:44 +01:00
Paul Chavard	e391fe6bec	Clarify procedure path availability code	2018-10-30 15:59:37 +01:00
Paul Chavard	b42095363e	Refactor procedure model	2018-10-30 12:01:45 +01:00
Paul Chavard	78dc582588	Remove ProcedurePath	2018-10-30 12:01:45 +01:00
Frederic Merizen	f6207bee26	Do not take time of day into account when searching dates	2018-10-26 17:53:26 +02:00
simon lehericey	a06f872a4b	ProcedurePresentation: rescue big int as a datetime value	2018-10-26 14:39:17 +02:00
simon lehericey	63db387984	ProcedurePresentation: display dossier date in d/m/Y	2018-10-26 10:10:20 +00:00
simon lehericey	3685c65fb7	[fix #2905] fix DATE_TRUNC usage ... DATE_TRUNC is played on the db where the timestamp are stored in utc. So if a user search for 12/12/2012 in Paris timezone and that we truncate it should do something similar to : SELECT DATE_TRUNC('day', foo.timezone) from (SELECT timestamp '2012-12-12 00:00:00' AT TIME ZONE 'Europe/Paris') as foo; => 2012-12-11 To avoid such pb, I suggest avoiding DATE_TRUNC when exact results are needed	2018-10-26 10:10:20 +00:00
simon lehericey	3dad743d56	remove localtime as it uses server timezone	2018-10-26 10:10:20 +00:00
simon lehericey	e684cec516	DateTime.new => Time.zone.local	2018-10-26 10:10:20 +00:00
simon lehericey	4b25d16f5a	Time.zone.parse(_, options) => Time.zone.strptime(_, options)	2018-10-26 10:10:20 +00:00
simon lehericey	f620e4aee2	DateTime.parse => Time.zone.parse	2018-10-26 10:10:20 +00:00
simon lehericey	2238e5bd9f	Time.now => Time.zone.now	2018-10-26 10:10:20 +00:00
simon lehericey	13ffa61435	DateTime.now => Time.zone.now	2018-10-26 10:10:20 +00:00
Frederic Merizen	64cb231b01	[#2675] Fix notification sort order	2018-10-24 17:10:30 +02:00
Frederic Merizen	02f4ef215a	[#2675] Make dossiers_id_with_notifications public	2018-10-24 17:10:30 +02:00
Frederic Merizen	dfdcfc62e2	[#2675] Make dossiers_id_with_notifications self-contained	2018-10-24 17:10:30 +02:00
Paul Chavard	5a8a4b393f	Add RPG carte source	2018-10-23 18:13:44 +02:00
Paul Chavard	ed46e2c3be	Use Typhoeus in ApiGeo adapter	2018-10-23 18:13:44 +02:00
Frederic Merizen	51954a6d85	[#2604] Warn that we are destroying an invalid ProcedurePresentation	2018-10-23 16:41:51 +02:00
Frederic Merizen	14fd60bee7	[Fix #2604] Handle ProcedurePresentations that have gone invalid	2018-10-23 16:41:51 +02:00
Frederic Merizen	7baa239095	[#2604] Introduce errors when retrieving ProcedurePresentation	2018-10-23 16:34:38 +02:00
Frederic Merizen	84cac7a5c2	[#2604] Remove unneeded self in AssignTo	2018-10-23 16:34:35 +02:00
Paul Chavard	c8c75fc254	Better handle empty user selection layers	2018-10-23 09:35:25 +02:00
Paul Chavard	99e1a20d98	Add champ carte endpoint	2018-10-23 09:35:25 +02:00
Paul Chavard	a541f1fcee	Add type options on carte champ	2018-10-23 09:35:25 +02:00
Paul Chavard	df73e442e9	Explicit foreign_key on CarteChamp	2018-10-22 23:28:00 +02:00
Frederic Merizen	a2bd0582b9	[Fix #2741] Filter / sort by en_construction_at	2018-10-17 12:16:51 +02:00
Paul Chavard	93ba94a9e6	Add carte champ and geo area models	2018-10-16 14:01:12 +03:00
gregoirenovel	22088b167d	Remove ApiAdresse::Geocodeur	2018-10-16 09:33:16 +02:00
gregoirenovel	76cf9ab746	ApiGeo::Driver → ApiGeo::API	2018-10-15 23:31:23 +02:00
gregoirenovel	5e9e913dce	Carto::Geocodeur → ApiAdresse::Geocodeur	2018-10-15 20:55:46 +02:00
gregoirenovel	4903a6b189	Carto::GeoAPI → ApiGeo	2018-10-15 20:55:46 +02:00
gregoirenovel	1f0af303f3	Remove the unused ModuleApiCarto#classes method	2018-10-15 16:16:16 +02:00
Paul Chavard	c63675461a	Add new carto init code	2018-10-14 12:34:43 +02:00
Frederic Merizen	3dca3c7dee	[Fix #1961] Check that sorted_ids works for individual	2018-10-11 12:13:03 +02:00
Frederic Merizen	abd066c6f4	[#1961] filtered_ids for individual	2018-10-11 12:13:03 +02:00
Frederic Merizen	34da620b0f	[#1961] get_value for individual	2018-10-11 12:13:03 +02:00
Frederic Merizen	5d862ae92b	[#1961] Add individual fields	2018-10-11 12:13:03 +02:00
Frederic Merizen	07b8838561	Remove dead code ... Should have been removed as part of #2720 but was accidentally reintroduced in #2770	2018-10-11 12:00:49 +02:00
Frederic Merizen	577475f26e	[Fix #2580] Filter by created_at / updated_at	2018-10-10 18:18:28 +02:00
gregoirenovel	c8f872c566	InviteUser → Invite	2018-10-10 12:07:10 +02:00
gregoirenovel	ed11852300	Delete the InviteGestionnaire model	2018-10-10 12:07:10 +02:00
Frederic Merizen	fac6922b98	[#2750] Set might be overkill here	2018-10-10 09:07:57 +02:00
Frederic Merizen	667deae5cc	[#2750] Sanity check procedure	2018-10-10 09:07:57 +02:00
Frederic Merizen	30ef6e6d95	[#2750] No need to validate table and column ... Because they are pre-validated by rails on the model	2018-10-10 09:07:57 +02:00
Frederic Merizen	58c0ec1bbd	[#2750] Validate order on model update rather than on usage	2018-10-10 09:07:57 +02:00
Frederic Merizen	026c322fce	[#2750] Make ProcedurePresentation checks private	2018-10-10 09:07:57 +02:00
Frederic Merizen	40a5ff0266	[#2750] do parsing of displayed_fields inside ProcedurePresentation ... rather than in the view	2018-10-10 09:07:57 +02:00
Frederic Merizen	f59984ea70	[#2750] Remove redundant references to procedure	2018-10-10 09:07:57 +02:00
Frederic Merizen	462c818025	[#2750] Move fields from DossierFieldService to ProcedurePresentation	2018-10-10 09:07:57 +02:00
Frederic Merizen	9fa7a6fd0e	[#2750] Move get_value to ProcedurePresentation	2018-10-10 09:07:57 +02:00
Frederic Merizen	fc157c3e4c	[#2750] Move sorted_ids to ProcedurePresentation	2018-10-10 09:07:57 +02:00
Frederic Merizen	2e9dafb4c3	[#2750] Move filtered_ids to ProcedurePresentation	2018-10-10 09:07:57 +02:00
Frederic Merizen	0e9b40ccf6	[#2750] Move fields from Procedure to ProcedurePresentation	2018-10-10 09:07:57 +02:00
Frederic Merizen	efcac5192a	[#2750] Move fields_for_select to ProcedurePresentation	2018-10-10 09:07:57 +02:00
Frederic Merizen	c1f18a164d	Remove dead, buggy code	2018-10-10 05:51:17 +02:00
Paul Chavard	bcbfc370b2	Add button in manager to transition démarche in brouillon state ... fix #2565	2018-10-09 16:14:18 +02:00
simon lehericey	87e731bc75	Dossier: move state translation to model dossier	2018-10-08 17:55:20 +02:00
Frederic Merizen	33f29f35ab	Avoid recreating service too often	2018-10-04 18:09:39 +02:00
Frederic Merizen	eafd0e8348	Evite de cacher la whitelist trop longtemps	2018-10-04 18:09:39 +02:00
gregoirenovel	36ce94195b	Remove france_connect delegation on User	2018-10-04 13:54:07 +02:00
gregoirenovel	14c8e02aca	[Fixes #2597] Remove given_name and family_name delegation	2018-10-04 13:54:07 +02:00
gregoirenovel	5107b33af8	Remove FC fields from search	2018-10-04 13:54:07 +02:00
Frederic Merizen	b36d153620	Fix missing sort columns	2018-10-03 17:09:49 +02:00
gregoirenovel	c91a1cf474	Enable Style/SymbolArray	2018-10-03 12:15:48 +02:00
gregoirenovel	a171186dd8	Enable Style/TrailingCommaInHashLiteral	2018-10-03 12:03:21 +02:00
Frederic Merizen	8bb08a1b8b	[#2579] Validate columns on ProcedurePresentation model	2018-10-03 10:17:46 +02:00
Frederic Merizen	3bb6fd2d47	[#2579] Remove no-op ... (sanitize_sql_for_order does not do anything when its argument is a string)	2018-10-03 10:17:46 +02:00
Paul Chavard	941c529b2c	Remove CGU checkbox ... fix #2725	2018-10-03 08:59:02 +02:00
gregoirenovel	b994fa4206	Do one thing per line	2018-10-01 16:15:46 +02:00
Pierre de La Morinerie	0526551e71	templates: update link to dossier	2018-09-27 17:22:59 +02:00
simon lehericey	4d4dba1550	Procedure: small renaming on mean_time	2018-09-27 15:02:38 +02:00
simon lehericey	88f7e888c3	Administrateur: do not save api_token in clear text anymore	2018-09-27 10:24:56 +02:00
simon lehericey	4a04f2e59f	ApiController: check token validity for a given admin	2018-09-27 10:24:56 +02:00
simon lehericey	8c4f8347ca	Api Token: store token in an encrypted form	2018-09-27 10:14:32 +02:00
simon lehericey	1997f45d7e	Api Token: do not generate one token by default	2018-09-27 10:14:32 +02:00
Paul Chavard	f94a24d7ce	Add path field to procedure information form	2018-09-26 10:53:45 +02:00
Paul Chavard	f6a6d8f457	Fix destroy dossiers on procedure reset	2018-09-26 10:53:45 +02:00
Mathieu Magnin	499021588d	[Fix #1285] Password strength is ensured when saving an administrateur	2018-09-26 09:03:03 +02:00
Frederic Merizen	998754ab73	[Fix #2258] Validate options for linked dropdown menus	2018-09-25 20:32:19 +02:00
Frederic Merizen	3fea14c07d	[#2258] Let dynamic type validate the type de champ	2018-09-25 20:31:34 +02:00
Frederic Merizen	695426316c	[#2258] Make linked menus more robust in the face of bad configuration	2018-09-25 20:31:06 +02:00
Frederic Merizen	9beaa293cd	[#1421] Use delegation rather than STI for TypeDeChamp	2018-09-25 08:26:56 +02:00
Frederic Merizen	7d382837d9	[Fix #2622] Change filters to proper JSONB	2018-09-24 19:39:01 +02:00
Frederic Merizen	1419e9b73f	[#2622] Change sort to proper JSONB	2018-09-24 19:39:01 +02:00
Frederic Merizen	68608307ad	[#2622] Change displayed_fields to proper JSONB	2018-09-24 19:39:01 +02:00
gregoirenovel	e4eb55a37f	Revert "[Fix #2623] Ensure numbers are integers" ... This reverts commit 68789ff43b.	2018-09-21 15:15:11 +02:00
gregoirenovel	68789ff43b	[Fix #2623] Ensure numbers are integers	2018-09-21 08:12:52 +02:00
Frederic Merizen	43d8db88d9	[#1946] Check if a dossier’s retention period has expired	2018-09-20 17:44:31 +02:00
Frederic Merizen	b672377f5b	[#1946] Query dossiers by remaining retention time	2018-09-20 17:44:31 +02:00
gregoirenovel	0c9628c180	Fix some files according the the .editorconfig rules	2018-09-20 16:23:09 +02:00
gregoirenovel	8ea021fb69	Factorize code in a method	2018-09-19 12:31:59 +02:00
gregoirenovel	6b98c36dad	Add Dossier#mean_traitement_time for the upcoming page de garde	2018-09-19 12:31:59 +02:00
gregoirenovel	f3a257d81d	Show the mean verification time in the Résumé tab	2018-09-19 12:31:59 +02:00
gregoirenovel	d55c9dff4d	Show the mean instruction time in the Résumé tab	2018-09-19 12:31:59 +02:00
Pierre de La Morinerie	082ef92a99	invite: move invites link to the after_confirmation callback ... Refactored from 6a69d958da The `after_confirmation_path_for` isn't really made to be a callbback. For instance, it is not executed during tests. Moving the invitations linking to a proper documented callback allows the linking to work in a testing environment, when invoking `user.confirm`.	2018-09-19 12:08:28 +02:00
Paul Chavard	36812793d4	Do not clone procedure path	2018-09-18 14:40:02 +02:00
Frederic Merizen	63fc0b3bc3	[Fix #2584] Move Field related code to a service	2018-09-18 13:49:34 +02:00
Paul Chavard	18922122b4	Fix SQL ambiguous name error	2018-09-18 13:21:29 +02:00
Paul Chavard	b042efdcba	Update procedure path attribute when procedure_path changes	2018-09-18 13:21:29 +02:00
Paul Chavard	b772256a97	Read from path attribute instead of procedure_path when possible	2018-09-18 13:21:18 +02:00
Paul Chavard	2787f040af	Add path attribute to Procedure model	2018-09-18 13:21:18 +02:00
Paul Chavard	3f6cc668a7	Implement check_availability route	2018-09-12 12:37:15 +02:00
Paul Chavard	631df3197a	Add uniqueness validation to procedure path	2018-09-11 10:38:31 +02:00
Paul Chavard	2770f1db82	Archive only when path changes owner	2018-09-11 10:38:31 +02:00
Paul Chavard	be51802983	Add reopen aasm event	2018-09-11 10:38:31 +02:00
Paul Chavard	5a794cbb08	Use Procedure#publish_or_reopen!	2018-09-11 10:38:31 +02:00
Paul Chavard	ec3a0dc4cf	Use Procedure#publish_with_path!	2018-09-11 10:38:31 +02:00
Paul Chavard	b3f8b68b99	Add Procedure#publish_with_path!	2018-09-11 10:38:31 +02:00
Paul Chavard	e6485603c4	Add ProcedurePath#valid?	2018-09-11 10:38:31 +02:00
Paul Chavard	f2f3c54147	Procedure: update -> update!	2018-09-11 10:38:31 +02:00
Paul Chavard	7a322266fa	Make aasm related methods private	2018-09-11 10:38:31 +02:00
Paul Chavard	de908ef4be	Extract ProcedurePath#find_by_path	2018-09-11 10:38:31 +02:00
Paul Chavard	b63038faca	Allow administrateur to try dossier info on aperçu page	2018-09-07 19:41:34 +01:00
Paul Chavard	23170f54c0	Instructeur should see published drafts	2018-09-07 11:20:16 +01:00
gregoirenovel	00ecae5f93	Procédure → Démarche	2018-09-05 15:46:24 +02:00
Frederic Merizen	7326065590	[fix #2486] Include all needed attributes on downloadable_sorted ... to avoid N+1 select	2018-08-30 14:13:32 +02:00
Frederic Merizen	9403d4c042	[#2486] followers_gestionnaires should not be a method ... To help activerecord caching	2018-08-30 14:13:32 +02:00
Frederic Merizen	37c45f0d29	[#2486] Always order champs ... to help activerecord cache the champs collection	2018-08-30 14:13:32 +02:00
gregoirenovel	4b071ecf06	Use enum to the fullest with Dossier.states	2018-08-29 17:31:08 +02:00
gregoirenovel	2d3b553e4d	Use enum to the fullest with TypeDeChamp.type_champs	2018-08-29 17:31:08 +02:00
gregoirenovel	606b56033a	Use enum to the fullest with VirusScan.statuses	2018-08-29 17:31:08 +02:00
gregoirenovel	66c5f080cc	Add AR validation for Feedback rating	2018-08-28 10:36:36 +02:00
gregoirenovel	4103861f90	Add the rating column to feedbacks	2018-08-27 17:03:11 +02:00
Frederic Merizen	1134877d59	[#2179] Remove newly dead code	2018-08-23 11:57:06 +02:00
Frederic Merizen	650a740642	[#2179] Remove dead code	2018-08-23 11:57:06 +02:00
Frederic Merizen	3b2919a326	[#2179] Use new updated value for search terms ... Rather than old in-database value	2018-08-23 10:34:25 +02:00
Frederic Merizen	333f4e8824	[#2179] update champ and individual association with default ... That way, they are safe to read in update_search_terms, and no reload is needed later	2018-08-23 10:34:25 +02:00
Paul Chavard	aec02a9b8a	Remove references to test_procedure	2018-08-14 16:30:43 +02:00
Paul Chavard	7237ff80cc	Drop procedure dossiers when updating brouillon	2018-08-14 11:21:05 +02:00
Paul Chavard	3be678dbe5	Add publish_draft feature flag	2018-08-13 19:27:28 +02:00
simon lehericey	b33f11115c	[fix #2358] Checkbox: serialize in attestation by oui or no	2018-08-10 16:25:34 +02:00
lucien mollard	9ecc5f7928	add a user satisfaction form'	2018-08-09 11:41:26 +02:00
Paul Chavard	46e75ac8ef	Only notify on dossier supression if dossier is en_construction	2018-08-02 17:07:24 +02:00
Paul Chavard	e358e72867	Do not display gestionnaire emails in the messaging interface ... fix #2302	2018-07-31 15:27:36 +02:00
Frederic Merizen	0e639030f9	[#2179] Generate denormalized search terms value for Dossier	2018-07-27 11:11:52 +02:00
Pierre de La Morinerie	13182ad291	dossier: send deletion email also to the following gestionnaires	2018-07-25 13:49:55 +02:00
gregoirenovel	eb95fce194	[Fix #2272] Add a SIRET field to the Service form	2018-07-19 15:43:13 +02:00
gregoirenovel	4d41381155	Move the attestation route inside the member block	2018-07-17 17:26:42 +02:00
Mathieu Magnin	e748b6883f	Fix comportement chelou in LinkedDropDownListChamp	2018-07-12 12:31:54 +02:00
Pierre de La Morinerie	b0a9e49549	procedures: group new_from_existing list by organization ... As procedures are not grouped by Service (which are unique to an administrator) but by organization, this allows procedures with the same organization name to be displayed together.	2018-07-03 23:43:42 +02:00
Mathieu Magnin	9afbd16bbf	[Fix #2145] When procedure is archived, usager should not be able to submit a dossier	2018-07-02 11:10:33 +02:00
Frederic Merizen	5192929730	[#1421] Format linked dropdown menus in attestations and mails	2018-06-28 20:06:32 +02:00
Frederic Merizen	b326cb9c3e	[#1421] Handle mandatory fields	2018-06-28 20:06:32 +02:00
Frederic Merizen	e794515c8e	[#1421] Format linked dropdown menus in spreadsheet export	2018-06-28 20:06:32 +02:00
Frederic Merizen	04892f6c55	[#1421] Format value for display	2018-06-28 20:06:32 +02:00
Paul Chavard	d0a6957862	Remove old cerfa code	2018-06-28 15:16:20 +02:00
Paul Chavard	93d6d72df5	Do not copy service info when cloning from library	2018-06-28 11:33:10 +02:00