[#2622] Change displayed_fields to proper JSONB

app/controllers/new_gestionnaire/procedures_controller.rb

@@ -102,11 +102,9 @@ module NewGestionnaire
       fields = values.map do |value|
         table, column = value.split("/")
 
-        c = procedure.fields.find do |field|
+        procedure.fields.find do |field|
           field['table'] == table && field['column'] == column
         end
-
-        c.to_json
       end
 
       procedure_presentation.update(displayed_fields: fields)

app/models/procedure_presentation.rb

@@ -1,12 +1,6 @@
 class ProcedurePresentation < ApplicationRecord
   belongs_to :assign_to
 
-  def displayed_fields
-    read_attribute(:displayed_fields).map do |field|
-      field = JSON.parse(field)
-    end
-  end
-
   def sort
     JSON.parse(read_attribute(:sort))
   end

lib/tasks/2018_09_20_procedure_presentation_jsonb.rake

@@ -0,0 +1,9 @@
+namespace :'2018_09_20_procedure_presentation_jsonb' do
+  task run: :environment do
+    ProcedurePresentation.update_all(
+      <<~SQL
+        displayed_fields = ('[' || ARRAY_TO_STRING(old_displayed_fields, ',') || ']')::JSONB
+      SQL
+    )
+  end
+end

spec/models/procedure_presentation_spec.rb

@@ -4,8 +4,8 @@ describe ProcedurePresentation do
   let (:procedure_presentation_id) {
     ProcedurePresentation.create(
       displayed_fields: [
-        { "label" => "test1", "table" => "user" }.to_json,
-        { "label" => "test2", "table" => "champs" }.to_json
+        { "label" => "test1", "table" => "user" },
+        { "label" => "test2", "table" => "champs" }
       ],
       sort: { "table" => "user","column" => "email","order" => "asc" }.to_json,
       filters: { "a-suivre" => [], "suivis" => [{ "label" => "label1", "table" => "table1", "column" => "column1" }] }.to_json