Martin
c24bc45137
clean(trads): remove unused i18n
2021-11-16 16:25:32 +01:00
Martin
f0950b592b
clean(CommentaireService): extract soft delete within controller. returning an instance with an error[:base] is not persisted with validation : avoid poluting stuff
2021-11-16 16:13:11 +01:00
Martin
8bbd77f89f
refactor(mail.delay): use simplier implementation using after_action to prevent email delivery with delay
2021-11-16 15:12:05 +01:00
Martin
e48b6e0c1f
tech(lint): rubocop
2021-11-16 14:30:06 +01:00
Martin
0aecc301c9
refactor(Commentarie.soft_delete): use discard
2021-11-16 14:28:38 +01:00
Martin
988fe34d0a
fix(spec): add missing double
2021-11-16 03:42:31 +01:00
mfo
08350f394e
feat(mails): send it on mailer queue
2021-11-15 16:19:46 +01:00
Martin
ddabed0c7e
fix(refactor): continue to revert to past implementation. now use a job instead of calling deliver_later(wait: 5.minutes) [was not a satisfying implementation]
2021-11-15 15:45:48 +01:00
Martin
5534c3fbd6
fix(refactor): forgot to cleanup former implementation
2021-11-15 15:43:51 +01:00
Martin
5b6bb5171c
tech(lint): rubocopify
2021-11-15 15:42:20 +01:00
Martin
c68fa2d7f3
feat(Commentaire.notify_user): wait 5 minutes before sending email to user when instructor write a commentaire. leaving some space for instructor to destroy his message
2021-11-15 15:38:57 +01:00
Martin
f8783c9f00
fix(spec): stop doing time comparisson, ensure it is not more nil
2021-11-15 15:23:57 +01:00
Martin
46fc956de3
fix(refactor): forgot to pass var, classy
2021-11-15 15:01:56 +01:00
Martin
a74ca8ad39
fix(spec): scope out time as reference for time comparission, hope not a matter of precision
2021-11-15 14:55:35 +01:00
Martin
f1293814a3
fix(spec): apparently we do store time with zone
2021-11-15 14:35:43 +01:00
Martin
4042d51d1a
tech(lint): rubocopify
2021-11-15 14:17:57 +01:00
Martin
d4c74b5621
feat(rc.1): refine with better translations, better design
2021-11-15 14:15:05 +01:00
Martin
3b78a9d81a
feat(rc): first stable
2021-11-15 13:53:32 +01:00
Martin
8b931a57d4
feat(CommentairesController#destroy): implement destroy endpoint using CommentaireService
2021-11-15 13:18:10 +01:00
Martin
9d666b32bc
fix(missing_file): add missing migration
2021-11-15 13:17:11 +01:00
Martin
c7bfd1af04
feat(CommentaireService.soft_delete): ensure it purge piece_jointe later
2021-11-15 12:59:38 +01:00
Martin
9a8ec1087c
feat(commentaire.soft_delete): wrap deletion behaviour in service
2021-11-15 12:43:53 +01:00
Martin
5b72bdec7e
fix(Commentaire.sent_by?): &.email compared to nil could sent by true when nil==nil, avoid this one
2021-11-15 12:01:56 +01:00
Martin
b03dc6ad5d
wip(dossiers/messages/_message): poc destroy button with expected ACL support
2021-11-15 11:30:41 +01:00
Paul Chavard
f250a750fd
Merge pull request #6619 from tchak/fix-reset-notifications-when-changing-dossier-state
...
Reset notifications when changing dossier state
2021-11-11 13:03:33 +01:00
Paul Chavard
da47f491b3
fix(dossier): nullify close to expiration notice timestamps when changing state
2021-11-11 12:52:58 +01:00
Paul Chavard
18808358f9
fix(dossiers): add processed_at to processed dossiers
2021-11-11 09:37:09 +01:00
Paul Chavard
faa235d205
fix(dossier): destroy operation logs when destroying an expired dossier
2021-11-11 09:37:09 +01:00
Pierre de La Morinerie
3f52ecbd0f
Merge pull request #6629 from tchak/fix-repetition-spreadsheets
...
Correction de colonnes non désirées dans les démarches clonées comportant des blocs répétables (#6629 )
2021-11-11 08:31:05 +01:00
Paul Chavard
71939c650b
fix(export): remove wrong columns from repetition spreadsheets
...
This fix prevent repetition children types de champ from being pulled from cloned procedures. stable_id is stable across revisions but also across cloned procedures.
2021-11-10 20:45:32 +01:00
Pierre de La Morinerie
f5fc5022a6
Merge pull request #6625 from betagouv/fix-flaky-test-for-real
2021-11-10 08:42:36 +01:00
Pierre de La Morinerie
9dd7806ae5
specs: add two missing fields to the brouillon spec
2021-11-09 15:22:20 +01:00
Pierre de La Morinerie
5dbb9f9e3c
specs: fix flaky "dossier brouillon" spec
...
The previous fix (scrolling to the viewport) didn't actually worked,
because the code tried to scroll the checkbox itself.
2021-11-09 15:21:59 +01:00
Pierre de La Morinerie
23f56577ee
Merge pull request #6623 from pengfeidong/fix_6622_clean_dossier_table_css
...
Amélioration de l'affichage du tableau des dossiers supprimés (#6623 )
2021-11-09 12:50:02 +01:00
Peng-Fei DONG
dc560479ec
clean css in page deleted_dossiers for show the dossier table
2021-11-09 12:45:41 +01:00
Pierre de La Morinerie
ad083aec70
Merge pull request #6606 from betagouv/faster-ci
...
Accélération du temps des tests sur la CI
2021-11-09 11:06:44 +01:00
Pierre de La Morinerie
75e207122b
ci: use previous test timings to split the tests
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
184bf38bb2
ci: split actions into several sub-actions
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
641f0df712
ci: avoid installing node modules again
...
By default `bin/rails assets:precompile` will run `yarn install` again.
The suggested workaround is to remove `bin/yarn` before running the
task.
See https://github.com/rails/webpacker/issues/405
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
d0a6fc4b8e
ci: precompile (and cache) assets
...
This avoids the assets to be compiled lazily during the first spec,
which confuses test metrics.
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
a01a619ec0
js: update caniuse browsers db
...
This follows a warning during tests:
> Browserslist: caniuse-lite is outdated. Please run:
> npx browserslist@latest --update-db
>
> Why you should do it regularly:
> browserslist/browserslist#browsers-data-updating
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
2c96ade1b2
ci: split tests automatically
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
ba78e2bfb2
ci: use bin/rails instead of rake
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
21efece09e
ci: use builtin cache for node modules
...
This is around 20s faster (10s when retrieved the cache and installing
node modules, and 10s when saving the cache).
2021-11-09 08:32:31 +01:00
Pierre de La Morinerie
d83c036ef1
specs: profile specs runtime
2021-11-09 08:32:31 +01:00
LeSim
6ab6031fe0
Merge pull request #6621 from betagouv/fix-typo
...
fix typo
2021-11-08 13:34:59 +01:00
krichtof
954fa12656
fix typo
...
Uniquement des corrections d'orthographe ou de grammaire
2021-11-08 11:10:55 +01:00
Kara Diaby
f29d93097b
Merge pull request #6608 from betagouv/feat/6547
...
FIX PJ - Lancer les jobs d'antivirus et analyse rails indépendamment
2021-11-05 14:09:25 +01:00
kara Diaby
1b27ab5aff
tests
2021-11-05 13:32:21 +01:00
kara Diaby
9ee9389ba1
add the good retry_on StaleObjectError
2021-11-05 13:32:21 +01:00
