Commit graph

8277 commits

Author SHA1 Message Date
simon lehericey
acb99609ba Move defaut_groupe_instructeur as has_one and eager_load 2019-09-16 15:57:07 +02:00
simon lehericey
afa0237349 remove logo n+1 2019-09-16 15:48:19 +02:00
Nicolas Bouilleaud
9770212e1d
Merge pull request #4193 from betagouv/get-rid-of-old-migrations
Replace old migrations with a single “recreate_structure”
2019-09-16 15:01:02 +02:00
Nicolas Bouilleaud
661b80777d Replace old migrations with a single “recreate_structure”
* copy-paste the description from schema.rb,
 * without the `force: :cascade` options (that drops the tables before recreating them).
* create a new migration with it
* give it the same timestamp as the last deleted migration, so that it exists in the schema_migration table and it is not run in production.
* (Also got rid of some stray changes in schema.rb for mon_avis and unconfirmed_email)
* Run rake db:migrate and make sure nothing moves
2019-09-16 14:44:37 +02:00
Paul Chavard
f2b399df72
Merge pull request #4303 from tchak/tag-champ-repetition
Serialize champ repetition for tags
2019-09-12 17:29:14 +02:00
Paul Chavard
b97cbd3402 Serialize champ repetition for tags
closes #4272
2019-09-12 17:23:18 +02:00
Paul Chavard
1eac6beb51
Merge pull request #4308 from tchak/select-filter
Add Style/CollectionMethods to rubocop
2019-09-12 15:15:06 +02:00
Paul Chavard
3b8d3b7967 Add Style/CollectionMethods to rubocop 2019-09-12 14:48:18 +02:00
Paul Chavard
3f970eee74
Merge pull request #4305 from betagouv/dependabot/bundler/devise-4.7.1
Bump devise from 4.6.1 to 4.7.1
2019-09-12 11:50:29 +02:00
dependabot[bot]
683265367d
Bump devise from 4.6.1 to 4.7.1
Bumps [devise](https://github.com/plataformatec/devise) from 4.6.1 to 4.7.1.
- [Release notes](https://github.com/plataformatec/devise/releases)
- [Changelog](https://github.com/plataformatec/devise/blob/master/CHANGELOG.md)
- [Commits](https://github.com/plataformatec/devise/compare/v4.6.1...v4.7.1)

Signed-off-by: dependabot[bot] <support@github.com>
2019-09-12 09:44:36 +00:00
Paul Chavard
8758caf7f4
Merge pull request #4299 from tchak/fix-flipper-initialize
Correctly create new flipper flags
2019-09-12 11:39:40 +02:00
Paul Chavard
d24e0e72a7 Correctly create new flipper flags 2019-09-12 10:46:13 +02:00
Pierre de La Morinerie
49a2308469
Corrige un bug de notifications dans le tableau de bord des ins… (#4304)
Instructeur : corrige des notifications manquantes dans le tableau de bord
2019-09-11 21:14:11 +02:00
simon lehericey
82bef0f651 use notifications_per_procedure properly 2019-09-11 20:49:48 +02:00
Pierre de La Morinerie
14ea10b1c7
Merge pull request #4300 from betagouv/fix-helpscout-stats
Statistiques: correction du taux de contact usager
2019-09-11 17:38:24 +02:00
Pierre de La Morinerie
503c393a87 helpscout: use replies_sent to compute contact rate
The `conversations_count` we previously used counts replies, but also
all conversations that were tagged or re-tagged during the month – with
made counting the actual work spent on user support brittle.

Counting the replies is a better estimation of what we get.

Unfortunately this also removes the filtering-by-tag feature. To
mitigate this, the reports are now scoped to a specific mailbox. This
allows to create extra mailboxes for conversations that should't be
counted in the stats.
2019-09-11 17:26:10 +02:00
Paul Chavard
52226804d0
Merge pull request #4297 from tchak/cleanup-flipflop
Cleanup FlipFlop
2019-09-11 11:48:20 +02:00
Paul Chavard
c370c2f475 Cleanup FlipFlop 2019-09-10 23:52:44 +02:00
Pierre de La Morinerie
c8eecaec42
Tentative de correction des tests qui deadlock (#4294)
Tentative de correction des tests d'acceptance qui deadlock
2019-09-10 16:57:02 +02:00
Pierre de La Morinerie
d94a5cee8e spec: during js specs, cleanup database using deletion
This attempts to solve the database deadlock on cleanup by fiddling
with the settings.

Ref #4293
2019-09-10 16:40:02 +02:00
Pierre de La Morinerie
f99a80147e
Bump mixin-deep from 1.3.1 to 1.3.2 (#4295)
Bump mixin-deep de 1.3.1 à 1.3.2
2019-09-10 16:39:29 +02:00
dependabot[bot]
675eb46e9d
Bump mixin-deep from 1.3.1 to 1.3.2
Bumps [mixin-deep](https://github.com/jonschlinkert/mixin-deep) from 1.3.1 to 1.3.2.
- [Release notes](https://github.com/jonschlinkert/mixin-deep/releases)
- [Commits](https://github.com/jonschlinkert/mixin-deep/compare/1.3.1...1.3.2)

Signed-off-by: dependabot[bot] <support@github.com>
2019-09-10 14:22:37 +00:00
Pierre de La Morinerie
e4e4c5da11
Merge pull request #4261 from tchak/flipper
Migration des feature-flags de FlipFlop à Flipper
2019-09-10 16:21:20 +02:00
Paul Chavard
65e227c44b Migrate to flipper 2019-09-10 16:10:14 +02:00
Pierre de La Morinerie
28d869e818
#4269 - Inclure les pièces jointes des blocs répétables dans le… (#4274)
Instructeur : les pièces jointes des blocs répétables sont maintenant incluses dans l'archive complète du dossier
2019-09-10 16:04:47 +02:00
clemkeirua
feb9c32537 search attachments inside bloc repetables 2019-09-10 15:30:44 +02:00
Paul Chavard
cce84a4209
Merge pull request #4289 from tchak/fix-template-render-with-empty-files
Redirect to pdf attachement old name if not attached
2019-09-10 15:13:19 +02:00
Paul Chavard
347f03d2a9 Redirect to pdf attachement old name if not attached 2019-09-10 15:06:47 +02:00
Pierre de La Morinerie
0201a501c6
Rename “Passé en construction le” to 'Déposé le' for clarity (#4248)
Instructeur : dans l'export tableur, la colonne « Passé en construction le » est renommée en « Déposé le »
2019-09-10 15:04:03 +02:00
Paul Chavard
3eb3ae001e Rename “Passé en construction le” to 'Déposé le' for clarity 2019-09-10 14:59:10 +02:00
Pierre de La Morinerie
a15bbd5b4e
Add no-reply email to transactional emails (#4265)
Emails : les emails transactionnels d'une démarche ont maintenant une adresse de réponse en NO_REPLY ; cette adresse renvoie un message d'orientation automatique en cas de réponse.
2019-09-10 13:47:30 +02:00
Chaïb Martinez
dd6c6bfe7a mailers: add a NO_REPLY address to transactional emails 2019-09-10 13:37:28 +02:00
Pierre de La Morinerie
aa1cf6788b mailers: turn revert_to_instruction into a notification email 2019-09-10 13:29:06 +02:00
Pierre de La Morinerie
19e07b0cbf
[fix #4181] add service to procedure API (#4287)
API : le service d'une démarche est maintenant exposé
2019-09-10 11:10:48 +02:00
pedong
a7d3bbb8cc Del SIRET in service for API 2019-09-10 11:06:28 +02:00
pedong
25596ca2f2 [fix #4181] add service to procedure API 2019-09-10 11:06:28 +02:00
Paul Chavard
a32ac46492
Merge pull request #4256 from tchak/rename-active-storage-files-setep-1
Remove carrierwave uploaders (Step 1)
2019-09-10 10:56:09 +02:00
Paul Chavard
d8402fbd2c Remove last reference to commentaire.file 2019-09-10 10:49:12 +02:00
Paul Chavard
434210de2e Ignore to be removed columns 2019-09-10 10:49:12 +02:00
Paul Chavard
e975e2a0aa Add an active_storage attachmens rename task 2019-09-10 10:49:12 +02:00
Paul Chavard
7ffb98e616 Remove carrierwave uploaders 2019-09-10 10:49:12 +02:00
Pierre de La Morinerie
9bfa34f985
Correction de la suppression des démarches (#4286)
Administrateur : correction de la suppression des démarches de test
2019-09-09 17:40:07 +02:00
Pierre de La Morinerie
2724f4667b groupe_instructeur: unsassign instructeurs on group destroy
Fix #4282
2019-09-09 17:29:29 +02:00
Pierre de La Morinerie
f1f0c76d13
Merge pull request #4279 from Keirua/4278-fix-texte-messagerie-instructeur
Messagerie : le texte explicatif indiquant le destinataire du message est  plus clair
2019-09-09 16:36:11 +02:00
clemkeirua
6849fd6afe change le texte de la messagerie selon le type d'utilisateur 2019-09-09 16:25:02 +02:00
Keirua
79c5df00ef
Merge pull request #4284 from betagouv/fix_routage_migrations
Fix routage migrations
2019-09-09 14:19:35 +02:00
simon lehericey
b9f35a9763 ensure that the task is idempotent 2019-09-09 14:08:09 +02:00
simon lehericey
875313e01e add defaut groupe instructeur to hidden procedure 2019-09-09 13:41:08 +02:00
Pierre de La Morinerie
add402337e
mailers: prevent the signature from being auto-linked (#4283)
Emails : la signature des messages n'est plus transformée en lien cliquable
2019-09-09 12:03:13 +02:00
Pierre de La Morinerie
c26da5ec37 mailers: prevent the signature from being auto-linked
Some emails clients (Gmail or Mail.app) may turn the signature into
a clickable link.

This can distract users, and make them think we are a good point of
contact (where they should contact their administration or use the
website directly instead).
2019-09-09 11:43:57 +02:00