Commit graph

4251 commits

Author SHA1 Message Date
Paul Chavard
f0d334ea69
Merge pull request #10916 from tchak/graphql-fix-n+1
fix(graphql): n+1 on procedure and france_connect_informations
2024-10-11 15:20:53 +00:00
Paul Chavard
a3375be7c5
fix(graphql): n+1 on procedure and france_connect_informations 2024-10-11 12:20:24 +02:00
Eric Leroy-Terquem
d9f604e8ce
feat(gallery): notify instructeur if pieces jointes updates 2024-10-11 11:20:46 +02:00
Paul Chavard
e56bc9d35b
chore(prefill): remove unused prefill support on complex champs 2024-10-09 12:11:42 +02:00
simon lehericey
34b0379203
procedure.find_column raise NotFound to fit AR interface 2024-10-09 09:23:06 +02:00
simon lehericey
14809b35af
add comments 2024-10-09 09:21:44 +02:00
simon lehericey
450420aa81
cache columns per request using Current 2024-10-08 22:51:26 +02:00
simon lehericey
249ddf291f
update_displayed_fields can use sorted_column 2024-10-08 22:51:26 +02:00
simon lehericey
4f0cac251d
use sorted_column to sort dossier 2024-10-08 22:51:26 +02:00
simon lehericey
ba91f2f66e
remove now useless validation 2024-10-08 22:51:25 +02:00
simon lehericey
da98aa556b
use update(sorted_column:) and remove obsolete update_sort(column_id:, order:) 2024-10-08 22:51:25 +02:00
simon lehericey
76fee12653
remove now unused procedure_presentation.opposite_order_for 2024-10-08 22:51:25 +02:00
simon lehericey
7349dd183a
notified_toggle_component use sorted_column 2024-10-08 22:51:24 +02:00
simon lehericey
22cbf725ec
column_table_header compute update_sort_path 2024-10-08 22:51:24 +02:00
simon lehericey
21533f91e3
add storted_column_type 2024-10-08 22:47:37 +02:00
simon lehericey
9652cf78c3
add default_sorted_column 2024-10-08 22:47:37 +02:00
simon lehericey
305b31e53b
add sorted_column 2024-10-08 22:47:37 +02:00
simon lehericey
693629afc8
add column type 2024-10-08 22:47:36 +02:00
mfo
5cba847d10
perf(Instructeurs/Dossiers#demande): remove n+1 2024-10-08 14:47:34 +02:00
simon lehericey
d5a722c143
weird frozen_string bug 2024-10-07 22:09:21 +02:00
simon lehericey
a418cf6632
remove_filter double_write 2024-10-07 22:09:21 +02:00
simon lehericey
870d67e844
add_filter double write 2024-10-07 22:09:21 +02:00
simon lehericey
5f6d8e93ca
update_display double write 2024-10-07 22:09:20 +02:00
simon lehericey
98c2b7e954
update_sort double write 2024-10-07 22:09:20 +02:00
simon lehericey
0abee08329
add filters for 2024-10-07 22:09:20 +02:00
simon lehericey
3d79c6176e
add columns_ids to procedure_presentations table 2024-10-07 22:09:20 +02:00
simon lehericey
e3697bd976
colonne.id = { procedure_id:, column_id: }.to_json
because:
- id should be a string as other id
- id need procedure_id to allow ColumnType.deserialize(id) -> Column as the columns are built by a procedure
2024-10-07 22:09:20 +02:00
simon lehericey
a8b41e90cc
remove make_id 2024-10-07 21:47:03 +02:00
simon lehericey
3740a79219
add procedure_id to column.id 2024-10-07 21:46:59 +02:00
simon lehericey
3c7521a428
extract dossier_id_column, notifications_column 2024-10-07 15:49:58 +02:00
simon lehericey
c6559577f1
remove old comment 2024-10-07 14:50:35 +02:00
Paul Chavard
274e43c5e6
fix(dossier): projected champs should have updated_at 2024-10-05 22:22:04 +02:00
Paul Chavard
70699a681d
Merge pull request #10889 from tchak/fix-dossier-follow-should-bump-updated-at
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-05 08:58:05 +00:00
Paul Chavard
ecbf985147
refactor(dossier): champs_* -> project_champs_* 2024-10-04 12:05:55 +02:00
Paul Chavard
8fdf5cbe80
refactor(dossier): explicitly build default values - less callbacks, less magic 2024-10-04 12:05:54 +02:00
Paul Chavard
25977fd97d
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent 2024-10-03 18:10:04 +02:00
mfo
5879d54145
Merge pull request #10866 from mfo/US/fix-filter-ilike
amelioration : ETQ instructeur, je souhaite pouvoir filtrer les dossiers sur mon tableau de bord fonction des choix simple/multiple/etc.. sans conflit parmis les autres valeurs de ces même choix simple/multiple/etc...
2024-10-03 13:08:49 +00:00
simon lehericey
fb66434a15
remove empty option at the start of default options 2024-09-30 15:37:02 +02:00
simon lehericey
c638ac0261
rename drop_down_list_value -> drop_down_option_from_text 2024-09-30 15:37:02 +02:00
simon lehericey
5fc0eb11f5
rename remaining drop_down_list_enabled_non_empty_options(other: true) -> drop_down_options_with_other 2024-09-30 15:37:02 +02:00
simon lehericey
532f0f48fa
replace drop_down_list_enabled_non_empty_options by drop_down_options when possible 2024-09-30 15:37:02 +02:00
simon lehericey
cfb03fc747
remove enabled_non_empty_options indirection 2024-09-30 15:37:01 +02:00
simon lehericey
77b754a08d
no more empty case 2024-09-30 15:37:01 +02:00
simon lehericey
5a19cc1a09
remove drop_down_list_value reader 2024-09-30 15:37:01 +02:00
Paul Chavard
084a68a121
refactor(repetition): consolidate repetition manipulation methods 2024-09-27 11:34:06 +02:00
mfo
75063ae31e
fix(filter): filtering types_de_champs by enum should not ilike. nows it search by exact match since enum are normalized so findable with simple where 2024-09-24 20:48:10 +02:00
mfo
b30cbf3032
tech(doc): explain which columns are ilikable for user/individual 2024-09-24 20:48:09 +02:00
mfo
51ce0cd562
clean(filter): avis column are not filterable, not needed to ilike them 2024-09-24 20:47:43 +02:00
mfo
284bdc5b2b
clean(deadcode): their is no column for avis.label. so clean this one 2024-09-24 20:47:09 +02:00
Colin Darie
99534ef834
Merge pull request #10812 from colinux/date-last-updated-at-tag
ETQ admin, créé les balises "date de mise à jour" du dossier et "date prévisionnelle SVA/SVR"
2024-09-24 12:21:07 +00:00
Colin Darie
2b07826202
fix(sva): add sva/svr decision date tag for relevant template emails
Closes #10033
2024-09-24 11:28:18 +02:00
Colin Darie
861f7359b1
feat(attestation): support last champ updated at as tag
closes #9825
2024-09-24 11:28:17 +02:00
Mathieu Magnin
af0692163b
Merge pull request #10839 from demarches-simplifiees/fix-10837
ETQ Administrateur, si j'oublie de renseigner le SIRET de mon service, je souhaite recevoir un message d'erreur explicite pour m'alerter.
2024-09-24 08:31:47 +00:00
mfo
12ef66c2b0
Merge pull request #10847 from mfo/US/clean-db
amélioration : ETQ tech je souhatie que ma base de donnée ne stock pas de donnée inutile
2024-09-24 08:12:09 +00:00
mfo
a71e83dabe
clean(db): remove ignored column 2024-09-24 10:04:04 +02:00
Paul Chavard
b5eb87de6a
fix(champ): improve row_id validation and remove it during export 2024-09-23 17:06:33 +02:00
mfo
7adbdaa4de
tech(clean): unused index and column 2024-09-23 14:53:37 +02:00
Paul Chavard
4ab9ef1f3f
Merge pull request #10842 from tchak/revert-du-revert-de-refactoring-champs
Revert "Revert "Merge pull request #10771""
2024-09-23 12:27:04 +00:00
Lisa Durand
0272f79c6a
migration to remove hidden_at from dossiers 2024-09-23 10:58:36 +02:00
Paul Chavard
3429a72f53
fix(dossier): do not show repetitions in header sections summary 2024-09-23 10:51:38 +02:00
Paul Chavard
6254b50de9
Revert "Revert "Merge pull request #10771 from tchak/refactor-champs-revert""
This reverts commit 10a1ae5534.
2024-09-23 10:21:07 +02:00
Paul Chavard
e4ac781b54
fix(rnf): remove deprecated status attribute 2024-09-20 16:58:51 +02:00
Mathieu Magnin
e9b5c4a615
[#10837] Add an explicit message when SIRET is not valid on service 2024-09-20 15:44:46 +02:00
mfo
cd8c55b161
Merge pull request #10814 from demarches-simplifiees/fix-10813
[bug] Ne pas afficher de 500 quand value_json d'un champ SIRET est nil
2024-09-19 15:22:45 +00:00
simon lehericey
10a1ae5534
Revert "Merge pull request #10771 from tchak/refactor-champs-revert"
This reverts commit c902061ebf, reversing
changes made to b4ed11c788.
2024-09-19 11:09:01 +02:00
LeSim
d32124d732
Merge pull request #10807 from demarches-simplifiees/slow_drop_down_cleaning
Tech: simplification de la logique des champs listes
2024-09-18 12:46:15 +00:00
Lisa Durand
3d50f9363f
Merge pull request #10741 from demarches-simplifiees/secu-improve-complexity-password-ldu
[sécu] Améliorer la complexité des mots de passe pour tous les users
2024-09-18 12:40:17 +00:00
LeSim
c89e60d5fa
Merge pull request #10793 from demarches-simplifiees/remove_virtual_attribute_in_code
Tech: retire la protection contre les colonnes virtuelles
2024-09-18 08:38:20 +00:00
simon lehericey
061c9cc6f3
remove default empty value in drop_down_list 2024-09-18 10:26:00 +02:00
simon lehericey
51e192939c
pack drop_down stuff together 2024-09-18 10:08:12 +02:00
simon lehericey
85684e3bea
homogenize render? if not options 2024-09-18 10:08:12 +02:00
simon lehericey
f1a606da6d
one less indirection 2024-09-18 10:08:12 +02:00
simon lehericey
b3ad237fa1
simplify drop_down_list_value 2024-09-18 10:08:12 +02:00
simon lehericey
2f64fe5e4c
one less indirection 2024-09-18 10:08:12 +02:00
simon lehericey
f046f31dcc
remove_disabled_options 2024-09-18 10:08:11 +02:00
Mathieu Magnin
bfb7b59033
[#10813] When value_json of champ SIRET is nil do not crash 2024-09-17 19:05:36 +02:00
mfo
1e0391c9dc
Merge pull request #10806 from mfo/US/fix-number-not-number-in-filters
Correctif: ETQ instructeur, la recherche par numéro de dossier ne doit accepter que des numero
2024-09-17 14:39:08 +00:00
Eric Leroy-Terquem
969706163b
Merge pull request #10641 from demarches-simplifiees/move-image-treatment-to-jobs
Technique : déplace les traitements d‘images côté jobs
2024-09-17 13:43:51 +00:00
mfo
ebb51e8128
fix(filters): filter by dossier should only accept number 2024-09-17 15:18:23 +02:00
Paul Chavard
3fef831524
move child? method for clarity 2024-09-17 10:29:34 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids 2024-09-17 10:29:34 +02:00
Paul Chavard
33e502234e
refactor(dossier loader): simplify all the things 2024-09-17 10:29:34 +02:00
Paul Chavard
2ba356bc68
cleanup(prefill): remove unused validation 2024-09-17 10:29:34 +02:00
Paul Chavard
c94d1b7eea
cleanup: more concistent methods usage 2024-09-17 10:29:34 +02:00
Paul Chavard
a474cf4590
refactor(attestation): unspecified_champs_for_dossier based on types_de_champ 2024-09-17 10:29:34 +02:00
Paul Chavard
54926db89b
refactor(champ): more concistent champ_for_update usage 2024-09-17 10:29:34 +02:00
Paul Chavard
988025ba69
refactor(champs): validate only champs in current revision 2024-09-17 10:29:34 +02:00
Paul Chavard
ed4fbc887a
refactor(dossier): remove unused scopes 2024-09-17 10:29:34 +02:00
Paul Chavard
3817f334c9
refactor(repetition): use less champs and public_id methods 2024-09-17 10:29:34 +02:00
Paul Chavard
34a05d0bf0
Merge pull request #10462 from demarches-simplifiees/can-filter-from-repetition-content
ETQ instructeur je peux filtrer à partir du contenu d'un bloc répétable
2024-09-16 14:59:05 +00:00
Paul Chavard
e7bc7c4783
feat(procedure): can filter from repetion content 2024-09-16 16:46:49 +02:00
mfo
7bbf04b9b5
Merge pull request #10774 from mfo/US/fix-PG-NumericValueOutOfRange
correctif: ETQ instructeur, si j'ai essayé de filtrer mes dossiers par numéro et que j'ai saisi un numero superieur à 2147483647, ma page ne doit pas planter
2024-09-16 14:43:59 +00:00
Lisa Durand
00a155b896
add password complexity for instructeur, user and password change 2024-09-16 15:23:43 +02:00
Paul Chavard
f5fdef0600
fix(api-entreprise): save libelle_commune_etranger and libelle_pays_etranger in db 2024-09-16 12:55:59 +02:00
mfo
7a78fdc913
fix(normalized_address): should not raise an error for addresses without code postal 2024-09-13 11:19:05 +02:00
simon lehericey
bc7d91751d
Revert "fix: ignore virtual data in column initialization"
This reverts commit 4289aa2cf5.
2024-09-13 11:00:08 +02:00
Mathieu Magnin
d8a0adc6ed
Merge pull request #10772 from demarches-simplifiees/fix-10751
ETQ Instructeur, jamais connecté, je ne veux pas recevoir 10 mails si j'ai été ajouté à 10 groupes
2024-09-13 08:08:16 +00:00
Colin Darie
8dfddba433
Merge pull request #10584 from colinux/attestation-render-list
ETQ admin, améliore l'affichage de champ choix multiple et répétitions dans les attestations v2
2024-09-12 14:40:32 +00:00
Mathieu Magnin
a99fae168c
[#10751] Allow sending a new invitation if the user's previous one has expired 2024-09-11 18:45:15 +02:00
mfo
02bbf26d3f
feat(ProcedurePresentation): validates that ProcedurePresentation.filters using a value casted as an integer [search by id] is not out of pg integer range 2024-09-10 17:47:50 +02:00
Colin Darie
6240d54fd4
fix: unbreakable space for better look in filters 2024-09-10 12:36:13 +02:00
Colin Darie
40b5eb5ea7
fix: typo region => région 2024-09-10 12:29:53 +02:00
simon lehericey
4289aa2cf5
fix: ignore virtual data in column initialization 2024-09-09 16:37:22 +02:00
mfo
5ab57a32ce
Merge pull request #10762 from mfo/US/export-when-tdc-change
Correctif, ETQ instructeur exportant mes dossiers, je souhaite retrouver la valeur saisie par les usagers quand les types de champ ont changés de type mais que les données restent compatible
2024-09-09 09:26:42 +00:00
mfo
7ec17ff7f5
fix(dossier.export): should not use default value when types_de_champ changed to a similar one 2024-09-09 11:00:01 +02:00
Colin Darie
977e47fa74
Merge pull request #10757 from mfo/US/fix-required-dossier-link-with-missing-dossier
correct: ETQ administrateur, je souhaite que les types de champ liens vers un dossier pointent vers un dossier valide si ils sont obligatoire
2024-09-09 07:28:48 +00:00
mfo
915779c9b0
Merge pull request #10749 from mfo/US/commune-without-insee
correctif: ETQ administrateur/instructeur, je souhaite que les champs de type commune aient tjr un code insee afin de router de maniere fiable
2024-09-06 11:44:00 +00:00
mfo
eb8b9a13ca
fix(Champs::DossierLinkChamp): when required, should point to existing dossier 2024-09-06 11:23:12 +02:00
mfo
5abba5a166
feat(Champs::CommuneChamp): ensure presence of external_id since some of Champs::CommuneChamp.external_id are missing while .value is present 🔥 2024-09-06 08:37:08 +02:00
LeSim
9fd53b182a
Merge pull request #10570 from demarches-simplifiees/feat/10425
ETQ Usager se connectant par FC, je dois confirmer mon mail
2024-09-05 08:07:23 +00:00
Colin Darie
247bb6f8c6
refactor(attestation): hide libelle of empty repetitions 2024-09-04 17:42:04 +02:00
Kara Diaby
9cebac1d99
Supprime la vérification par feature flag et utilise la vérif par booléen au booléen 2024-09-04 15:00:03 +00:00
simon lehericey
eaef5c7e39
readapt name and logic 2024-09-04 08:08:01 +00:00
Kara Diaby
b6d0502f39
modifications après dernière review 2024-09-04 08:05:54 +00:00
Kara Diaby
337f88575d
Modifications sur la méthode after_confirmation dans le modèle user 2024-09-04 08:05:53 +00:00
Kara Diaby
9c41c9a08f
Model FC : au lieu de valider le mail on envoie une demande de confirmation par mail 2024-09-04 08:05:52 +00:00
Lisa Durand
27c8abfb4b
Merge pull request #10734 from demarches-simplifiees/cannot-publish-with-test-service-ldu
ETQ Admin, je ne dois pas pouvoir publier une démarche avec les informations du service de test
2024-09-03 15:00:30 +00:00
simon lehericey
e0daf1032d
rename virtual_dates by non_displayable_dates 2024-09-02 17:27:35 +02:00
simon lehericey
245f7bb975
remove column.virtual params 2024-09-02 17:25:46 +02:00
simon lehericey
3c7c58623f
replace virtual: true by displayable: false 2024-09-02 17:25:22 +02:00
Lisa Durand
b5051a25d9
it displays an alert if using test service before publishing a procedure 2024-09-02 16:52:21 +02:00
Colin Darie
4db4cf1513
fix(attestation): don't render block levels presentation elements into a p 2024-09-02 16:11:02 +02:00
Colin Darie
c9956c4881
feat(attestation): better presentation of repetition champs 2024-09-02 16:11:02 +02:00
Colin Darie
09581ad028
feat(attestation): render multiple drop down list as list 2024-09-02 15:23:11 +02:00
Colin Darie
8e1cfd50dd
feat(procedure): improve dossier_for_preview with last dossier, excluding hidden by user 2024-09-02 15:23:10 +02:00
Colin Darie
cb902732be
Merge pull request #10710 from demarches-simplifiees/remove-unused-hidden-at-for-dossiers-ldu
[Tech] Retirer la colonne obsolète 'hidden_at' des dossiers (part 1)
2024-09-02 12:41:28 +00:00
mfo
f171727140
Merge pull request #10703 from mfo/US/dry-rna-rnf-siret-addresses-view
ETQ instructeur, je souhaite acceder aux information liées à l'adresses des champs RNA/RNF/SIRET
2024-09-02 12:25:54 +00:00
Colin Darie
e7443c2308
Revert "Champ related cleanups and refactoring" 2024-08-30 16:43:30 +02:00
Eric Leroy-Terquem
37a018880b
chore: generate representations coming from ActionText in background 2024-08-30 16:37:19 +02:00
Eric Leroy-Terquem
00c905a615
chore: generate variant for procedure logo in background 2024-08-30 14:28:42 +02:00
simon lehericey
516205efd9
add path_rewrite model 2024-08-29 16:15:07 +02:00
Paul Chavard
79c9784d17
refactor(dossier loader): simplify all the things 2024-08-26 14:53:56 +02:00
Paul Chavard
bb288337bf
cleanup(prefill): remove unused validation 2024-08-26 14:53:56 +02:00
Paul Chavard
3ef6f450da
cleanup: more concistent methods usage 2024-08-26 14:53:56 +02:00
Paul Chavard
5edb8749c0
refactor(attestation): unspecified_champs_for_dossier based on types_de_champ 2024-08-26 14:53:56 +02:00
Paul Chavard
1aee7ab1d2
refactor(champ): more concistent champ_for_update usage 2024-08-26 14:53:56 +02:00
Paul Chavard
f7cd7e615d
refactor(champs): validate only champs in current revision 2024-08-26 14:53:56 +02:00
Paul Chavard
701a28302e
refactor(dossier): remove unused scopes 2024-08-26 14:53:56 +02:00
Paul Chavard
bb2f590d18
refactor(repetition): use less champs and public_id methods 2024-08-26 14:53:56 +02:00
Eric Leroy-Terquem
fade633828
feat(routing): can create simple routing with address tdc 2024-08-26 11:16:47 +02:00
Eric Leroy-Terquem
8b4b4d7cb7
feat(conditional): can condition and route on address champ 2024-08-26 11:16:46 +02:00
Lisa Durand
b586f23009
remove hidden at column from dossiers 2024-08-22 17:36:41 +02:00
Lisa Durand
8e7e8d9624
Merge pull request #10705 from demarches-simplifiees/email-expert-need-confirmation-ldu
ETQ expert, je dois confirmer mon mail
2024-08-22 12:53:52 +00:00
mfo
70983c50f9
spec(normalized_address): add simple spec 2024-08-22 10:37:31 +02:00
mfo
fdff699d51
feat(champ.rnf/rna/siret): render normalized address the same way 2024-08-22 09:45:27 +02:00
Colin Darie
992c61b51a
fix: as of parsby 1.1, IO can be mutated during parsing
See 534f8a95b4/lib/parsby.rb (L572C11-L572C17)

Trace:
IOError: not modifiable string
    # parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
    # parsby-1.1.1/lib/parsby.rb:572:in `ungetc'
    # parsby-1.1.1/lib/parsby.rb:539:in `block in restore'
    # parsby-1.1.1/lib/parsby.rb:539:in `each'
2024-08-22 09:26:48 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment 2024-08-22 09:26:48 +02:00
Lisa Durand
3cf3dc4623
make email confirmation more generic 2024-08-21 16:23:56 +02:00
Lisa Durand
ea354d46c4
Create new invitation email if expert not confirm 2024-08-21 16:19:51 +02:00
mfo
ec9a03ac17
Merge pull request #10693 from mfo/US/filter-by-json-path-3
ETQ instructeur, je peux filtrer par les donnée de champs issues d'API, a commencer par RNA/RNF SIRET
2024-08-21 09:50:47 +00:00
mfo
750842f742
feat(Column::JSONPathColumn): allow search by json path column
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-08-21 10:23:39 +02:00
Paul Chavard
271602082b
refactor(columns): rename virtual to displayable 2024-08-20 18:46:19 +02:00
Lisa Durand
ab483a8959
simplifie tabs supprimes and reduce to one 2024-08-20 15:26:09 +02:00
Colin Darie
e4d460965f
Merge pull request #10690 from mfo/US/normalize-addresses-for-rnf-rna-siret
ETQ Tech, les adresses des champs siret / rna / rnf sont normalisées pour une recherche homogène via les filtres
2024-08-20 10:11:48 +00:00
Colin Darie
1e53e3bfef
Merge pull request #10661 from demarches-simplifiees/feat/10460
ETQ admin, je veux que l'email du déposant ne puisse pas être similaire à l'email du mandataire
2024-08-20 09:34:03 +00:00
LeSim
befe74b801
Merge pull request #9758 from demarches-simplifiees/purge_supprimer_dol
Tech: quand un dossier est définitivement supprimé, on ne garde que le log (DOL) concernant sa suppression
2024-08-20 09:26:33 +00:00
simon lehericey
28b338452a
feat(dossier_purge): when the dols are purged, only keep supprimer dol but destroy its data
Note, the only remaining data are dossier_id, automatic_operation, digest and bill_id, created_at
2024-08-20 10:55:32 +02:00
mfo
d866309d45
feat(rnf/rna/siret): normalize address in champs.value_json 2024-08-20 10:31:23 +02:00
mfo
dba6f9b3aa
refactor(Facet): to column 🚀 2024-08-19 15:46:14 +02:00
mfo
b910705353
move tdc facets builder to tdc 2024-08-19 15:30:08 +02:00
mfo
b6464c1963
tech: use facet_id to sort fields 2024-08-19 15:30:08 +02:00
mfo
743ff8c8a9
extract Instructeurs::FacetTableHeaderComponent wrapping sort logic 2024-08-19 15:30:08 +02:00
simon lehericey
61051771a7
stay the old way for the moment ? 2024-08-19 15:30:07 +02:00
simon lehericey
ef63579e2e
clean facets_concern 2024-08-19 15:30:07 +02:00
mfo
60c6c86d70
ProcedurePresentation.displayable_fields_for_select -> InstructeurFacetPickerComponent.displayable_fields_for_select 2024-08-19 15:29:59 +02:00
mfo
41ea39abb1
ProcedurePresentation.filterable_fields_options -> InstructeurFilterComponent.filterable_fields_options 2024-08-19 15:29:59 +02:00
simon lehericey
379c9fb812
procedure should provide its facets 2024-08-19 15:29:59 +02:00
simon lehericey
e19f1bd8c2
sortable? -> sorted_by 2024-08-19 15:29:59 +02:00
simon lehericey
c5c2d5782d
lets keep it private 2024-08-19 15:29:59 +02:00
simon lehericey
7a1c25271d
small refactors 2024-08-19 15:29:56 +02:00
simon lehericey
772424ff5e
move field_enum to instructeur filter component 2024-08-19 15:28:36 +02:00
simon lehericey
73293b0d06
give facet object instead of field_id to instructeur_filter_component 2024-08-19 15:28:36 +02:00
simon lehericey
437e632f6a
move facet_find to Facet.find 2024-08-19 15:28:36 +02:00
simon lehericey
969282e453
remove last field_hash 2024-08-19 15:28:36 +02:00
simon lehericey
305b8c13c7
! BREAKING : break previous filter by type_de_champ_private
simplify type_de_champ_private -> type_de_champ, fix spec, add facet_spec
2024-08-19 15:28:36 +02:00
simon lehericey
2239172fac
move facets list to facets 2024-08-19 15:28:36 +02:00
simon lehericey
49eaf10bce
fields -> facets 2024-08-19 15:28:36 +02:00
simon lehericey
5c09581228
move id to facet and search_by facet_id 2024-08-19 15:28:34 +02:00
mfo
b3cb3e974e
refactor(Facet): extract Facet from ProcedurePresentation
Co-Authored-By: LeSim <mail@simon.lehericey.net>

clean(code): no comment 🎶
2024-08-19 15:27:39 +02:00
Kara Diaby
88cd4a94dd
Ajoute la validation sur le modèle Individual 2024-08-19 12:51:39 +00:00
Paul Chavard
065000cae3
Merge pull request #10674 from colinux/really-fix-rnf
ETQ usager, permet de saisir un champ RNF en ignorant les espaces/tabulations
2024-08-01 18:09:21 +00:00
Colin Darie
c2159ca0bf
fix(contact): allow deletion of contact form of users having dossiers 2024-08-01 19:44:44 +02:00
Colin Darie
720a312b00
fix(rnf): really normalize spaces
Fix #10653
2024-08-01 18:54:50 +02:00
Paul Chavard
25d4e7dfee
fix(rnf): no crash on identifiers with spaces 2024-08-01 18:00:46 +02:00
Colin Darie
4b6d3ee16d
refactor(contact): support => contact 2024-07-31 17:08:02 +02:00
Colin Darie
5af32b46f4
refactor(contact): form is persisted in db before pushed to HS 2024-07-31 17:08:01 +02:00
Colin Darie
4bc0a04106
chore(schema): add contact_forms 2024-07-31 17:08:01 +02:00
Paul Chavard
9d7d7da85a
Merge pull request #10572 from demarches-simplifiees/add-pj-from-messagerie-to-gallery
ETQ instructeur je peux voir les pjs envoyées par la messagerie dans l‘onglet "pièces jointes"
2024-07-30 09:35:14 +00:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
simon lehericey
057868a48e
small work on tiptap 2024-07-26 13:34:49 +02:00
simon lehericey
8906a59635
simplify export_template model and spec 2024-07-26 13:34:49 +02:00
simon lehericey
977cfc87ce
Add export_item type 2024-07-26 13:31:06 +02:00
simon lehericey
24109a0128
add exportables_pieces_jointes_for_all_versions and outdated to pj_list_concern 2024-07-26 13:31:06 +02:00
simon lehericey
53a48f963d
tdc: add libelle_as_filename 2024-07-26 13:31:05 +02:00
Paul Chavard
223317fb5a
fix(rebase): avoid errors when adding pj champs to a new revision 2024-07-25 18:29:01 +02:00
Lisa Durand
4f7b0c93d0
fix multiple errors from creation of dedicated method to restore and extend 2024-07-25 16:55:00 +02:00
Lisa Durand
7da3e05752
small refacto to simplify scope 2024-07-24 17:07:48 +02:00
Lisa Durand
b820577461
create a method to extend and restore 2024-07-24 17:07:48 +02:00
Lisa Durand
ae1a6e1b3d
improve hidden_by_expired scope 2024-07-24 17:07:47 +02:00
Lisa Durand
5c26073af7
small refacto with hidden_by_expired? method 2024-07-24 17:07:47 +02:00
Lisa Durand
df13e53815
small refactos from Sim review 2024-07-24 17:07:47 +02:00
Lisa Durand
94e1f048ce
fix tabs count 2024-07-24 17:07:47 +02:00
Lisa Durand
eb3b928cf2
change scope to include new column for expiring dossiers 2024-07-24 17:07:47 +02:00
Lisa Durand
0dcdcb5643
add column hidden_by_expired_at 2024-07-24 17:07:41 +02:00
Lisa Durand
1441855fe8
fix query for instructeur tabs count 2024-07-24 17:06:31 +02:00
Lisa Durand
2d66a67564
use automatic flag for dossier operation log 2024-07-24 17:06:31 +02:00
Lisa Durand
9346020889
dont use depreciated column hidden_at 2024-07-24 17:06:30 +02:00
Lisa Durand
8b88fafc25
add correct action for instructeur 2024-07-24 17:06:30 +02:00
Lisa Durand
c2abceaa72
hide expired dossiers instead of delete them 2024-07-24 17:06:30 +02:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories 2024-07-22 13:53:45 +02:00
Eric Leroy-Terquem
3bbcda9c04
refactor(dossier): refactor pieces jointes 2024-07-22 10:07:39 +02:00
Eric Leroy-Terquem
3516bae008
feat(gallery): create representations for pjs sent by messagerie 2024-07-22 10:07:39 +02:00
Paul Chavard
be83f2c7d1
Merge pull request #10609 from tchak/champs-selection-multiple-combobox
Utiliser les nouvelles combobox pour les champs de sélection multiple
2024-07-16 13:17:41 +00:00
Paul Chavard
d640ab8428
fix(combobox): dispatch change event on multiple combo changes 2024-07-16 15:10:45 +02:00
Paul Chavard
42ed6d7c87
refactor(dossier): use each instead of filter with side effects 2024-07-16 09:03:56 +02:00
Lisa Durand
7630cc39fa
Merge pull request #10595 from demarches-simplifiees/email-mandant-need-confirmation-ldu
ETQ Mandant, je dois confirmer mon mail avant de recevoir des notifs
2024-07-15 14:00:38 +00:00
Lisa Durand
e9f5389f83
resent email if link too old and better style email 2024-07-15 12:00:03 +02:00
Lisa Durand
3eabcb0736
add tests 2024-07-15 11:56:18 +02:00
mfo
b55ed262ed
Merge pull request #10607 from mfo/US/fix-invisible-pj
Amélioration: ETQ usager, je souhaite que les PJs d'un champ qui n'est plus visible ne soient pas soumise a l'administration
2024-07-15 09:36:01 +00:00
mfo
1cd539297f
feat(dossier.passer_en_construction!): clean up PJ for champs that are not visible [condition is false] 2024-07-15 11:28:59 +02:00
mfo
d5c8b7464c
fix(users.update_email): optimistic 2024-07-12 15:42:50 +02:00
Eric Leroy-Terquem
ea8112b8b3
fix(routing): open routing wizard to all conditionable types 2024-07-11 14:55:03 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types 2024-07-11 12:17:46 +02:00
Lisa Durand
7539d2ddea
fix specs 2024-07-10 16:11:38 +02:00
Lisa Durand
42633c0012
Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into instructeur-invitation-include-typo-suggestion-ldu 2024-07-10 14:58:55 +02:00
Lisa Durand
3b138d5bb7
add confirmation for tiers email 2024-07-10 10:57:26 +02:00
mfo
f3690d8890
Merge pull request #10587 from tchak/refactor-no-validate-on-format
refactor(champ): remove call to validation from value formatting code
2024-07-09 14:31:10 +00:00
Colin Darie
142ed6f762
fix(cojo): fetch external data when "-01" suffix is typed, even if its deleted later by .to_i 2024-07-09 12:49:22 +02:00
Paul Chavard
133689b4d3
refactor(champ): remove call to validation from value formatting code 2024-07-08 15:39:28 +02:00
Colin Darie
3e9cb6f388
Merge pull request #10576 from colinux/secure-cookies
Tech: cookies avec flag `secure` et `httponly`
2024-07-08 09:33:30 +00:00
mfo
75a6c8b4b6
Merge pull request #10555 from mfo/US/normalize-number-cahmp
tech: Normalisation des champs de type number/decimal pr enlever les espace blanc à la saisi
2024-07-08 07:31:29 +00:00
Paul Chavard
f0f88ef3f0
refactor(champ): update champ drop_down_list 2024-07-05 09:36:33 +02:00
Paul Chavard
cb01f15570
refactor(champ): update champ commune 2024-07-05 09:36:33 +02:00
Paul Chavard
f1f1af4e61
refactor(champ): update champ annuaire education 2024-07-05 09:36:33 +02:00
Paul Chavard
79a65a4847
refactor(champ): update champ address 2024-07-05 09:36:33 +02:00
mfo
c50f949acd
feat(Champs::number*): normalize values by stripping spaces. 2024-07-04 09:56:23 +02:00
Lisa Durand
c8906d20b8
add reusable code in concern for typo detection email 2024-07-03 16:09:34 +02:00
Colin Darie
1eb0bdb4ae
chore: cookies with "secure" flag (only transmitted through https) 2024-07-03 11:18:16 +02:00
Colin Darie
b3ccfc16c4
Merge pull request #10547 from colinux/mandatory-by-default
ETQ admin, un nouveau champ est obligatoire par défaut
2024-07-02 14:26:29 +00:00
Eric Leroy-Terquem
2b0c53cd82
Merge pull request #10565 from demarches-simplifiees/add-demarches-publiees-page-in-manager
ETQ superadmin, je peux accéder aux informations essentielles des dernières démarches publiées
2024-07-02 07:46:30 +00:00
Eric Leroy-Terquem
0a70c6b90f
manager: add a page for demarches publiees 2024-06-28 18:20:05 +02:00
Colin Darie
48e5a237e3
chore(schema): change default types_de_champ#mandatory from false to true 2024-06-25 17:17:21 +02:00
Lisa Durand
d7893b9102
instructeur need to confirm mail after invitation 2024-06-25 15:14:26 +02:00
Colin Darie
ccf5b255ed
Merge pull request #10465 from colinux/attestations-v2-prod
ETQ admin je peux activer la délivrance des attestations v2 (sous feature flag)
2024-06-24 08:56:31 +00:00
mfo
2ee6f2350a
Merge pull request #10536 from mfo/US/summary-in-instructeur-demande
ETQ instructeur, je peux naviguer dans le formulaire de l'usager via un sommaire, idem pour les annotations privées.
2024-06-21 14:44:50 +00:00
mfo
4caeecadff
Merge pull request #10534 from mfo/US/fix-ineligibilite-rules-check-without-rules
Correctif: ETQ admin, je ne peux pas activer l'inéligibilité des dossiers sans règles d'inéligibilité
2024-06-21 09:47:43 +00:00
mfo
d46dc7055d
feat(instructeurs/dossiers): add summary to dossier.champs and dossier.champ_private views, also extract summary in
two component. one of type de champ editor. one for viewable champs
2024-06-21 11:06:45 +02:00
mfo
5a5ebfb235
Merge pull request #10531 from mfo/US/add-champ-summary-to-annotations
ETQ administrateur, je peux naviguer dans l'editeur des annotations en utilisant le sommaire façon editeur des champs du formulaire
2024-06-21 08:34:12 +00:00
mfo
6eaf870cbf
feat(administrateurs/procedure#annotations): add summary 2024-06-21 05:50:24 +02:00
mfo
24d7b0b014
fix(ineligibilite_rules): prevent admin to enable ineligibilite rules without rules 2024-06-20 15:35:36 +02:00
mfo
9adb1bcf49
fix(ineligibilite_rules): cache bust champs.visible after checking for ineligibilite rules
Update app/models/dossier.rb

Co-authored-by: Paul Chavard <github@paul.chavard.net>
2024-06-20 15:20:32 +02:00
Colin Darie
f2669fbca8
fix(attestation): fix unspecified_attestation_champs for v2 2024-06-20 14:15:06 +02:00
Colin Darie
a540f8dccb
feat(attestation): can render & attach attestations v2 2024-06-20 14:15:05 +02:00
Colin Darie
11d29f5574
chore(attestation): publish a v2 attestation 2024-06-20 11:08:15 +02:00
Colin Darie
4af6957237
fix(attestation): dup keep all attributes 2024-06-20 11:08:15 +02:00
Colin Darie
c5c24c01d8
chore(attestation): procedure#attestation_template always returns the published attestation 2024-06-20 11:08:15 +02:00
Colin Darie
ad3c5a7493
chore(schema): add attestation_templates#state 2024-06-20 11:08:15 +02:00
Benoit Queyron
97ef01b075
Merge branch 'main' into etq-usager-bouton-jdma 2024-06-11 18:09:01 +02:00
mfo
f6a5e932b8
Merge pull request #10292 from mfo/US/elligible-on-submit
ETQ administrateur, je peux ajouter des conditions d'eligibilité auxquelles les dossiers doivent correspondre sans quoi l'usager ne peut déposer son dossier
2024-06-11 09:46:25 +00:00
mfo
f819da8921
tech(clean): simplify implementation of eligibilite rules, code, enhance wording and test coverage 2024-06-11 09:57:36 +02:00
mfo
a011576757
feat(procedure_revision.validates): ineligibilite_rules 2024-06-11 09:39:21 +02:00
mfo
c480bc00c3
feat(Users/Dossiers#submit_brouillon_or_en_construction): prevent transition to en_construction if ineligibilite_rules matches. pop error nicely 2024-06-11 09:32:54 +02:00
mfo
178685b34b
feat(TypeDeChampEditor): prevent to destroy a type de champ used by inligibilite rules 2024-06-11 09:32:54 +02:00
mfo
2210db3b81
feat(Dossier::EditFooterComponent): disable submit button when inligibilite_rules matches 2024-06-11 09:32:54 +02:00
mfo
5644692448
feat(Logic.computable?): add computable? to know if a ineligibilite_rules set is computable 2024-06-11 09:32:53 +02:00
mfo
5de4ce889f
feat(ProcedureRevision.ineligibilites_rules): keep track of changes and show it to admin for republication 2024-06-11 09:32:53 +02:00
mfo
aca3e38859
feat(ProcedureRevision.ineligibilite_rules): add ineligibilite_rules management to procedure revision based on conditional logic 2024-06-11 09:32:53 +02:00
mfo
12d23f1498
feat(Procedure::Cards::IneligibleDossier): add an ineligibilite dossier card to procedure dashboard 2024-06-11 09:32:53 +02:00
Benoit Queyron
a8e382d0d0 fix(clone): le lien monavis est reinitialise lors du clonage 2024-06-10 14:55:51 +02:00
Benoit Queyron
0983f35dfd ajout d'un helper pour la source 2024-06-10 11:09:55 +02:00
mfo
73fe247c3d feat(avis): ensure consistent ordering, use ASC ordering to give back most recent avis first 2024-06-05 17:50:32 +02:00
Kara Diaby
cb5ba455eb Fixe bug sur toutes les démarches 2024-06-05 14:13:44 +00:00
mfo
5ef29a2f31
Merge pull request #10479 from mfo/us/enhance-procedure-validation
ETQ Admin, les erreurs liés aux formulaire usager et instructeurs sont plus consistantes
2024-06-05 05:14:45 +00:00
mfo
ef3ca9839b feat(procedure.validation): extract validation context: types_de_champ_public_editor, types_de_champ_private_editor and publication [combining both contextes]. validate conditions, headers_sections, regexp on type_de_champ_private too. dry validation 2024-06-04 18:25:24 +02:00
Paul Chavard
9753a91db6
feat(graphql): messages can be discarded through api 2024-06-04 17:41:26 +02:00
mfo
f14c88a54a clean(spec): speed, avoid using with_all_champs factory. takes too much time when not needed 2024-06-04 15:34:34 +02:00
krichtof
45814fdbfb
Merge pull request #10454 from demarches-simplifiees/9827-add-specs
corrige quelques bugs de la feature export template (renommage dans le zip)
2024-06-04 13:18:12 +00:00
Christophe Robillard
ac23d5fb41 convert date with dash for export renaming 2024-06-04 10:32:14 +02:00
Paul Chavard
68c15ba99f
feat(champ): add updated_by column 2024-06-03 18:45:16 +02:00
simon lehericey
5d259ec47b
refactor(user): rename invite! -> invite_instructeur! 2024-05-31 14:53:49 +02:00
simon lehericey
607fbf5287
feat(user): block unverified_email from being sent 2024-05-31 14:53:49 +02:00
Kara Diaby
2371705efc
Merge pull request #10437 from demarches-simplifiees/feat/10332
Amélioration de la page toutes les démarches :  Quick Wins
2024-05-29 13:50:04 +00:00
Paul Chavard
ed2f615f2b
Merge pull request #10468 from tchak/fix-handle-missing-siret-information
fix(dossier): handle missing siret information when dossier passe en instruction
2024-05-29 12:19:30 +00:00
Kara Diaby
7281f3ec1a SQL pour renvoyer les zones dans ProcedureDetail 2024-05-29 11:45:31 +00:00
Paul Chavard
de209954e1
Merge pull request #10466 from tchak/fix-supprimes_recemment-should-include-archived
fix(instructeur): supprimes_recemment should include archived dossiers
2024-05-29 11:09:41 +00:00
Paul Chavard
eb9aad27c3
fix(dossier): handle missing siret information when dossier passe en instruction 2024-05-29 13:09:04 +02:00
Paul Chavard
5154231ccf
fix(dossier): batch operations to termine dossier should send emails 2024-05-29 11:31:58 +02:00
Paul Chavard
b06934b8d3
fix(instructeur): supprimes_recemment should include archived dossiers 2024-05-29 11:03:46 +02:00
Christophe Robillard
d61203e57c remove dead code 2024-05-28 19:14:57 +02:00
Christophe Robillard
d9f7b6d1df fix dossier directory for etablissement when export with export template 2024-05-28 18:25:38 +02:00
Christophe Robillard
2267ec98cf fix dossier directory for attestation when export with export template 2024-05-28 18:25:37 +02:00
Christophe Robillard
ce6ebf3589 fix dossier directory for commentaire when export with export template 2024-05-28 18:25:37 +02:00
simon lehericey
fa06d17169
Feat(user): set email_verified_at when setting confirmed_at 2024-05-27 17:24:56 +02:00
simon lehericey
841c1cc845
Feat(user): verify user email during devise confirmation 2024-05-27 17:24:55 +02:00
Paul Chavard
1bca3c123b
chore(dossier): remove legacy update attributes 2024-05-27 10:33:37 +02:00
Colin Darie
3617368a35
fix(search): increase debounce delay because of too frequent brouillon updates 2024-05-27 09:57:05 +02:00
simon lehericey
e38999efda
perf(pj service): compute row_id without extraneous requests 2024-05-23 10:01:29 +02:00
simon lehericey
6184b33a18
perf(preloader): preloader use batch for batches 2024-05-23 10:01:29 +02:00
simon lehericey
ca12a56e6a
perf(zip): give champ to avoid seeking stable_id 2024-05-23 10:00:42 +02:00
simon lehericey
080bcd8628
refactor: DossierPreloader rename includes_for_dossier -> includes_for_champ 2024-05-23 10:00:41 +02:00