gregoirenovel
a0660d17eb
Refactor SiretFormatValidator#luhn_checksum
2018-09-19 10:32:43 +02:00
gregoirenovel
9d18f4187c
Simplify SiretFormatValidator
...
We can remove nil checks as we never get nil
values
2018-09-19 10:32:43 +02:00
gregoirenovel
4e4b7c617f
[ Fix #2618 ] Do not enforce Luhn for La Poste SIRET numbers
2018-09-19 10:29:43 +02:00
gregoirenovel
940dfe422b
Further refactor SiretFormatValidator#validate_each
2018-09-19 10:28:07 +02:00
gregoirenovel
36950b985b
Refactor SiretFormatValidator#validate_each
2018-09-19 10:15:44 +02:00
gregoirenovel
49d872452a
Improve SiretFormatValidator readability
2018-09-19 10:15:44 +02:00
gregoirenovel
471f6799c8
Refactor Siret tests
2018-09-19 10:15:42 +02:00
gregoirenovel
1299b125f1
Merge pull request #2617 from tchak/fix-add-path-to-procedures-task
...
Fix add path to procedures task
2018-09-18 19:20:47 +02:00
Paul Chavard
7591878b89
Fix add path to procedures task
2018-09-18 18:26:54 +02:00
Pierre de La Morinerie
ff4934eca2
Merge pull request #2601 from betagouv/new-dossier-feature-switch
...
dossier: finish feature-switch for enabled new dossier details
2018-09-18 16:54:02 +02:00
Pierre de La Morinerie
38f6d11c57
dossier: finish feature-switch for enabled new dossier details
2018-09-18 16:48:27 +02:00
gregoirenovel
326a1f7aaf
Merge pull request #2561 from betagouv/bump-gems
...
Bump gems
2018-09-18 15:22:50 +02:00
gregoirenovel
31a95cfb4e
Bump development/test gems
...
- rspec-rails (3.8.0)
2018-09-18 15:06:29 +02:00
gregoirenovel
81d8e998b9
Bump test gems
...
- factory_bot (4.11.0 → 4.11.1)
2018-09-18 15:06:29 +02:00
gregoirenovel
40df5bb1f0
Bump development gems
...
- rubocop (0.58.2 → 0.59.0)
2018-09-18 15:06:29 +02:00
gregoirenovel
1a33984e8b
Bump default gems
...
- aasm (5.0.0 → 5.0.1)
- pg (1.1.2 → 1.1.3)
- skylight (2.0.2 → 3.0.0)
- uglifier (4.1.18 → 4.1.19)
2018-09-18 15:06:29 +02:00
Paul Chavard
6cf7c2fe09
Merge pull request #2607 from tchak/do-not-clone-procedure-path
...
Do not clone procedure path
2018-09-18 13:48:41 +01:00
Paul Chavard
36812793d4
Do not clone procedure path
2018-09-18 14:40:02 +02:00
Paul Chavard
b13db523d5
Merge pull request #2606 from betagouv/fix-active-record-translations
...
Gemfile: add default ActiveRecord translations
2018-09-18 13:39:49 +01:00
Pierre de La Morinerie
110f657849
Gemfile: add default ActiveRecord translations
...
Before:
```ruby
> Commentaire.create!
ActiveRecord::RecordInvalid (translation missing: fr.activerecord.errors.messages.record_invalid)
```
After:
```ruby
> Commentaire.create!
ActiveRecord::RecordInvalid (La validation a échoué : Body Votre message ne peut être vide)
```
Fix #2096
2018-09-18 14:22:08 +02:00
Frederic Merizen
b36346d045
Merge pull request #2605 from betagouv/frederic/fix_2584-extract_dossier_field_service
...
Frederic/fix 2584 extract dossier field service
2018-09-18 14:17:12 +02:00
Frederic Merizen
89a1d990e9
[ #2584 ] Minor cleanup of DossierFieldService
2018-09-18 13:49:49 +02:00
Frederic Merizen
63fc0b3bc3
[ Fix #2584 ] Move Field related code to a service
2018-09-18 13:49:34 +02:00
Paul Chavard
36994ab697
Merge pull request #2583 from tchak/add-path-to-procedure
...
Add path to procedure
2018-09-18 12:38:12 +01:00
Paul Chavard
18922122b4
Fix SQL ambiguous name error
2018-09-18 13:21:29 +02:00
Paul Chavard
b042efdcba
Update procedure path attribute when procedure_path changes
2018-09-18 13:21:29 +02:00
Paul Chavard
b772256a97
Read from path attribute instead of procedure_path when possible
2018-09-18 13:21:18 +02:00
Paul Chavard
2787f040af
Add path attribute to Procedure model
2018-09-18 13:21:18 +02:00
Paul Chavard
1cf65c1b89
Add task to fill procedures table path column
2018-09-18 13:21:18 +02:00
Paul Chavard
5ab22ee139
Add path column to procedures table
2018-09-18 13:21:18 +02:00
Paul Chavard
bce2e53f71
Merge pull request #2603 from tchak/use-helpers
...
Use helpers rather then view_context
2018-09-18 11:53:35 +01:00
Paul Chavard
e2f13a8b73
Use helpers rather then view_context
2018-09-18 12:06:27 +02:00
Paul Chavard
ff9afa69e2
Merge pull request #2600 from tchak/procedure-demarche
...
fix procédure -> démarche
2018-09-18 10:47:37 +01:00
Paul Chavard
db1a93ab35
fix procédure -> démarche
2018-09-18 11:22:06 +02:00
gregoirenovel
8aab263a1e
Merge pull request #2599 from betagouv/improve-demarches
...
Affichage du service dans la liste des démarches
2018-09-18 10:56:22 +02:00
gregoirenovel
f696560a14
Affichage du service dans la liste des démarches
2018-09-18 10:44:49 +02:00
gregoirenovel
3229f542dc
Merge pull request #2598 from betagouv/fix-task
...
Fix the 2018_09_12_fix_templates task
2018-09-18 10:44:35 +02:00
gregoirenovel
b5368ea72b
Fix the 2018_09_12_fix_templates task
2018-09-18 10:41:55 +02:00
gregoirenovel
40ee79ad75
Merge pull request #2594 from betagouv/improve-status-texts
...
Dossier : amélioration des textes décrivant les différents statuts
2018-09-18 10:41:33 +02:00
Pierre de La Morinerie
a820f2118a
dossier: improve wording for 'en instruction'
2018-09-18 10:33:11 +02:00
Pierre de La Morinerie
4a5218ffe9
dossier: improve wording for 'en construction'
2018-09-18 10:33:11 +02:00
Pierre de La Morinerie
ea3267c0d7
dossier: don't display 'brouillon' in the timeline if not required
...
Unless the user is actually editing a brouillon, we don't need to show
this state.
2018-09-18 10:33:11 +02:00
Pierre de La Morinerie
530baf6ca6
Merge pull request #2559 from betagouv/fix-2544
...
[Fix #2544 ] Add a task to fix now invalid templates
2018-09-17 17:48:18 +02:00
gregoirenovel
1b6e49b49e
[ Fix #2544 ] Add a task to fix now invalid templates
2018-09-17 17:27:40 +02:00
gregoirenovel
29b47f48ab
Merge pull request #2593 from betagouv/dossier-add-termine-state
...
Dossier : amélioration des états terminés
2018-09-17 16:53:07 +02:00
Pierre de La Morinerie
de07171acd
dossier: improve styling of finished dossier infos
2018-09-17 16:29:48 +02:00
Pierre de La Morinerie
a7cb4b6514
dossier: add download icon to attestation link
2018-09-17 16:29:48 +02:00
Pierre de La Morinerie
27727eabf3
dossier: add link to attestation when accepted
2018-09-17 16:29:48 +02:00
Pierre de La Morinerie
fd7f07a244
dossier: add link to messagerie when rejected
2018-09-17 16:29:48 +02:00
Pierre de La Morinerie
2de480d6e9
dossier: show latest message only when dossier is pending
2018-09-17 16:29:48 +02:00