DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
13715 commits 250 branches 1166 tags 78 MiB
Commit graph

13715 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Chavard
71c54a226d
Merge pull request #6667 from betagouv/active-storage-validations-max-size 
Simplification des messages d’erreur en cas de fichier trop volumineux
 2021-11-24 13:10:14 +03:00
Pierre de La Morinerie
60c2718f29 models: remove custom code for file size validation message 
With active_storage_validations 0.9.6, we can use the %{max_size}
variable directly in the error message.
 2021-11-24 10:06:45 +01:00
Pierre de La Morinerie
4b557a4f18 gems: update active_storage_validation to 0.9.6 
This allows us to have the %{file_max_size} variable defined in the
error message.

See https://github.com/igorkasyanchuk/active_storage_validations/pull/134
 2021-11-24 08:18:18 +01:00
LeSim
d4cbcaf768
Merge pull request #6663 from betagouv/remove-procedure-autocomplete-leftovers 
Suppression du code obsolète pour l'auto-validation du chemin des démarches
 2021-11-23 17:44:31 +01:00
Martin
0fd9e15cc1 i18n(expiration_banner): extract test in i18n files 2021-11-23 15:23:22 +01:00
Pierre de La Morinerie
2227dcc1e7 app: remove leftovers of procedure path autocomplete 
We used to pre-validate the procedure, to display in advance if the path
could be used.

Now that the path autocomplete is long gone, we can remove this kludgy
code.
 2021-11-23 14:30:21 +01:00
LeSim
4fc224490e
Merge pull request #6660 from betagouv/agent_connect 
Prise en charge d'agent connect (#6027)
 2021-11-23 14:26:05 +01:00
simon lehericey
4efd15377c spec 2021-11-23 14:17:59 +01:00
simon lehericey
c5097451ef add redirect 2021-11-23 14:17:59 +01:00
simon lehericey
5234a1854c manage AgentConnect callback 2021-11-23 14:17:59 +01:00
simon lehericey
1926a630f9 add agent_connect_id to instructeur 2021-11-23 14:17:59 +01:00
simon lehericey
3316dfc866 reopen openid_connect gem to support AC encrypted jwt response 2021-11-23 14:17:59 +01:00
simon lehericey
898df449d4 redirect to AgentConnect 2021-11-23 14:17:59 +01:00
simon lehericey
45ce274721 add agent connect secrets 2021-11-23 14:17:59 +01:00
simon lehericey
d2432e34eb AgentConnect UI 2021-11-23 14:17:59 +01:00
simon lehericey
ed7d776727 Bump jwt dep to decrypt ES256 FCA response 2021-11-23 14:17:59 +01:00
simon lehericey
91109dc944 bump openid connect (mandatory to avoid lets encrypt certs pb) 2021-11-23 14:17:59 +01:00
Pierre de La Morinerie
a82ce9a13c
Merge pull request #6633 from betagouv/improve-procedure-factory 2021-11-23 14:04:15 +01:00
mfo
49bb12a70e
Merge branch 'main' into 6649-etq-usager-instructeur-rendre-la-suppression-plus-visible 2021-11-23 11:05:51 +01:00
Pierre de La Morinerie
997c197980 specs: simplify the syntax of some factories 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
2203a7762f specs: create dossier revision and individual declaratively 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
f2233300b6 specs: assign the default groupe instructeur declaratively 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
0e809ac1a2 specs: build the default groupe instructeur before the create callback 
This allows for better ergonomics, by having the default groupe
instructeur available even before the procedure is saved.
 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
032e3e2cb1 specs: create the procedure administrateur declaratively 
It seems better to create associations in an declarative fashion, rather
than using imperative code. This also makes the attribute compatible
with build_stubbed.
 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
970c3e4b2b specs: avoid executing business logic in Procedure factory 
Calling business logic in a factory is a code-smell, because it
usually requires the object to be saved into database, and may have
unintended consequences when the business logic is changed.

Also, this allows to just build a published procedure, without saving it
to the database.
 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
d8fbcfe2e2 specs: explicitely pass the dossier to champs factories 
Otherwise the factory will not know in avance which procedure this
champs belongs to.
 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
ef2d9a3e86 specs: fix :champ_siret factory not using the procedure 
Unlike all other champs factories, :champ_siret would attempt to build
a champ with a `nil` procedure (instead of using the dossier's one).
 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
774ef00f8e specs: improve dossier_spec#build_default_individual 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
8d89ae366b specs: minor cleanups 2021-11-23 08:07:07 +01:00
Pierre de La Morinerie
09ca70eef0 specs: improve search controller specs 2021-11-23 08:07:07 +01:00
Martin
b6adf5fc72 feat(dossiers/show): enhance header with expirations message/banner. also ensure consistent design between dossier states 
fix(spec): broken due to last refactoring

spec(dossier.extend_conservation): add system spec

lint(ruby): still not yet ready for auto lint in IDE...
 2021-11-23 05:50:25 +01:00
Paul Chavard
e934d6ea30
Merge pull request #6657 from betagouv/sentry-ignore-parse-errors 
GraphQL : affiche la cause des erreurs de syntaxe des requêtes
 2021-11-22 17:05:24 +03:00
Martin
2a87b9bf89 feat(users/dossiers/*): rework header for consistent design, add some utils spacers 2021-11-22 14:46:10 +01:00
Martin
8368d62ed3 fix(spec): broken due to new view var 2021-11-19 15:53:15 +01:00
Pierre de La Morinerie
859a147c49 api: return error cause on parse error 
Currently, when a query can't be parsed, the error is:
- logged to Sentry (which is useless to us),
- returned as a generic 'Internal Server Error' (which is useless to the
  user who made the query).

With this commit, the error is instead ignored from our logs (because it
is a user error), but the parse error details are returned to the user,
with the following format:

> {'errors': [{'message': 'Parse error on ")" (RPAREN) at [3, 23]'}]}
 2021-11-19 15:15:10 +01:00
Martin
3d1533dee9 feat(users/dossiers?statut=dossiers-expirant): add dossiers-expirant tab 2021-11-19 15:14:39 +01:00
Martin
eecc0c38b6 lint(rubocop): come on, maybe i will find the inspiration to setup it up in my ide 2021-11-19 14:36:21 +01:00
Martin
a9978fb70b clean(code): move mfo comment to its rightful place 2021-11-19 14:34:20 +01:00
Martin
608a85148f feat(Dossier.close_to_expiration): add method to find any kind of dossier close to expiration [reuse previous scopes], add missing spec to termine_close_to_expiration, complement spec for each kind of expiration scope with general close_to_expiration spec 2021-11-19 14:28:54 +01:00
Martin
d8257284ef tech(refactor): extract states close to expiration within their scope. 2021-11-19 14:07:47 +01:00
Martin
1d721f14a0 fix(spec): get back to stable state 2021-11-19 12:36:03 +01:00
Martin
646459a1da fix(spec): at least let us start from a green suite 2021-11-18 18:15:57 +01:00
Paul Chavard
df474b60cf WIP 2021-11-18 18:58:17 +03:00
krichtof
2167c02454
Merge pull request #6651 from betagouv/main 
2021-11-17-01
 2021-11-17 15:10:59 +01:00
Paul Chavard
2e4635c786
Merge pull request #6650 from tchak/fix-champ-commune 
fix(champs): save departement info on champ commune
 2021-11-17 17:00:51 +03:00
Paul Chavard
ae09b37e72 fix(champs): save departement info on champ commune 2021-11-17 14:52:47 +03:00
LeSim
8fb6e32132
Merge pull request #6648 from betagouv/main 
2021-11-17-01
 2021-11-17 09:50:26 +01:00
LeSim
333a4029af
Merge pull request #6639 from betagouv/bump_js_dep 
bump all the js
 2021-11-17 09:31:52 +01:00
simon lehericey
f1855e4be1 bump all the js 2021-11-17 09:28:00 +01:00
mfo
31089440db
Merge pull request #6636 from betagouv/6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur 
6624/etq-instructeur-je-souhaite-supprimer-des-messages-envoyes-par-erreur 🚀
 2021-11-17 05:52:35 +01:00