DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
7860 commits 250 branches 1166 tags 78 MiB
Commit graph

4536 commits

Author SHA1 Message Date
Pierre de La Morinerie
60a61da644 tasks: extract dossier migration to a separate method 2019-06-12 18:58:47 +02:00
pedong
7ef1a558f4 change date format for all, use try_format_date of helper 2019-06-12 17:48:12 +02:00
simon lehericey
ee296f2b44 Use default format for date and datetime champ 2019-06-12 17:48:12 +02:00
pedong
abcd58c35d [fix #3710] date with letter 
Co-Authored-By: simon lehericey <mail@simon.lehericey.net>
 2019-06-12 17:48:12 +02:00
Nicolas Bouilleaud
5acb7a3f1b Make rubocop happy 
I did make some changes some lines above this 🤷.
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
1ac6cad132 Display previous followers in “personnes impliquées” 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
6b90bc1ea1 Add “previously followed” dossiers and gestionnaires 
Using an “inactive” Follow scope, similar to the “active” scope.

(I was tempted to use a default_scope, but this breaks when trying to `unscope` it in associations.)
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
be4c575622 Add Follow.unfollowed_at 
The active scopes is used indirectly in the dossier<->gestionnaire associations: the existing tests in dossier and gestionnaire just work™.
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
d417907f36 Just rely on the constraints to avoid duplicate Follows 
Don’t check manually in advance: just try to create the new Follow and silently fail.

Since we have both Rails validation and DB constraints in place, we have two types of errors to check. I’m not actually sure this change improves the legibility of the code.
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
ba48a1da6e Ensure Follow dates can not be not null 
* Add Follow.unfollowed_at
* Change the unicity constraint to gestionnaire/dossier AND unfollowed_at
 2019-06-12 17:33:53 +02:00
Nicolas Bouilleaud
8e04b4f0c9 Clear the “add admin” field after submit 
Extract the add_admin form to its own partial and re-render it when an admin is successfully added.
 2019-06-12 16:58:30 +02:00
Pierre de La Morinerie
55c9dfc001 api_entreprise: display better error message when SIRET is private 
Previously we blamed the network.

Now we say that the entreprise infos cannot be retrieved. Which is not
ideal, but better.
 2019-06-12 11:58:04 +02:00
Pierre de La Morinerie
78f75744e3 javascript: fix payload of ActiveStorage events missing on IE 11 
Under some circumstances (like dispatching events just before a page
navigation), IE 11 events will be dispatched twice by the browser: once
with the payload, and a second time without.

To prevent these errors, ignore the events if the payload is missing.
 2019-06-06 15:00:57 +02:00
Chaïb Martinez
eccd456325 Add crisp 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-05 17:41:47 +02:00
Paul Chavard
5a216b5583 Fix default button type 
fix #3924
 2019-06-04 17:59:02 +02:00
Chaïb Martinez
9198f7f437 Remove useless select options 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-04 16:55:11 +02:00
Chaïb Martinez
3b513af32a Add nb_of_dossiers by years and deadline to PipeDrive Person 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-06-04 16:55:11 +02:00
Paul Chavard
6d312e1716 spec: refactor wait_for_ajax to work with out new ajax utils 
`wait_for_ajax` is not used anymore, but it may be in the future.
 2019-06-04 16:30:36 +02:00
Paul Chavard
d5911071f8 Return dossiers on api with stable order 2019-06-04 15:34:49 +02:00
Pierre de La Morinerie
1f69c6c6eb stylesheets: fix font of dropdown items on Firefox 
Styling `<select>` elements is notoriously hard. Here, it seems that
Firefox doesn't handle custom fonts on `<option>` elements. As we have
no fallback font, the browser uses its default font, Times.

Having fallback fonts is good practice anyway.
 2019-06-04 11:37:40 +02:00
Pierre de La Morinerie
f2f16e2580 carte: disable tiles layer during tests 
During integration tests, we don't want to load the tiles from OSM:

- It hits OSM servers during every test run;
- It it slow (Capybara waits for the tiles to be loaded to proceed);
- It makes test time out when tiles cannot be loaded for some reason.

Fix #3913
 2019-06-03 17:24:15 +02:00
Paul Chavard
ff44b7a600 Refactor purge pj to be more generic 2019-05-29 15:54:51 +02:00
Pierre de La Morinerie
a8847e40ea pj migration: add comments and notices 2019-05-29 14:46:49 +02:00
Pierre de La Morinerie
6cb02f2927 pj migration: handle signal interrupts 2019-05-29 14:46:49 +02:00
Pierre de La Morinerie
1a256b37f8 pj migration: print a notice when migrating missing files 2019-05-29 12:20:10 +02:00
Pierre de La Morinerie
a168ae3a72 pj migration: reduce the number of queries by preloading champs 2019-05-29 12:20:10 +02:00
Pierre de La Morinerie
10df7b70ee carrierwave: when migrating, create an empty blob if file is missing 2019-05-28 18:19:33 +02:00
Pierre de La Morinerie
44c410d40d piece_justificative_service: fix for missing order_place 
In production some pieces justificatives don't have an order place.

In this case, insert the champs after the ones that have an order place.
 2019-05-28 17:20:07 +02:00
Pierre de La Morinerie
d410e31344 active_storage: document the virus scan hooks 2019-05-28 11:39:22 +02:00
Pierre de La Morinerie
52b7a82932 services: mark attachments migrated from CarrierWave as safe 
This avoids to enqueue thousands of scans when migrating the PJs of
a whole procedure.
 2019-05-28 11:39:22 +02:00
Pierre de La Morinerie
4cf54e0d28 tasks: add progress report to the pjs migration task 
Progress is indicated per migrated champ.
 2019-05-28 10:42:18 +02:00
Pierre de La Morinerie
21ac60ad04 tasks: add a task to migrate pjs of procedures in batches 2019-05-28 10:42:18 +02:00
Chaïb Martinez
920c8c0c32 Add Gestionnaire ID and ROLES 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-05-27 16:30:03 +02:00
clemkeirua
f06ae1631f no crash when q is missing on RechercheController::index 2019-05-22 15:02:57 +02:00
Paul Chavard
6797c01b69 Properly handle justificatif_motivation case 2019-05-22 14:11:08 +02:00
Paul Chavard
6a3413018a Refresh attachments with virus scan result 2019-05-21 14:21:55 +02:00
Paul Chavard
f6421e081a Refactor attachment view 2019-05-21 14:21:13 +02:00
Paul Chavard
f833f57e45 Add PurgeUnattachedBlobsJob 2019-05-21 14:05:33 +02:00
Paul Chavard
4a9ef5d12e Always use purge_later 2019-05-21 14:05:33 +02:00
Chaïb Martinez
49f0127300 [fix #3856] Add form contact admin link 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-05-20 15:30:28 +02:00
Chaïb Martinez
855d4d0245 [fix #3867] Add legal text 
Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-05-20 13:43:46 +02:00
Nicolas Bouilleaud
e423da9319 Fix unclosed div tags in manager views 2019-05-20 13:30:52 +02:00
Paul Chavard
42235e81b1 Use active storage load hook to extend blob 2019-05-16 20:43:01 +02:00
Paul Chavard
348b15f595 Put devtools behind feature flags 2019-05-15 18:10:25 +02:00
Keirua
a0b2e504dd
Merge branch 'dev' into fix/add-refresh-for-pj 2019-05-15 17:16:35 +02:00
Paul Chavard
2817e571e8 Remove unused sendinblue import 2019-05-15 16:00:12 +02:00
clemkeirua
285e75f470 correction wording 2019-05-15 15:08:37 +02:00
clemkeirua
131f1aacc4 ajout de plus d'informations utilisateur pour télécharger le justificatif 2019-05-15 14:56:03 +02:00
Paul Chavard
0265c10474 Safari throw if deleting inexistent property 2019-05-14 17:12:27 +02:00
Paul Chavard
9725f2a418 Enable new champs editor for all 2019-05-14 16:18:29 +02:00
Paul Chavard
3446782cd0 Remove deprecated editor 2019-05-14 16:18:29 +02:00
Paul Chavard
9ce1f0d0a6 Set keep_until on operation_log if available on procedure 2019-05-14 14:31:03 +02:00
Paul Chavard
b8bf662c6d Track dossier demander un avis 2019-05-14 14:31:03 +02:00
Paul Chavard
9c472e6524 Track dossier private annotations modifications 2019-05-14 14:31:03 +02:00
Paul Chavard
dba8d65137 Track dossier operations with author and subject 2019-05-14 14:31:03 +02:00
Paul Chavard
c93b1bb276 Add intersection-observer polyfill 2019-05-14 10:55:16 +02:00
Paul Chavard
c4dc2adcea Add new type de champ after type de champ on screen 2019-05-14 10:55:16 +02:00
Chaïb Martinez
3004f96cf5 Add video and webinar URLs to admin pages 
Fix #3850

Signed-off-by: Chaïb Martinez <chaibax@gmail.com>
 2019-05-13 17:47:02 +02:00
simon lehericey
5f18b07eda webpacker stays mysterious 2019-05-13 17:35:11 +02:00
Pierre de La Morinerie
d36cb85f6a notification_mailer: send procedure id when reporting a missing logo 2019-05-13 16:23:11 +02:00
Pierre de La Morinerie
f5f7dfba40 france_connect: fix for params entirely missing from the callback 
Fix a Sentry exception encountered in production.
 2019-05-13 15:45:12 +02:00
pedong
a226999382 redirect to same path after use signup 2019-05-13 15:28:25 +02:00
Pierre de La Morinerie
e66e78b4db helpscout: remove integration of custom fields 
Our new HelpScout plan doesn't allow custom fields
anymore.
 2019-05-13 12:33:29 +02:00
clemkeirua
25bcd51fce add log for virus_scanner 2019-05-13 12:22:19 +02:00
pedong
f0ed61cce8 Carrierwave: change the method name to extension_whitelist for filter uploader file extension 2019-05-07 13:20:20 +02:00
clemkeirua
afa6711564 refacto suite à simplification virusscan 2019-05-07 08:54:29 +02:00
clemkeirua
d0794f42d1 fix tag_substitution_concern links for lien attestation 2019-05-07 08:54:29 +02:00
clemkeirua
c98655be52 ellipsis on file input overflow 2019-05-07 08:54:29 +02:00
clemkeirua
67a3d435d0 added some space after the optionnal justificatif button 2019-05-07 08:54:29 +02:00
clemkeirua
0e26bda186 cleanup the tag substitution concern & uniformization 2019-05-07 08:54:29 +02:00
clemkeirua
653eff01f0 add download link for instructeur 2019-05-07 08:54:29 +02:00
clemkeirua
486a6eccd6 fix invalid refactoring 2019-05-07 08:54:29 +02:00
clemkeirua
e4259466b4 nettoyage du tag_substitution_concern 2019-05-07 08:54:29 +02:00
clemkeirua
b3956bc072 introduce virus scans 2019-05-07 08:54:29 +02:00
clemkeirua
f8a2598647 ajout du lien vers le justificatif dans la balise --lien attestation-- 2019-05-07 08:54:29 +02:00
clemkeirua
ec2e17032e suppression de la double confirmation 2019-05-07 08:54:29 +02:00
clemkeirua
183f1a5fa8 suppression de l'ajout en PJ 2019-05-07 08:54:29 +02:00
clemkeirua
4aab72be68 implementation du systeme de PJ de motivation 2019-05-07 08:54:29 +02:00
Pierre de La Morinerie
67fb561119 Apply suggestions from code review 
Co-Authored-By: n-b <nico@bou.io>
 2019-05-06 16:19:08 +02:00
Nicolas Bouilleaud
0590cc1e28 Ignore the Procedure.administrateur_id column again 
following #3822
 2019-05-06 16:19:08 +02:00
Nicolas Bouilleaud
df865e71dc Make sure that there always is at least one administrator per Procedure 2019-05-06 16:19:08 +02:00
Nicolas Bouilleaud
8d84dba3f2 Link to multi-admin settings from the left panel 
refs #1626
 2019-05-06 16:19:08 +02:00
Nicolas Bouilleaud
3ff0c83485 Add multi-admin UI 
refs #1626
 2019-05-06 16:19:08 +02:00
maatinito
2308b3bc5c [Fix 3827] Champ Pays: la ligne de tirets ne devrait pas être selectionnable 2019-05-06 14:55:29 +02:00
clemkeirua
64b858ef19 handle Gon + add report-uri URL 2019-05-06 10:07:51 +02:00
Paul Chavard
96b3547788 Exercices and RNA information are optional and should not block the request 2019-05-03 18:23:21 +02:00
Paul Chavard
91f2d7d706 Remove deprecated virus_scan model 2019-05-03 11:07:19 +02:00
Paul Chavard
6e8b9cf668 Refactor piece_jointe template to avoid repetition 2019-05-02 15:58:09 +02:00
Paul Chavard
f113d108c9 Save virus scan status to blob metadata 2019-05-02 15:58:09 +02:00
Paul Chavard
2f633b5d23 Load leaflet from a separate chunk 2019-05-02 14:10:48 +02:00
Pierre de La Morinerie
e06e32238c api_entreprise: display a specific error message on network errors 2019-05-02 11:24:38 +02:00
Pierre de La Morinerie
ad4a89f0f6 api_entreprise: raise on network error 2019-05-02 11:24:22 +02:00
Pierre de La Morinerie
6c8280fba6 api_entreprise: add a feature flag for toggling API INSEE v3 2019-04-30 17:27:58 +02:00
Pierre de La Morinerie
b74fdd3cc8 Revert "Fix API Entreprise call" 
This reverts commit 7deb228477.
 2019-04-30 17:19:46 +02:00
Pierre de La Morinerie
54813db0ad dossiers: fix the cache not actually caching 
As the expensive `procedure.usual_traitement_time` was called outside of
the cache, the cache was useless.
 2019-04-30 15:56:27 +02:00
Pierre de La Morinerie
d855468cb6 dossiers: display the estimate of the entire processing time 
Displaying separate estimations for en_construction and en_instruction
doesn't really make sense for the users: they want to know how
long it is going to take overall, not the petty details of our workflow.
 2019-04-30 15:56:27 +02:00
Pierre de La Morinerie
10fee7a12b dossiers: decrease estimation cache duration 
Some badly outdated data where shown to the users.
 2019-04-30 15:56:27 +02:00
Paul Chavard
1c71355574 Better warnings in test mode 2019-04-30 11:03:24 +02:00
Paul Chavard
1d67005545 Add a default value for drop_down_list_value to avoid validation error on new type_de_champ 2019-04-30 10:39:27 +02:00
simon lehericey
7deb228477 Fix API Entreprise call 2019-04-30 10:27:35 +02:00
Pierre de La Morinerie
9c6aa209c9 sign_in: fix line breaks on form header 2019-04-29 17:59:11 +02:00
Pierre de La Morinerie
8bd1064532 tasks: populate Procedure.administrateurs even for hidden procedures 
The previous procedure migration (created in
f7af01e0dc) worked fine, but didn't run
on hidden procedures (due to the default scope).
 2019-04-29 16:35:34 +02:00
simon lehericey
14c3686969 ApiAdresse: add timeout 2019-04-23 14:31:01 +02:00
Paul Chavard
8d093bd9ba Fix missing dossier_id on champs inside repetition 2019-04-18 16:55:35 +02:00
simon lehericey
e65e21a72f Email notification: use the right method for procedures 2019-04-18 15:07:01 +02:00
Pierre de La Morinerie
1f955db2c7 gestionnaire: ignore when the gestionnaire already follows the dossier 
Fix #3720
 2019-04-18 11:41:24 +02:00
simon lehericey
1d051dc3ef Can change a piece_justificative_template on a type_de_champ 2019-04-18 11:13:35 +02:00
simon lehericey
11f8e7a3f9 Small refactor 2019-04-18 11:13:35 +02:00
Nicolas Bouilleaud
562fe90d42 Fix signout arrow direction 2019-04-18 11:03:58 +02:00
Philémon
d533abedbc Ajout rappel enregistrement nécessaire 2019-04-18 10:25:16 +02:00
Mathieu Magnin
0770362fb4 Fix when missing logo on remote storage crash email sending 2019-04-11 15:32:52 +02:00
Paul Chavard
9beff5ee9a Always create menu deroulant champs with a value 2019-04-11 14:38:21 +02:00
Mathieu Magnin
1a97cd42de Fix missing helper in notification mailer 2019-04-11 12:25:55 +02:00
Mathieu Magnin
28f9208ce8 When mail template is updated, stay on edit page to easily preview it 2019-04-11 11:03:13 +02:00
Mathieu Magnin
b3f3106888 [Fix #3064] Change logo size 2019-04-11 11:03:13 +02:00
Mathieu Magnin
9c6c11027c [Fix #3064] Add service footer on notification emails 2019-04-11 11:03:13 +02:00
Mathieu Magnin
60d66f0422 [Fix #3064] Add logo and cancel link on preview 2019-04-11 11:03:13 +02:00
Mathieu Magnin
7e551a9d8d [Fix #3064] If procedure has logo, then display it in emails 2019-04-11 11:03:13 +02:00
Mathieu Magnin
b3970a5e6f [Fix #3064] Change default signature 2019-04-11 11:03:13 +02:00
Mathieu Magnin
14c3fb7224 [Fix #3064] Add a preview button for state notifications emails 2019-04-11 11:03:13 +02:00
Mathieu Magnin
e91b412254 [Fix #3064] Use a different layout for state notifications emails 2019-04-11 11:03:12 +02:00
Nicolas Bouilleaud
c5122ee7f5 Allow filtering ProcedurePresentation by followers_gestionnaires 
fixes #3464
 2019-04-10 14:32:51 +02:00
Nicolas Bouilleaud
988df15c6b Refactor ProcedurePresentation::sanitize_columns to use model reflection 
The passed “table” is actually an association, and may not match the table name. Use model reflection instead of manually pluralizing.
 2019-04-10 14:32:51 +02:00
Nicolas Bouilleaud
2fb1b19e09 Hide other motivation fields when switching between states 2019-04-10 10:32:43 +02:00
Paul Chavard
833bafaba6 Align with behaviour on user dossier form 2019-04-09 17:16:18 +02:00
Paul Chavard
adb6255d5d Do not crash if element to remove is not found 2019-04-09 17:15:45 +02:00
Paul Chavard
a60943a173 Polyfill insertAdjacentElement and dataset on old browsers 2019-04-09 15:26:42 +02:00
Mathieu Magnin
052bd9a9fc [Fix #3682] Remove placeholder on textarea champ 2019-04-08 16:30:16 +02:00
Nicolas Bouilleaud
c1d1754236 Fix a typo in admin/procedures 2019-04-08 16:20:43 +02:00
Pierre de La Morinerie
8ca683c515 mailers: fix last_week_overview crash when the overview is missing 
This is because procedures may be unpublished between the time where
the job is enqueued and the time the mailer is run

Fix #3745
 2019-04-04 17:32:12 +02:00
Pierre de La Morinerie
e90b1cdcc0 api_entreprise: use API v3 again 
This reverts commit 10e1408a88.
 2019-04-04 17:14:58 +02:00
Mathieu Magnin
3de9148e33 Change WeeklyOverviewJob hour and day 2019-04-04 15:42:06 +02:00
Mathieu Magnin
f768cb2dae [Fix #3721] Change notification screen to make it understandable 2019-04-04 15:42:06 +02:00
Paul Chavard
4fb889f10a Send browser support information and format user id 2019-04-04 14:21:32 +02:00
Paul Chavard
8e6e730c80 Send user information to sentry without email 2019-04-04 14:21:32 +02:00
Pierre de La Morinerie
41ad89d8ac commencer: fix redirection with invalid path 2019-04-04 14:03:40 +02:00
Paul Chavard
1cbd348569 Fix scope error 2019-04-04 10:31:24 +02:00
Pierre de La Morinerie
158d6e1ae6 avis: format newlines in avis 
Fix #3738
 2019-04-04 10:20:57 +02:00
Paul Chavard
8157fd0127 Fix type de champ menu déroulant 2019-04-03 21:53:57 +02:00
Paul Chavard
b9be186d2c Sentry should send environment information 2019-04-03 18:19:16 +02:00
Paul Chavard
8e20b6dec2 Make buttons bar wider 2019-04-03 17:59:42 +02:00
Paul Chavard
2374877e98 Add plus icon to ajouter un champ button 2019-04-03 17:59:42 +02:00
Paul Chavard
a197459e4d Fix react props warning 2019-04-03 17:59:42 +02:00
Pierre de La Morinerie
253008e666 types_de_champ_editor: add title to actions 2019-04-03 17:49:03 +02:00
Pierre de La Morinerie
d79fee7040 types_de_champ_editor: improve the move handle 2019-04-03 17:15:35 +02:00
Pierre de La Morinerie
1880e5161b types_de_champs_editor: improve apparence of Move buttons 2019-04-03 17:15:35 +02:00
Pierre de La Morinerie
adefd26413 procedure_context: hide the description on auth pages 2019-04-03 17:14:48 +02:00
Pierre de La Morinerie
e896310e34 procedure_context: display the procedure description on small screens 
Fix #3658
 2019-04-03 17:14:48 +02:00
Mathieu Magnin
a997f683f5 Fix pétouille on service form placeholder 2019-04-03 16:52:15 +02:00
Pierre de La Morinerie
22f2ca105e commencer: display a FranceConnect button 
Fix #3640
 2019-04-03 16:08:09 +02:00