DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
6898 commits 4 branches 1166 tags 84 MiB
Commit graph

4018 commits

Author SHA1 Message Date
Mathieu Magnin
31c45fe2e5 Fix Sentry 161 2019-01-10 15:21:40 +01:00
simon lehericey
e55fe2bb91 link_sent: add sentence to warn max email delay 2019-01-10 12:06:35 +01:00
simon lehericey
eb6ef1eb46 Gestionnaire: increase validity token to 45 minutes 2019-01-10 12:06:35 +01:00
simon lehericey
29fff9ee68 [fix #3269] bufferize login token email 2019-01-10 12:06:35 +01:00
Pierre de La Morinerie
5719107cbc views: fix misnamed textarea template 2019-01-10 11:26:43 +01:00
simon lehericey
e7d5f30192 Admin: small reword in admin procedure ui 2019-01-09 16:25:00 +01:00
simon lehericey
a197285742 [fix #2612] Admin: add missing steps to admin UI 2019-01-09 16:25:00 +01:00
simon lehericey
8ca7eb1c54 Procedure: cloning set the current admin gestionnaire of the procedure 2019-01-09 16:25:00 +01:00
simon lehericey
b38fbc78ef SessionControllerSpec: remove specific attribut test 
change user.update(log_in_with_france_connect: nil) as log_in_france_connect is an enum
 2019-01-09 13:49:47 +01:00
simon lehericey
f0139c5962 Spec Factory: an administrateur always has a gestionnaire 2019-01-09 13:49:47 +01:00
Paul Chavard
1beefe4469 Fix champ repetition belongs_to associations 2019-01-08 11:56:33 +00:00
gregoirenovel
1c2f1a715c Rely on the champs partial for annotations privées when printing 2019-01-08 12:32:27 +01:00
gregoirenovel
55419b92a8 Simplify code 2019-01-08 12:32:27 +01:00
gregoirenovel
864bb38d8a Add #for_api methods to CheckboxChamp and YesNoChamp 
Otherwise, we return nil instead of “off” / “non”,
so we don’t expose the data properly
 2019-01-08 12:32:27 +01:00
gregoirenovel
0846bad1c8 Mutualize code in methods 
As done in YesNoChamp
 2019-01-08 12:32:27 +01:00
gregoirenovel
866c74ce63 Add Champ#for_api 2019-01-08 12:32:27 +01:00
gregoirenovel
083dfb4eaa Improve ProcedureExportService 2019-01-08 12:32:27 +01:00
gregoirenovel
b4781f7440 Make dossier link clickable for users in the Demande tab 2019-01-08 12:32:27 +01:00
gregoirenovel
cc07f0d701 Add a blank line to improve readability 2019-01-08 12:32:27 +01:00
gregoirenovel
e4f10a3d2d Order a case statement alphabetically 2019-01-08 12:32:26 +01:00
gregoirenovel
66c633a1e5 Mutualize some code 2019-01-08 12:32:26 +01:00
gregoirenovel
5014e3f4c1 Move the display logic directly into the carte champ partial 2019-01-08 12:32:26 +01:00
gregoirenovel
dbbe2866d5 Extract the siret champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
c1ebae3ee8 Extract the textarea champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
e6e67dab35 Extract multiple_drop_down_list champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
81d6e193e5 Extract the piece_justificative champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
c7f2293c15 Extract the dossier_link champ view in a partial 2019-01-08 12:32:26 +01:00
gregoirenovel
004cdd4c43 Add highlights to all champs 2019-01-08 12:32:26 +01:00
gregoirenovel
20ea577a66 Remove a case that can be handled by the general case 2019-01-08 12:32:26 +01:00
gregoirenovel
f9df32d72e Use c.to_s instead of value, to avoid confusion 2019-01-08 12:32:26 +01:00
gregoirenovel
f5a31be36a Remove the now useless #formatted_value method 2019-01-08 12:32:26 +01:00
gregoirenovel
c00aac2f80 We can now replace processing in #formatted_value by #to_s calls 2019-01-08 12:32:26 +01:00
gregoirenovel
f27717ab23 Make the CheckboxChamp export similar to YesNoChamp 
Previously, nil values would be returned as nil
and not as off
 2019-01-08 12:32:26 +01:00
gregoirenovel
4a6930b60a Remove from EngagementChamp a method it’s inheriting 2019-01-08 12:32:26 +01:00
gregoirenovel
66d1b7ba10 Use ternary conditions 2019-01-08 12:32:26 +01:00
gregoirenovel
9e42190148 Remove the proxy value_for_export method 
Overload for_export instead
 2019-01-08 12:32:26 +01:00
gregoirenovel
7cd50531cf Remove the proxy string_value method 
Overload to_s instead
 2019-01-08 12:32:26 +01:00
gregoirenovel
9a2341c56c Remove the useless #for_display proxy method 2019-01-08 12:32:26 +01:00
gregoirenovel
2e6c91e9b0 Move #selected_options to the only relevant model 2019-01-08 12:32:26 +01:00
gregoirenovel
c4b9a0b79e Rename DropDownList#selected_options_without_decorator 2019-01-08 12:32:26 +01:00
gregoirenovel
4b4eb6d53e Simplify code 2019-01-08 12:32:26 +01:00
gregoirenovel
16bccb2386 Remove the useless #value_for_export method 2019-01-08 12:32:26 +01:00
Pierre de La Morinerie
142b684170 layouts: fix styling of the sign_in and sign_up pages 
This was broken during the shared layout refactoring
 2019-01-08 08:16:55 +01:00
Pierre de La Morinerie
be1567ecbd messages: improve wording of the "Send" button 2019-01-07 16:20:23 +01:00
Pierre de La Morinerie
46b4d3c46b messages: fix Send button being clipped on mobile screens 2019-01-07 16:20:23 +01:00
Pierre de La Morinerie
0a7b061e70 layouts: move the procedure_context CSS to its own stylesheet 2019-01-07 15:40:19 +01:00
Pierre de La Morinerie
e25bd7139f layouts: use a common procedure_context layout for the demarche overview 2019-01-07 15:39:58 +01:00
Pierre de La Morinerie
5a36546485 layouts: rename "application" to "application_old" 2019-01-07 12:17:05 +01:00
Chaïb Martinez
144bc86cd0 Add sendinblue tracking in admin backoffice pages 2019-01-07 10:27:50 +01:00
Chaïb Martinez
0452a3046c Add sendinblue tracking in admin backoffice pages 2019-01-07 10:27:50 +01:00
Chaïb Martinez
b04de622c6 Add sendinblue js 2019-01-07 10:27:50 +01:00
gregoirenovel
fd2b44b45e Fix the FC info link 2019-01-07 08:52:51 +01:00
gregoirenovel
c66342aa2f Add a CTA in the header on the registration page 2019-01-07 08:52:51 +01:00
gregoirenovel
a43ec4e0d1 Align the remember me and forgotten password items 2019-01-07 08:52:51 +01:00
simon lehericey
7b935a6486 login_token: lets constantize 2019-01-07 08:18:29 +01:00
gregoirenovel
65798feba3 Unify code 2019-01-07 08:12:52 +01:00
gregoirenovel
382a50abcf Reorder the admin sidebar links 2019-01-07 08:12:52 +01:00
gregoirenovel
5fa5f2aa37 Bump development gems 
- rubocop (0.61.1 → 0.62.0)
 2019-01-05 11:47:55 +01:00
Pierre de La Morinerie
dbbe96d333 signature: replace RbNaCl by ActiveSupport::MessageVerifier 2019-01-03 17:48:53 +01:00
Pierre de La Morinerie
86b9e2d092 stats: fix exception when HelpScout env vars are missing 
This fixes the stats page, which used to raise an exception when
HelpScout env vars are not present.
 2019-01-03 17:27:56 +01:00
Pierre de La Morinerie
da675bb47e api: fix formatting error when a request fails 2019-01-03 17:27:56 +01:00
Pierre de La Morinerie
efae27b901 stats: start helpscout stats at 01-2018 
Data before is very variable, as it is based on a low dossiers count.
 2019-01-03 17:23:22 +01:00
Pierre de La Morinerie
d77530c461 Make Procedure state consistent after switching types de champ order 
Fixes an issue where, after clicking the "move champ up" button,
the new form is rendered with an incoherent order.
 2019-01-03 15:13:14 +01:00
gregoirenovel
9466442aff Remove the TypeDeChamp decorators 2019-01-03 12:08:25 +01:00
gregoirenovel
9c130c41da Remove ProcedureDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
b41764ec03 Remove ChampDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
b8f57415cd Remove the unused decorator DossierDecorator 2019-01-03 12:08:25 +01:00
gregoirenovel
559df6b82a Remove the unused decorator ProceduresDecorator 2019-01-03 12:08:24 +01:00
gregoirenovel
6565ce9c3c Remove the unused decorator DossiersDecorator 2019-01-03 12:08:24 +01:00
gregoirenovel
71c8083b92 Remove the unused decorator UserDecorator 2019-01-03 12:08:24 +01:00
gregoirenovel
4f30e30a08 Remove the unused decorator FranceConnectInformationDecorator 2019-01-03 12:08:24 +01:00
gregoirenovel
0c8b228fbf Enable the Lint/UselessAssignment cop 2019-01-03 10:53:50 +01:00
gregoirenovel
0336ecf639 Remove useless arguments from some methods 2019-01-03 10:53:50 +01:00
gregoirenovel
0596d53ac2 Enable the Lint/UnusedBlockArgument cop 2019-01-03 10:53:50 +01:00
gregoirenovel
baf7977786 Enable the Lint/StringConversionInInterpolation cop 2019-01-03 10:53:50 +01:00
gregoirenovel
d473119f9d Enable the Lint/ParenthesesAsGroupedExpression cop 2019-01-03 10:53:50 +01:00
gregoirenovel
186e362701 Enable the Layout/SpaceInsideArrayLiteralBrackets 2019-01-03 10:53:50 +01:00
gregoirenovel
386fbce776 Enable the Layout/SpaceBeforeBlockBraces cop 2019-01-03 10:53:50 +01:00
gregoirenovel
8b0b8162f0 Enable the Layout/SpaceAfterComma cop 2019-01-03 10:53:50 +01:00
gregoirenovel
d6e4f775ba Add some space between the Merci content and the footer 2018-12-28 19:03:19 +01:00
Chaïb Martinez
802f2086d6 Redirect admins with no démarches to the new demarche page 2018-12-28 18:57:51 +01:00
Chaïb Martinez
e88a3f8dbf Add a message to the démarches library page if the admin has 0 demarches 2018-12-28 18:25:15 +01:00
Chaïb Martinez
c19b1bb6cf Make the “New démarche from scratch ” button bigger 2018-12-28 18:25:12 +01:00
Chaïb Martinez
d0d11edf61 Make a démarches library title bigger 2018-12-28 18:24:59 +01:00
maatinito
4ad3a60e25 [Fix #2575] Créer automatiquement un compte instructeur aux administrateurs 2018-12-26 09:44:20 -10:00
gregoirenovel
03eb47016c Fix a gestionnaire sign in bug 2018-12-26 18:14:04 +01:00
Chaïb Martinez
1a7d0f2e12 Remove mailto contact DS into admin header 2018-12-26 14:43:34 +01:00
Chaïb Martinez
1c4eb72fa5 Suspect by defaut 2018-12-22 11:49:15 +01:00
Chaïb Martinez
905d2f1635 Add phone number from pipedrive 2018-12-22 11:49:15 +01:00
maatinito
384dbf3e1b Add an intro to the last week overview email 2018-12-20 17:07:19 +01:00
maatinito
10cd16656d Improve the style of the last week overview email 2018-12-20 17:07:17 +01:00
maatinito
15ad7bae53 Improve the style of the avis invitation email 2018-12-20 17:07:15 +01:00
maatinito
5ca9267065 Improve the style of the dossier expiration summary email 2018-12-20 17:07:11 +01:00
maatinito
87cccae17a Change the title of the avis invitation 2018-12-20 17:07:07 +01:00
maatinito
249a64f1a6 Improve the copy of the invite guest email 2018-12-20 17:07:06 +01:00
maatinito
e4883aa152 [Fix #325] Set InviteMailer’s layout 2018-12-20 16:21:27 +01:00
maatinito
a1a11adb83 [#325] Make the notification layout inherit from the general layout 2018-12-20 16:21:27 +01:00
maatinito
d80bf601e1 [#325] Add support for a footer in layout.html.erb 2018-12-20 16:21:27 +01:00
Mathieu Magnin
b40c706d98 [Fix #3192] Clone service if procedure is transferred 2018-12-20 15:45:48 +01:00
Chaïb Martinez
0fe473b84e Add 2 new categories in admin contact form 2018-12-20 15:29:49 +01:00
Chaïb Martinez
206f17be90 Add warning text in email field 2018-12-20 15:29:49 +01:00
Mathieu Magnin
1dcc8303a6 Add html links in invitation mail templates 2018-12-20 15:01:04 +01:00
Paul Chavard
eb9edc1cee Order types de champ in scope 2018-12-20 14:14:15 +01:00
gregoirenovel
af21618652 Improve the avis invitation email footer 2018-12-20 11:57:07 +01:00
maatinito
b72fd330b5 Use the layout's footer for the avis invitation email 2018-12-20 11:20:10 +01:00
maatinito
e554cc3644 Unify the emails' intro tag 2018-12-20 11:20:10 +01:00
maatinito
2de328da64 Unify the emails' intro sentence 2018-12-20 11:20:10 +01:00
maatinito
f51cdd0e48 Add a partial for the emails' signature 2018-12-20 11:20:10 +01:00
Frederic Merizen
2a758d0759 [Fix #3196] Convert YAML to JSON 2018-12-19 23:17:55 +01:00
Frederic Merizen
36d6a43084 [#3196] Make TypeDeChamp#options compatible with raw JSON 
instead of YAML inside a JSON string.
We still need to support the YAML form until the data has been migrated
 2018-12-19 18:43:56 +01:00
Paul Chavard
5d1c24f3d8 Add type de champ repetition models (with row) 2018-12-19 15:31:11 +01:00
gregoirenovel
df7e0a9881 Remove dead code 2018-12-19 14:59:15 +01:00
gregoirenovel
4b0e632abb Enable the Style/ColonMethodCall cop 2018-12-19 13:56:10 +01:00
gregoirenovel
616e9305e9 Enable the Style/ClassCheck cop 2018-12-19 13:56:10 +01:00
gregoirenovel
fba8d97256 Enable the Stlye/BlockDelimiters cop 2018-12-19 13:56:10 +01:00
gregoirenovel
a8f700b572 Enable the Style/FormatString cop 2018-12-19 13:56:10 +01:00
pedong
09552ed9ff [fix #3188] replace a to link_to in footer 2018-12-19 13:18:01 +01:00
gregoirenovel
85a20f9b28 Remove double spaces 2018-12-19 12:35:22 +01:00
Chaïb Martinez
408ee31595 Add Sendinbue subscribe form 
Remove Mailjet newsletter subscribe popin
 2018-12-19 12:35:22 +01:00
Frederic Merizen
d1cfe4468d Encourager la création de champs PJ plutôt que de vieilles PJS 2018-12-19 11:57:23 +01:00
gregoirenovel
336ee6aba0 Remove the Tour de France banner from the administration landing page 2018-12-19 10:57:28 +01:00
gregoirenovel
e69310fe07 ModuleApiCartoService → ApiCartoService 2018-12-19 10:29:11 +01:00
gregoirenovel
129df93fb1 Add a blank line to ease readability 2018-12-18 22:49:27 +01:00
gregoirenovel
3ce3d203d4 Simplify some code 2018-12-18 22:49:27 +01:00
gregoirenovel
81ee1c2961 Use a method instead of a comparison 2018-12-18 22:18:38 +01:00
gregoirenovel
026fd1aaa2 Use parentheses 2018-12-18 22:18:38 +01:00
maatinito
008793d844 [Fix #1318] ETQ Instructeur, j'aimerais être averti que le texte de la motivation sera visible par les utilisateurs 2018-12-18 16:27:51 +01:00
Mathieu Magnin
8435ff004f Add annotations privées to procedure page on manager 2018-12-18 12:15:50 +01:00
Frederic Merizen
57a136c861 Make champ PJ generally available 2018-12-18 11:11:23 +01:00
Pierre de La Morinerie
d614ea6bd5 stats: display contact rate 2018-12-18 10:38:59 +01:00
Mathieu Magnin
5ab0853f1c Harmonize user champ pj purge route to gestionnaire 2018-12-14 11:38:59 +01:00
Mathieu Magnin
edf3eefa87 Fix Sentry 114, Instructeur can delete pj in private champs 2018-12-13 17:27:05 +01:00
gregoirenovel
ebb76c57f1 Fix a typo 2018-12-12 11:29:59 +01:00
gregoirenovel
56dcbb5b64 Update message so that it reflects the reality 2018-12-10 17:25:44 +01:00
pedong
de5de75869 [fix #2985] del champ_linked_dropdown in feature 2018-12-10 16:47:22 +01:00
simon lehericey
5a87fad02e [fix #3154] order export 2018-12-10 16:41:37 +01:00
Pierre de La Morinerie
30774aa189 api_geo: cache requests for one day 
This should make the 500 errors that we get in production less frequent.

NB: Unfortunately we can't write a spec for the caching behavior, as the
VCR mocks are never cached.
 2018-12-10 11:41:07 +01:00
Pierre de La Morinerie
a0ae1afb45 typhoeus: add a cache store for successful requests 2018-12-10 11:41:07 +01:00
gregoirenovel
3b0562949c Ask API Entreprise for insee v3 2018-12-10 10:49:56 +01:00
gregoirenovel
31250b4642 Make more ApiEntreprise::API methods private 2018-12-10 10:48:57 +01:00
pedong
f70f276ae9 [fix #2813] set lien_notice nil when clone a procedure 2018-12-06 21:28:08 +01:00
Chaïb Martinez
80133601c7 Add Matomo tracking code for logged usagers 2018-12-06 19:44:50 +01:00
simon lehericey
db6c86b242 DossierController: user can destroy pjs 2018-12-06 10:45:10 +01:00
Frederic Merizen
4699e515ed [Fix #2999] Send gestionnaire back to what they were doing after email verification 2018-12-06 10:03:21 +01:00
Paul Chavard
ee93b4e33d Revert legacy carte API to parsed json 2018-12-05 18:19:15 +01:00
Paul Chavard
35494df78e Procedure export dossiers with champs siret 2018-12-05 17:09:39 +01:00
Pierre de La Morinerie
e206f3d4d4 gestionnaire: display draft procedures in the list 
Fix #3088
 2018-12-05 15:38:20 +01:00
Paul Chavard
a08f170dbd Assign users and gestionnaires to commentaires 
fix #2052
 2018-12-05 13:40:57 +01:00
Paul Chavard
2f2aa580f8 Update activestorage.js 2018-12-04 11:37:00 +01:00
Paul Chavard
c492e1cd88 Update webpacker (babel7) 2018-12-04 11:37:00 +01:00