Simon Lehericey
62894175ae
DossierControllerSpec: refactor by remove sign_in test logic
...
As this test belongs to ProcedureControllerSpec
2017-09-06 11:11:29 +02:00
Simon Lehericey
f6bc9ec852
DossierControllerSpec: rename describe (add #)
2017-09-06 11:11:28 +02:00
gregoirenovel
7ff7710803
A gestionnaire can only see procédures publiées
2017-09-06 11:11:26 +02:00
gregoirenovel
55a4f1288f
Fix a gestionnaire test
2017-09-06 11:11:26 +02:00
Simon Lehericey
714b2a5f08
NewDesign: gestionnaire can add a new commentaire
2017-09-06 11:11:25 +02:00
Simon Lehericey
d5535aaaaa
DossierControllerSpec: refactor
2017-09-06 11:11:23 +02:00
Simon Lehericey
97de5b2dd9
DossierControllerSpec: remove duplicate test
2017-09-06 11:11:23 +02:00
Simon Lehericey
86ea47bb0d
BackofficeDossierController: follow dossier when receive
2017-09-06 11:11:23 +02:00
Simon Lehericey
b80d6a6a59
Follow: add flash notice to dossier_controller
2017-09-06 11:11:23 +02:00
Simon Lehericey
95fbd1824a
Follow: remove old backoffice follow and toggle_follow
2017-09-06 11:11:22 +02:00
Simon Lehericey
6cff044a50
NewDossierController: add next_step follow
2017-09-06 11:11:22 +02:00
Simon Lehericey
e68f3332c1
Gestionnaire: add follow(dossier) method
2017-09-06 11:11:21 +02:00
Simon Lehericey
033f08524f
Gestionnaire: refactor follow?
2017-09-06 11:11:21 +02:00
Mathieu Magnin
923a16a8c8
remove extra line
2017-09-06 11:11:18 +02:00
Mathieu Magnin
2b0c0567b8
Add header section in form table
2017-09-06 11:11:16 +02:00
Mathieu Magnin
f9f313e990
Add identité demandeur for entreprise on dossier detail page
2017-09-06 11:11:15 +02:00
Mathieu Magnin
5b417889b2
Use same counters on procedures index than show
2017-09-06 11:11:14 +02:00
Simon Lehericey
a064ae64a4
NewDesign: add archive and unarchive actions on dossier
2017-09-06 11:11:12 +02:00
Simon Lehericey
eb65318844
NewDesign: add follow and unfollow actions on dossier
2017-09-06 11:11:12 +02:00
Simon Lehericey
ad1a11ab52
NewDesign: procedure show add dossier table
2017-09-06 11:11:11 +02:00
Simon Lehericey
b48af51ee9
NewDesign: procedure show only header
2017-09-06 11:11:11 +02:00
Mathieu Magnin
f7d1cfc462
Add tests on procedures#index
2017-09-06 11:11:09 +02:00
Mathieu Magnin
05f83fb3d3
convert simple quote to double quote
2017-09-06 11:11:09 +02:00
gregoirenovel
650a39b371
Use delete_all instead of destroy_all to batch delete
2017-08-29 14:22:14 +02:00
Simon Lehericey
806c41af38
[ Fix #667 ] Can add an already register gestionnaire with uppercase email
2017-08-28 15:36:34 +02:00
Simon Lehericey
a7b00ee847
Rubocop: enable Layout/SpaceAroundOperators
2017-08-28 13:39:13 +02:00
Simon Lehericey
62f1b9c712
Rubocop: enable indentation width rule
2017-08-28 12:20:58 +02:00
Mathieu Magnin
dd1fea78ac
[ Fix #658 ] when dossier linked to avis is hidden, do not crash application
2017-08-28 10:11:50 +02:00
Mathieu Magnin
dd581082ca
[ Fix #395 ] Export user email in API
2017-08-25 12:01:53 +02:00
Mathieu Magnin
931e547afa
[ Fix #395 ] Export user email in csv
2017-08-25 12:01:52 +02:00
gregoirenovel
af91751e1e
Refactor a test to avoid logging a Sentry error message
2017-08-21 16:34:52 +02:00
gregoirenovel
2908a81a1b
Remove a warning
...
We used to have `warning: removing `initialize'
may cause serious problems` when running this test
2017-08-21 15:23:01 +02:00
Simon Lehericey
d40eef284d
Dossier: fixup n+1 champ query
2017-08-03 13:02:13 +02:00
Simon Lehericey
1363999621
Dossier: fixup n+1 private champ query
2017-08-03 13:01:55 +02:00
Mathieu Magnin
03fde0a502
[ FIX #589 ] Force birthdate format when saving
2017-08-01 16:47:43 +02:00
Mathieu Magnin
dae700788f
Fix test that fail when is run on the 1st day of the month following a 31 days month
2017-08-01 16:42:39 +02:00
Simon Lehericey
7016bdc49a
Avis: move assign_gestionnaire logic to avis model
2017-07-21 11:22:16 +02:00
Simon Lehericey
fe1b97b738
Avis: move notify_gestionnaire to private method
2017-07-21 11:19:18 +02:00
Mathieu Magnin
ed11ee4fb4
Fix SQL injections
2017-07-20 18:22:14 +02:00
Mathieu Magnin
1d0734dda2
Admin should be owner of procedure to hide it
2017-07-20 16:40:11 +02:00
Mathieu Magnin
e468612d95
Admin should be owner of procedure to destroy it
2017-07-20 14:30:36 +02:00
Mathieu Magnin
b0c0477622
[ Fix #315 ] Order champs by procedure order in export
2017-07-19 16:31:30 +02:00
gregoirenovel
9666ed7d5d
Remove useless tests
2017-07-19 13:32:59 +02:00
Simon Lehericey
3a17c86a74
Follow: follow must be uniq
2017-07-18 15:12:10 +02:00
gregoirenovel
6f2c63c094
Remove default values for some stat methods’ arguments
2017-07-17 16:00:16 +02:00
gregoirenovel
32e0fa9f69
Add Procedure#publiee_ou_archivee?
2017-07-13 17:01:39 +02:00
gregoirenovel
36bee67085
Add Procedure#brouillon?
2017-07-13 17:01:38 +02:00
gregoirenovel
25800305ad
cefixup publiee
2017-07-13 17:01:33 +02:00
gregoirenovel
9a7d5d1833
Add Procedure#publiee?
2017-07-13 15:44:18 +02:00
gregoirenovel
cfec05506a
Rename Procedure#archived? -> #archivee?
2017-07-13 15:32:13 +02:00
gregoirenovel
fc2540649f
Add the publiees scope on Procedure
2017-07-13 14:46:07 +02:00
benjaminhenkel
0a060dbb53
Wording spelling mistake
2017-07-13 11:02:30 +02:00
gregoirenovel
bb10e13e2f
[Ref #145 ] Don't use Procedure.archived anymore
2017-07-11 15:03:35 +02:00
gregoirenovel
f55b7914cf
[Ref #144 ] Don't use Procedure.published anymore
2017-07-11 14:51:43 +02:00
Mathieu Magnin
c3fa1e01b9
[ Fix #577 ] Restrict comment creation to Users/Gestionnaires allowed on dossier
2017-07-11 11:01:06 +02:00
Mathieu Magnin
065719ea06
[ Fix #576 ] When user or gestionnaire has no access to dossier, he cannot create an invitation
2017-07-11 10:43:33 +02:00
Simon Lehericey
9d48249660
Attestation: uninterlaced png file to be compatible with Prawn
2017-07-10 10:52:27 +02:00
Mathieu Magnin
aa929bb5b2
[ Fix #554 ] If procedure is hidden, then don't crash
2017-07-06 14:40:06 +02:00
Mathieu Magnin
e51e5afe55
Fix tests that often fail on circle ci when comparing datetimes
2017-07-04 17:17:14 +02:00
Mathieu Magnin
ce171208da
Fix redirect loop for gestionnaire if hidden procedure is saved in procedure_filter
2017-07-04 14:34:26 +02:00
Mathieu Magnin
be3304f71e
Add a scope to Dossier to check if procedure is not hidden
2017-07-04 14:34:16 +02:00
Mathieu Magnin
760efcdad3
Add hidden_at on procedure
2017-07-04 14:33:40 +02:00
Simon Lehericey
12c12953d6
[ FIX #433 ] Add Raven Metadata on the current user/gestionnaire/admin ...
2017-07-04 14:18:46 +02:00
Simon Lehericey
48e881f9ec
[ FIX #491 ] Attestation: allow administrateur to change attestation template on a published procedure
2017-07-04 13:59:54 +02:00
gregoirenovel
84751cdedf
[ Fix #528 ] Fix a spelling mistake
2017-07-04 12:18:13 +02:00
Simon Lehericey
b1d96f4a94
[ FIX #492 ] switch to new attestation download system
2017-07-03 14:09:14 +02:00
Simon Lehericey
4e6a8c5939
New Routes: add new_gestionnaire/dossier_controller attestation
2017-07-03 14:09:14 +02:00
Simon Lehericey
94f8fb748f
New Routes: add new_gestionnaire/procedures_controller
2017-07-03 14:09:14 +02:00
Simon Lehericey
3eec07ac08
New Routes: add new_gestionnaire/gestionnaire_controller
2017-07-03 14:09:14 +02:00
Simon Lehericey
1e661fa686
New Routes: add new_user/dossier_controller attestation
2017-07-03 14:09:14 +02:00
Simon Lehericey
15b16f36b7
New Routes: add new_user/dossier_controller
2017-07-03 14:09:14 +02:00
Simon Lehericey
081ed90968
New Routes: add new_user/user_controller
2017-07-03 14:09:13 +02:00
gregoirenovel
6b90e0ccfa
[Ref #145 ] Record archived_at when archiving a procedure
2017-07-03 10:18:49 +02:00
gregoirenovel
0ec3855f8d
Add a missing test
2017-07-03 10:18:48 +02:00
gregoirenovel
28f2ec1d86
Reorder some tests
2017-07-03 10:18:48 +02:00
gregoirenovel
53b94e0017
Remove tests that test nothing
2017-07-03 10:18:48 +02:00
Simon Lehericey
603e2dd020
ProcedureOverview: reboot model and layout
2017-06-29 16:07:46 +02:00
Simon Lehericey
ee415c4aa6
[ FIX #509 ] add dossier id tag in attestation template
2017-06-28 10:59:14 +02:00
gregoirenovel
aeeb0dd22f
[ Fix #170 ] Keep drop down menu values for annot. privées when cloning
2017-06-27 14:31:33 +02:00
gregoirenovel
556359cd05
[ Fix #318 ] Add annotations privées to exported files
2017-06-27 14:27:02 +02:00
gregoirenovel
bb57002eff
[ Fix #352 ] Downcase admin emails when transferring a procedure
...
See config/initializers/devise.rb:L44
config.case_insensitive_keys = [ :email ]
We therefore need to downcase the email before
looking for an admin by its email address
2017-06-27 14:25:56 +02:00
gregoirenovel
cf5398fe99
Record published_at when publishing a procedure
2017-06-27 13:55:17 +02:00
gregoirenovel
99ee68451a
Add proper tests for Procedure#publish!
2017-06-27 13:55:15 +02:00
gregoirenovel
68b9cd209d
Remove tests that were just testing if Rails worked
2017-06-27 13:55:06 +02:00
Simon Lehericey
3d99407495
[ Fix #499 ] Attestation: add maxlength to footer
2017-06-27 13:35:01 +02:00
Simon Lehericey
84e3d8fbe0
Attestation_template: use etablissement inline_adresse
2017-06-27 11:15:25 +02:00
Simon Lehericey
d69d0f8a78
Etablissement: add inline_adresse
2017-06-27 11:15:25 +02:00
gregoirenovel
0e3ebfd819
[ Fix #183 ] Display “oui” or “non” instead of “true” or “false”
2017-06-26 14:53:38 +02:00
gregoirenovel
469f0aed4b
[ Fix #440 ] Show the current month only if logged in as superadmin
2017-06-26 10:50:31 +02:00
gregoirenovel
ba5d816ce6
[ Fix #176 ] Delete useless new_assignement email
2017-06-26 10:49:42 +02:00
Mathieu Magnin
3f90e82d09
[ Fix #327 ] flashes messages can deal with Arrays
2017-06-21 18:08:05 +02:00
Mathieu Magnin
ac5c00c26f
[ fix #452 ] redesign sign up form
2017-06-21 17:38:38 +02:00
Mathieu Magnin
6777b51331
rename login css to auth, since it will also be used by sign up
2017-06-21 17:38:34 +02:00
Mathieu Magnin
58350f219a
Rewrite tests that should fail so that they actually do
2017-06-20 17:04:54 +02:00
Mathieu Magnin
b68a8b37e8
Redesign the login form
2017-06-19 18:21:15 +02:00
gregoirenovel
d0b927857a
Add stats for encart motivation
2017-06-19 18:01:59 +02:00
gregoirenovel
14823560a1
Expose the motivation on exported files
2017-06-19 15:01:14 +02:00
gregoirenovel
ce2def9c40
Expose the motivation on the API
2017-06-19 15:01:14 +02:00
Simon Lehericey
dd441ff0c7
Attestation: fix mail attachment when the files are remotely stored
2017-06-19 13:47:32 +02:00
Simon Lehericey
5c70d38a23
Attestation: fix missing_attachment
2017-06-16 14:47:44 +02:00
Simon Lehericey
e60ce35ae8
[ Fix #196 ] Attestation: join the attestation to the closed mail
...
Add a upper limit to the attachment size as it could be a problem with Mailjet and receiver
(https://www.mailjet.com/support/what-is-the-size-limit-for-attachments-files-sent-via-mailjet,289.htm )
If the attestation cannot be sent, it is logged in sentry
2017-06-16 12:11:10 +02:00
Simon Lehericey
b664709c3d
[ Fix #196 ] Attestation: allow vizualisation after the procedure is published
2017-06-16 12:11:10 +02:00
Simon Lehericey
671a0575ce
[ Fix #196 ] Recapitulatif: user can download its attestation
2017-06-16 12:11:10 +02:00
Simon Lehericey
602527a09d
[ Fix #196 ] Attestation: building logic from template
2017-06-16 12:11:09 +02:00
Simon Lehericey
c0facbf679
[ Fix #196 ] AttestionTemplate: add preview
2017-06-16 12:11:09 +02:00
Simon Lehericey
fdb4d15bcf
[ Fix #196 ] AttestationTemplate: add edition
2017-06-16 12:11:09 +02:00
Simon Lehericey
d7ff3d6139
[ Fix #196 ] AttestationTemplate: add model
2017-06-16 11:35:13 +02:00
gregoirenovel
12d74be668
Refactor Backoffice::DossiersController#process_dossier
2017-06-13 15:14:51 +02:00
gregoirenovel
88267a990d
[ Fix #197 ] Show the motivation on a dossier’s details
2017-06-13 15:14:48 +02:00
gregoirenovel
33944e343a
Add Backoffice::DossiersController#process_dossier and use it
2017-06-13 15:05:09 +02:00
gregoirenovel
1bff7d1914
Fix incorrect Backoffice::DossiersController tests
2017-06-13 15:05:09 +02:00
gregoirenovel
d248afc376
Enable the Layout/ExtraSpacing cop
2017-06-13 10:35:35 +02:00
gregoirenovel
24e7537c49
Enable the Layout/EmptyLinesAroundClassBody cop
2017-06-13 10:35:32 +02:00
gregoirenovel
f1907f4d0e
Enable the Layout/EmptyLinesAroundBlockBody cop
2017-06-13 10:35:23 +02:00
gregoirenovel
f496f1adab
Enable the Layout/EmptyLines cop
2017-06-13 10:35:20 +02:00
gregoirenovel
a62d5322b6
Enable the Layout/DotPosition cop
2017-06-13 10:35:19 +02:00
gregoirenovel
bc16027ccc
Enable the Layout/BlockEndNewline cop
2017-06-13 10:35:19 +02:00
gregoirenovel
9439e1abb1
Enable the Layout/AlignParameters cop
2017-06-13 10:35:16 +02:00
Mathieu Magnin
b9522ce404
[ Fix #376 ] Before save format champ date to ISO
2017-06-12 14:05:31 +02:00
Mathieu Magnin
41a5ed59f3
[ Fix #376 ] Force every browser to use native input[type=date] on date champ
2017-06-12 14:05:31 +02:00
gregoirenovel
2a74207d15
you_are_invited_on_dossier -> avis_invitation
...
- shorter
- clearer
2017-06-12 10:53:59 +02:00
gregoirenovel
9eb897f721
Fix spacing in auto_archive_procedure_worker_spec.rb
2017-06-08 15:06:01 +02:00
gregoirenovel
107c322062
[ Fix #323 ] Refactor received dossier notification: use a callback
2017-06-08 15:06:01 +02:00
gregoirenovel
ec69086ebc
Don’t use alias_method_chain, use a proxy method
2017-06-08 12:22:48 +02:00
gregoirenovel
bc7fc2634e
Fix test indentation, name and remove a blank line
2017-06-08 12:22:48 +02:00
gregoirenovel
07ea0ceea1
Make MailTemplateConcern.slug a constant
2017-06-08 12:22:44 +02:00
Mathieu Magnin
c52a979199
Fix email collision in tests
2017-06-01 18:11:56 +02:00
gregoirenovel
0971ede57e
Add a termine scope to Dossier
2017-06-01 11:08:00 +02:00
gregoirenovel
5e5a01cdc8
Do not test scopes
2017-06-01 11:07:32 +02:00
gregoirenovel
ab1c19c09b
Rename some Dossier scopes
2017-06-01 10:58:08 +02:00
Mathieu Magnin
8e9144f565
[ Fix #378 ] Remove redirect based on referrer
2017-06-01 10:36:36 +02:00
Simon Lehericey
9e6098dc09
Add the weekly avis answer percentage to Stats
2017-05-31 14:24:33 +02:00
Mathieu Magnin
068b635b7c
Add the weekly avis answer time average to Stats
2017-05-31 14:24:32 +02:00
Simon Lehericey
b5f1b898c7
Add the weekly avis usage to Stats
2017-05-31 13:31:19 +02:00
gregoirenovel
4655707eb5
[ Fix #319 ] Include archived dossiers in the export
2017-05-30 15:41:35 +02:00
Mathieu Magnin
69a5857322
[ Fix #264 ] Add pie chart to count administrations
2017-05-30 15:36:21 +02:00
Simon Lehericey
ae8b126594
ProcedureOverview: use procedure_url to link with absolute path in email
2017-05-30 15:03:51 +02:00
gregoirenovel
3215411547
Delete the 30 days flows graphs
2017-05-30 12:05:28 +02:00
gregoirenovel
711f21c458
[ Fix #264 ] Add the mean filling time graph to Stats
2017-05-30 12:05:27 +02:00
gregoirenovel
faa547e891
[ Fix #264 ] Add the mean instruction time graph to Stats
2017-05-30 12:05:27 +02:00
gregoirenovel
ed7ba60cf0
[ Fix #264 ] Add the last 4 months evolution graphs to Stats
2017-05-30 12:05:26 +02:00
gregoirenovel
0cc5d85f13
Improve the Procedure factory
...
We can now specify how many types_de_champ a
procedure has
2017-05-29 16:11:53 +02:00
gregoirenovel
b820f9d39c
Move a test in the right describe section
2017-05-29 16:11:53 +02:00
Simon Lehericey
64f7cab3cf
Avis: add claimant gestionnaire to track who asks for an avis
2017-05-29 11:44:28 +02:00
Simon Lehericey
cdcd5b951f
AvisController: add a notification when a avis has been received
2017-05-29 11:44:28 +02:00
Simon Lehericey
34a7905828
DossierController: giving an advice does not remove the notifications
2017-05-29 11:44:28 +02:00
Simon Lehericey
3483ec075b
DossierController: extract dossier_id from params[:id]
2017-05-29 11:44:28 +02:00
Simon Lehericey
f9aee06040
AvisController: add redirection logic for various login cases
2017-05-29 11:44:28 +02:00
Simon Lehericey
842999d229
Avis: add create_gestionnaire logic
2017-05-29 11:44:28 +02:00
Simon Lehericey
aaf155df72
Avis: add sign_up logic for new tps gestionnaire
2017-05-29 11:44:28 +02:00
