[Fix #352] Downcase admin emails when transferring a procedure
See config/initializers/devise.rb:L44 config.case_insensitive_keys = [ :email ] We therefore need to downcase the email before looking for an admin by its email address
This commit is contained in:
parent
47e50e3731
commit
bb57002eff
2 changed files with 20 additions and 8 deletions
|
@ -121,7 +121,7 @@ class Admin::ProceduresController < AdminController
|
|||
end
|
||||
|
||||
def transfer
|
||||
admin = Administrateur.find_by_email(params[:email_admin])
|
||||
admin = Administrateur.find_by_email(params[:email_admin].downcase)
|
||||
|
||||
if admin.nil?
|
||||
render '/admin/procedures/transfer', formats: 'js', status: 404
|
||||
|
|
|
@ -500,20 +500,32 @@ describe Admin::ProceduresController, type: :controller do
|
|||
it { expect(subject.status).to eq 404 }
|
||||
end
|
||||
|
||||
context 'when admin is know' do
|
||||
let(:new_admin) { create :administrateur, email: 'new_admin@admin.com' }
|
||||
let(:email_admin) { new_admin.email }
|
||||
context 'when admin is known' do
|
||||
let!(:new_admin) { create :administrateur, email: 'new_admin@admin.com' }
|
||||
|
||||
it { expect(subject.status).to eq 200 }
|
||||
it { expect { subject }.to change(Procedure, :count).by(1) }
|
||||
context "and its email address is correct" do
|
||||
let(:email_admin) { 'new_admin@admin.com' }
|
||||
|
||||
it { expect(subject.status).to eq 200 }
|
||||
it { expect { subject }.to change(Procedure, :count).by(1) }
|
||||
end
|
||||
|
||||
context 'when admin is know but its email was not downcased' do
|
||||
let(:email_admin) { "NEW_admin@adMIN.com" }
|
||||
|
||||
it { expect(subject.status).to eq 200 }
|
||||
it { expect { subject }.to change(Procedure, :count).by(1) }
|
||||
end
|
||||
|
||||
describe "correctly assigns the new admin" do
|
||||
let(:email_admin) { 'new_admin@admin.com' }
|
||||
|
||||
context {
|
||||
before do
|
||||
subject
|
||||
end
|
||||
|
||||
it { expect(Procedure.last.administrateur).to eq new_admin }
|
||||
}
|
||||
end
|
||||
end
|
||||
end
|
||||
end
|
||||
|
|
Loading…
Reference in a new issue