Commit graph

10040 commits

Author SHA1 Message Date
Pierre de La Morinerie
97dc927289
Merge pull request #5002 from betagouv/js-fix-scroll-exceptions
Usager : corrige une erreur Javascript au moment du Feedback, liée à l'utilisation de `window.scroll`
2020-04-06 18:32:11 +02:00
Pierre de La Morinerie
52afb41bab js: fix errors on browsers not supporting window.scroll options
IE and Safari only know about `window.scroll(x, y)`, and not the form
with options.
2020-04-06 18:30:15 +02:00
Pierre de La Morinerie
6dbbaf9528
Merge pull request #4994 from betagouv/add-validation-to-champ
Ajoute une validation pour vérifier la cohérence des champs (#4994)
2020-04-06 18:25:47 +02:00
Christophe Robillard
dc31f41c26 fix tests for procedure_presentation 2020-04-06 17:39:51 +02:00
Christophe Robillard
5b6044803b forbid to create champ with same type_de_champ and same row 2020-04-06 17:39:51 +02:00
Pierre de La Morinerie
0538da3fad
Merge pull request #4993 from betagouv/fix-piece-justificative-in-repetitions
Usager : correction de l'envoi automatique de pièces justificatives dans un bloc répétable
2020-04-06 12:03:49 +02:00
Pierre de La Morinerie
ded65cfdb9 dossier: fix rendering of piece_justificative in repetition
In repetitions we can't render the piece_justificative champ in the way
we do for normal champs (which was already a bit hackish).

Instead we render the whole form partial – and then extract the champ
from the form. In this way, we're sure to render the champ as it
appears in the form, without any hacks to reproduce the form structure.
2020-04-06 11:50:31 +02:00
Pierre de La Morinerie
c506402dcb dossier: remove the now unused champId in auto-upload 2020-04-06 11:50:31 +02:00
Pierre de La Morinerie
91260e2867 dossier: fix upload route of piece_justificative in repetitions
In repetitions, `form.index` doesn't make much sense. Turns out we
don't really need the index of the champ: we can just use the champ id.
2020-04-06 11:50:31 +02:00
krichtof
e869e2741e
Merge pull request #4990 from betagouv/ameliore-decouvrabilite-fichier-telecharge
instructeurs: ameliore la découvrabilité du fichier téléchargé
2020-04-06 11:05:31 +02:00
Christophe Robillard
4fcbfffec1 laisse afficher le message flash avec le fichier à télécharger 2020-04-06 10:12:00 +02:00
Christophe Robillard
290edd9e69 ameliore la découvrabilité du fichier téléchargé 2020-04-06 10:12:00 +02:00
Pierre de La Morinerie
d47ec3d3ad
Merge pull request #4970 from betagouv/improve-identite-required-fields
Usager : simplification de l'apparence des champs sur la page Identité
2020-04-02 18:05:17 +02:00
Pierre de La Morinerie
e166f89aa0 identite: remove the "*" for required labels
When all fields are required, it's better to say nothing.
2020-04-02 17:34:00 +02:00
Pierre de La Morinerie
7f629ffca1 identite: mark the radio buttons as actually required 2020-04-02 17:34:00 +02:00
Kara Diaby
da938d0571
Merge pull request #4950 from betagouv/feat/4893
feat/4893 - migrate the mapReader to mapbox-gl with react
2020-04-02 15:56:09 +02:00
kara Diaby
aa56cfd7a0 migrate map to mapbox-gl with a react component 2020-04-02 15:39:47 +02:00
Paul Chavard
bbaffd7f4b
Merge pull request #4988 from tchak/refactor-expired-tests
Refactor expired dossiers deletion service
2020-04-02 15:35:15 +02:00
Paul Chavard
ca6c97bf0f Refactor expired dossiers deletion service 2020-04-02 15:24:02 +02:00
Paul Chavard
725cfa45d3 Do not set processed_at if already defined 2020-04-02 15:23:53 +02:00
Pierre de La Morinerie
c3b6e7e30f
Merge pull request #4987 from tchak/fix-order-in-test
Les dossier.dossier_operation_logs sont par défaut ordonnés par ordre de création
2020-04-02 14:18:18 +02:00
Paul Chavard
413abccd3c Add default order to dossier.dossier_operation_logs 2020-04-02 14:05:40 +02:00
Pierre de La Morinerie
d7faa7aeab
Merge pull request #4971 from betagouv/autocomplete-identity
Usager : permet au navigateur web de remplir automatiquement les champs prénom, nom et mot de passes
2020-04-02 12:15:51 +02:00
Pierre de La Morinerie
c4f2e6cab0 credentials: add autocomplete attributes
Allow browsers to autofill more informations.

References:
- MDN: Autofill (https://developer.mozilla.org/fr/docs/Web/HTML/Attributs/autocomplete)
- Safari Password Autofill (https://developer.apple.com/documentation/security/password_autofill/enabling_password_autofill_on_an_html_input_element)
2020-04-02 12:07:42 +02:00
Pierre de La Morinerie
8f7a21317a
Merge pull request #4981 from betagouv/fix-champ-policy-for-invite
Usager : corrige les champs Carte, SIRET et pièce justificative pour les invités
2020-04-02 11:43:55 +02:00
Pierre de La Morinerie
059e11601b policies: fix champ policy for guest users 2020-04-02 11:27:14 +02:00
Pierre de La Morinerie
c17ceb4440 policies: DRY the scope 2020-04-02 11:27:14 +02:00
Pierre de La Morinerie
ac922c456e policies: refactor champ_policy_spec
Creating champs without attaching them to a procedure works only by
chance.
2020-04-02 11:27:13 +02:00
Paul Chavard
533b16b6ea
Merge pull request #4976 from tchak/fix-reassign-dossiers-group-instructeur
Reassign discarded dossiers on group_instructeur
2020-04-01 18:30:29 +02:00
Paul Chavard
c0bbfa42b7 Reassign discarded dossiers on group_instructeur
fix #4851
2020-04-01 18:10:12 +02:00
Paul Chavard
d55535b237
Merge pull request #4982 from tchak/prepare_for_more_deletions
Refactor notify near deletion mailers
2020-04-01 18:01:35 +02:00
Paul Chavard
7ba4c513e6 Refactor notify near deletion mailers 2020-04-01 17:40:52 +02:00
Paul Chavard
ccb884df6d
Merge pull request #4944 from tchak/discard-procedures
Discard/Undo Démarches and Dossiers in manager
2020-03-31 20:46:26 +02:00
Paul Chavard
288ace2f34 Dossier on discarded procedure should have access to discarded procedure 2020-03-31 17:08:29 +02:00
Paul Chavard
bd81970f67 DeletedDossier should have access to discarded demarche 2020-03-31 17:08:29 +02:00
Paul Chavard
e4ab2574ce Démarches discarded by administrateur can be reactivated in manager 2020-03-31 17:08:28 +02:00
Paul Chavard
58c126308c Add DiscardedProceduresDeletionJob job 2020-03-31 17:08:28 +02:00
Paul Chavard
da52ec30bd Undo discard dossiers and demarches from manager 2020-03-31 17:08:28 +02:00
Paul Chavard
876e05aed3 Discard demarches from manager 2020-03-31 17:08:28 +02:00
Paul Chavard
89f1f70f0d
Merge pull request #4968 from tchak/clean-up-deleted-dossiers
Clean up deleted dossiers
2020-03-31 17:06:34 +02:00
Paul Chavard
aa066bc20a Validate deleted dossiers dossier_id uniqueness 2020-03-31 16:54:33 +02:00
Paul Chavard
60cb9bcf09 Remove brouillons deleted dossiers 2020-03-31 16:54:33 +02:00
Pierre de La Morinerie
8dcbe5f47c
Merge pull request #4918 from betagouv/auto-upload
Usager : envoi automatique des pièces jointes au dossier (désactivé pour l'instant)
2020-03-31 13:30:18 +02:00
Pierre de La Morinerie
6417c0d2c0 dossiers: allow auto upload of attachments 2020-03-31 13:09:44 +02:00
Pierre de La Morinerie
a1083ca253 javascript: add some comments to the upload systems 2020-03-31 13:09:17 +02:00
Pierre de La Morinerie
2a1c91a2a5
Merge pull request #4960 from betagouv/fix-js-alerts
Javascript : mise à jour d'eslint et de ses dépendences
2020-03-31 13:08:56 +02:00
Pierre de La Morinerie
f4b15da26f js: upgrade eslint and dependencies
Fix vulnerabilities in acorn and minimist.
2020-03-31 13:00:39 +02:00
Pierre de La Morinerie
0f6f447a6c
Merge pull request #4961 from betagouv/remove-wait-for-ajax
Tests : suppression du helper inutilisé `wait-for-ajax`
2020-03-31 13:00:13 +02:00
Pierre de La Morinerie
7a27e78452 specs: remove unused wait-for-ajax helper
This helper is:
- no longer used;
- buggy (not all requests increment it);
- discouraged (we should instead match an UI change that signals the end
of an ajax request).

Good riddance.
2020-03-31 12:54:49 +02:00
Pierre de La Morinerie
34dc554748
Merge pull request #4940 from betagouv/improve-rspec-harness
Simplification de la configuration rspec
2020-03-31 12:54:28 +02:00