Merge pull request #4940 from betagouv/improve-rspec-harness

Simplification de la configuration rspec

.rspec

@@ -1,2 +1,2 @@
 --color
---require spec_helper
+--require rails_helper

spec/controllers/admin/assigns_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Admin::AssignsController, type: :controller do
   let(:admin) { create(:administrateur) }
 

spec/controllers/admin/instructeurs_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Admin::InstructeursController, type: :controller do
   let(:admin) { create(:administrateur) }
   let(:email_2) { 'plip@octo.com' }

spec/controllers/admin/mail_templates_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Admin::MailTemplatesController, type: :controller do
   let(:procedure) { create :procedure }
   let(:initiated_mail) { Mails::InitiatedMail.default_for_procedure(procedure) }

spec/controllers/admin/procedures_controller_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 require 'uri'
 
 describe Admin::ProceduresController, type: :controller do

spec/controllers/administrations/omniauth_callbacks_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Administrations::OmniauthCallbacksController, type: :controller do
   before(:each) do
     @request.env["devise.mapping"] = Devise.mappings[:administration]

spec/controllers/api/v1/dossiers_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe API::V1::DossiersController do
   let(:admin) { create(:administrateur) }
   let(:token) { admin.renew_api_token }

spec/controllers/api/v2/graphql_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe API::V2::GraphqlController do
   let(:admin) { create(:administrateur) }
   let(:token) { admin.renew_api_token }

spec/controllers/api_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe APIController, type: :controller do
   describe 'valid_token_for_procedure?' do
     let(:procedure) { create(:procedure) }

spec/controllers/application_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApplicationController, type: :controller do
   describe 'before_action: set_raven_context' do
     it 'is present' do

spec/controllers/attachments_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe AttachmentsController, type: :controller do
   let(:user) { create(:user) }
 

spec/controllers/champs/carte_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::CarteController, type: :controller do
   let(:user) { create(:user) }
   let(:procedure) { create(:procedure, :published) }

spec/controllers/champs/dossier_link_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::DossierLinkController, type: :controller do
   let(:user) { create(:user) }
   let(:procedure) { create(:procedure, :published) }

spec/controllers/champs/siret_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::SiretController, type: :controller do
   let(:user) { create(:user) }
   let(:procedure) { create(:procedure, :published) }

spec/controllers/concerns/procedure_context_concern_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe ProcedureContextConcern, type: :controller do
   class TestController < ActionController::Base
     include ProcedureContextConcern

spec/controllers/devise/store_location_extension_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe Devise::StoreLocationExtension, type: :controller do
   class TestController < ActionController::Base
     include Devise::Controllers::StoreLocation

spec/controllers/instructeurs/avis_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Instructeurs::AvisController, type: :controller do
   context 'with a instructeur signed in' do
     render_views

spec/controllers/instructeurs/dossiers_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Instructeurs::DossiersController, type: :controller do
   render_views
 

spec/controllers/instructeurs/instructeur_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Instructeurs::InstructeurController, type: :controller do
   describe 'before actions: authenticate_instructeur!' do
     it 'is present' do

spec/controllers/instructeurs/procedures_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Instructeurs::ProceduresController, type: :controller do
   describe "before_action: ensure_ownership!" do
     it "is present" do

spec/controllers/instructeurs/recherche_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Instructeurs::RechercheController, type: :controller do
   let(:dossier) { create(:dossier, :en_construction) }
   let(:dossier2) { create(:dossier, :en_construction, procedure: dossier.procedure) }

spec/controllers/invites_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe InvitesController, type: :controller do
   let(:dossier) { create(:dossier, :en_construction) }
   let(:email) { 'plop@octo.com' }

spec/controllers/ping_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe PingController, type: :controller do
   describe 'GET #index' do
     subject { get :index }

spec/controllers/root_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe RootController, type: :controller do
   subject { get :index }
 

spec/controllers/stats_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe StatsController, type: :controller do
   describe "#last_four_months_hash" do
     context "while a regular user is logged in" do

spec/controllers/support_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe SupportController, type: :controller do
   render_views
 

spec/controllers/users/commencer_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Users::CommencerController, type: :controller do
   let(:user) { create(:user) }
   let(:published_procedure) { create(:procedure, :published) }

spec/controllers/users/confirmations_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Users::ConfirmationsController, type: :controller do
   let!(:user) { create(:user, :unconfirmed) }
   let(:confirmation_token) { user.confirmation_token }

spec/controllers/users/dossiers_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Users::DossiersController, type: :controller do
   let(:user) { create(:user) }
 

spec/controllers/users/passwords_controller_spec.rb

@@ -1,5 +1,3 @@
-require "spec_helper"
-
 describe Users::PasswordsController, type: :controller do
   before do
     @request.env["devise.mapping"] = Devise.mappings[:user]

spec/controllers/users/profil_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Users::ProfilController, type: :controller do
   include ActiveJob::TestHelper
 

spec/controllers/users/user_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Users::UserController, type: :controller do
   describe 'before actions: authenticate_instructeur!' do
     it 'is present' do

spec/controllers/webhook_controller_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe WebhookController, type: :controller do
   describe '#helpscout' do
     before { allow(controller).to receive(:verify_signature!).and_return(true) }

spec/features/admin/admin_creation_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'As an administrateur', js: true do
   let(:administration) { create(:administration) }
   let(:admin_email) { 'new_admin@gouv.fr' }

spec/features/admin/procedure_cloning_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 require 'features/admin/procedure_spec_helper'
 
 feature 'As an administrateur I wanna clone a procedure', js: true do

spec/features/admin/procedure_creation_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 require 'features/admin/procedure_spec_helper'
 
 feature 'As an administrateur I wanna create a new procedure', js: true do

spec/features/admin/procedure_locked_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'procedure locked' do
   let(:administrateur) { create(:administrateur) }
 

spec/features/admin/procedure_update_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 require 'features/admin/procedure_spec_helper'
 
 feature 'Administrateurs can edit procedures', js: true do

spec/features/france_connect/france_connect_particulier_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'France Connect Particulier Connexion' do
   let(:code) { 'plop' }
   let(:given_name) { 'titi' }

spec/features/help_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Getting help:' do
   scenario 'a Help button is visible on public pages' do
     visit '/'

spec/features/instructeurs/expert_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Inviting an expert:' do
   include ActiveJob::TestHelper
   include ActionView::Helpers

spec/features/instructeurs/instructeur_creation_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'As an instructeur', js: true do
   let(:administrateur) { create(:administrateur, :with_procedure) }
   let(:procedure) { administrateur.procedures.first }

spec/features/instructeurs/instruction_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Instructing a dossier:' do
   include ActiveJob::TestHelper
 

spec/features/instructeurs/procedure_filters_spec.rb

@@ -1,5 +1,3 @@
-require "spec_helper"
-
 feature "procedure filters" do
   let(:instructeur) { create(:instructeur) }
   let(:procedure) { create(:procedure, :published, :with_type_de_champ, instructeurs: [instructeur]) }

spec/features/new_administrateur/types_de_champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'As an administrateur I can edit types de champ', js: true do
   let(:administrateur) { procedure.administrateurs.first }
   let(:procedure) { create(:procedure) }

spec/features/outdated_browser_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Outdated browsers support:' do
   context 'when the user browser is outdated' do
     before(:each) do

spec/features/routing/full_scenario_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'The routing', js: true do
   let(:password) { 'a very complicated password' }
   let(:procedure) { create(:procedure, :with_type_de_champ, :with_service, :for_individual) }

spec/features/sessions/sign_in_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Signin in:' do
   let!(:user) { create(:user, password: password) }
   let(:password) { 'démarches-simplifiées-pwd' }

spec/features/users/brouillon_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 feature 'The user' do
   let(:password) { 'démarches-simplifiées-pwd' }
   let!(:user) { create(:user, password: password) }

spec/features/users/change_email_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Changing an email' do
   let(:old_email) { 'old@email.com' }
   let(:user) { create(:user, email: old_email) }

spec/features/users/dossier_creation_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Creating a new dossier:' do
   let(:user)  { create(:user) }
   let(:siret) { '40307130100044' }

spec/features/users/invite_spec.rb

@@ -1,4 +1,3 @@
-require 'spec_helper'
 require 'features/users/dossier_shared_examples.rb'
 
 feature 'Invitations' do

spec/features/users/linked_dropdown_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'linked dropdown lists' do
   let(:password) { 'démarches-simplifiées-pwd' }
   let!(:user) { create(:user, password: password) }

spec/features/users/list_dossiers_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe 'user access to the list of their dossiers' do
   let(:user) { create(:user) }
   let!(:dossier_brouillon)       { create(:dossier, user: user) }

spec/features/users/managing_password_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Managing password:' do
   context 'for simple users' do
     let(:user) { create(:user) }

spec/features/users/sign_out_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Sign out' do
   context 'when a user is logged in' do
     let(:user) { create(:administrateur).user }

spec/features/users/sign_up_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 feature 'Signing up:' do
   let(:user_email) { generate :user_email }
   let(:user_password) { 'démarches-simplifiées-pwd' }

spec/helpers/commentaire_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe CommentaireHelper, type: :helper do
   let(:commentaire) { create(:commentaire, email: "michel@pref.fr") }
 

spec/helpers/conservation_de_donnees_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe ConservationDeDonneesHelper, type: :helper do
   let(:procedure) { build(:procedure, duree_conservation_dossiers_dans_ds: dans_ds, duree_conservation_dossiers_hors_ds: hors_ds) }
 

spec/helpers/dossier_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe DossierHelper, type: :helper do
   describe ".highlight_if_unseen_class" do
     let(:seen_at) { Time.zone.now }

spec/jobs/administrateur_activate_before_expiration_job_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe AdministrateurActivateBeforeExpirationJob, type: :job do
   describe 'perform' do
     let(:administrateur) { create(:administrateur) }

spec/jobs/application_job_spec.rb

@@ -1,4 +1,3 @@
-require 'rails_helper'
 include ActiveJob::TestHelper
 
 RSpec.describe ApplicationJob, type: :job do

spec/jobs/auto_archive_procedure_job_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe AutoArchiveProcedureJob, type: :job do
   let!(:procedure) { create(:procedure, :published, :with_instructeur, auto_archive_on: nil) }
   let!(:procedure_hier) { create(:procedure, :published, :with_instructeur, auto_archive_on: 1.day.ago.to_date) }

spec/jobs/declarative_procedures_job_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe DeclarativeProceduresJob, type: :job do
   describe "perform" do
     let(:date) { Time.utc(2017, 9, 1, 10, 5, 0) }

spec/jobs/find_dubious_procedures_job_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe FindDubiousProceduresJob, type: :job do
   describe 'perform' do
     let(:mailer_double) { double('mailer', deliver_later: true) }

spec/jobs/weekly_overview_job_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe WeeklyOverviewJob, type: :job do
   describe 'perform' do
     let!(:instructeur) { create(:instructeur) }

spec/lib/api_carto/api_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiCarto::API do
   describe '.search_qp' do
     subject { described_class.search_qp(geojson) }

spec/lib/api_carto/cadastre_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiCarto::CadastreAdapter do
   subject { described_class.new(coordinates).results }
 

spec/lib/api_carto/quartiers_prioritaires_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiCarto::QuartiersPrioritairesAdapter do
   subject { described_class.new(coordinates).results }
 

spec/lib/api_entreprise/api_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiEntreprise::API do
   let(:procedure_id) { 12 }
 

spec/lib/api_entreprise/entreprise_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiEntreprise::EntrepriseAdapter do
   let(:siren) { '418166096' }
   let(:procedure_id) { 22 }

spec/lib/api_entreprise/etablissement_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiEntreprise::EtablissementAdapter do
   let(:procedure_id) { 33 }
 

spec/lib/api_entreprise/exercices_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiEntreprise::ExercicesAdapter do
   let(:siret) { '41816609600051' }
   let(:procedure_id) { 11 }

spec/lib/api_entreprise/rna_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ApiEntreprise::RNAAdapter do
   let(:siret) { '50480511000013' }
   let(:procedure_id) { 22 }

spec/lib/asn1/timestamp_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ASN1::Timestamp do
   let(:asn1timestamp) { File.read('spec/fixtures/files/bill_signature/signature.der') }
 

spec/lib/biz_dev_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe BizDev, lib: true do
   let(:first_biz_dev_id) { BizDev::PIPEDRIVE_ID }
   let(:non_biz_dev_id) { first_biz_dev_id - 1 }

spec/lib/helpscout/form_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Helpscout::FormAdapter do
   describe '#send_form' do
     let(:api) { spy(double(:api)) }

spec/lib/helpscout/user_conversations_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Helpscout::UserConversationsAdapter do
   let(:from) { Date.new(2017, 11) }
   let(:to)   { Date.new(2017, 12) }

spec/lib/pipedrive/deal_adapter_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Pipedrive::DealAdapter do
   let(:url) { PIPEDRIVE_API_URL }
   let(:status) { 200 }

spec/lib/tasks/graphql_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe 'graphql' do
   let(:current_defn) { Api::V2::Schema.to_definition }
   let(:printout_defn) { File.read(Rails.root.join('app', 'graphql', 'schema.graphql')) }

spec/lib/tasks/task_helper_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe ProgressReport, lib: true do
   context 'when the count pass above 100%' do
     let(:total) { 2 }

spec/lib/typhoeus/cache/successful_requests_rails_cache.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Typhoeus::Cache::SuccessfulRequestsRailsCache, lib: true do
   let(:cache) { described_class.new }
 

spec/lib/universign/api_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Universign::API do
   describe '.request_timestamp', vcr: { cassette_name: 'universign' } do
     subject { described_class.timestamp(digest) }

spec/mailers/avis_mailer_spec.rb

@@ -1,5 +1,3 @@
-require "rails_helper"
-
 RSpec.describe AvisMailer, type: :mailer do
   describe '.avis_invitation' do
     let(:avis) { create(:avis) }

spec/mailers/dossier_mailer_spec.rb

@@ -1,5 +1,3 @@
-require "rails_helper"
-
 RSpec.describe DossierMailer, type: :mailer do
   let(:to_email) { 'instructeur@exemple.gouv.fr' }
 

spec/mailers/notification_mailer_spec.rb

@@ -1,5 +1,3 @@
-require "spec_helper"
-
 RSpec.describe NotificationMailer, type: :mailer do
   let(:user) { create(:user) }
   let(:procedure) { create(:simple_procedure) }

spec/mailers/user_mailer_spec.rb

@@ -1,5 +1,3 @@
-require "rails_helper"
-
 RSpec.describe UserMailer, type: :mailer do
   let(:user) { build(:user) }
 

spec/middlewares/rack_attack_spec.rb

@@ -1,5 +1,3 @@
-require "rails_helper"
-
 describe Rack::Attack, type: :request do
   let(:limit) { 5 }
   let(:period) { 20 }

spec/models/administrateur_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Administrateur, type: :model do
   let(:administration) { create(:administration) }
 

spec/models/administration_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Administration, type: :model do
   describe '#invite_admin' do
     let(:administration) { create :administration }

spec/models/avis_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe Avis, type: :model do
   let(:claimant) { create(:instructeur) }
 

spec/models/bill_signature_spec.rb

@@ -1,5 +1,3 @@
-require 'rails_helper'
-
 RSpec.describe BillSignature, type: :model do
   describe 'validations' do
     subject(:bill_signature) { BillSignature.new }

spec/models/champ_private_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champ do
   describe '#private?' do
     let(:type_de_champ) { build(:type_de_champ, :private) }

spec/models/champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champ do
   require 'models/champ_shared_example.rb'
 

spec/models/champs/carte_champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::CarteChamp do
   let(:champ) { Champs::CarteChamp.new(value: value) }
   let(:value) { '' }

spec/models/champs/checkbox_champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::CheckboxChamp do
   let(:checkbox) { Champs::CheckboxChamp.new(value: value) }
 

spec/models/champs/decimal_number_champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::DecimalNumberChamp do
   subject { build(:champ_decimal_number, value: value).tap(&:valid?) }
 

spec/models/champs/header_section_champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::HeaderSectionChamp do
   describe '#section_index' do
     let(:types_de_champ) do

spec/models/champs/integer_number_champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::IntegerNumberChamp do
   subject { build(:champ_integer_number, value: value).tap(&:valid?) }
 

spec/models/champs/linked_drop_down_list_champ_spec.rb

@@ -1,5 +1,3 @@
-require 'spec_helper'
-
 describe Champs::LinkedDropDownListChamp do
   describe '#unpack_value' do
     let(:champ) { described_class.new(value: '["tata", "tutu"]') }