Pierre de La Morinerie
75a1046315
active_storage: refactor concerns
...
Follow-up of #5953 .
Refactor the concerns with two goals:
- Getting closer from the way ActiveStorage adds its own hooks.
Usually ActiveStorage does this using an `Attachment#after_create`
hook, which then delegates to the blob to enqueue the job.
- Enqueuing each job only once. By hooking on `Attachment#after_create`,
we guarantee each job will be added only once.
We then let the jobs themselves check if they are relevant or not, and
retry or discard themselves if necessary.
We also need to update the tests a bit, because Rails'
`perform_enqueued_jobs(&block)` test helper doesn't honor the `retry_on`
clause of jobs. Instead it forwards the exception to the caller – which
makes the test fail.
Instead we use the inline version of `perform_enqueued_jobs()`, without
a block, which properly ignores errors catched by retry_on.
2021-03-16 11:49:14 +01:00
Pierre de La Morinerie
c14720d915
Merge pull request #5982 from betagouv/ignore-integrity-errors
...
Jobs : lorsqu'une erreur ActiveStorage::IntegrityError se produit pendant le scan des virus, le job est maintenant automatiquement retenté plus tard.
2021-03-16 10:58:53 +01:00
Pierre de La Morinerie
08094e5384
jobs: retry on ActiveStorage::IntegrityError during virus scan
...
This is the same setting than what ActiveStorage::AnalyzeJob uses.
2021-03-16 10:52:12 +01:00
LeSim
3d76319424
Merge pull request #5981 from betagouv/disable-rails-ip-spoofing
...
config: avoid blocking legitimate requests from mobile ISPs
2021-03-16 09:19:40 +01:00
Pierre de La Morinerie
70104d7059
config: avoid blocking legitimate requests from mobile ISPs
2021-03-11 18:28:10 +01:00
Paul Chavard
e42d6f4f14
Merge pull request #5977 from tchak/fix-carto
...
Fix invalid GeoJSON handling
2021-03-11 15:58:08 +01:00
Paul Chavard
6f543d3770
Handle invalid GeoJSON in the editor
2021-03-11 15:51:09 +01:00
Paul Chavard
c37feba8d1
Remove invalid geo areas
2021-03-11 15:51:09 +01:00
Paul Chavard
a7fb7bf1ef
Add geo json validation
2021-03-11 15:51:09 +01:00
Paul Chavard
4c9305dbb1
Merge pull request #5978 from tchak/fix-data-fetch-jobs
...
Try to reduce the number of external data fetches
2021-03-11 15:03:53 +01:00
Paul Chavard
d24ee27cac
Try to reduce the number of external data fetches
...
Only fetch external data if the external_id is the current one and data is not yet fetched
2021-03-11 14:56:37 +01:00
Paul Chavard
21d5da379f
remove unused job
2021-03-11 14:56:37 +01:00
LeSim
6e95d1c710
Merge pull request #5976 from tchak/relax-etablissement-validations
...
capital_social and numero_tva_intracommunautaire can be null
2021-03-11 13:38:03 +01:00
Paul Chavard
bee66d41c4
capital_social and numero_tva_intracommunautaire can be null
2021-03-11 11:13:50 +01:00
Kara Diaby
2c724cbec3
Merge pull request #5973 from betagouv/claimant-type-to-avis-table-fix
...
Claimant type to avis table fix
2021-03-10 15:26:58 +01:00
kara Diaby
53ba442235
fix after party task
2021-03-10 09:04:23 +01:00
kara Diaby
6383e6b9e7
Revert "Revert "Claimant type to avis table""
...
This reverts commit f4fd220d43
.
2021-03-10 08:48:55 +01:00
Pierre de La Morinerie
873cea8c86
Merge pull request #5972 from betagouv/rspec-5
...
Mise à jour de rspec 3 vers rspec 5
2021-03-09 15:58:37 +01:00
Pierre de La Morinerie
4c3fcfeec2
specs: upgrade to rspec 5
...
Rspec 5 is compatible with Rails 6.1.
2021-03-09 15:51:19 +01:00
Pierre de La Morinerie
5bf499baa0
specs: remove rspec_junit_formatter
...
It was unsed by CircleCI to generate test reports in the JUnit XML
format, but:
- We now use Github Actions, which has its own reporting system,
- It prevents us to upgrade to rspec > 3.
2021-03-09 15:51:19 +01:00
Paul Chavard
6b52390324
Merge pull request #5934 from tchak/blank-default-groupe-instructeur
...
Le sélecteur du groupe instructeur est vide par défaut
2021-03-09 14:54:43 +01:00
Paul Chavard
00d7c3186a
fix indentation
2021-03-09 14:47:23 +01:00
Paul Chavard
70500e3d56
Groupe instructeur selector default blank
2021-03-09 14:47:23 +01:00
Paul Chavard
9c3e72c84a
Use revision instead of groupe instructeur as dossier procedure link
2021-03-09 14:47:23 +01:00
Pierre de La Morinerie
1e10298859
Merge pull request #5967 from betagouv/dependabot/npm_and_yarn/elliptic-6.5.4
...
build(deps): bump elliptic from 6.5.3 to 6.5.4
2021-03-09 14:27:35 +01:00
dependabot[bot]
f87efe9670
build(deps): bump elliptic from 6.5.3 to 6.5.4
...
Bumps [elliptic](https://github.com/indutny/elliptic ) from 6.5.3 to 6.5.4.
- [Release notes](https://github.com/indutny/elliptic/releases )
- [Commits](https://github.com/indutny/elliptic/compare/v6.5.3...v6.5.4 )
Signed-off-by: dependabot[bot] <support@github.com>
2021-03-09 13:20:03 +00:00
Paul Chavard
c2fed3f952
Merge pull request #5969 from tchak/remove-circle-ci
...
Remove circle ci config
2021-03-09 14:03:13 +01:00
Paul Chavard
d04d9ea5d8
Remove circle ci config
2021-03-09 13:50:45 +01:00
Kara Diaby
8157fe8c5c
Merge pull request #5971 from betagouv/revert-5965-claimant-type-to-avis-table
...
Revert "Claimant type to avis table"
2021-03-09 13:49:07 +01:00
Kara Diaby
f4fd220d43
Revert "Claimant type to avis table"
2021-03-09 13:40:10 +01:00
Pierre de La Morinerie
0c5ad449c5
Merge pull request #5968 from tchak/fix-carto-ie-again
...
Correction (à nouveau) du chargement des cartes dans Internet Explorer 11 (#5968 )
2021-03-09 11:46:54 +01:00
Paul Chavard
1644c9d44b
Another attempt at fixing IE
2021-03-09 11:29:20 +01:00
Kara Diaby
d124512336
Merge pull request #5965 from betagouv/claimant-type-to-avis-table
...
Claimant type to avis table
2021-03-09 11:04:15 +01:00
kara Diaby
0870ebfd90
After party backfill claimant type on avis table
2021-03-09 10:15:19 +01:00
kara Diaby
0211d1f105
modify create_avis_concern
2021-03-07 22:47:53 +01:00
kara Diaby
af4a27f4e0
add claimant type on avis table
2021-03-07 22:47:24 +01:00
krichtof
bdcce19841
Merge pull request #5963 from tchak/fix-association-serilizer
...
Make more association fields nullable
2021-03-05 10:26:22 +01:00
Paul Chavard
82fca8be0b
Make more association fields nullable
2021-03-05 10:13:22 +01:00
Paul Chavard
5525fc7be8
Merge pull request #5962 from betagouv/fix-invalid-proc
...
fix limit date for notice validation
2021-03-05 09:46:32 +01:00
Christophe Robillard
6169399a6b
fix limit date for notice validation
2021-03-05 08:34:39 +01:00
Pierre de La Morinerie
3969556e31
Merge pull request #5960 from betagouv/fix-warnings
...
Suppression de nouveaux messages d'avertissements pendant les tests et lors de l'exécution de commandes `bin/rails` (#5960 )
2021-03-04 23:07:33 +01:00
Pierre de La Morinerie
f9401cfbad
spec: better split spec_helper and rails_helper
...
This fixes the
> DEPRECATION WARNING: Initialization autoloaded the constants ActionText::ContentHelper and ActionText::TagHelper.
error appearing when running specs.
It also gets us closer from a newly-generated rails config.
2021-03-04 22:59:39 +01:00
Pierre de La Morinerie
71c4ce67b2
gemfile: don't require i18n-tasks by default
...
i18n-tasks is only used as a standalone command-line tool. It doesn't
need to be included in the app.
It also prevent a parser warning from appearing when running any rails
command:
> warning: parser/current is loading parser/ruby27, which recognizes
> warning: 2.7.2-compliant syntax, but you are running 2.7.1.
> warning: please see https://github.com/whitequark/parser#compatibility-with-ruby-mri .
Now this (legitimate) warning only appears when running the i18n-tasks
command.
2021-03-04 22:52:19 +01:00
Pierre de La Morinerie
b0735aafe0
config: fix DynamicSmtpSettingsInterceptor warning again
...
This warning re-appeared when running mailer tests:
```
DISABLE_SPRING=1 bin/rspec spec/mailers/administration_mailer_spec.rb
```
It is now fixed properly, in a way recommanded by the documentation.
2021-03-04 22:52:19 +01:00
krichtof
abb8b04208
Merge pull request #5961 from tchak/fix-carto
...
fix mapbox-gl transpilation
2021-03-04 19:46:40 +01:00
Paul Chavard
d4a34edab5
fix mapbox-gl transpilation
2021-03-04 19:04:39 +01:00
Pierre de La Morinerie
c8d775af29
Merge pull request #5958 from tchak/make_association_date_creation_nullable
...
GraphQL : corrige la date de création des associations
2021-03-04 16:41:24 +01:00
Paul Chavard
47e232f439
Some associations have no date_creation
2021-03-04 16:28:20 +01:00
krichtof
2a5d7cf696
Merge pull request #5957 from betagouv/fix-invalid-proc
...
no validation for old procedures
2021-03-04 16:26:31 +01:00
Christophe Robillard
7f496c43e5
no validation for old procedures
2021-03-04 16:13:19 +01:00