Paul Chavard
a6cf311f56
Revert "if is not only in draft, its gonna be cloned anyway"
...
This reverts commit 71e9240a7d
.
2022-05-18 22:53:39 +02:00
simon lehericey
74653631c3
few comments
2022-05-18 22:23:31 +02:00
simon lehericey
71e9240a7d
if is not only in draft, its gonna be cloned anyway
2022-05-18 22:23:31 +02:00
simon lehericey
20288fbb7d
revise_type_de_champ -> replace_tdcs_and_children_by_clones
2022-05-18 22:15:22 +02:00
simon lehericey
e7524b3f0d
extract var
2022-05-18 21:59:31 +02:00
Paul Chavard
0e335f58ac
fix(revision): update children coordinate instead of duplicating
2022-05-18 19:39:20 +02:00
Pierre de La Morinerie
49410ff5f7
models: update database comments
2022-05-18 15:39:33 +02:00
simon lehericey
419d853d1d
add target_revision on rebase
2022-05-18 15:18:17 +02:00
simon lehericey
8bd3de2050
remove use of repetition.types_de_champ (except rebase)
2022-05-18 15:18:17 +02:00
Martin
58d205a022
fix(dossier_vide.pdf.prawn): avoid overlap on for multiline label on label
2022-05-18 15:13:15 +02:00
simon lehericey
1921661fad
simplify children_of
2022-05-18 12:30:58 +02:00
simon lehericey
633f0d1ce5
remove_repetition
2022-05-18 12:12:25 +02:00
simon lehericey
4d97f6aa8c
types_de_champ_for_revision
2022-05-18 11:40:34 +02:00
Paul Chavard
6c2a3bafa4
refactor(dossier): champs order by coordinate
2022-05-18 11:20:50 +02:00
simon lehericey
09744839f1
in manager dossier
2022-05-18 10:43:08 +02:00
simon lehericey
be33c0ce7b
extract coordinate_and_tdc
2022-05-18 10:11:31 +02:00
simon lehericey
7f23449f24
remove set_position
2022-05-18 10:11:31 +02:00
Paul Chavard
0dfc015690
feat(dossiers): bring back export all dossiers
2022-05-17 18:34:00 +02:00
Paul Chavard
e33022ffc7
refactor(dossier): export to use turbo-poll
2022-05-17 16:08:47 +02:00
Paul Chavard
e9b02642c5
refactor(attachment): attachments controller to use turbo
2022-05-17 16:08:47 +02:00
Paul Chavard
32bd1b6d9f
refactor(attachment): remove unused helpers
2022-05-17 16:08:47 +02:00
Paul Chavard
bc77390cfe
refactor(attachment): use new components
2022-05-17 16:08:47 +02:00
Paul Chavard
2ce389d474
refactor(dossier): add Dossier::ExportComponent
2022-05-17 16:08:47 +02:00
Paul Chavard
7e1c793728
refactor(attachment): add Attachment::ShowComponent
2022-05-17 16:08:47 +02:00
Paul Chavard
d6384caf10
refactor(attachment): add Attachment::EditComponent
2022-05-17 16:08:47 +02:00
Paul Chavard
57c55107c0
feat(turbo): longer dely before hiding flash messages
2022-05-17 16:08:47 +02:00
Paul Chavard
df914d273f
feat(turbo): add turbo-poll controller
2022-05-17 16:08:47 +02:00
Paul Chavard
2eb7da5227
fix(dossier): redirect on not found dossiers
2022-05-17 11:42:10 +02:00
Paul Chavard
b6ea44f7e7
refactor(revision): remove type_de_champ#revision_id
2022-05-17 11:31:49 +02:00
Pierre de La Morinerie
51512ff733
views: clarify why contact informations are important
2022-05-17 10:45:34 +02:00
Pierre de La Morinerie
c0b96bfecb
views: improve Service breadcrumbs
...
- Make the procedure name shorter
- Capitalize the words
2022-05-17 10:45:34 +02:00
Paul Chavard
e8c875a461
fix(fetch): prevent double parsing of fetch error messages
2022-05-17 10:38:19 +02:00
Pierre de La Morinerie
0063b68689
mailers: add deposit receipt to initiated_mail
...
See #6146
2022-05-17 10:25:13 +02:00
Martin
bb96d49743
fix(recherche#index): move paginate outside of table row loop
2022-05-16 15:56:02 +02:00
Paul Chavard
6d0b3d93ed
fix(autosave): prevent autosave if current champ is detached from the form
2022-05-16 14:07:02 +02:00
Paul Chavard
246db0e1cf
fix(menu-button): should be a button
2022-05-16 09:44:30 +02:00
Paul Chavard
e193c652e7
fix(recherche): expert actions should be a menu-button
2022-05-16 09:44:10 +02:00
Paul Chavard
95bd13872b
refactor(dossier): change state with turbo
2022-05-13 17:38:09 +02:00
Paul Chavard
8d9929aa9f
fix(revision): (re)move child type de champ should clone parent for now
2022-05-13 17:17:24 +02:00
Paul Chavard
85c20784a2
refactor(revision): delete unused code
2022-05-13 17:17:23 +02:00
Paul Chavard
d7678c4389
Revert "Merge pull request #7295 from tchak/rollback-attempt"
...
This reverts commit 24b37c230d
, reversing
changes made to 08b90b9173
.
2022-05-13 17:17:23 +02:00
Martin
a7bb6f1627
feat(links): add link to www.solidarite-numerique.fr
2022-05-13 15:25:04 +02:00
Martin
da57a1dc9e
fix(commencer#commencer): broken due to missing interpolated variable in i18n
2022-05-13 13:15:31 +02:00
Kara Diaby
e99bd5f558
models
2022-05-13 10:31:51 +02:00
Kara Diaby
897d5571f7
layout
2022-05-13 10:31:51 +02:00
mfo
c6ef17341b
Merge branch 'main' into sentry/3267070633
2022-05-12 16:41:33 +02:00
Martin
0826baeba3
bug(commencer#commencer): raise when procedure does not have a service
...
fix(commencer#commencer): use alternate message when procedure does not have a service
2022-05-12 16:41:11 +02:00
Paul Chavard
6adb3f7a3a
fix(revision): fix migrate_parent!
2022-05-12 10:40:41 +02:00
Paul Chavard
edf0cbf320
bring back find_type_de_champ_by_stable_id old implementation
2022-05-11 20:29:01 +02:00
Paul Chavard
4c26e34c79
Revert "Merge pull request #7270 from betagouv/remove_type_de_champ_v2"
...
This reverts commit 41b6f8f51b
, reversing
changes made to 79d5946ab6
.
2022-05-11 20:03:42 +02:00
Paul Chavard
08caa122dd
Revert "Merge pull request #7280 from betagouv/move_type_de_champ_v2"
...
This reverts commit 08b90b9173
, reversing
changes made to bc9a90bd08
.
2022-05-11 20:03:33 +02:00
simon lehericey
5d6dd853d4
refactor reorder: add order_place only in children
2022-05-11 16:54:26 +02:00
simon lehericey
df91fd1180
move_type_de_champ new style
2022-05-11 16:54:26 +02:00
Paul Chavard
2e8bc7e1d0
fix(js): polyfill Node.isConnected for IE
2022-05-11 16:23:42 +02:00
Paul Chavard
771a92a5e2
refactor(menu-button): use menu button controller
2022-05-11 16:23:42 +02:00
Paul Chavard
b076ecaf96
feat(a11y): implement accessible menu button
2022-05-11 16:23:42 +02:00
simon lehericey
b6c2aa30f4
reorder the siblings after deletion
2022-05-11 15:59:17 +02:00
simon lehericey
5dd8bbe797
fix remove type de champ
2022-05-11 15:59:17 +02:00
Paul Chavard
10f6378cf0
fix(upload): silence common client errors in sentry
2022-05-11 13:44:50 +02:00
Paul Chavard
142e6c032c
cleanup(dossier): remove legacy menu
2022-05-11 11:01:25 +02:00
Paul Chavard
531464fab1
fix(js): bring back js request for now
2022-05-11 09:34:19 +02:00
Paul Chavard
c9b8d43acd
feat(autosave): use new autosave controller
2022-05-10 18:10:20 +02:00
Paul Chavard
3fea34732e
feat(autosave): add stimulus autosave-status controller
2022-05-10 18:10:20 +02:00
Paul Chavard
adb19a941f
feat(autosave): add stimulus autosave controller
2022-05-10 18:10:20 +02:00
Paul Chavard
525eebf600
feat(js): implement auto upload class
2022-05-10 18:10:20 +02:00
Paul Chavard
b29116817b
refactor(js): improuve uploader
2022-05-10 18:10:20 +02:00
Paul Chavard
ce58ab98c1
refactor(js): move around stimulus initializers
2022-05-10 18:10:20 +02:00
Paul Chavard
39761f45a0
cleanup(js): remove old autosave/autoupload code
2022-05-10 18:10:20 +02:00
Paul Chavard
3d8980f686
feat(httpRequest): add error body parsing
2022-05-10 18:10:20 +02:00
Paul Chavard
12884e0242
cleanup(js): remove unused utils
2022-05-10 18:10:20 +02:00
Paul Chavard
59c6fd1763
refactor(ts): improuve utils types
2022-05-10 18:10:20 +02:00
Paul Chavard
9b01b2cff9
feat(stimulus): add onGlobal helper
2022-05-10 18:10:20 +02:00
Kara Diaby
513f749e72
layout
2022-05-10 16:16:16 +02:00
Kara Diaby
d187b7e881
model
2022-05-10 16:16:16 +02:00
Kara Diaby
990fc04b03
controller
2022-05-10 16:16:16 +02:00
Martin
bf277d4802
bug(export): expect dossiers_for_export not to include dossiers brouillon
...
fix(export.dossiers_for_export): add missing visible_by_administration
2022-05-10 16:09:12 +02:00
simon lehericey
d2509e7492
add procedure_revision children_of
2022-05-10 14:52:57 +02:00
Paul Chavard
c5addb4829
fix(turbo): use link_to instead of submit button
2022-05-10 13:39:33 +02:00
Paul Chavard
219fc2f3bc
fix(turbo): patch turbo to make link_to work without global turbo enabled
2022-05-10 13:39:33 +02:00
Paul Chavard
83afe1ad8c
fix(multiselect): allow to have options with the same label
2022-05-10 13:30:40 +02:00
Pierre de La Morinerie
2bd4599190
views: truncate procedure title in Experts breadcrumbs
2022-05-10 12:55:16 +02:00
Pierre de La Morinerie
3bdbf7bb4c
views: align Expert header actions to the right
2022-05-10 12:54:02 +02:00
Pierre de La Morinerie
41cf700c15
spec: fix avis/instruction view spec
...
Due to a faulty naming convention, the test was not executed.
2022-05-10 12:51:27 +02:00
Martin
75da4d8c8d
Revert "migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id"
...
This reverts commit 19360e7aac
.
2022-05-09 18:45:35 +02:00
Martin
19360e7aac
migration(fix.data): when a repetable revision_types_de_champ points to a non active revision type de champs, relink it to the actuel revision_type_de_champs pointing to the stable id of its parent.type_de_champ.stable_id
2022-05-09 18:01:02 +02:00
simon lehericey
4ec5b418cb
fix create_new_revision
2022-05-06 12:37:59 +02:00
simon lehericey
5040b877d1
remove unused franceconnect.js
2022-05-06 11:50:32 +02:00
Paul Chavard
9e0b3b642f
cleanup(sendinblue): remove sendinblue tracking
2022-05-06 11:14:44 +02:00
Paul Chavard
842506f993
refactor(revision): rename revision methods params to reflect usage of stable_id
2022-05-06 11:08:58 +02:00
Paul Chavard
98814c3812
refactor(revision): test for type_de_champ having a unique revision
2022-05-06 11:08:51 +02:00
simon lehericey
ce0a592f3c
simplify find_type_de_champ_by_id
2022-05-06 10:34:40 +02:00
Martin
ba7a316f5e
fix(Dossier.for_export): instead of iterating champs to build an hash {stable_id: values} ; we iterate on the list of all type de champs, so when there is a type de champ with mutliple values for export, we build the column with the nil value
2022-05-06 09:38:45 +02:00
Kara Diaby
5f6f19871f
tests
2022-05-06 09:04:15 +02:00
Kara Diaby
39edea5541
Ajoute dans l'interface usager le contact du service de la démarche en cas de cloture ou suppression
2022-05-05 15:22:34 +02:00
Paul Chavard
dcd9e44ce7
fix(dossier): on dossier update render empty js response
2022-05-05 13:39:24 +02:00
Martin
3737311390
feat(procedure.procedure_expires_when_termine_enabled): enable by default, allow contributor to choose the default settings of this flag using an env var during migration. ie: DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED=true|false
...
feat(administrateurs/procedures#show): warning/alert when procedure_expires_when_termine_enabled is not true on current procedure
feat(administrateur/procedure#update): after an update redirect to procedure show: suggested by: https://ux.stackexchange.com/questions/55291/after-updating-form-should-redirect-back-to-form-itself-or-to-the-show-page-or-b and confirmed by Olivier
clean(Flipper.archive_zip_globale): no more in use, so remove all occurences
Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
Update app/views/administrateurs/procedures/_suggest_expires_when_termine.html.haml
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
Update spec/views/administrateurs/procedures/show.html.haml_spec.rb
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
fix(review): typo, why ena?, who knows
fix(env.example.optional): add missing DEFAULT_PROCEDURE_EXPIRES_WHEN_TERMINE_ENABLED
2022-05-05 13:07:11 +02:00
Paul Chavard
fa1bc0b88b
fix(dossier): annotations privées form
2022-05-05 12:42:58 +02:00
Paul Chavard
4307445999
fix(js): prevent old Edge from crashing
2022-05-05 09:35:53 +02:00
Pierre de La Morinerie
63b1ff9e2d
dossiers: fix wrong use of created_at in the deposit receipt
2022-05-04 17:41:21 +02:00
Pierre de La Morinerie
982a209e7d
dossiers: use the depose_at date in the deposit recepit
...
A dossier has several submission dates:
- `depose_at` is the first date at which the dossier was submitted
- `en_construction_at` is the last date at which the dossier was
submitted OR reverted from `en_instruction` to `en_construction`.
For now we prefer to display the earliest date:
- it gives more rights to the user,
- en_construction_at means the administration can reset at will the date
printed on deposit receipts (by moving the dossier `en_instruction`
and then back), which we don't want.
2022-05-04 17:41:21 +02:00