Commit graph

11793 commits

Author SHA1 Message Date
Paul Chavard
81c325f938 chore(task): another attempt to backfill stable_id 2024-04-04 17:55:38 +02:00
Lisa Durand
5155049873 remove column with checkbox if no batch actions 2024-04-04 17:17:03 +02:00
simon lehericey
42af5a9149
make cron_job work with both delayed_job and sidekiq 2024-04-04 16:38:38 +02:00
Paul Chavard
38a703034e feat(champ): expose paths 2024-04-04 16:13:23 +02:00
Corinne Durrmeyer
8039464541
feat(improve-contact-page-a11y) : Replace %span.mandatory * with AsteriskMandatoryComponent 2024-04-04 14:53:51 +02:00
Corinne Durrmeyer
9dab2afc11
feat(improve-contact-page-a11y) : Replace 'All fields are mandatory.' with 'Fields marked by an asterisk are mandatory' - fix #10264 2024-04-04 14:53:51 +02:00
Corinne Durrmeyer
5523dd4b35
feat(improve-contact-page-a11y) : Remove useless <h2> around paragraphs - fix #8212 #10264 2024-04-04 14:53:51 +02:00
Paul Chavard
9593e8825f chore(browser): be more agressive about browser deprecation 2024-04-04 13:53:41 +02:00
Colin Darie
c005991470
Merge pull request #10230 from demarches-simplifiees/fix-alert-for-closed-procedures-in-dossiers-list
Correctif : affiche correctement le lien vers la page de fermeture dans la liste des dossiers
2024-04-04 09:44:55 +00:00
Colin Darie
8af3f07181
Merge pull request #10231 from colinux/fix-gouv-fr-banner
Tech: petites corrections pour le .gouv
2024-04-04 09:02:03 +00:00
Eric Leroy-Terquem
8d7c078f92
fix(dossiers list): display link correctly 2024-04-04 09:44:37 +02:00
Corinne Durrmeyer
1cd552c79f
feat(move_after_edit_list) : Add new line at end of file to avoid lint error 2024-04-04 09:39:40 +02:00
Colin Darie
0c4a4c8764
Merge pull request #10232 from demarches-simplifiees/redirect-fermeture-to-commencer-if-procedure-not-closed
Correctif: redirige la page fermeture vers la page commencer si la démarche n'est pas fermée
2024-04-04 07:34:23 +00:00
Colin Darie
df59503ab7
Merge pull request #10224 from colinux/mail-host
Tech (mailers): `from`, liens et application en respectent le preferred domain du destinataire
2024-04-04 07:25:43 +00:00
LeSim
3f54d46f19
Merge pull request #10258 from demarches-simplifiees/fix_strange_locale
tech: verifie que la locale est disponible
2024-04-03 07:11:12 +00:00
simon lehericey
fc8d5adf2f
fix: avoid buggy locale from user 2024-04-02 21:53:56 +02:00
Colin Darie
8c0375fe6f
chore: easier to test .gouv / new host using APP_HOST 2024-04-02 19:36:39 +02:00
Colin Darie
033b2fa63d
chore(banner): easier with hardcoded .gouv.fr name 2024-04-02 19:36:37 +02:00
Colin Darie
d5515fca33
fix(banner): not closed form tag broke JS 2024-04-02 19:36:35 +02:00
Colin Darie
95e80d6ce3
fix(layout): header text alignemnt 2024-04-02 19:25:46 +02:00
Colin Darie
36fc535386
refactor(mailer): for devise mailer set locale in dedicated action 2024-04-02 19:25:44 +02:00
Colin Darie
172aeec3dc
chore(mail): replace textual logo with simple logo + application name as text 2024-04-02 18:47:53 +02:00
Colin Darie
df198a8946
style(mailer): big button in dsfr style 2024-04-02 18:47:51 +02:00
Colin Darie
68ee4a3404
feat(mail): use contextualized Current.application_name 2024-04-02 18:47:48 +02:00
Colin Darie
8b9d4c87f7
refactor(mailer): more thread safe defaults tweaks 2024-04-02 18:47:47 +02:00
Colin Darie
21991d7253
feat(mail): link with hosts for recipient for user mailer 2024-04-02 18:47:46 +02:00
Colin Darie
5bf580b6ac
feat(mail): link with hosts for recipient for notification mailer 2024-04-02 18:47:45 +02:00
Colin Darie
f8a9e72aa2
feat(mail): from and link with host for recipient in dossier_mailer 2024-04-02 18:47:44 +02:00
Colin Darie
3512e071d3
feat(mail): devise mailer respect user preferred host for any mail 2024-04-02 18:47:43 +02:00
Colin Darie
d14fe83261
feat(mail): devise confirmation instructions respect user preferred host 2024-04-02 18:47:41 +02:00
Paul Chavard
0006a12aea
Update app/models/dossier.rb
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-04-02 18:09:29 +02:00
Paul Chavard
7cf1cdb47b fix(champ): do not expose champs without row_id in repetitions 2024-04-02 17:51:57 +02:00
Corinne Durrmeyer
84f0165520
feat(move_after_edit_list) : Remove useless aria attribute - fix #10254 2024-04-02 17:23:25 +02:00
Corinne Durrmeyer
d54bac71bf
feat(move_after_edit_list) : Improve the "move after" edit list - fix #10206 2024-04-02 17:23:25 +02:00
Corinne Durrmeyer
a5a7e880eb
feat(move_after_edit_list) : Correct a typo - fix #10254 2024-04-02 17:23:25 +02:00
LeSim
2ea45d5dba
Merge pull request #10251 from colinux/exports-reduce-memory
Tech (exports): télécharge les PJ > 10mb en chunks pour ne pas les mettre en mémoire
2024-04-02 14:48:33 +00:00
Colin Darie
fe12df1892
Merge pull request #10252 from demarches-simplifiees/more_log_to_adresse_controller
Tech: ajoute des metadata pour débugger un pb sur l'adresse controller
2024-04-02 14:16:37 +00:00
Paul Chavard
94aef62e87
Merge pull request #10253 from tchak/chore-task-stable-id
chore(task): reduce batch size of fill stable id task
2024-04-02 14:10:22 +00:00
Paul Chavard
61a6f0b382
Merge pull request #10243 from demarches-simplifiees/small_job_fixes
Tech: petites corrections pour éviter les réessais inutile sur les jobs de mail et de rnf
2024-04-02 14:09:55 +00:00
Paul Chavard
792bf47658 chore(task): reduce batch size of fill stable id task 2024-04-02 15:55:44 +02:00
Colin Darie
e23e2d9c31
perf(export): download in chunks files >= 10 mb 2024-04-02 15:54:46 +02:00
simon lehericey
57927a3783
chore: more log to address controller errors 2024-04-02 15:47:11 +02:00
mfo
b245d9b063
Merge pull request #10220 from demarches-simplifiees/fix-drop-down-missing-hint
ETQ usager : Champ choix multiple, ajouter une aide a a la saisie
2024-04-02 09:28:34 +00:00
mfo
84f0891a8b
Merge pull request #10245 from demarches-simplifiees/US/fix-attestation-link
correctif(lien.attestation): ETQ expert, je souhaite avoir accès à l'attestation même si je ne suis pas instructeur
2024-04-02 08:14:37 +00:00
mfo
e40ef51f61
Merge pull request #10247 from colinux/fix-export-memory-leak
Tech: fix memory leak pendant le téléchargement des PJ des exports
2024-04-02 08:14:28 +00:00
mfo
3a895fbd4a
tech(review): add a guard clause to prevent missing pdf, enhance specs 2024-04-02 10:04:22 +02:00
simon lehericey
8405c83c12
fix: do not retry rnf bad request 2024-04-02 10:00:07 +02:00
simon lehericey
dd6c558541
fix: discard deserialization error as there are raised from AR not found 2024-04-02 10:00:06 +02:00
mfo
4da36531d4
Merge pull request #10242 from demarches-simplifiees/US/fix-decimal-number-validator
Correctif(annotations privées): ETQ instructeur, je ne pouvais modifier une annotation quand un usager avait saisi des valeur de champs incorrectes
2024-04-02 07:13:07 +00:00
Colin Darie
f9af570cab perf(export): fix memory leak after large files downloads 2024-04-01 20:03:35 +02:00
Paul Chavard
13005b0a4a fix(dossier): enqueue jobs after commit 2024-04-01 19:00:25 +02:00
Paul Chavard
5d302fb6ac refactor(dossier): extract aasm callbacks in to a concern 2024-04-01 18:55:08 +02:00
mfo
e08aa7d28b
wip(validates): prefill and validate_champ_value? on all other missing validation checks 2024-04-01 07:36:14 +02:00
mfo
284a10e235
fix(Champs::EngagementJuridiqueChamp): validates Champs::EngagementJuridiqueChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
ff527517c9
fix(Champs::CiviliteChamp): validates Champs::CiviliteChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
94ea16c894
fix(Champs::BooleanChamp): validates Champs::BooleanChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
d7f152f4af
fix(Champs::PhoneChamp): validates Champs::PhoneChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
374d763084
fix(Champs::IntegerNumberChamp): validates Champs::IntegerNumberChamp respecting it's validation context. 2024-04-01 07:18:13 +02:00
mfo
fd5faad31f
fix(Champs::PaysChamp): validates Champs::PaysChamp respecting it's validation context. Also do not save value when external_id/code can't be found by lookup 2024-04-01 07:18:13 +02:00
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context 2024-04-01 07:07:11 +02:00
Martin
2944a0c2c3
fix(expert.attestation.url): was pointing to attestation_instructeur_dossier_path, so did not worked when expert was not instructeur. use active_storage_link, secured enough because served to authenticated users as well as expiring link 2024-03-30 06:20:11 +01:00
Paul Chavard
46c5830306
Merge pull request #10238 from demarches-simplifiees/fix-mailbox-missing-link
ETQ usager : ajout d'un lien vers la messagerie dans les dossiers en attente de correction
2024-03-28 16:56:17 +00:00
Paul Chavard
3c336c437a chore(task): optimize maintenance task 2024-03-28 17:35:17 +01:00
Corinne Durrmeyer
d5af837872 feat(messagerie_missing_link): Add link to messaging system in the alert block - fix #10198 2024-03-28 11:55:09 +01:00
Eric Leroy-Terquem
78530f9823
fix(fermeture): redirect to commencer if procedure not closed 2024-03-27 12:16:04 +01:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257 add validation on decimal max 3 digits after coma 2024-03-27 10:55:10 +01:00
mfo
465de75e6b
Merge pull request #10215 from demarches-simplifiees/US/catch-oomed-jobs
tech(export_job): sometimes ExportJob are OOMed, in those cases jobs are stuck and never retried. release lock and increase attempts
2024-03-27 09:34:46 +00:00
Kara Diaby
bfc68f8377
Merge pull request #10216 from demarches-simplifiees/dark_mode_admin_mails
ETQ Admin, je souhaite voir l'éditeur de mail adapté au dark mode
2024-03-26 20:04:21 +00:00
Corinne Durrmeyer
ba290110e5 feat(multiple_drop_down_list): Replace blank option 2024-03-26 15:39:27 +01:00
Martin
be47152096 tech(export_job): sometimes ExportJob are OOMed, in those cases jobs are stuck and never retried. release lock and increase attemps 2024-03-26 15:29:04 +01:00
Corinne Durrmeyer
ab6a76ad46 feat(multiple_drop_down_list) : Add missing space - fix #10185 2024-03-26 15:27:59 +01:00
Colin Darie
d161589e2f fix(api-entreprise): Context is not defined in jobs 2024-03-26 12:45:28 +01:00
Paul Chavard
06d81dcfaf
Merge pull request #10169 from tchak/refactor-champ-public_id
fix(champ): use public_id in views
2024-03-26 10:31:13 +00:00
Paul Chavard
6ad0b901b6 fix(champ): use public_id in views 2024-03-26 11:23:23 +01:00
Kara Diaby
8da7ff7eaa editeur mail administrateur : adaptation pour le dark mode 2024-03-26 11:14:17 +01:00
Paul Chavard
b02ba1e909 feat(textarea): autoresize textareas 2024-03-25 19:53:29 +01:00
Colin Darie
b3d2ca1486
Merge pull request #10203 from colinux/dev-warn-visible
Tech: bannière indiquant staging / env de test plus visible
2024-03-25 17:31:03 +00:00
Colin Darie
6977d0e89f
style(dev): staging env more visible 2024-03-25 15:58:55 +01:00
Paul Chavard
f589129ef5 chore(attachment): remove unused replace code 2024-03-25 15:13:14 +01:00
Eric Leroy-Terquem
536a03bbb4
Merge pull request #10180 from demarches-simplifiees/update-bulk-messages-associations
Technique : Mise à jour de l'association bulk messages - procédures
2024-03-25 13:35:23 +00:00
Eric Leroy-Terquem
b1e8c2ab49
Merge pull request #10182 from demarches-simplifiees/remove-closing-attributes-from-cloned-procedures
Correctif : supprime les closing attributes lors du clonage d'une démarche
2024-03-25 13:23:27 +00:00
Eric Leroy-Terquem
7d28a2f38b
Merge pull request #10132 from demarches-simplifiees/add-alert-on-accepted-files-if-closed-procedure
ETQ usager je vois un message d'alerte dans la liste de mes dossiers sur mes dossiers terminés sur une démarche close
2024-03-25 10:24:34 +00:00
Eric Leroy-Terquem
d01cd3a310
refacto(dossier list): do not use html safe 2024-03-25 11:16:06 +01:00
Eric Leroy-Terquem
bfd4ae9d50
refacto(dossier list): use model method en_construction_ou_instruction? 2024-03-25 11:15:35 +01:00
Eric Leroy-Terquem
5754d01242
feat(dossier): add alert on dossiers list for dossiers termines on closed procedures 2024-03-25 11:15:34 +01:00
Colin Darie
e31cd40adc fix(banner): correct http/https protocol for dev/prod 2024-03-25 09:54:05 +01:00
Eric Leroy-Terquem
a726d34404 fix(cloned procedures): reset closing attributes 2024-03-22 17:07:22 +01:00
Eric Leroy-Terquem
e712cf5f23 task(procedure): fix open procedures with closing reason 2024-03-22 16:00:36 +01:00
Eric Leroy-Terquem
773de2dbf2 chore(groupe_instructeurs): do not reaffect bulk messages anymore 2024-03-22 14:56:54 +01:00
Eric Leroy-Terquem
30f96a79c2 chore(bulk messages): update associations 2024-03-22 14:52:34 +01:00
Martin
2281e3de4b fixup! feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Martin
8eb6e5d6bb feat(type_de_champ_editor): can't move champ after his previousSibling, nor after himself, noop 2024-03-22 10:10:28 +01:00
Martin
44cdb14fb9 feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Martin
b8a155a7ee feat(type_de_champ_editor): show tdc position indexed starting at 1 not 0 2024-03-22 10:10:28 +01:00
Martin
0cff8668fa fix(dossier.pdf): code path not tested reached a typo 2024-03-22 09:26:50 +01:00
Martin
862af8a9f6 fix(dosser#show.pdf): missing user indirection on fci 2024-03-22 08:45:19 +01:00
Martin
015e606f50 fix(dossier.has_many.france_connect_informations): wip 2024-03-22 07:47:02 +01:00
Colin Darie
b6526cfad9
Merge pull request #10172 from colinux/fix-banner-domain
Tech: fix pour la bannière du domaine
2024-03-21 21:04:30 +00:00
simon lehericey
46087e4577 raise Error if generation fail 2024-03-21 21:03:21 +01:00
simon lehericey
76f7222e7a add metadata to pdf 2024-03-21 21:03:21 +01:00
simon lehericey
77744f510e add upstream context to weasyprint html generation 2024-03-21 21:03:21 +01:00
LeSim
a8f2274939
Merge pull request #10174 from demarches-simplifiees/do_not_cache_application_name_on_landing
Tech: sort le nom de l'application du cache dans la page de landing
2024-03-21 18:08:52 +00:00
mfo
d00b146dc3
Merge pull request #10165 from mfo/US/add_champ_descriptor_id
feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id
2024-03-21 17:05:56 +00:00
simon lehericey
5c416105ee do not cache application name on landing 2024-03-21 17:38:00 +01:00
Colin Darie
d8b35e2e77 feat(banner-domain): hide error msg by default because while redirecting, we briefly see the banner 2024-03-21 17:20:03 +01:00
Colin Darie
dd0dba2959 fix(domain-banner): oops 2024-03-21 17:18:54 +01:00
Colin Darie
17f9992722
Merge pull request #10040 from colinux/cross-domain-component
Prépare la bannière informant du changement de nom de domaine, avec redirection automatique le cas échéant
2024-03-21 14:58:29 +00:00
Eric Leroy-Terquem
058350df53 fix(administrateur): can delete administrateur with a discarded procedure with no dossier 2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
9139bfbf48 clean(administrateur): remove dead code 2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
6a77bbb6c9 fix(administrateur): can be deleted only if other admin or dossiers on all procedures included with discarded 2024-03-21 14:27:52 +01:00
simon lehericey
fa47eea07e oups 2024-03-21 14:01:52 +01:00
Colin Darie
f768801b7d
feat(registration): set preferred host on signup/signin 2024-03-21 13:15:36 +01:00
Colin Darie
41a02d1ead
feat: notify sentry when connection test on new host fail 2024-03-21 13:15:35 +01:00
Colin Darie
2f4444bd5e
chore: mark preferred domain to new domain when closing notice 2024-03-21 13:15:34 +01:00
Colin Darie
a16f88f8af
chore(schema): add preferred_domain to users 2024-03-21 12:21:19 +01:00
Colin Darie
4dd24f0925
chore: cross domain banner between APP_HOST_LEGACY and APP_HOST 2024-03-21 12:21:16 +01:00
simon lehericey
2ea6a5d25c remove now useless biz_dev module 2024-03-21 11:54:03 +01:00
simon lehericey
a42f85ef05 remove useless administration_id in invite_admin and invite_administrateur! 2024-03-21 11:54:02 +01:00
Martin
22fa2e61b4 feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id 2024-03-21 10:29:33 +01:00
simon lehericey
44b113e433 fix brakeman 2024-03-21 10:06:09 +01:00
simon lehericey
1dfd3bf573 use Current.application_base_url in app 2024-03-21 10:06:09 +01:00
simon lehericey
4c3b0229eb set Current.application_base_url 2024-03-21 10:06:09 +01:00
simon lehericey
72a2b764dc add demarches.gouv.fr as sender of automatic emails 2024-03-21 10:06:09 +01:00
simon lehericey
edc4e60b81 use Current.contact_email in app 2024-03-21 10:06:09 +01:00
simon lehericey
d13910dac4 set Current.contact_email 2024-03-21 10:06:09 +01:00
simon lehericey
efa35e04a5 use Current.application_name in app excluding mail 2024-03-21 10:06:09 +01:00
simon lehericey
b9fcb25f1a set Current.application_name 2024-03-21 10:06:08 +01:00
Kara Diaby
6222a3b797
Merge pull request #10164 from demarches-simplifiees/feat/10151
ETQ instructeur, je souhaite voir la gestion des notifications instructeurs au DSFR
2024-03-21 08:51:07 +00:00
Eric Leroy-Terquem
a89b471b5c
Merge pull request #10163 from demarches-simplifiees/fix-bulk-message-maintenance-task
fix(maintenance task): fix query and add a test
2024-03-21 08:26:09 +00:00
Kara Diaby
84890f954b gestion des notifications instructeurs au DSFR 2024-03-21 04:02:53 +00:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Eric Leroy-Terquem
dd7a407187 fix(maintenance task): fix query and add a test 2024-03-20 15:24:21 +01:00
Eric Leroy-Terquem
73d6609eb3
Merge pull request #10158 from demarches-simplifiees/fix-closing-reason-form
Correctif : ETQ admin je ne peux pas fermer une démarche en redirigeant sans choisir la nouvelle démarche
2024-03-20 13:28:40 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Eric Leroy-Terquem
280f1ac3c7 refactor(procedure): add a prefix to closing_reason enum 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
579fe2c933 chore(procedure): remove unnecessary safe operator 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
234f0d7a75 fix(data): update closing_reason to other if no replaced_by_procedure_id 2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
e55531c6f4 fix(procedure): validates presence of replaced_by_id if procedure redirected 2024-03-20 14:04:59 +01:00
Lisa Durand
db244c821b remove ununcessary instance variable for current admin 2024-03-20 11:24:24 +01:00
Paul Chavard
eff03aaf23 refactor(dossier): label indexes based on type_de_champ not champ 2024-03-20 09:58:47 +01:00
Paul Chavard
33125c691e
Merge pull request #10145 from tchak/fix-clone-with-stable-id
fix(champ): fill stable_id and stream when cloning from old champs
2024-03-20 08:29:12 +00:00
simon lehericey
75db5ee320 replace AGENT_CONNECT_ENABLED and move AC conf to optionnal env 2024-03-19 21:17:45 +01:00
simon lehericey
df0298ac42 simply deal with multiple agent_connect_information by taking the last used 2024-03-19 21:17:45 +01:00
simon lehericey
ca17524559 Allow instructeur to have multiple agent_connect_information
AC will return two different sub depending of the domain demarches.gouv.fr or ds.
Both agent_connect_information are stored and the corresponding instructeur is found by its email.
We do not store anymore the agent_connect_id on the instructeur as the are many.
2024-03-19 21:17:45 +01:00
simon lehericey
2f6147308c use ac gouv conf when needed 2024-03-19 21:17:44 +01:00
simon lehericey
bdcc65ff4a fix: delete AgentConnect cookies instead of nullify 2024-03-19 21:17:44 +01:00
simon lehericey
759d729bf3 use AC autoconf discovery end_session_endpoint 2024-03-19 21:17:44 +01:00
simon lehericey
916407ec95 remove secret indirection and fetch AC conf once for all 2024-03-19 21:17:44 +01:00
simon lehericey
4997a81639 remove one indirection 2024-03-19 21:17:44 +01:00