Paul Chavard
25e009df78
refactor(prefill): use champ_for_update method
2024-04-22 13:55:01 +02:00
Paul Chavard
0c7bc6b555
feat(dossier): add methods to upsert champ values
2024-04-22 13:55:01 +02:00
Paul Chavard
c479d46b47
refactor(champs): extract dossier champ related methods in to a concern
2024-04-22 13:55:01 +02:00
Paul Chavard
5788997519
Merge pull request #10347 from tchak/cleanup-dossier-user
...
fix(dossier): always use user_email_for instead of user.email
2024-04-22 08:22:51 +00:00
simon lehericey
9e33b1ee6d
fix: allow unsigned expert when restricted list
2024-04-19 13:03:09 +02:00
mfo
4041bfa160
Merge pull request #10317 from mfo/US/aria-labelled-by-error-message
...
ETQ Usager, je souhaite que mon screen reader verbalise les erreurs sur les champs unique contenu dans un `fieldset`
2024-04-18 08:53:12 +00:00
Paul Chavard
6644f8157f
fix(dossier): always use user_email_for instead of user.email
2024-04-18 10:21:32 +02:00
mfo
8453e121d7
feat(champ.errors): add aria-labelledby error on champs wrapped within a fieldset, make error messages always present and aria-live: assertive on validation error
...
Co-authored-by: Corinne Durrmeyer <corinne@inseo.fr>
Co-authored-by: Colin Darie <colin@darie.eu>
2024-04-18 10:00:27 +02:00
Paul Chavard
2c9f809a46
Merge pull request #10250 from mfo/US/add-missing-validators
...
tech(champs.validators): dry and standardize champs.validations
2024-04-17 15:06:47 +00:00
simon lehericey
ca4ab4cfe1
fix: multi FC do not change const
2024-04-17 15:33:37 +02:00
LeSim
6165df277b
Merge pull request #10342 from demarches-simplifiees/dirty_fix_to_make_fc_work_again
...
hack: always use default redirect_uri
2024-04-17 09:45:21 +00:00
simon lehericey
2424885adf
hack: always use default redirect_uri
2024-04-17 11:36:35 +02:00
mfo
aca67a2274
tech(refactor.champs.validation): all champs validation use :validate_champ_value_or_prefill?
2024-04-17 06:27:26 +02:00
mfo
c6e21fb7bd
feat(champs.contextual_validation): extract contextual methods validation in module
2024-04-17 06:27:25 +02:00
simon lehericey
981003975c
refactor: use last_sign_in_at as confirmed_at is not reliable
2024-04-16 17:58:30 +02:00
simon lehericey
d95ce505a8
feat: suggest recently added user even if its not confirmed
2024-04-16 17:58:30 +02:00
simon lehericey
8d95df2250
feat: do not suggest unconfirmed experts
2024-04-16 17:58:30 +02:00
simon lehericey
1502635327
refactor: experts emails pluck
2024-04-16 17:58:30 +02:00
simon lehericey
5cd780251b
refactor: mutualize email_expert logic
2024-04-16 17:58:29 +02:00
Colin Darie
71b0592b0a
Merge pull request #10336 from colinux/fix-address-without-postcode
...
Usager: fix champ adresse dans un TOM sans code postal dans la BAN (ex. Nouvelle-Calédonie à Nouméa)
2024-04-16 13:45:04 +00:00
Colin Darie
db65c9178e
fix(address): BAN does not return postcode for some TOM like Nouvelle-Calédonie
...
But we have to fallback to an empty string because API graphql / serializer
expects a non-null attribute.
2024-04-16 15:37:56 +02:00
Paul Chavard
ee56a7da21
refactor(champ): remove stable_id delegate to type_de_champ
2024-04-16 12:10:07 +02:00
Lisa Durand
7a80574afc
Merge pull request #10190 from demarches-simplifiees/add-AR-feature-ldu
...
ETQ Admin je peux configurer une démarche avec accusé de lecture
2024-04-16 09:58:13 +00:00
simon lehericey
6982b2d5e8
refactor: do not enqueue antivirus job for safe blob
2024-04-16 09:57:31 +02:00
Lisa Durand
c6e2e6445c
add instructeur feedback on accuse de lecture agreement
2024-04-15 12:10:28 +02:00
Lisa Durand
71268c7f3b
hide decision from email for tiers if procedure has accuse de lecture
2024-04-15 11:15:13 +02:00
Lisa Durand
1cf3db5899
hide dossier with accuse de lecture in user list when using state filter
2024-04-15 11:15:13 +02:00
Lisa Durand
e486f789f6
add AR in user view - hide decision on second dossier tab
2024-04-15 11:15:13 +02:00
Lisa Durand
ae08044ff2
create AR email and send it at the right time
2024-04-15 11:15:05 +02:00
mfo
cb2dd3dd3a
Merge pull request #10314 from mfo/US/enhance-a11y-on-carte-champs
...
ETQ Usager je souhaite que le champ carte soit plus accessible
2024-04-14 13:25:06 +00:00
mfo
938f5043a4
feat(champs.validation): standardize champ error messages
2024-04-12 11:39:43 +02:00
mfo
d8a8fb53ce
feat(Champ.carte): some error style on carte
2024-04-12 10:59:42 +02:00
Eric Leroy-Terquem
1e50223267
Merge pull request #10293 from demarches-simplifiees/re-router-tous-les-dossiers-d-une-demarche
...
ETQ tech je peux relancer le routage pour tous les dossiers en construction d'une démarche
2024-04-11 13:27:43 +00:00
simon lehericey
bda9c4b455
fix: drop unused column and fk procedure_revisions.attestation_template_id which block procedure.destroy
2024-04-11 13:38:38 +02:00
simon lehericey
ab4a6b1c7d
fix: rescue and sentry log procedure.purge_discarded to avoid blowing up the whole job
2024-04-11 13:22:37 +02:00
Paul Chavard
fe508c0a73
Merge pull request #10302 from tchak/ignore-attestation_template_id
...
chore(db): ignore attestation_template_id
2024-04-11 10:30:37 +00:00
Paul Chavard
ceae749746
chore(db): ignore attestation_template_id
2024-04-11 12:03:06 +02:00
simon lehericey
124433b781
refactor: commune_champ
2024-04-11 11:57:18 +02:00
Eric Leroy-Terquem
51312b178e
task(routing): reroute dossiers en construction
2024-04-09 17:17:49 +02:00
Colin Darie
3c7018fd31
fix: don't set preferred domain on signup/signin unless feature is enabled
2024-04-09 10:04:18 +02:00
Paul Chavard
707d3980c0
Merge pull request #10171 from tchak/fix-perf-filters
...
perf(filter): we query by stable_id - no need to check type_de_champ private attribute
2024-04-08 09:24:54 +00:00
LeSim
22830fd7f6
Merge pull request #10275 from demarches-simplifiees/fix_api_entreprise_status
...
Tech: corrige le mécanisme de surveillance des fournisseurs d entreprise.api.gouv.fr
2024-04-08 08:08:38 +00:00
Paul Chavard
c5c671f391
Merge pull request #10234 from tchak/type-de-champ-paths
...
feat(champ): add paths to type_de_champ
2024-04-08 08:07:30 +00:00
simon lehericey
e82a8787d5
dirty fix: avoid changing preferred domain
2024-04-05 15:26:12 +02:00
Paul Chavard
80b3f0c0b3
fix(champ): no validate on hidden champs
2024-04-05 13:24:57 +02:00
simon lehericey
7b33963a67
add and use api_djepva_up?
2024-04-05 12:27:26 +02:00
simon lehericey
e994738a2e
add and use api_insee_up?
2024-04-05 12:26:44 +02:00
Paul Chavard
742e6f4a92
perf(filter): we query by stable_id - no need to check type_de_champ private attribute
2024-04-04 19:01:47 +02:00
Paul Chavard
282ce1322c
fix(stats): more accurat stats about deleted dossiers
2024-04-04 19:00:48 +02:00
Paul Chavard
38a703034e
feat(champ): expose paths
2024-04-04 16:13:23 +02:00
Colin Darie
df59503ab7
Merge pull request #10224 from colinux/mail-host
...
Tech (mailers): `from`, liens et application en respectent le preferred domain du destinataire
2024-04-04 07:25:43 +00:00
Colin Darie
d14fe83261
feat(mail): devise confirmation instructions respect user preferred host
2024-04-02 18:47:41 +02:00
Paul Chavard
0006a12aea
Update app/models/dossier.rb
...
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-04-02 18:09:29 +02:00
Paul Chavard
7cf1cdb47b
fix(champ): do not expose champs without row_id in repetitions
2024-04-02 17:51:57 +02:00
mfo
4da36531d4
Merge pull request #10242 from demarches-simplifiees/US/fix-decimal-number-validator
...
Correctif(annotations privées): ETQ instructeur, je ne pouvais modifier une annotation quand un usager avait saisi des valeur de champs incorrectes
2024-04-02 07:13:07 +00:00
Paul Chavard
13005b0a4a
fix(dossier): enqueue jobs after commit
2024-04-01 19:00:25 +02:00
Paul Chavard
5d302fb6ac
refactor(dossier): extract aasm callbacks in to a concern
2024-04-01 18:55:08 +02:00
mfo
e08aa7d28b
wip(validates): prefill and validate_champ_value? on all other missing validation checks
2024-04-01 07:36:14 +02:00
mfo
284a10e235
fix(Champs::EngagementJuridiqueChamp): validates Champs::EngagementJuridiqueChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
ff527517c9
fix(Champs::CiviliteChamp): validates Champs::CiviliteChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
94ea16c894
fix(Champs::BooleanChamp): validates Champs::BooleanChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
d7f152f4af
fix(Champs::PhoneChamp): validates Champs::PhoneChamp respecting it's validation context.
2024-04-01 07:18:14 +02:00
mfo
374d763084
fix(Champs::IntegerNumberChamp): validates Champs::IntegerNumberChamp respecting it's validation context.
2024-04-01 07:18:13 +02:00
mfo
fd5faad31f
fix(Champs::PaysChamp): validates Champs::PaysChamp respecting it's validation context. Also do not save value when external_id/code can't be found by lookup
2024-04-01 07:18:13 +02:00
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context
2024-04-01 07:07:11 +02:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
...
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257
add validation on decimal max 3 digits after coma
2024-03-27 10:55:10 +01:00
Paul Chavard
6ad0b901b6
fix(champ): use public_id in views
2024-03-26 11:23:23 +01:00
Eric Leroy-Terquem
536a03bbb4
Merge pull request #10180 from demarches-simplifiees/update-bulk-messages-associations
...
Technique : Mise à jour de l'association bulk messages - procédures
2024-03-25 13:35:23 +00:00
Eric Leroy-Terquem
a726d34404
fix(cloned procedures): reset closing attributes
2024-03-22 17:07:22 +01:00
Eric Leroy-Terquem
30f96a79c2
chore(bulk messages): update associations
2024-03-22 14:52:34 +01:00
Martin
44cdb14fb9
feat(type_de_champ_editor): move champs after another champ.
2024-03-22 10:10:28 +01:00
Martin
015e606f50
fix(dossier.has_many.france_connect_informations): wip
2024-03-22 07:47:02 +01:00
mfo
d00b146dc3
Merge pull request #10165 from mfo/US/add_champ_descriptor_id
...
feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id
2024-03-21 17:05:56 +00:00
Colin Darie
17f9992722
Merge pull request #10040 from colinux/cross-domain-component
...
Prépare la bannière informant du changement de nom de domaine, avec redirection automatique le cas échéant
2024-03-21 14:58:29 +00:00
Eric Leroy-Terquem
9139bfbf48
clean(administrateur): remove dead code
2024-03-21 14:27:53 +01:00
Eric Leroy-Terquem
6a77bbb6c9
fix(administrateur): can be deleted only if other admin or dossiers on all procedures included with discarded
2024-03-21 14:27:52 +01:00
Colin Darie
2f4444bd5e
chore: mark preferred domain to new domain when closing notice
2024-03-21 13:15:34 +01:00
Colin Darie
a16f88f8af
chore(schema): add preferred_domain to users
2024-03-21 12:21:19 +01:00
simon lehericey
a42f85ef05
remove useless administration_id in invite_admin and invite_administrateur!
2024-03-21 11:54:02 +01:00
Martin
22fa2e61b4
feat(api): add champs.champDescriptorId so champRepetitions.rows[x] has a uniq id
2024-03-21 10:29:33 +01:00
simon lehericey
4c3b0229eb
set Current.application_base_url
2024-03-21 10:06:09 +01:00
simon lehericey
72a2b764dc
add demarches.gouv.fr as sender of automatic emails
2024-03-21 10:06:09 +01:00
simon lehericey
d13910dac4
set Current.contact_email
2024-03-21 10:06:09 +01:00
simon lehericey
efa35e04a5
use Current.application_name in app excluding mail
2024-03-21 10:06:09 +01:00
simon lehericey
b9fcb25f1a
set Current.application_name
2024-03-21 10:06:08 +01:00
mfo
086cc1537b
Merge pull request #10068 from mfo/US/user-has-many-fcis
...
tech(User.FranceConnect): un usager peut avoir plusieurs profils FranceConnect, pas uniquement un
2024-03-20 16:30:39 +00:00
Eric Leroy-Terquem
73d6609eb3
Merge pull request #10158 from demarches-simplifiees/fix-closing-reason-form
...
Correctif : ETQ admin je ne peux pas fermer une démarche en redirigeant sans choisir la nouvelle démarche
2024-03-20 13:28:40 +00:00
Lisa Durand
6c5c744411
Merge pull request #10119 from demarches-simplifiees/add-explanation-when-publish-with-same-url-ldu
...
ETQ admin j'ai un message d'explication si j'utilise une URL déja utilisée lors de la publication d'une démarche
2024-03-20 13:21:59 +00:00
Eric Leroy-Terquem
280f1ac3c7
refactor(procedure): add a prefix to closing_reason enum
2024-03-20 14:04:59 +01:00
Eric Leroy-Terquem
e55531c6f4
fix(procedure): validates presence of replaced_by_id if procedure redirected
2024-03-20 14:04:59 +01:00
Paul Chavard
eff03aaf23
refactor(dossier): label indexes based on type_de_champ not champ
2024-03-20 09:58:47 +01:00
Paul Chavard
33125c691e
Merge pull request #10145 from tchak/fix-clone-with-stable-id
...
fix(champ): fill stable_id and stream when cloning from old champs
2024-03-20 08:29:12 +00:00
simon lehericey
df0298ac42
simply deal with multiple agent_connect_information by taking the last used
2024-03-19 21:17:45 +01:00
simon lehericey
ca17524559
Allow instructeur to have multiple agent_connect_information
...
AC will return two different sub depending of the domain demarches.gouv.fr or ds.
Both agent_connect_information are stored and the corresponding instructeur is found by its email.
We do not store anymore the agent_connect_id on the instructeur as the are many.
2024-03-19 21:17:45 +01:00
simon lehericey
4997a81639
remove one indirection
2024-03-19 21:17:44 +01:00
Paul Chavard
a962e2d94e
fix(champ): fill stable_id and stream when cloning from old champs
2024-03-18 20:04:53 +01:00
Paul Chavard
c5892a1ca2
Merge pull request #10141 from tchak/fix-rows-order
...
fix(champs): fix rows order
2024-03-18 16:56:21 +00:00
Paul Chavard
f21192bb06
Merge pull request #10123 from tchak/fix-multiple-champ-copies-bug
...
fix(champ): fix multiple champ copies bug
2024-03-18 16:46:17 +00:00
Paul Chavard
818dcc32da
fix(champs): fix rows order
2024-03-18 17:26:41 +01:00
