Commit graph

14400 commits

Author SHA1 Message Date
LeSim
9a3be41c90
Merge pull request #4564 from betagouv/fix-routage-feature-spec
Corrige un test bout en bout peu fiable sur le routage
2019-11-21 20:43:25 +01:00
Pierre de La Morinerie
1de4ef8a9a specs: fix error in routing feature test by waiting for Turbolinks 2019-11-21 18:37:51 +01:00
Pierre de La Morinerie
b78134c691 specs: make the routing feature test more robust
- Use human-readable form labels
- Always wait for the result of the previous action to be loaded before
  starting another action
2019-11-21 18:29:45 +01:00
LeSim
04f29b404f
Merge pull request #4556 from betagouv/more_accessibility
Corrige des fautes syntaxiques html
2019-11-21 17:17:09 +01:00
Pierre de La Morinerie
0c76fb83f6
2019-11-21-02 (#4554)
2019-11-21-02
2019-11-21 15:35:38 +01:00
simon lehericey
054181a16f Champ Repetition has no label, thus it's displayed as a section 2019-11-21 15:34:59 +01:00
simon lehericey
2162522814 ul should have li childs 2019-11-21 15:34:59 +01:00
simon lehericey
bc85e9b7ec Use aria-describedby to link notice and input again
https://www.w3.org/WAI/tutorials/forms/instructions/#using-aria-describedby
2019-11-21 15:34:59 +01:00
simon lehericey
84b125d272 p cannot be included in label
The main problem come from
%label{for: input_id}
  #{champ.libelle}
  %span.notice= string_to_html(champ.description)
%input

where string_to_html contains p tags

The proposed solution is
%label #{champ.libelle}
%p.notice
%input

It should be iso in the graphic sense.
2019-11-21 15:34:59 +01:00
simon lehericey
d5da7916e5 Placeholder not allowed in date input 2019-11-21 15:34:59 +01:00
simon lehericey
f45ede7f44 href should not contain space 2019-11-21 15:34:59 +01:00
Keirua
1bba20a782
Merge pull request #4550 from Keirua/fix-devise-mailer-smtp-syntax-error
#4419 - correction des erreurs d'envoi de mail Devise
2019-11-21 15:13:29 +01:00
clemkeirua
f2c69400aa add rescue_from to UserDeviseMailer 2019-11-21 14:59:30 +01:00
Pierre de La Morinerie
ff3f4774e8 Add a Github Actions workflow for automatic rebase
Add /rebase to a comment to trigger an automatic rebase.
2019-11-21 14:51:52 +01:00
Pierre de La Morinerie
b4a4d8c0ea
Merge pull request #4551 from betagouv/autosave
Usager : permet d'enregistrer les brouillons automatiquement (désactivé pour l'instant)
2019-11-21 14:44:14 +01:00
Pierre de La Morinerie
85accfd389
2019-11-21-01 (#4553)
2019-11-21-01
2019-11-21 14:28:38 +01:00
Pierre de La Morinerie
6de5c0c9d1 autosave: make requests time out
This avoids recent requests being stuck because an older request never
finished.
2019-11-21 14:00:06 +01:00
Pierre de La Morinerie
68f5aae99d autosave: add feature test 2019-11-21 14:00:06 +01:00
Pierre de La Morinerie
bff7892ba8 dossiers: autosave drafts 2019-11-21 14:00:06 +01:00
Paul Chavard
6f2779a312
Merge pull request #3991 from tchak/cleanup-old-export
Supprimer le code du vieux export de xls (15/11/2019)
2019-11-21 10:50:03 +01:00
Paul Chavard
0c6705f7fd Drop old export service 2019-11-21 10:25:40 +01:00
Keirua
36ffde35a2
Merge pull request #4549 from betagouv/fix-unknown-format
Fix UnknownFormat durant les exports de procédures
2019-11-21 09:53:13 +01:00
clemkeirua
be7fde1103 fix UnknownFormat raised in Instructeurs::ProceduresController#download_export 2019-11-21 09:52:38 +01:00
Pierre de La Morinerie
0b8512362e
javascript: make utils resilient to missing elements (#4546)
Javascript : les fonctions utilitaires fonctionnent lorsque l'élément n'existe pas
2019-11-20 17:41:51 +01:00
Pierre de La Morinerie
74a9db6580 javascript: make utils resilient to missing elements 2019-11-20 17:36:09 +01:00
LeSim
10ebb8a373
Merge pull request #4539 from betagouv/4163-suivi-automatique-apres-envoi-instructeur
permet le suivi auto d'un dossier après envoi instructeur
2019-11-20 16:49:20 +01:00
Christophe Robillard
b42f21264e permet le suivi auto après envoi instructeur
Close #4163
2019-11-20 16:41:30 +01:00
Keirua
de9be2f0e5
Merge pull request #4538 from mfaure/4537-Description-des-entrées-du-env.example
DOC ajout commentaires + explications pour env.example
2019-11-20 16:16:34 +01:00
Keirua
c2035ba797
Merge branch 'dev' into 4537-Description-des-entrées-du-env.example 2019-11-20 16:07:12 +01:00
Matthieu FAURE
87813c42d9
Update config/env.example
Co-Authored-By: Keirua <Keirua@users.noreply.github.com>
2019-11-20 15:40:02 +01:00
Matthieu FAURE
1f2f904f8f
Update config/env.example
Co-Authored-By: Keirua <Keirua@users.noreply.github.com>
2019-11-20 15:39:50 +01:00
Pierre de La Morinerie
5038df54df
dossiers controller: render JSON if needed (#4545)
DossiersController : évite de générer du HTML en cas de requête JSON
2019-11-20 13:02:18 +01:00
Pierre de La Morinerie
5f9a9d059e dossiers: render JSON if needed
When receiving a request that expects JSON, return a simple '200'.

This avoids the unecessary work of rendering all the HTML page (which
ultimately will not be used).
2019-11-20 11:30:27 +01:00
Pierre de La Morinerie
4125d81869
Autosave : id unique de form ; brouillon par défaut (#4528)
DossiersController : enregistre par défaut en brouillon
2019-11-20 11:30:05 +01:00
Pierre de La Morinerie
8b8a96abda dossiers: save draft by default (instead of submitting)
Make the default behavior of `update_brouillon` be to update the draft,
instead of submitting the dossier.

This makes all requests made to `update_brouillon` without specifying
an extra `submit_draft` parameter to just save the draft. It will make
autosaving the draft easier and safer.
2019-11-20 11:24:31 +01:00
Pierre de La Morinerie
03a7bc3d5a dossiers: give the edit form an unique id 2019-11-20 11:24:31 +01:00
Pierre de La Morinerie
ac69c89a03
Améliorations diverses sur l'accessibilité (#4530)
Usager : améliorations diverses sur l'accessibilité
2019-11-20 11:23:33 +01:00
Paul Chavard
4faec089e9
Merge pull request #4544 from betagouv/dev
2019-11-20-01
2019-11-20 11:13:17 +01:00
Matthieu FAURE
85bbafc256
Update config/env.example based on @keirua review
Co-Authored-By: Keirua <Keirua@users.noreply.github.com>
2019-11-20 11:03:19 +01:00
Matthieu FAURE
0089a9d520
Update config/env.example based on @keirua review
Co-Authored-By: Keirua <Keirua@users.noreply.github.com>
2019-11-20 11:01:54 +01:00
Matthieu FAURE
98d545b1d9
Update config/env.example based on @keirua review
Co-Authored-By: Keirua <Keirua@users.noreply.github.com>
2019-11-20 11:01:27 +01:00
Pierre de La Morinerie
b90cd9f28f styles: fix hover on dropdown items
More specifically, fix items in the Help dropdown displaying a pointer
cursor on the whole area – where only the links inside the item should
have the hover cursor.

Also, having a `cursor: pointer` rule applied only on hover state is
difficult to debug: better to apply it always, and let the browser
handle it.
2019-11-20 10:48:53 +01:00
Matthieu FAURE
1a63d7e4e2 DOC ajout commentaires + explications pour env.example 2019-11-19 15:24:57 +01:00
simon lehericey
59d5cd7abc fix label > div by label > span 2019-11-19 15:14:06 +01:00
simon lehericey
45ff1fd697 Change span by div to fix Element p not allowed as child of element span 2019-11-19 15:14:06 +01:00
simon lehericey
4a5059ed34 Add alt='' to decorative image https://www.w3.org/WAI/tutorials/images/decorative/ 2019-11-19 15:14:06 +01:00
simon lehericey
0e6ffd0baa Fix table layout: tbody was wrapped in thead 2019-11-19 15:14:06 +01:00
simon lehericey
279696451e Fix html: Element div not allowed as child of element span 2019-11-19 15:14:06 +01:00
simon lehericey
59432594a0 Header: same outline for the search button 2019-11-19 15:14:06 +01:00
simon lehericey
9f6b9c5028 Make the help button accessible for keyboard 2019-11-19 15:14:06 +01:00