Améliorations diverses sur l'accessibilité (#4530)

Usager : améliorations diverses sur l'accessibilité
2019-11-20 11:23:33 +01:00 · 2019-11-20 11:23:33 +01:00 · ac69c89a03
commit ac69c89a03
parent 0d8e7f956f b90cd9f28f
15 changed files with 62 additions and 54 deletions
--- a/app/assets/stylesheets/new_design/buttons.scss
+++ b/app/assets/stylesheets/new_design/buttons.scss
@ -130,6 +130,10 @@
  }
 }

+.state-button {
+  display: inline-block;
+}
+
 .dropdown {
  display: inline-block;
  position: relative;
@ -213,10 +217,13 @@
      }
    }

-    &.selected,
-    &:hover:not(.inactive) {
-      background: $light-grey;
+    &:not(.inactive) {
      cursor: pointer;
+
+      &:hover,
+      &.selected {
+        background: $light-grey;
+      }
    }

    &.danger {
--- a/app/assets/stylesheets/new_design/new_header.scss
+++ b/app/assets/stylesheets/new_design/new_header.scss
@ -150,6 +150,8 @@ $header-mobile-breakpoint: 550px;
  }

  button {
+    @extend %outline;
+
    padding: 9px;
    border: none;
    background: none;
--- a/app/views/instructeurs/dossiers/_header_actions.html.haml
+++ b/app/views/instructeurs/dossiers/_header_actions.html.haml
@ -1,5 +1,5 @@
 %span.dropdown.print-menu-opener
-  %button.button.dropdown-button.icon-only
+  %button.button.dropdown-button.icon-only{ title: 'imprimer' }
    %span.icon.printer
  %ul.print-menu.dropdown-content
    %li
@ -20,5 +20,5 @@

 = render partial: "instructeurs/procedures/dossier_actions", locals: { procedure: dossier.procedure, dossier: dossier, dossier_is_followed: current_instructeur&.follow?(dossier) }

-%span.state-button
+.state-button
  = render partial: "state_button", locals: { dossier: dossier }
--- a/app/views/instructeurs/dossiers/_state_button.html.haml
+++ b/app/views/instructeurs/dossiers/_state_button.html.haml
@ -1,4 +1,4 @@
-%span.dropdown
+.dropdown
  -# Dropdown button title
  %button.button.primary.dropdown-button{ class: button_or_label_class(dossier) }
    = dossier_display_state dossier
--- a/app/views/invites/_dropdown.html.haml
+++ b/app/views/invites/_dropdown.html.haml
@ -1,4 +1,4 @@
-%span.dropdown.invite-user-action
+.dropdown.invite-user-action
  %button.button.dropdown-button
    %span.icon.person
    - if dossier.invites.count > 0
--- a/app/views/layouts/_account_dropdown.haml
+++ b/app/views/layouts/_account_dropdown.haml
@ -1,4 +1,4 @@
-%span.dropdown.header-menu-opener
+.dropdown.header-menu-opener
  %button.button.dropdown-button.header-menu-button
    = image_tag "icons/account-circle.svg", title: "Mon compte"
  %ul.header-menu.dropdown-content
@ -8,30 +8,30 @@
    - if administration_signed_in?
      %li
        = link_to manager_root_path, class: "menu-item menu-link" do
-          = image_tag "icons/super-admin.svg"
+          = image_tag "icons/super-admin.svg", alt: ''
          Passer en super-admin
    - if multiple_devise_profile_connect?
      - if user_signed_in? && nav_bar_profile != :user
        %li
          = link_to dossiers_path, class: "menu-item menu-link" do
-            = image_tag "icons/switch-profile.svg"
+            = image_tag "icons/switch-profile.svg", alt: ''
            Passer en usager
      - if instructeur_signed_in? && nav_bar_profile != :instructeur
        %li
          = link_to instructeur_procedures_path, class: "menu-item menu-link" do
-            = image_tag "icons/switch-profile.svg"
+            = image_tag "icons/switch-profile.svg", alt: ''
            Passer en instructeur
      - if administrateur_signed_in? && nav_bar_profile != :administrateur
        %li
          = link_to admin_procedures_path, class: "menu-item menu-link" do
-            = image_tag "icons/switch-profile.svg"
+            = image_tag "icons/switch-profile.svg", alt: ''
            Passer en administrateur

    %li
      = link_to profil_path, class: "menu-item menu-link" do
-        = image_tag "icons/switch-profile.svg"
+        = image_tag "icons/switch-profile.svg", alt: ''
        Voir mon profil
    %li
      = link_to destroy_user_session_path, method: :delete, class: "menu-item menu-link" do
-        = image_tag "icons/sign-out.svg"
+        = image_tag "icons/sign-out.svg", alt: ''
        Se déconnecter
--- a/app/views/layouts/_new_header.haml
+++ b/app/views/layouts/_new_header.haml
@ -38,7 +38,7 @@
            = form_tag instructeur_recherche_path, method: :get, class: "form" do
              = text_field_tag "q", "#{@search_terms if @search_terms.present?}", placeholder: "Rechercher un dossier"
              %button{ title: "Rechercher" }
-                = image_tag "icons/search-blue.svg"
+                = image_tag "icons/search-blue.svg", alt: ''

      - if nav_bar_profile == :user && user_signed_in? && current_user.dossiers.count > 2
        %li
@ -46,7 +46,7 @@
            = form_tag recherche_dossiers_path, method: :post, class: "form" do
              = text_field_tag :dossier_id, "", placeholder: "Numéro de dossier"
              %button{ title: "Rechercher" }
-                = image_tag "icons/search-blue.svg"
+                = image_tag "icons/search-blue.svg", alt: ''

      - if instructeur_signed_in? || user_signed_in?
        %li
@ -60,15 +60,14 @@
          = link_to "Connexion", new_user_session_path, class: "button secondary"

      %li
-        .header-help
-          - if dossier.present? && nav_bar_profile == :user
-            = render partial: 'shared/help/help_dropdown_dossier', locals: { dossier: dossier }
+        - if dossier.present? && nav_bar_profile == :user
+          = render partial: 'shared/help/help_dropdown_dossier', locals: { dossier: dossier }

-          - elsif procedure.present? && (nav_bar_profile == :user || nav_bar_profile == :guest)
-            = render partial: 'shared/help/help_dropdown_procedure', locals: { procedure: procedure }
+        - elsif procedure.present? && (nav_bar_profile == :user || nav_bar_profile == :guest)
+          = render partial: 'shared/help/help_dropdown_procedure', locals: { procedure: procedure }

-          - elsif nav_bar_profile == :instructeur
-            = render partial: 'shared/help/help_dropdown_instructeur'
+        - elsif nav_bar_profile == :instructeur
+          = render partial: 'shared/help/help_dropdown_instructeur'

-          - else
-            = render partial: 'shared/help/help_button'
+        - else
+          = render partial: 'shared/help/help_button'
--- a/app/views/shared/dossiers/_champ_row.html.haml
+++ b/app/views/shared/dossiers/_champ_row.html.haml
@ -16,7 +16,7 @@
        %th.libelle{ class: repetition ? 'padded' : '' }
          = "#{c.libelle} :"
        %td.rich-text
-          %span{ class: highlight_if_unseen_class(demande_seen_at, c.updated_at) }
+          %div{ class: highlight_if_unseen_class(demande_seen_at, c.updated_at) }
            - case c.type_champ
            - when TypeDeChamp.type_champs.fetch(:carte)
              = render partial: "shared/champs/carte/show", locals: { champ: c }
--- a/app/views/shared/dossiers/messages/_form.html.haml
+++ b/app/views/shared/dossiers/messages/_form.html.haml
@ -7,7 +7,7 @@
    %div
      = f.file_field :piece_jointe, id: 'piece_jointe', direct_upload: true
      %label{ for: :piece_jointe }
-        .notice
+        %span.notice
          (taille max : 20 Mo)

    %div
--- a/app/views/shared/dossiers/messages/_message_icon.html.haml
+++ b/app/views/shared/dossiers/messages/_message_icon.html.haml
@ -1,7 +1,7 @@
 - if commentaire.sent_by_system?
-  = image_tag('icons/mail.svg', class: 'person-icon')
+  = image_tag('icons/mail.svg', class: 'person-icon', alt: '')
 - elsif commentaire.sent_by?(connected_user)
-  = image_tag('icons/account-circle.svg', class: 'person-icon')
+  = image_tag('icons/account-circle.svg', class: 'person-icon', alt: '')
 - else
-  = image_tag('icons/blue-person.svg', class: 'person-icon')
+  = image_tag('icons/blue-person.svg', class: 'person-icon', alt: '')

--- a/app/views/shared/help/_help_dropdown_dossier.html.haml
+++ b/app/views/shared/help/_help_dropdown_dossier.html.haml
@ -1,5 +1,5 @@
 .dropdown.help-dropdown
-  .button.primary.dropdown-button Aide
+  %button.button.primary.dropdown-button Aide
  .dropdown-content.fade-in-down
    %ul.dropdown-items
      - title = dossier.brouillon? ? "Besoin d’aide pour remplir votre dossier ?" : "Une question sur votre dossier ?"
--- a/app/views/shared/help/_help_dropdown_instructeur.html.haml
+++ b/app/views/shared/help/_help_dropdown_instructeur.html.haml
@ -1,5 +1,5 @@
 .dropdown.help-dropdown
-  .button.primary.dropdown-button Aide
+  %button.button.primary.dropdown-button Aide
  .dropdown-content.fade-in-down
    %ul.dropdown-items
      = render partial: 'shared/help/dropdown_items/faq_item'
--- a/app/views/users/dossiers/_dossier_actions.html.haml
+++ b/app/views/users/dossiers/_dossier_actions.html.haml
@ -4,7 +4,7 @@
 - has_actions = has_delete_action || has_new_dossier_action

 - if has_actions
-  %span.dropdown.user-dossier-actions
+  .dropdown.user-dossier-actions
    %button.button.dropdown-button
      Actions
    .dropdown-content.fade-in-down
--- a/app/views/users/dossiers/index.html.haml
+++ b/app/views/users/dossiers/index.html.haml
@ -30,26 +30,26 @@
          %th.status-col Statut
          %th.updated-at-col Mis à jour
          %th
-        %tbody
-          - @dossiers.each do |dossier|
-            %tr{ data: { 'dossier-id': dossier.id } }
-              %td.folder-col
-                = link_to(url_for_dossier(dossier), class: 'cell-link') do
-                  %span.icon.folder
-              %td.number-col
-                = link_to(url_for_dossier(dossier), class: 'cell-link') do
-                  = dossier.id
-              %td
-                = link_to(url_for_dossier(dossier), class: 'cell-link') do
-                  = procedure_libelle(dossier.procedure)
-              %td.status-col
-                = link_to(url_for_dossier(dossier), class: 'cell-link') do
-                  = render partial: 'shared/dossiers/status_badge', locals: { dossier: dossier }
-              %td.updated-at-col
-                = link_to(url_for_dossier(dossier), class: 'cell-link') do
-                  = try_format_date(dossier.updated_at)
-              %td.action-col.action-col
-                = render partial: 'dossier_actions', locals: { dossier: dossier }
+      %tbody
+        - @dossiers.each do |dossier|
+          %tr{ data: { 'dossier-id': dossier.id } }
+            %td.folder-col
+              = link_to(url_for_dossier(dossier), class: 'cell-link') do
+                %span.icon.folder
+            %td.number-col
+              = link_to(url_for_dossier(dossier), class: 'cell-link') do
+                = dossier.id
+            %td
+              = link_to(url_for_dossier(dossier), class: 'cell-link') do
+                = procedure_libelle(dossier.procedure)
+            %td.status-col
+              = link_to(url_for_dossier(dossier), class: 'cell-link') do
+                = render partial: 'shared/dossiers/status_badge', locals: { dossier: dossier }
+            %td.updated-at-col
+              = link_to(url_for_dossier(dossier), class: 'cell-link') do
+                = try_format_date(dossier.updated_at)
+            %td.action-col.action-col
+              = render partial: 'dossier_actions', locals: { dossier: dossier }
    = paginate(@dossiers)

    - if current_user.feedbacks.empty? || current_user.feedbacks.last.created_at < 1.month.ago
--- a/app/views/users/sessions/new.html.haml
+++ b/app/views/users/sessions/new.html.haml
@ -13,7 +13,7 @@

    .auth-options
      %div
-        = f.check_box :remember_me, as: :boolean
+        = f.check_box :remember_me
        = f.label :remember_me, "Se souvenir de moi", class: 'remember-me'

      .text-right