simon lehericey
13356f26c3
remove procedure from component signature
2024-10-31 10:54:28 +01:00
simon lehericey
7ed0b91351
plug column_filter, column_picker, column_header in new controller
2024-10-31 10:54:28 +01:00
simon lehericey
d8e63221b5
extract a procedure_presentation controller
2024-10-31 10:26:43 +01:00
simon lehericey
92a863d48c
remove_all as there is no some_usager_columns
2024-10-30 18:28:25 +01:00
mfo
26a078bc45
feat(naming): enhance naming of dates columns.
2024-10-30 18:28:24 +01:00
mfo
fa50e21101
review(pull/10591#discussion_r1818919818): export without user id
2024-10-30 18:28:24 +01:00
Christophe Robillard
df71c6a689
align columns naming and order for filter and add for export
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-30 18:28:23 +01:00
Paul Chavard
c6329ef10a
feat(column): add column get_value
2024-10-30 08:10:50 +01:00
Corinne Durrmeyer
f72c55631c
fix(trad): Add traduction to supporting document
2024-10-29 16:47:16 +01:00
Corinne Durrmeyer
10909c8879
Merge pull request #10965 from demarches-simplifiees/a11y-process-screen-2
...
Restitution des bandeau de statut (erreur ou succès)
2024-10-28 10:34:38 +00:00
mfo
2429f11d5c
fix(spec): fill_in(label) search by grep like, so if another label contains your label, you got an Ambiguous match
2024-10-28 10:39:36 +01:00
simon lehericey
b22f049318
fix: do not allow empty filter in models
2024-10-24 12:06:32 +02:00
Paul Chavard
c56aa67297
Merge pull request #10980 from colinux/helpscout-more-validation
...
ETQ tech, réduit le bruit Helpscout sur Sentry
2024-10-24 09:31:51 +00:00
Eric Leroy-Terquem
56b1355f71
Merge pull request #10970 from demarches-simplifiees/add-multicombobox-in-instructeur-interface
...
ETQ instructeur je peux ajouter plusieurs instructeurs à la fois
2024-10-24 07:38:42 +00:00
Colin Darie
eaa3350b77
feat(contact): delete contact forms when max attempts has been reached
2024-10-23 17:05:27 +02:00
mfo
84870615d8
feat(flash_messages): dry up code and ensure turbo_force: :server otherwise morphing does not refresh page with new attrs
2024-10-23 16:13:30 +02:00
Corinne Durrmeyer
dd362055df
Remove useless code
2024-10-23 14:58:21 +02:00
Corinne Durrmeyer
c91d8698bd
Remove useless note for screen readers
2024-10-23 14:00:24 +02:00
Corinne Durrmeyer
fd049f6025
Improve status message delivery to assistive technologies
2024-10-23 14:00:24 +02:00
Paul Chavard
1b188f65b0
Merge pull request #10977 from tchak/champ-oui-non-improve-format-on-export
...
ETQ Instructeur, je veux pouvoir faire la différence entre un champ Oui/Non vide et “Non”
2024-10-23 09:24:57 +00:00
Benoit Queyron
2b8e2b41da
Merge pull request #10968 from demarches-simplifiees/tech-nettoyage-options-header-section
...
Tech: task, nettoyage des options des header_section
2024-10-23 09:23:53 +00:00
benoitqueyron
1169dae310
task: clean header_section options
2024-10-23 10:35:07 +02:00
Mathieu Magnin
ba54890632
Merge pull request #10967 from demarches-simplifiees/fix-10966
...
Fix 500 when email is malformed
2024-10-23 07:23:07 +00:00
Paul Chavard
08490bfb82
ETQ Instructeur, je veux pouvoir faire la difference entre un champ Oui/Non vide et “Non”
2024-10-22 21:18:17 +02:00
Eric Leroy-Terquem
fa449d3e41
fix(instructeurs test): avoid duplication of instructor with same email
2024-10-22 17:33:31 +02:00
Eric Leroy-Terquem
81cbda0553
feat(instructeurs): can add many instructeurs
2024-10-22 17:31:31 +02:00
Thibaut Poullain
b969c1717f
🛠️ Fix | add test to the minimal admin presence for procedure
2024-10-22 17:01:57 +02:00
simon lehericey
0137763d42
feat: add empty_brouillon scope
2024-10-22 12:03:03 +02:00
Paul Chavard
02934188b4
refactor(champ): move champ value format methods from TypeDeChamp class to instance
2024-10-21 13:09:49 +02:00
Eric Leroy-Terquem
d17b913ccc
db(task): set a date_time to pieces_jointes_seen_at for remaining follows
2024-10-18 16:43:28 +02:00
Mathieu Magnin
478103b01a
[ #10966 ] Fix 500 when email is malformed
2024-10-18 16:22:13 +02:00
Corinne Durrmeyer
fcb868c6a8
Merge pull request #10893 from demarches-simplifiees/a11y-form-errors
...
Améliore la restitution des message d'erreur lors d'une soumission en erreur
2024-10-17 10:37:32 +00:00
Paul Chavard
8c8bb870fc
refactor(dossier): filled champs
2024-10-17 11:33:24 +02:00
simon lehericey
4059bfdc11
fix: make filter works on multiple_drop_down_list
2024-10-16 18:09:51 +02:00
Colin Darie
5522efc3e5
Merge pull request #10954 from tchak/fix-dossier-merge-with-multiple-rows
...
ETQ usager, fix soumission d'un dossier en construction quand multiples lignes de champs répétables ont été modifiées
2024-10-16 15:00:26 +00:00
LeSim
6862f6c6bd
Merge pull request #10875 from demarches-simplifiees/add_id_to_column_third_part
...
Utilisation des colonnes dans l'affichage et le filtrage
2024-10-16 14:53:30 +00:00
Paul Chavard
c417614695
fix(dossier): fix apply_diff with multiple changed rows
2024-10-16 14:15:26 +02:00
Mathieu Magnin
04bbf09097
Merge pull request #10939 from demarches-simplifiees/fix-10919
...
Correction bug champ carto
2024-10-15 18:13:13 +00:00
simon lehericey
f850924dc0
remove procedure_presentation from export
2024-10-15 16:09:09 +02:00
simon lehericey
71bcbbc440
remove useless snapshot
2024-10-15 16:09:09 +02:00
simon lehericey
b5ed8c9b61
export cache_key based on column
2024-10-15 16:09:08 +02:00
simon lehericey
603c2a108e
remove useless Export.by_key procedure_presentation arg
2024-10-15 16:09:08 +02:00
simon lehericey
4d7715fbb6
extract filter and sort function to a filter_service
2024-10-15 16:09:08 +02:00
simon lehericey
16e93a217b
reset procedure_presentation if a pb occurs with a column deserialization
2024-10-15 16:09:07 +02:00
simon lehericey
3677f3b2d3
tech(clean): remove Column classname: attribute
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:07 +02:00
simon lehericey
b2754cd26c
move validations concern to filtered_column
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:06 +02:00
simon lehericey
14fe11b612
use displayed_columns !
2024-10-15 16:09:06 +02:00
simon lehericey
7e4ca07df2
use filtered_column to filter !
...
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-10-15 16:09:05 +02:00
simon lehericey
4c5d7e2950
remove now useless add_filters and remove_filters
2024-10-15 16:09:05 +02:00
simon lehericey
72c389161a
remove filter using generic add_filter methods
2024-10-15 16:09:05 +02:00
simon lehericey
175f303399
display filter tags
2024-10-15 16:09:05 +02:00
simon lehericey
e9c11a95f1
directly write in new filter columns
2024-10-15 16:09:05 +02:00
simon lehericey
d54ab64e40
add filtered_column type
2024-10-15 16:09:05 +02:00
Mathieu Magnin
4b5235e42f
[ #10919 ] Fix tests
2024-10-15 15:32:46 +02:00
Mathieu Magnin
097074fdc7
Merge pull request #10865 from demarches-simplifiees/fix-10799
...
ETQ Admin / Instructeur je veux être savoir si le jeton api entreprise d'une démarche a expiré ou va expirer prochainement
2024-10-15 13:25:20 +00:00
Benoit Queyron
c8f69283cc
Merge pull request #10713 from demarches-simplifiees/etq-admin-bug-message-info-character-limit
...
Tech : amélioration de la gestion des types_de_champ.options
2024-10-15 13:02:33 +00:00
Mathieu Magnin
dfa3276cb6
[ #10799 ] Missing test
2024-10-15 14:40:50 +02:00
Mathieu Magnin
4266a76db6
[ #10799 ] Move test in right file
2024-10-15 14:40:50 +02:00
Mathieu Magnin
c897893e8a
[ #10799 ] Remove dead code
2024-10-15 14:40:50 +02:00
Mathieu Magnin
f26ff30538
[ #10799 ] Add maintenance task to fill api_entreprise_token_expires_at for previous data
2024-10-15 14:40:50 +02:00
Mathieu Magnin
6b326b634e
[ #10799 ] Modifications after Marlene's comments
2024-10-15 14:40:50 +02:00
Mathieu Magnin
687617cb08
[ #10799 ] Add test
2024-10-15 14:40:50 +02:00
Mathieu Magnin
ec2c913ab4
[ #10799 ] Display token error on related card
2024-10-15 14:40:49 +02:00
Mathieu Magnin
703a722c54
[ #10799 ] Handle the case when api_entreprise_token is not nil then set to nil
2024-10-15 14:40:49 +02:00
Mathieu Magnin
7009eed9d7
[ #10799 ] Move api entreprise token logic in a concern
2024-10-15 14:40:49 +02:00
Mathieu Magnin
39fdb8ddbb
[ #10799 ] Display a warning about token expiration on token form page
2024-10-15 14:40:49 +02:00
Mathieu Magnin
2d9854dc01
[ #10799 ] Declare api_entreprise_token_expires_at attribute and feed it on save
2024-10-15 14:40:49 +02:00
benoitqueyron
e88d84cf57
ajout d'un nettoyage des options des types_de_champ lors de la publication d'une procedure ou d'une nouvelle revision
2024-10-15 14:40:33 +02:00
benoitqueyron
4f62590b7a
ProcedureRevision#compare_type_de_champ: fix bug comparaison character_limit chaine vide vs nil
2024-10-15 14:40:33 +02:00
simon lehericey
b588b77571
TypeDeChamp: amélioration de la gestion des drop_down_options
2024-10-15 14:40:15 +02:00
Mathieu Magnin
49c9f274e4
[ #10919 ] When data in geo_area is invalid do not crash when .label is called
2024-10-15 14:37:32 +02:00
Corinne Durrmeyer
89d31ddf11
Improve rendering of “n°” by assistive technologies
2024-10-15 12:18:23 +02:00
Paul Chavard
bd32f5693d
refactor(repetition): remove parent_id
2024-10-15 11:42:36 +02:00
mfo
e7080c1ad1
Merge pull request #10927 from mfo/US/renormalize_department_code_and_name
...
amelioration ETQ tech, je souhaite que les composants d'adresses soient normalisés en anglais
2024-10-15 07:49:16 +00:00
mfo
366c02dbb7
fix(typo): use english for normalized addresses component
2024-10-15 09:13:05 +02:00
Colin Darie
ed6a254135
Merge pull request #10930 from colinux/fix-dropdown-list-filter-length
...
ETQ instructeur je peux filtrer un champ "choix simple" avec un long libellé d'option
2024-10-14 19:18:35 +00:00
Colin Darie
1c32a30b80
fix(filters): drop down list filters can have much longer values.
...
Notre infra supporte des urls d'au moins 8000 caractères, probablement
plus encore, donc on est large.
2024-10-14 16:01:48 +02:00
Eric Leroy-Terquem
60be8d68fc
test(instructeurs management): update tests
2024-10-14 15:14:06 +02:00
Eric Leroy-Terquem
59fe8b64c4
wording(instructeurs management): update translations
2024-10-14 15:13:35 +02:00
Colin Darie
9e27295a36
fix(admin): all procedures really filtered by tags
2024-10-14 10:26:47 +02:00
Kara Diaby
2c85757289
Créé la liste de nouveaux tags en base et les associe aux démarches
2024-10-14 10:26:47 +02:00
Kara Diaby
953ccbcfb6
Mise à jour des tests
2024-10-14 10:26:47 +02:00
Paul Chavard
32d8cbfe48
Merge pull request #10923 from tchak/graphql-siret-address-optimize
...
fix(graphql): parse_etablissement_address is slow (up to 300ms) – bypasse it when possible
2024-10-14 08:14:51 +00:00
Paul Chavard
960385831e
Merge pull request #10904 from tchak/remove-some-complex-champs-from-prefill
...
chore(prefill): remove unused prefill support on complex champs
2024-10-14 08:11:30 +00:00
Paul Chavard
b027839721
fix(graphql): parse_etablissement_address is slow (300ms) – bypasse it when possible
2024-10-14 09:23:35 +02:00
Mathieu Magnin
2222b6ff2d
[ #10921 ] Extend error handling to cover new error codes
2024-10-11 16:16:17 +02:00
Eric Leroy-Terquem
3397beb71d
refactor(gallery test): use freeze_time instead of Timecop
2024-10-11 13:14:19 +02:00
Eric Leroy-Terquem
72ae654ce7
style(pieces jointes): update UI
2024-10-11 11:20:47 +02:00
Eric Leroy-Terquem
3bc232e81e
feat(gallery): update gallery item badge class after seen
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
d9f604e8ce
feat(gallery): notify instructeur if pieces jointes updates
2024-10-11 11:20:46 +02:00
Eric Leroy-Terquem
bc237152e7
feat(gallery): add origin tag to gallery item
2024-10-11 10:41:05 +02:00
Eric Leroy-Terquem
df08617387
feat(gallery): add badge for date of created_at or updated_at
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
3560d73b58
refactor(gallery): use gallery component in gallery demande
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
2882af43aa
refactor(gallery): extract representation_url_for method
2024-10-11 10:41:04 +02:00
Eric Leroy-Terquem
bae752f1aa
refactor(gallery): add attachment_gallery_item component
2024-10-11 10:41:03 +02:00
Colin Darie
7f18db6c91
fix(job): non crirtical mail must be sent into < 15min, not hours
2024-10-10 17:14:28 +02:00
mfo
fc37bbaa4a
Merge pull request #10906 from mfo/US/reword-queueing
...
amelioration : ETQ operateur j'aimerais simplifier/optimiser la gestion des tâches asynchrones
2024-10-10 07:47:59 +00:00
mfo
b8b727f06b
feat(default.queues): mailers that are not critical are low, otherwise critical. analysis is default, purge is low
2024-10-10 09:31:20 +02:00
Colin Darie
9ef445a4a1
Merge pull request #10905 from tchak/fix-api-entreprise-sentry-error
...
ETQ Usager, je veux pouvoir déposer mon dossier même si le service des SIRET n'est pas disponible
2024-10-09 14:13:47 +00:00
LeSim
163fa42007
Merge pull request #10869 from demarches-simplifiees/add_id_to_column_second_part
...
Tech: utilise les objets `SortedColumn`
2024-10-09 13:05:50 +00:00
Colin Darie
cae5d8afed
feat(task): task enqueueing a maintenance task runnable on deploy
2024-10-09 13:44:17 +02:00
Colin Darie
d0f77d0aab
feat(task): with_statement_timeout helper for long running collection or process query
2024-10-09 13:44:17 +02:00
Paul Chavard
668aba8986
fix(api-entreprise): do not raise an error when the service is unavailable
2024-10-09 12:47:26 +02:00
Paul Chavard
e56bc9d35b
chore(prefill): remove unused prefill support on complex champs
2024-10-09 12:11:42 +02:00
simon lehericey
34b0379203
procedure.find_column raise NotFound to fit AR interface
2024-10-09 09:23:06 +02:00
simon lehericey
4f0cac251d
use sorted_column to sort dossier
2024-10-08 22:51:26 +02:00
simon lehericey
ba91f2f66e
remove now useless validation
2024-10-08 22:51:25 +02:00
simon lehericey
da98aa556b
use update(sorted_column:) and remove obsolete update_sort(column_id:, order:)
2024-10-08 22:51:25 +02:00
simon lehericey
21533f91e3
add storted_column_type
2024-10-08 22:47:37 +02:00
simon lehericey
305b31e53b
add sorted_column
2024-10-08 22:47:37 +02:00
simon lehericey
693629afc8
add column type
2024-10-08 22:47:36 +02:00
simon lehericey
a418cf6632
remove_filter double_write
2024-10-07 22:09:21 +02:00
simon lehericey
870d67e844
add_filter double write
2024-10-07 22:09:21 +02:00
simon lehericey
5f6d8e93ca
update_display double write
2024-10-07 22:09:20 +02:00
simon lehericey
98c2b7e954
update_sort double write
2024-10-07 22:09:20 +02:00
simon lehericey
a7ebe23504
migrate procedure_presentation to column
2024-10-07 22:09:20 +02:00
simon lehericey
a8b41e90cc
remove make_id
2024-10-07 21:47:03 +02:00
simon lehericey
3740a79219
add procedure_id to column.id
2024-10-07 21:46:59 +02:00
Paul Chavard
274e43c5e6
fix(dossier): projected champs should have updated_at
2024-10-05 22:22:04 +02:00
Paul Chavard
5cbdfd8677
Merge pull request #10882 from tchak/playwright-bun
...
chore(playwright): run playwright using bunx instead of default npx
2024-10-05 08:58:19 +00:00
Paul Chavard
70699a681d
Merge pull request #10889 from tchak/fix-dossier-follow-should-bump-updated-at
...
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-05 08:58:05 +00:00
Paul Chavard
7a39267473
refactor(spec): champs_* -> project_champs_*
2024-10-04 12:29:50 +02:00
Paul Chavard
8fdf5cbe80
refactor(dossier): explicitly build default values - less callbacks, less magic
2024-10-04 12:05:54 +02:00
Paul Chavard
25977fd97d
ETQ intégrateur d’API, je veux que le dossier soit remonté comme modifié quand ses instructeurs changent
2024-10-03 18:10:04 +02:00
mfo
5879d54145
Merge pull request #10866 from mfo/US/fix-filter-ilike
...
amelioration : ETQ instructeur, je souhaite pouvoir filtrer les dossiers sur mon tableau de bord fonction des choix simple/multiple/etc.. sans conflit parmis les autres valeurs de ces même choix simple/multiple/etc...
2024-10-03 13:08:49 +00:00
Colin Darie
3923e316e1
Merge pull request #10883 from colinux/helpscout-instructeur-notif
...
ETQ support je vois dans HS lorsqu'un instructeur a désactivé ses notifications
2024-10-03 09:12:15 +00:00
Colin Darie
a933e45e7b
feat(helpscout): warn when instructeur disabled notifs
2024-10-03 10:03:34 +02:00
Corinne Durrmeyer
480c8f493e
Remove nav when empty
2024-10-01 10:16:03 +02:00
Paul Chavard
9aee925ab1
chore(playwright): run playwright using bunx instead of default npx
...
without this change, specs fail on systems without node installed
2024-09-30 21:13:32 +02:00
simon lehericey
c638ac0261
rename drop_down_list_value -> drop_down_option_from_text
2024-09-30 15:37:02 +02:00
simon lehericey
532f0f48fa
replace drop_down_list_enabled_non_empty_options by drop_down_options when possible
2024-09-30 15:37:02 +02:00
simon lehericey
8b5f689a67
use drop_down_options when possible
2024-09-30 15:37:01 +02:00
simon lehericey
5a19cc1a09
remove drop_down_list_value reader
2024-09-30 15:37:01 +02:00
Paul Chavard
084a68a121
refactor(repetition): consolidate repetition manipulation methods
2024-09-27 11:34:06 +02:00
Mathieu Magnin
5e0ebb69f8
Merge pull request #10779 from demarches-simplifiees/fix-10753
...
ETQ Mainteneur je veux marqué les emails des instructeurs qui se sont connectés il y a < 5 mois comme vérifiés
2024-09-26 13:07:04 +00:00
mfo
1339e10280
bug(filter): filtering types_de_champs.value with ilike is trickier than expected. indead, some enum might overlap on word ex: Favorable, Defavorable. Searching with ilike Favorable finds Defavorable
2024-09-24 20:48:10 +02:00
mfo
0cbb296e7d
Merge pull request #10864 from mfo/US/fix-export-template-with-lots-of-types-de-champs
...
correctif: ETQ instructeur, j'aimerais pouvoir modifier mes modèles d'export, meme sur des démarches avec beaucoup de champs
2024-09-24 16:37:37 +00:00
mfo
b117bc9774
fix(export_template#preview): avoid 414 responses, using get method is not a good option for procedure with a lot of types_de_champ, otherwise we reach http get size limit
2024-09-24 18:07:18 +02:00
Lisa Durand
e1d9ea2a66
Merge pull request #10859 from demarches-simplifiees/improve-dossier-transfer-ldu
...
Améliorer le mail si un usager sans compte DS reçoit un transfert de dossier
2024-09-24 13:49:45 +00:00
Colin Darie
f700024df0
Merge pull request #10862 from colinux/fix-sva-with-complex-pending-corrections
...
ETQ usager: corrige la date prévisionnelle SVA lorsqu'il y a un mélange de demandes de corrections résolues et en attente
2024-09-24 12:35:26 +00:00
Colin Darie
99534ef834
Merge pull request #10812 from colinux/date-last-updated-at-tag
...
ETQ admin, créé les balises "date de mise à jour" du dossier et "date prévisionnelle SVA/SVR"
2024-09-24 12:21:07 +00:00
Colin Darie
b50d42fbb4
fix(sva): when there were resolved corrections and a pending correction
2024-09-24 12:48:09 +02:00
Lisa Durand
463e3e1538
improve email wording for transfert with DS account
2024-09-24 11:31:00 +02:00
Colin Darie
2b07826202
fix(sva): add sva/svr decision date tag for relevant template emails
...
Closes #10033
2024-09-24 11:28:18 +02:00
Colin Darie
861f7359b1
feat(attestation): support last champ updated at as tag
...
closes #9825
2024-09-24 11:28:17 +02:00
Colin Darie
655e4be0e7
Merge pull request #10858 from colinux/attestation-v2-better-v1-ording
...
ETQ admin, explique mieux que l'attestation v1 reste fonctionnelle alors que j'ai accès à la v2
2024-09-24 08:35:09 +00:00
Mathieu Magnin
af0692163b
Merge pull request #10839 from demarches-simplifiees/fix-10837
...
ETQ Administrateur, si j'oublie de renseigner le SIRET de mon service, je souhaite recevoir un message d'erreur explicite pour m'alerter.
2024-09-24 08:31:47 +00:00
Colin Darie
e7f5217211
chore(attestation): improve wording about v1/v2 switch
2024-09-24 10:18:00 +02:00
Eric Leroy-Terquem
7625ec5c8f
fix(manager): can add to super admin both roles of administrator and instructor if he is already one of them
2024-09-24 09:05:38 +02:00
Eric Leroy-Terquem
f16addd080
test(manager): nominal case of #add_administrateur_and_instructor
2024-09-24 09:05:37 +02:00
