Commit graph

5992 commits

Author SHA1 Message Date
Paul Chavard
95bb09a1f8 refactor(champs): do not depend on attributes hash key in old code 2024-04-22 18:38:59 +02:00
Colin Darie
c1d6c94df7
Merge pull request #10363 from colinux/simplecov
Tech: active le code coverage avec simplecov & codecov
2024-04-22 14:08:02 +00:00
Colin Darie
fa569c8bb4
ci: enable simplecov 2024-04-22 15:30:06 +02:00
Paul Chavard
f4f5416dd3
Merge pull request #10328 from tchak/refactor-dossier-champ-by-stable-id-controller
refactor(champs): update champs by public_id [controllers]
2024-04-22 12:23:16 +00:00
Paul Chavard
741712141a refactor(champs): add new champs controllers urls with stable_id and row_id 2024-04-22 13:55:02 +02:00
Paul Chavard
1021a31f7b refactor(dossier): use update_champs_private and update_champs_public methods 2024-04-22 13:55:02 +02:00
Paul Chavard
ee57d00507 refactor(champs): add new champ find strategy 2024-04-22 13:55:02 +02:00
Paul Chavard
0c7bc6b555 feat(dossier): add methods to upsert champ values 2024-04-22 13:55:01 +02:00
simon lehericey
cd808864b6
chore(spec): fix missing s in path 2024-04-22 11:59:28 +02:00
Eric Leroy-Terquem
f02cb19fd4
feat(gallery): display pieces jointes in a gallery 2024-04-22 11:09:10 +02:00
Paul Chavard
761ecf95b1
Merge pull request #10348 from demarches-simplifiees/fix_cron_operations_signature
Tech: repare le job de signature des operations
2024-04-22 08:22:38 +00:00
simon lehericey
9e33b1ee6d
fix: allow unsigned expert when restricted list 2024-04-19 13:03:09 +02:00
simon lehericey
2745be5672
chore: remove old code 2024-04-19 08:48:17 +02:00
simon lehericey
8f8b63ac6a
fix: load the dols day by day 2024-04-19 08:48:17 +02:00
Colin Darie
2f1b1ba5fe
fix(mailers): hardcode default url options host because APP_HOST is not yet migrated 2024-04-18 18:44:32 +02:00
Paul Chavard
ff2c691c18
Merge pull request #10345 from demarches-simplifiees/try_fix_flaky_address
Tech: essaye de corriger un test non fiable relatif aux adresses
2024-04-17 15:08:17 +00:00
Paul Chavard
2c9f809a46
Merge pull request #10250 from mfo/US/add-missing-validators
tech(champs.validators): dry and standardize champs.validations
2024-04-17 15:06:47 +00:00
mfo
009738f26b
Merge pull request #10313 from mfo/US/stop-using-placeholder-and-title-attribute
ETQ usage, je souhaite que les aides à la saisie soient vocalisées par le screenreader
2024-04-17 14:57:14 +00:00
simon lehericey
e1034f996b
fix: try fix flaky address spec 2024-04-17 16:19:49 +02:00
Colin Darie
09dd31829a
Merge pull request #10286 from demarches-simplifiees/fix-app-name-hardcoded
ETQ admin: form des infos de démarche plus lisible
2024-04-17 08:14:39 +00:00
mfo
94891b8695
fix(Champ.number): remove placeholder 2024-04-17 07:31:32 +02:00
mfo
6d84c38fca
tech(deadspec): no more brouillon context on dossier validation 2024-04-17 06:27:26 +02:00
mfo
aca67a2274
tech(refactor.champs.validation): all champs validation use :validate_champ_value_or_prefill? 2024-04-17 06:27:26 +02:00
simon lehericey
981003975c
refactor: use last_sign_in_at as confirmed_at is not reliable 2024-04-16 17:58:30 +02:00
simon lehericey
d95ce505a8
feat: suggest recently added user even if its not confirmed 2024-04-16 17:58:30 +02:00
simon lehericey
8d95df2250
feat: do not suggest unconfirmed experts 2024-04-16 17:58:30 +02:00
simon lehericey
5cd780251b
refactor: mutualize email_expert logic 2024-04-16 17:58:29 +02:00
Colin Darie
b336e1b606
chore(admin): fix hardcoded application names in translations 2024-04-16 17:55:09 +02:00
Colin Darie
71b0592b0a
Merge pull request #10336 from colinux/fix-address-without-postcode
Usager: fix champ adresse dans un TOM sans code postal dans la BAN (ex. Nouvelle-Calédonie à Nouméa)
2024-04-16 13:45:04 +00:00
Colin Darie
db65c9178e
fix(address): BAN does not return postcode for some TOM like Nouvelle-Calédonie
But we have to fallback to an empty string because API graphql / serializer
expects a non-null attribute.
2024-04-16 15:37:56 +02:00
Paul Chavard
08e127c120 chore(spec): remove test for old unused behaviour 2024-04-16 12:10:08 +02:00
Paul Chavard
ee56a7da21 refactor(champ): remove stable_id delegate to type_de_champ 2024-04-16 12:10:07 +02:00
Lisa Durand
7a80574afc
Merge pull request #10190 from demarches-simplifiees/add-AR-feature-ldu
ETQ Admin je peux configurer une démarche avec accusé de lecture
2024-04-16 09:58:13 +00:00
simon lehericey
6982b2d5e8
refactor: do not enqueue antivirus job for safe blob 2024-04-16 09:57:31 +02:00
Colin Darie
e3dbbf2009
Merge pull request #10235 from colinux/page-404
Pages d'erreur personnalisées / au dsfr
2024-04-15 21:12:04 +00:00
simon lehericey
7035f82bfb
fix: flaky test 2024-04-15 14:24:25 +02:00
Lisa Durand
c6e2e6445c add instructeur feedback on accuse de lecture agreement 2024-04-15 12:10:28 +02:00
Lisa Durand
a29719a15c small adjustments from PR feedbacks 2024-04-15 11:15:13 +02:00
Lisa Durand
71268c7f3b hide decision from email for tiers if procedure has accuse de lecture 2024-04-15 11:15:13 +02:00
Lisa Durand
18602e046a fix specs 2024-04-15 11:15:13 +02:00
Lisa Durand
1cf3db5899 hide dossier with accuse de lecture in user list when using state filter 2024-04-15 11:15:13 +02:00
Lisa Durand
5bbc4cab50 hide decision displayed in messagerie with auto commentaire 2024-04-15 11:15:13 +02:00
Lisa Durand
8fe9b174eb hide decision displayed in badge for user 2024-04-15 11:15:13 +02:00
Lisa Durand
e486f789f6 add AR in user view - hide decision on second dossier tab 2024-04-15 11:15:13 +02:00
Lisa Durand
8eda069bfc add AR in user view - hide decision on first dossier tab 2024-04-15 11:15:13 +02:00
Lisa Durand
ae08044ff2 create AR email and send it at the right time 2024-04-15 11:15:05 +02:00
Paul Chavard
ea47ba3747 fix(commune): no crash on blank codes 2024-04-15 11:01:15 +02:00
mfo
f1935eb7a0
Merge pull request #10318 from mfo/US/better-error-messages
ETQ Usager, je souhaite avoir des messages d'erreur homogènes et comprehensibles
2024-04-12 11:55:39 +00:00
mfo
938f5043a4
feat(champs.validation): standardize champ error messages 2024-04-12 11:39:43 +02:00
mfo
4773d9ebad
feat(Champ.repetition): hide destroy button of first repetition row when the repetition is mandatory 2024-04-12 09:29:00 +02:00
Colin Darie
a93a4cd5ce
chore: specific 422 error page 2024-04-11 18:19:32 +02:00
Colin Darie
5b98fd7c6d
chore: generic customized error page 2024-04-11 18:19:31 +02:00
Colin Darie
5d23b37f59
chore: custom dynamic & static 500 pages 2024-04-11 18:19:30 +02:00
Eric Leroy-Terquem
1e50223267
Merge pull request #10293 from demarches-simplifiees/re-router-tous-les-dossiers-d-une-demarche
ETQ tech je peux relancer le routage pour tous les dossiers en construction d'une démarche
2024-04-11 13:27:43 +00:00
simon lehericey
c77b66feef
refactor: api_geo_services raises if wrong dep or city code 2024-04-11 11:56:53 +02:00
simon lehericey
5567570d74
more robust normalization 2024-04-10 10:57:37 +02:00
Lisa Durand
758673a355
Merge pull request #10280 from demarches-simplifiees/ux-improve-usager-filter-dropdown-ldu
[UX] Améliorer les filtres d'un dossier sur le tableau de bord d'un usager
2024-04-10 07:18:55 +00:00
Eric Leroy-Terquem
51312b178e
task(routing): reroute dossiers en construction 2024-04-09 17:17:49 +02:00
Colin Darie
4bbe136987
Merge pull request #10283 from demarches-simplifiees/fix-main-menu-a11y
Remplacement de l'attribut `aria-current="page"` par `aria-current="true"` lorsque le lien concerne un ensemble de pages
2024-04-09 08:57:09 +00:00
Colin Darie
3c7018fd31 fix: don't set preferred domain on signup/signin unless feature is enabled 2024-04-09 10:04:18 +02:00
Corinne Durrmeyer
8999fe3aa2
fix(spec): Replace 'page' with 'true' 2024-04-08 12:30:20 +02:00
Paul Chavard
df8ad3f709 fix(adresse): fallback to city name if commune not found 2024-04-08 11:49:37 +02:00
Lisa Durand
e2d83d87d2 change wording in usager filter and target css to combobox component 2024-04-08 10:41:39 +02:00
LeSim
22830fd7f6
Merge pull request #10275 from demarches-simplifiees/fix_api_entreprise_status
Tech: corrige le mécanisme de surveillance des fournisseurs d entreprise.api.gouv.fr
2024-04-08 08:08:38 +00:00
Paul Chavard
c5c671f391
Merge pull request #10234 from tchak/type-de-champ-paths
feat(champ): add paths to type_de_champ
2024-04-08 08:07:30 +00:00
simon lehericey
e82a8787d5
dirty fix: avoid changing preferred domain 2024-04-05 15:26:12 +02:00
Paul Chavard
ce95fe1794
Merge pull request #10255 from demarches-simplifiees/fix-move-after-edit-list
ETQ Administrateur : Amélioration de l'accessibilité et de l'ergonomie de la liste d'édition du formulaire "déplacer après"
2024-04-05 11:39:55 +00:00
Paul Chavard
80b3f0c0b3 fix(champ): no validate on hidden champs 2024-04-05 13:24:57 +02:00
Paul Chavard
9edf0f5450 fix(spec): add- between position and label 2024-04-05 12:55:19 +02:00
simon lehericey
42f0b87c39
remove api_up? 2024-04-05 12:27:54 +02:00
simon lehericey
7b33963a67
add and use api_djepva_up? 2024-04-05 12:27:26 +02:00
simon lehericey
e994738a2e
add and use api_insee_up? 2024-04-05 12:26:44 +02:00
Paul Chavard
282ce1322c fix(stats): more accurat stats about deleted dossiers 2024-04-04 19:00:48 +02:00
Paul Chavard
38a703034e feat(champ): expose paths 2024-04-04 16:13:23 +02:00
Paul Chavard
9593e8825f chore(browser): be more agressive about browser deprecation 2024-04-04 13:53:41 +02:00
Colin Darie
8af3f07181
Merge pull request #10231 from colinux/fix-gouv-fr-banner
Tech: petites corrections pour le .gouv
2024-04-04 09:02:03 +00:00
Colin Darie
8c0375fe6f
chore: easier to test .gouv / new host using APP_HOST 2024-04-02 19:36:39 +02:00
Colin Darie
36fc535386
refactor(mailer): for devise mailer set locale in dedicated action 2024-04-02 19:25:44 +02:00
Colin Darie
68ee4a3404
feat(mail): use contextualized Current.application_name 2024-04-02 18:47:48 +02:00
Colin Darie
21991d7253
feat(mail): link with hosts for recipient for user mailer 2024-04-02 18:47:46 +02:00
Colin Darie
5bf580b6ac
feat(mail): link with hosts for recipient for notification mailer 2024-04-02 18:47:45 +02:00
Colin Darie
f8a9e72aa2
feat(mail): from and link with host for recipient in dossier_mailer 2024-04-02 18:47:44 +02:00
Colin Darie
3512e071d3
feat(mail): devise mailer respect user preferred host for any mail 2024-04-02 18:47:43 +02:00
Colin Darie
d14fe83261
feat(mail): devise confirmation instructions respect user preferred host 2024-04-02 18:47:41 +02:00
Colin Darie
863784a1a9
test: configure default host on APP_HOST everywhere 2024-04-02 18:47:40 +02:00
LeSim
2ea45d5dba
Merge pull request #10251 from colinux/exports-reduce-memory
Tech (exports): télécharge les PJ > 10mb en chunks pour ne pas les mettre en mémoire
2024-04-02 14:48:33 +00:00
Paul Chavard
61a6f0b382
Merge pull request #10243 from demarches-simplifiees/small_job_fixes
Tech: petites corrections pour éviter les réessais inutile sur les jobs de mail et de rnf
2024-04-02 14:09:55 +00:00
Colin Darie
e23e2d9c31
perf(export): download in chunks files >= 10 mb 2024-04-02 15:54:46 +02:00
mfo
84f0891a8b
Merge pull request #10245 from demarches-simplifiees/US/fix-attestation-link
correctif(lien.attestation): ETQ expert, je souhaite avoir accès à l'attestation même si je ne suis pas instructeur
2024-04-02 08:14:37 +00:00
mfo
3a895fbd4a
tech(review): add a guard clause to prevent missing pdf, enhance specs 2024-04-02 10:04:22 +02:00
simon lehericey
8405c83c12
fix: do not retry rnf bad request 2024-04-02 10:00:07 +02:00
mfo
284a10e235
fix(Champs::EngagementJuridiqueChamp): validates Champs::EngagementJuridiqueChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
d7f152f4af
fix(Champs::PhoneChamp): validates Champs::PhoneChamp respecting it's validation context. 2024-04-01 07:18:14 +02:00
mfo
374d763084
fix(Champs::IntegerNumberChamp): validates Champs::IntegerNumberChamp respecting it's validation context. 2024-04-01 07:18:13 +02:00
mfo
fd5faad31f
fix(Champs::PaysChamp): validates Champs::PaysChamp respecting it's validation context. Also do not save value when external_id/code can't be found by lookup 2024-04-01 07:18:13 +02:00
mfo
04f3b6a844
fix(Champs::DecimalNumberChamp): validates Champs::DecimalNumberChamp respecting it's validation context 2024-04-01 07:07:11 +02:00
mfo
b07bbfa455
bug(instructeurs/dossiers#update_annotations): should works if a champ_public is invalid 2024-04-01 07:07:10 +02:00
Martin
2944a0c2c3
fix(expert.attestation.url): was pointing to attestation_instructeur_dossier_path, so did not worked when expert was not instructeur. use active_storage_link, secured enough because served to authenticated users as well as expiring link 2024-03-30 06:20:11 +01:00
Lisa Durand
65b8f6881a
Merge pull request #10143 from demarches-simplifiees/float-too-many-decimal-ldu
ETQ admin, je veux que le champ nombre décimal ne prenne que 3 chiffres après la virgule
2024-03-27 10:05:35 +00:00
Lisa Durand
a3ab6dd257 add validation on decimal max 3 digits after coma 2024-03-27 10:55:10 +01:00