Commit graph

12218 commits

Author SHA1 Message Date
Pierre de La Morinerie
3f3d6ae399 controllers: use template: rather than file: to render PDFs
ActionView now throws an error if a relative path is used with `file:`.
2021-03-25 13:24:53 +01:00
Pierre de La Morinerie
185c74d891 dossier: fix SQL deprecation error
ActiveRecord 6.1 disallows passing strings to the `order()` function, to
prevent SQL injections.

Here we know that the order string is safe: `ts_vector` is constant,
and `ts_query` is properly escaped.

Wrap the SQL fragment in Arel.sql to bypass the error.
2021-03-25 13:24:53 +01:00
Pierre de La Morinerie
21356e42b8 specs: remove unused require 2021-03-25 13:24:53 +01:00
Pierre de La Morinerie
305a312815 db: migrate ActiveStorage to Rails 6.1 2021-03-25 13:24:53 +01:00
Pierre de La Morinerie
5990439ab7 app: update code to Rails 6.1 2021-03-25 13:24:53 +01:00
Pierre de La Morinerie
de9fab701a gems: use Rails 6.1 gems 2021-03-25 13:24:53 +01:00
Pierre de La Morinerie
66ffbf77a5
Merge pull request #5991 from betagouv/localize-sign-in-form
Usagers : traduction de la page `/users/sign_in` en anglais (derrière un feature-flag) (#5991)
2021-03-25 12:05:36 +01:00
lydiasan
8dce3e5d2a i18n: localize users/sign_in page 2021-03-25 11:59:05 +01:00
Pierre de La Morinerie
1d18df1d3a
Merge pull request #6018 from betagouv/fix-schema
Correction du schéma des experts
2021-03-25 11:54:42 +01:00
kara Diaby
2165b5bcc6 fix tmp expert migrated on schema 2021-03-25 11:48:19 +01:00
Pierre de La Morinerie
07aa588edf
Merge pull request #6002 from betagouv/remove-useless-code-avis-table
Nettoyage du code de migration des Experts (#6002)
2021-03-25 10:12:34 +01:00
kara Diaby
18f89b0d83 adjust tests 2021-03-24 17:47:24 +01:00
kara Diaby
fff6725799 modify api and serializer 2021-03-24 17:47:24 +01:00
kara Diaby
d17fdfec77 modify layout 2021-03-24 17:47:24 +01:00
kara Diaby
2930de1015 remove useless code in models 2021-03-24 17:47:24 +01:00
kara Diaby
fe7fb882c8 remove useless routes 2021-03-24 16:20:44 +01:00
kara Diaby
71973de17c remove useless columns from the db 2021-03-24 16:20:44 +01:00
krichtof
8e1569a658
Merge pull request #6016 from betagouv/5493-detect-staging
detect staging env
2021-03-24 15:39:39 +01:00
Christophe Robillard
83cf0fa903 detect staging env 2021-03-24 15:30:12 +01:00
Kara Diaby
db7603efb7
Merge branch 'production' into main 2021-03-24 09:51:34 +01:00
Kara Diaby
4abf5cf958
Merge pull request #6014 from betagouv/clean-avis
After party task to backfill experts_procedure_id on avis table
2021-03-24 09:42:07 +01:00
kara Diaby
fdc6521d02 After party task to backfill experts_procedure_id on avis table 2021-03-24 09:23:26 +01:00
Pierre de La Morinerie
909f1ba9ac
Merge pull request #6011 from betagouv/display-pdf-export-on-two-columns
Export PDF : les valeurs des champs sont maintenant affichés sur deux colonnes (#6011)
2021-03-23 17:11:33 +01:00
maatinito
a29fb5cc5b dossier pdf: display form fields in two columns (instead of 2 lines)
Identity fields are displayed on two columns, but until now Dossier
fields were displayed on two lines.

This was because of a bug in format_in_2_columns, where the multiple-
lines fields were not handled properly.

This has been fixed a while back by @maatinito, so we can now enable
two-columns formatting even for Dossier fields.
2021-03-23 17:02:52 +01:00
Pierre de La Morinerie
a580b7daf9
Merge pull request #6010 from betagouv/fix-missing-attestation-message
Instructeur : correction du message d'avertissement lorsqu'un champ d'attestation est manquant (#6010)
2021-03-23 17:02:44 +01:00
maatinito
cc19453f68 views: fix warning message about incomplete fields for attestation
The labels for the champs and private champs were inverted.
2021-03-23 16:56:02 +01:00
Kara Diaby
629ca86897
Merge pull request #6012 from betagouv/main
2021-03-23-02
2021-03-23 15:36:05 +01:00
Kara Diaby
922e157e16
Merge branch 'production' into main 2021-03-23 15:28:52 +01:00
Kara Diaby
b2a0bc1e6a
Merge pull request #6006 from betagouv/fix-avis-concern
backfill experts_procedure_id on avis table
2021-03-23 15:27:59 +01:00
kara Diaby
81d4db2afc backfill missing experts_procedure_id on avis table 2021-03-23 15:15:34 +01:00
Paul Chavard
96d286d2b8
Merge pull request #6009 from betagouv/main
2021-03-23-01
2021-03-23 14:06:31 +01:00
Paul Chavard
b730774118
Merge pull request #6008 from tchak/experts_procedure_non_optional
experts_procedure should not be optional
2021-03-23 13:58:46 +01:00
Paul Chavard
0b22788d60 experts_procedure should not be optional 2021-03-23 13:46:33 +01:00
Pierre de La Morinerie
25c85dd0f9
Merge pull request #6007 from tchak/fix-test-exports
Instructeur : les champs non-exportables sont correctement exclus de l'export (corrige l'export de certaines démarches) (#6007)
2021-03-23 11:56:47 +01:00
Paul Chavard
224c7ec6c3
Update spec/models/dossier_spec.rb
Co-authored-by: Pierre de La Morinerie <kemenaran@gmail.com>
2021-03-23 10:51:55 +01:00
Paul Chavard
84214f4bd4 Do not export non exportable champs on draft procedures 2021-03-23 09:55:37 +01:00
Kara Diaby
3140c473e7
Merge pull request #6005 from betagouv/main
2021-03-22-01
2021-03-22 15:49:33 +01:00
Kara Diaby
93e1852109
Merge branch 'production' into main 2021-03-22 15:40:32 +01:00
Kara Diaby
4d639dedce
Merge pull request #6004 from betagouv/fix-avis-data
after party task to clean existing data on avis table
2021-03-22 15:39:21 +01:00
kara Diaby
1c134fdf09 after party task to clean existing data on avis table 2021-03-22 15:29:28 +01:00
Kara Diaby
0c6cf93376
Merge pull request #6003 from betagouv/main
2021-03-22-01
2021-03-22 10:56:10 +01:00
Pierre de La Morinerie
8f383e77d5
Merge pull request #5998 from betagouv/bootsnap
Utilisation de Bootsnap pour accélérer le démarrage de l'application Rails
2021-03-19 08:12:21 +01:00
Pierre de La Morinerie
56b3601063 app: enable Bootsnap
Bootsnap speeds up the initial loading of the Rails app by:
- Optimizing the LOAD_PATH dynamically
- Caching the result of Ruby bytecode compilation

Cached data are written to `tmp/cache/bootsnap*`.

This is enabled in the default Rails app template.
2021-03-19 08:05:14 +01:00
Pierre de La Morinerie
5e7424a782
Merge pull request #5999 from betagouv/remove-unused-mailer
Nettoyage : suppression d'un mailer inutilisé
2021-03-19 08:04:39 +01:00
Pierre de La Morinerie
1cb430a87a lib: remove unused AttestationClosedMailDiscrepancyMailer 2021-03-19 07:57:56 +01:00
Kara Diaby
372a4e8eee
Merge pull request #6000 from betagouv/fix-experts-lookup
Correction de DossiersController#avis_for_expert
2021-03-18 20:55:30 +01:00
Kara Diaby
38837443aa
Merge branch 'main' into fix-experts-lookup 2021-03-18 20:46:56 +01:00
Pierre de La Morinerie
d42156b494
Merge pull request #5997 from tchak/fix-mandatory-multiple-drop-down
Usager : un champ "Liste déroulante à choix multiple" est correctement détecté comme vide si aucun élément n'a été ajouté (#5997)
2021-03-18 18:09:46 +01:00
Pierre de La Morinerie
239169e925 dossier: fix looking-up avis from Expert
This line causes an error on Rails 6.1.

And it isn't even necessary: this line is supposed to query avis where
the expert advice has been requested – but this is handled by the
`if expert.dossiers.include?(self)` condition just above.
2021-03-18 17:59:30 +01:00
Paul Chavard
1449fbbe67 Fix multiple_drop_down_list mandatory check 2021-03-18 15:22:28 +01:00