Commit graph

169 commits

Author SHA1 Message Date
Paul Chavard
7ee90b6d85
refactor(champ): validate only champs in revision 2024-12-09 10:06:13 +01:00
mfo
a88325e224
fix(sentry#6088812113): avoid crash when trying to export a repetition which is not in a dossier revision 2024-11-26 11:05:15 +01:00
Paul Chavard
71009094a4
refactor(type_de_champ): improve and clean helper methods 2024-11-20 10:18:51 +01:00
Paul Chavard
dc6bad40fe
refactor(type_de_champ): cleanup type predicate methods 2024-11-12 12:02:08 +01:00
Paul Chavard
5182af820a
refactor(type_de_champ): type_de_champ should not expose revision or procedure 2024-11-05 21:57:05 +01:00
benoitqueyron
4f62590b7a
ProcedureRevision#compare_type_de_champ: fix bug comparaison character_limit chaine vide vs nil 2024-10-15 14:40:33 +02:00
Paul Chavard
8fdf5cbe80
refactor(dossier): explicitly build default values - less callbacks, less magic 2024-10-04 12:05:54 +02:00
Paul Chavard
084a68a121
refactor(repetition): consolidate repetition manipulation methods 2024-09-27 11:34:06 +02:00
Paul Chavard
6254b50de9
Revert "Revert "Merge pull request #10771 from tchak/refactor-champs-revert""
This reverts commit 10a1ae5534.
2024-09-23 10:21:07 +02:00
simon lehericey
10a1ae5534
Revert "Merge pull request #10771 from tchak/refactor-champs-revert"
This reverts commit c902061ebf, reversing
changes made to b4ed11c788.
2024-09-19 11:09:01 +02:00
simon lehericey
2f64fe5e4c
one less indirection 2024-09-18 10:08:12 +02:00
Paul Chavard
3fef831524
move child? method for clarity 2024-09-17 10:29:34 +02:00
Paul Chavard
54132df77d
dossier(champ): validate presence of row_ids 2024-09-17 10:29:34 +02:00
Colin Darie
77fb0553fc
chore: enable freeze string literals by comment 2024-08-22 09:26:48 +02:00
Paul Chavard
337eaff3f0
Merge pull request #10602 from demarches-simplifiees/fix-routing-fields-list
Correctif : ouvre l‘assistant de routage à tous les types de champ conditionnables
2024-07-30 09:01:24 +00:00
Paul Chavard
229483d16c
refactor(champ): remove type_de_champ_id and champ factories 2024-07-22 13:53:45 +02:00
Eric Leroy-Terquem
60ff785009
refactor(type de champ): rename routable_types in simple_routable_types 2024-07-11 12:17:46 +02:00
mfo
24d7b0b014
fix(ineligibilite_rules): prevent admin to enable ineligibilite rules without rules 2024-06-20 15:35:36 +02:00
mfo
f819da8921
tech(clean): simplify implementation of eligibilite rules, code, enhance wording and test coverage 2024-06-11 09:57:36 +02:00
mfo
a011576757
feat(procedure_revision.validates): ineligibilite_rules 2024-06-11 09:39:21 +02:00
mfo
5644692448
feat(Logic.computable?): add computable? to know if a ineligibilite_rules set is computable 2024-06-11 09:32:53 +02:00
mfo
5de4ce889f
feat(ProcedureRevision.ineligibilites_rules): keep track of changes and show it to admin for republication 2024-06-11 09:32:53 +02:00
mfo
aca3e38859
feat(ProcedureRevision.ineligibilite_rules): add ineligibilite_rules management to procedure revision based on conditional logic 2024-06-11 09:32:53 +02:00
mfo
12d23f1498
feat(Procedure::Cards::IneligibleDossier): add an ineligibilite dossier card to procedure dashboard 2024-06-11 09:32:53 +02:00
mfo
ef3ca9839b feat(procedure.validation): extract validation context: types_de_champ_public_editor, types_de_champ_private_editor and publication [combining both contextes]. validate conditions, headers_sections, regexp on type_de_champ_private too. dry validation 2024-06-04 18:25:24 +02:00
simon lehericey
bda9c4b455
fix: drop unused column and fk procedure_revisions.attestation_template_id which block procedure.destroy 2024-04-11 13:38:38 +02:00
Paul Chavard
ceae749746 chore(db): ignore attestation_template_id 2024-04-11 12:03:06 +02:00
Martin
44cdb14fb9 feat(type_de_champ_editor): move champs after another champ. 2024-03-22 10:10:28 +01:00
Paul Chavard
eff03aaf23 refactor(dossier): label indexes based on type_de_champ not champ 2024-03-20 09:58:47 +01:00
Paul Chavard
aa0aea1543 refactor(dossier_vide): use types_de_champ instead of empty dossier 2024-03-12 14:23:07 +01:00
Paul Chavard
9b26dedab4 refactor(dossier): make new methods arguments named 2024-03-04 10:59:11 +01:00
Paul Chavard
283ee72d51 refactor(dossier): implement champs_for_revision 2024-03-04 10:59:11 +01:00
Martin
3e64a3bbbc tech(refactor): extract clone logic inside its own class 2024-02-16 11:23:39 +01:00
Martin
ecc83edf4f wip 2024-01-26 13:43:10 +01:00
Martin
0e5768ec5b fixup! perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-26 09:45:59 +01:00
Martin
271ac14fad perf(draft_changed?): do not try to compare revisoin if they are not loaded 2024-01-25 17:20:30 +01:00
Martin
60800b6113 perf(editor): better perf to add, destroy, update, move up, move down and move with number 2024-01-25 15:49:44 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
Martin
0f194a5e8e refactor(procedure_revision): without renumber, use types_de_champ_public factory for ordered champs 2024-01-22 14:57:04 +01:00
mfo
89d2c57cb2 review(sim): some review suggestions
Co-authored-by: LeSim <mail@simon.lehericey.net>
2024-01-22 14:57:04 +01:00
Martin
434cd77030 poc(spec): renumber only at one point 2024-01-22 14:57:04 +01:00
Martin
a9c0d3e7e9 tech(clean): avoid useless indirection, cleanup some code complexity, rubocopify 2024-01-22 14:57:04 +01:00
Martin
a78a6b6f34 feat(remove_type_de_champ): stop renumbering all procedure_revision_type_de_champ on remove_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4d97c5bc8a feat(move_type_de_champ): stop renumbering all procedure_revision_type_de_champ on move_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
4b57ed871a feat(add_type_de_champ): stop renumbering all procedure_revision_type_de_champ 2024-01-22 14:57:04 +01:00
Martin
e43c2f1407 feat(procedure_revision.compate): track and show diff for TypeDeChamp.explication between draft and published revisions 2023-12-19 10:51:06 +01:00
Kara Diaby
1d66b47300 Prend en charge les révisions sur les démarches 2023-10-16 08:53:52 +00:00
Kara Diaby
a26df43577 User : Ajoute le type de champ Expression régulière coté utilisateur 2023-10-16 08:53:52 +00:00
Kara Diaby
9bf1c65dec Procedure Revision and tests 2023-10-16 08:53:52 +00:00
Eric Leroy-Terquem
956048ffea refactor(type de champ): extract routable? method 2023-09-15 10:02:14 +02:00