Commit graph

3080 commits

Author SHA1 Message Date
Colin Darie
17f5fb4a51
refactor(declarative): process dossier in job isolation 2023-06-14 12:06:22 +02:00
Paul Chavard
b3aeb46c1b fix(prefill): it should be possible to prefill a dossier on a test procedure 2023-06-14 09:14:12 +01:00
Lisa Durand
4b6d18608e split pj in two lists regarding to conditionnal 2023-06-13 11:00:16 +02:00
Lisa Durand
d2f91a6405 add list of PJ in procedure description 2023-06-13 10:58:05 +02:00
Paul Chavard
6723bdcd9d fix(carto): no crash on points with elevation 2023-06-12 14:56:52 +02:00
Colin Darie
75b2685230 fix(instructeurs): human format a filtered date 2023-06-08 19:01:23 +02:00
Paul Chavard
c4432b1b47 perf(carto): use json schema to validate geojson instead of rgeo 2023-06-06 15:43:56 +02:00
Colin Darie
66dc8f251f
Merge pull request #9128 from colinux/fix-procedure-presentation-show-avis
ETQ instructeur je veux pouvoir afficher sans erreur la colonne "avis"
2023-06-05 08:53:39 +00:00
Colin Darie
7e567d5080
fix(instructeurs): don't crash when displaying "avis" column 2023-06-02 17:07:02 +02:00
Colin Darie
b1bcc784bb
refactor(messagerie): preload commentaires with corrections & attachments blobs 2023-06-02 16:18:33 +02:00
Colin Darie
7f871728c7
refactor(message): badges à corriger/en attente/corrigé when related to a correction 2023-06-02 16:18:33 +02:00
Colin Darie
52c8553576
fix(dossier_correction): don't allow to save with a missing (invalid) commentaire 2023-06-02 16:18:33 +02:00
Colin Darie
b495e0aff0
feat(user): dossier résumé with commentaire about corrections 2023-06-02 16:18:32 +02:00
Colin Darie
62cc9d30d8
chore(correction): passing en_instruction resolve pending corrections 2023-06-02 16:16:14 +02:00
Colin Darie
5ab44fc7a9
chore: rename dossier_resolution => dossier_correction 2023-06-02 16:16:14 +02:00
Colin Darie
b14a70abf7
feat(instructeur): filter dossiers "en attente" 2023-06-02 16:16:14 +02:00
Colin Darie
9565267170
feat(dossier): notify user by email about pending corrections 2023-06-02 16:16:13 +02:00
Colin Darie
ca3b127942
feat(instructeur): can flag a dossier as "pending corrections" 2023-06-02 16:16:12 +02:00
Colin Darie
d73b96ea40
feat(dossier): pending resolution state 2023-06-02 16:13:16 +02:00
Colin Darie
2c79ca94f5
chore(schema): create dossier_corrections 2023-06-02 16:13:15 +02:00
Colin Darie
ec244f1a94
fix(procedure): auto_archive_on must be in future 2023-06-01 16:49:52 +02:00
Eric Leroy-Terquem
e8d687f5e7 fix(routing): routing engine works even with unconfigured groups 2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
54fe10ff76 add warning in revision change component if tdc options used for routing has been changed 2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
50abf496fd add warning in gi pages in rule does not match tdc 2023-05-31 11:38:16 +02:00
simon lehericey
25ebfc4928 always set procedure.instructeurs_self_management_enabled to true when routing_enabled? 2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
692010fa32 destroy all groups but defaut 2023-05-31 11:38:16 +02:00
simon lehericey
f61498693a use routable_type_de_champ 2023-05-31 11:38:16 +02:00
simon lehericey
5b0e0ced3c add groupes_management_component 2023-05-31 11:38:16 +02:00
Lisa Durand
a20ec44841
Merge pull request #9074 from demarches-simplifiees/add-more-info-on-procedure-description
[Refonte page accueil demarche] Détailler la description pour plus de clarté pour l'usager
2023-05-30 09:45:32 +00:00
krichtof
0051face93
Merge pull request #9014 from demarches-simplifiees/8859-default_zones
Etq admin, lors de la création ou modification d'une démarche, des zones par défaut me sont suggérées
2023-05-26 17:25:21 +00:00
Christophe Robillard
1bda86be03 suggest default zones 2023-05-24 17:40:00 +02:00
Christophe Robillard
b13e77650e update default zones after admin creation 2023-05-24 17:40:00 +02:00
Colin Darie
795e0ca471
fix(fork): can fork a dossier having invalid champs so it can be fixed in brouillon 2023-05-24 12:15:43 +02:00
Lisa Durand
7340206f81 rollback - add just one new field and use actual description field 2023-05-24 11:31:24 +02:00
Paul Chavard
cf13b942e7
Merge pull request #9076 from colinux/fix-instructeurs-filter-avis
ETQ instructeur je peux filtrer les dossiers par avis
2023-05-24 08:05:07 +00:00
Lisa Durand
b6cc35df68 fix specs 2023-05-23 10:34:03 +02:00
Colin Darie
ff8fba3725
fix(instructeur): can filter by avis answer 2023-05-23 09:40:21 +02:00
Lisa Durand
4a51a9a351 add two more fields for procedure description what et and for_who 2023-05-22 15:36:48 +02:00
Colin Darie
d16b81e09c fix(rebase): don't fail on force rebased when procedure is still in draft 2023-05-22 13:50:58 +02:00
Paul Chavard
a2e98f9065
Merge pull request #9051 from demarches-simplifiees/fix-bug-procedure-clone-validations
[fix] Vider les champs invalides pour permettre de cloner une procedure
2023-05-17 07:44:39 +00:00
Lisa Durand
7e39e8113b feedback PR Colin 2023-05-16 17:54:37 +02:00
Martin
f76e52cc97 tech(tache.recovery): ajoute une tache pour re-importer des dossiers venant d'un backup
Update app/lib/recovery/exporter.rb

Co-authored-by: Colin Darie <colin@darie.eu>
2023-05-16 14:49:36 +02:00
simon lehericey
06b6663662 import more stuff 2023-05-16 14:49:36 +02:00
Lisa Durand
f2cf3188d7 empty invalid fields to allow clone procedure 2023-05-16 10:59:17 +02:00
Christophe Robillard
34540d34e9 create default_zones_administrateurs 2023-05-16 09:40:53 +02:00
Christophe Robillard
3705dc2553 determine default zones according to tchap hs 2023-05-16 09:40:53 +02:00
Christophe Robillard
a191f66508 add tchap hs to zone 2023-05-16 09:40:53 +02:00
Colin Darie
8592571b50
Merge pull request #9034 from colinux/editor-typo
Admin: corrige une typo dans une option de nombre de caractères limite
2023-05-15 11:41:21 +00:00
Colin Darie
ec6d9f4e33
Merge pull request #9035 from colinux/fork-fix-champ-pj-updated-at
Correctif: ETQ usager le champ PJ d'un dossier en construction ne doit pas être marqué "à déposer" sans raison
2023-05-15 10:33:10 +00:00
Colin Darie
d3028f5570
Merge pull request #9037 from demarches-simplifiees/fix-bug-alert-batch-incrementation
[Fix] Actions multiples - Corriger le compteur dans les alertes + ajouter des infos sur le créateur du batch
2023-05-15 10:32:31 +00:00
Colin Darie
0d21450f8a
fix(fork): don't let active storage override our champ#updated_at after a transaction 2023-05-15 11:08:07 +02:00
Paul Chavard
f485f144fc chore(procedure): log dossiers before reset 2023-05-15 10:21:54 +02:00
Paul Chavard
b4a299c326 fix(user): always rebase original dossier before merge 2023-05-12 20:42:02 +02:00
simon lehericey
26fa5de790 avoid reset 2023-05-12 11:31:34 +02:00
simon lehericey
6148f24387 Revert "Merge pull request #9002 from tchak/feat-procedure-clone-preview-published"
This reverts commit 7a6f46a8ad, reversing
changes made to 4513c52213.
2023-05-12 11:29:11 +02:00
simon lehericey
7b17bfe0a1 feat: add info for screen reader 2023-05-12 10:03:54 +02:00
Lisa Durand
1e7add3b6e fix incrementation of success dossiers in batch alert 2023-05-11 15:42:23 +02:00
Colin Darie
79f450a422
Merge pull request #9021 from colinux/feat-en-construction-fork
ETQ usager, je modifie et soumets à nouveau mon dossier “en construction"
2023-05-10 19:46:40 +00:00
LeSim
4cde60ce2b
Merge pull request #9023 from mfo/US/clarify-counters
amelioration(instructeurs/procedure#show): ETQ instructeur, je souhaite avoir les mêmes compteurs entreles pages listant mes demarches et la page pour visualiser une démarches
2023-05-10 10:03:11 +00:00
Colin Darie
218c7d08c2
feat(fork): mark a fork as stale for future deletion, so it can't be reused 2023-05-09 18:49:53 +02:00
Colin Darie
c35176703f
feat(dossier): inform dossier en_construction having not submitted changes 2023-05-09 18:49:52 +02:00
Colin Darie
f6ebfe0e47
fix(dossier): sync search_terms after merge
Use a job instead of a lot of reloads
2023-05-09 18:49:52 +02:00
LeSim
d0bb759d3d
Merge pull request #8997 from demarches-simplifiees/add_defaut_procedure_for_new_admin
ETQ admin, je veux avoir une première démarche pré remplie lorsque j'arrive sur ds
2023-05-09 16:38:55 +00:00
Paul Chavard
71cfe094aa
fix(groupe_instructeur): always use assign_to_groupe_instructeur method 2023-05-09 17:23:23 +02:00
Paul Chavard
08a2a2c9aa
feat(dossier): fork dossier when editing en construction 2023-05-09 17:16:47 +02:00
Paul Chavard
025bd5beaf
feat(dossier): dossier can be forked for editing 2023-05-09 15:34:10 +02:00
Martin
386523019d amelioration(instructeurs/procedure#show): ETQ instructeur, je souhaite avoir les mêmes compteurs entreles pages listant mes demarches et la page pour visualiser une démarches 2023-05-09 13:59:49 +02:00
Paul Chavard
b88d984828 fix(instructeur): exclude repetitions from filters/display 2023-05-09 11:38:06 +02:00
Lisa Durand
2b2d65de87
Merge pull request #8994 from demarches-simplifiees/add-simple-filter-for-usagers
[refonte usager] Tableau de bord - Ajouter bouton filtres simples
2023-05-09 08:06:15 +00:00
mfo
2374ced5d2
Merge pull request #8987 from mfo/US/link-to-errored-champs
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-09 07:06:36 +00:00
Paul Chavard
f563fb3269
Merge pull request #8990 from tchak/fix-limit-textarea-size
ETQ administrateur, je veux pouvoir limiter le nombre de caractères dans les champs "texte long"
2023-05-05 14:54:41 +00:00
Paul Chavard
fe041b4c6c fix(textarea): fix character limit option 2023-05-05 16:36:51 +02:00
Paul Chavard
471da7eb61 Revert "Revert "Merge pull request #8844 from demarches-simplifiees/feat/7739""
This reverts commit 909d726429.
2023-05-05 16:36:51 +02:00
Paul Chavard
7a6f46a8ad
Merge pull request #9002 from tchak/feat-procedure-clone-preview-published
ETQ Administrateur, je veux cloner la version publiée des démarches en production
2023-05-05 14:36:03 +00:00
Martin
2135985583 correctif(procedure.clone): ET admin, je souhaite pouvoir cloner une procedure ayant deux groupes d'instructeur ayant le dernier fermé 2023-05-05 11:09:06 +02:00
Paul Chavard
11065946ce fix(instructeur): fix dossiers suivis filter (merge behavior change in rails 7) 2023-05-04 18:24:18 +02:00
Paul Chavard
616188bfe3 feat(administrateur): when clone or preview procedure should use published revision if not the owned 2023-05-04 16:15:55 +02:00
Lisa Durand
c039414872 feedback PR review 2023-05-04 12:39:06 +02:00
Lisa Durand
9fd9bdc7c0 add tag to display and remove active filters 2023-05-03 16:47:27 +02:00
simon lehericey
9c8020b05c feat(admin): add initiation procedure for a new admin 2023-05-03 15:08:21 +02:00
Colin Darie
6616acb825
chore(super-admin): update devise-two-factor v5 with otp_secret encrypted attribute 2023-05-03 11:35:32 +02:00
Colin Darie
d31016973c
chore(schema): model annotations accordingly to schema 2023-05-03 11:35:31 +02:00
Nicolas Cavigneaux
3aa6a5e28e
fix: url helper method calls for files 2023-05-03 11:35:28 +02:00
Nicolas Cavigneaux
388ccca263
fix redefinition of signed_id Rails method by supporting options as arg 2023-05-03 11:35:28 +02:00
Martin
c8ab1e8e03 amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement 2023-05-03 07:36:42 +02:00
Lisa Durand
24eca40f66 add from_depose_at filter 2023-05-02 10:32:38 +02:00
Lisa Durand
21ed6abcad add from_created_at filter 2023-05-02 09:37:03 +02:00
Paul Chavard
f2c1c071b4 Revert "Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique"
This reverts commit d3eda28f35, reversing
changes made to 6394996e7f.
2023-04-28 16:10:20 +02:00
Paul Chavard
909d726429 Revert "Merge pull request #8844 from demarches-simplifiees/feat/7739"
This reverts commit 04fbfa15b7, reversing
changes made to aac1cc7161.
2023-04-28 16:08:24 +02:00
Lisa Durand
39f534b3d7 add states filter for usager 2023-04-28 15:28:04 +02:00
Kara Diaby
04fbfa15b7
Merge pull request #8844 from demarches-simplifiees/feat/7739
Ajoute un compteur sur les champ texte
2023-04-27 13:53:20 +00:00
Colin Darie
b0f4c578a6
Merge pull request #8978 from colinux/refactor-dolist-module
Tech: ne mélange pas class & module Dolist, supprime adapter SMTP
2023-04-27 09:52:42 +00:00
Kara Diaby
f3f49941b6 Ajoute un compteur sur les champ de type textarea sur l'interface usager 2023-04-27 10:28:43 +02:00
Colin Darie
5cc2712873
refactor(dolist): drop smtp deliver method 2023-04-27 10:09:29 +02:00
Paul Chavard
cb752d1857 fix(dossier): do not bypass depositaire check on modifier path 2023-04-27 09:52:10 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Paul Chavard
a41713c837
Merge pull request #8968 from demarches-simplifiees/fix_defaut_groupe_instructeur_again
Correctif: definit le groupe instructeur par defaut pour certaines procedure clonées
2023-04-26 17:59:13 +00:00
Paul Chavard
d3eda28f35
Merge pull request #8899 from demarches-simplifiees/8738-validate-adresse-electronique
ETQ usager, je veux que les champs de type adresse électronique soit validé
2023-04-26 16:52:02 +00:00
Lisa Durand
e393132fd8
Merge pull request #8936 from demarches-simplifiees/add-yes-no-column-for-instructeurs
[instructeur] ajout du nb de réponses oui/non aux avis dans le tableau d'une procedure
2023-04-26 09:05:58 +00:00
simon lehericey
0934a672fe fix: defaut_groupe_instructeur for a cloned procedure from another admin without a group with default label 2023-04-26 10:52:31 +02:00
LeSim
1a704f0479
Merge pull request #8966 from mfo/US/fix-avis-remind-with-question
ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question
2023-04-26 08:09:41 +00:00
LeSim
c8ed0532ed
Merge pull request #8948 from colinux/fix-geoarea-geometry-blank
ETQ Usager, champ carte: ne permet pas d'enregistrer une geometry null pour ne pas casser les exports
2023-04-26 10:15:25 +02:00
Colin Darie
21a829ec1e fix(conditionel): error when using operator eq/not_eq with a multi dropdown 2023-04-26 09:58:00 +02:00
Martin
1ae40f1a22 correctif(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question 2023-04-26 07:46:21 +02:00
mfo
fdb361c207
Merge pull request #8955 from tchak/fix-typo
ETQ instructeur, je veux pouvoir accéder à mes annotations privées
2023-04-25 12:47:49 +00:00
Lisa Durand
384b7f9fac simplify humanized groupe instructeur filter 2023-04-25 14:15:40 +02:00
Lisa Durand
26ff82dbe4 Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier 2023-04-25 13:01:40 +02:00
Paul Chavard
08ed5e0d87 fix(type_de_champ): should use dossier revision instead of type_de_champ revision 2023-04-25 12:00:42 +02:00
Paul Chavard
eae58ae5b0 fix(type_de_champ): type_champs_private -> types_de_champ_private 2023-04-25 11:59:32 +02:00
Lisa Durand
3678015413
remove scope not_archived for brouillon
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2023-04-25 10:56:59 +02:00
Colin Darie
f7880352f0
Merge pull request #8941 from mfo/US/fixed-dossier-stalled-auto-processing
correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué]
2023-04-22 16:13:01 +00:00
Colin Darie
25956c5141
fix(geoarea): geometry must not be nil 2023-04-22 16:23:39 +02:00
Martin
9dec6f1611 correctif(procedure.declarative): ETQ administrateur d'une procedure declarative, certains de mes dossiers restent en construction [ex: l'object storage est down, le dossier reste bloqué] 2023-04-21 15:45:45 +02:00
Colin Darie
2775158052
Merge pull request #8943 from tchak/fix-dossier-can-create-new-dossiers
ETQ usager, je peux créer de nouveaux dossiers sur la démarche qui remplace la démarche fermée
2023-04-21 13:18:43 +00:00
simon lehericey
a202a57988 fix: defaut_groupe_instructeur_id for a cloned procedure 2023-04-21 12:20:50 +02:00
Paul Chavard
52d63a1b02 fix(dossier): user can create new dossiers when closed procedure is replaced 2023-04-21 11:18:27 +01:00
krichtof
c2461f230c validate value for email champ 2023-04-20 18:27:02 +02:00
Lisa Durand
34697a3085 add missing translation for filter groupe instructeur 2023-04-20 17:32:36 +02:00
Lisa Durand
65730bcfcb display avis_anwser yes/no in table 2023-04-20 15:55:31 +02:00
Paul Chavard
88f680a265
Merge pull request #8930 from tchak/fix-champ-commune-spaces
ETQ usager, je voudrai pouvoir remplir un code postal avec des espaces
2023-04-20 08:40:38 +00:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
Paul Chavard
4a2e499679 fix(commune): should accept postal codes with spaces 2023-04-20 10:16:48 +02:00
simon lehericey
e64ac79f05 tech(refactor): much nicer code, thx LeSim
root -> rooted_tree

depth_cach -> walk

smal refactor

comment

remove form for header_section

remove seen_at from header section

header_section: champ -> header_section

champ_subree: remove if not

remove root_depth use header_section_level_value instead

remove unused include

remove ChampTreeComponent

rename ChampsSubtreeComponent to SectionComponent

use TreeableConcern only in section component

remove fields_for_champ_component

champs -> tail

add split_section_champ helper

refactor(editable_champ::header_section): keep same interface everywhere

fix(repetition): add spec for SectionComponent on repetitions
2023-04-20 08:22:02 +02:00
Martin
88abefb370 tech(remaniement): isole la logique de rendu au champs_subtree_component 2023-04-20 08:22:02 +02:00
Martin
3b5d1bd55b tech(remaniement): extraction du passage d'une liste de champs a un simili arbre 2023-04-20 08:22:02 +02:00
Martin
ad77b9321b amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme 2023-04-20 08:22:02 +02:00
Martin
b9faa26560 amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3]. 2023-04-20 08:22:02 +02:00
Paul Chavard
ce466d072a feat(manager): display procedure state and unpublished date 2023-04-19 19:59:54 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
simon lehericey
9c6af921e5 Use has_one defaut_procdre to avoid before destroy prepend 2023-04-19 13:52:42 +02:00
simon lehericey
95ab81fd1c feat(routing): use procedure.defaut_groupe_instructeur_id to find defaut_groupe_instructeur 2023-04-19 13:52:41 +02:00
Paul Chavard
8904516b85 chore(procedure): remove duplicate code 2023-04-19 13:00:37 +02:00
Colin Darie
1af404c5e7
chore(rubocop): fix Rails/WhereMissing 2023-04-19 12:55:14 +02:00
Colin Darie
f4ad5289cd
chore(rubocop): fix Rails/RedundantPresenceValidationOnBelongsTo 2023-04-19 12:55:14 +02:00
Colin Darie
20f0b64736
chore(rubocop): fix Rails/WhereNotWithMultipleConditions 2023-04-19 12:55:14 +02:00
Colin Darie
e9649b667e
chore(rubocop): fix Rails/IgnoredColumnsAssignment 2023-04-19 12:55:14 +02:00
Colin Darie
8fa5e0dbb8
chore(rubocop): fix Rails/UnusedIgnoredColumns 2023-04-19 12:55:14 +02:00
Colin Darie
7aba5ccc3e
chore(rubocop): fix Rails/DurationArithmetic 2023-04-19 12:55:13 +02:00
Colin Darie
160178b8f8
chore(rubocop): fix Rails/ExpandedDateRange 2023-04-19 12:55:13 +02:00
Colin Darie
bd8e8633e7
chore(rubocop): fix Rails/CompactBlank 2023-04-19 12:55:13 +02:00
Colin Darie
ca11ec8380
chore(rubocop): fix Rails/OutputSafety 2023-04-19 12:55:12 +02:00
Paul Chavard
0912a30eb0 feat(dossier): use turbo on select with other 2023-04-18 15:24:23 +02:00
Paul Chavard
eb599394e0 feat(dossier): use turbo on linked lists 2023-04-18 15:24:23 +02:00
Lisa Durand
c565ed415b change scope and alert location after UI modification 2023-04-18 12:03:10 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
21b548d32b fix(dossier): delete all champs starting with children 2023-04-13 11:08:10 +02:00
Paul Chavard
7054c2d9ef fix(demarche): always reset outside of transactions 2023-04-13 11:05:38 +02:00
simon lehericey
f6948cfd5e feat(routing): record first groupe as default_groupe_instructeur 2023-04-13 10:36:42 +02:00
Eric Leroy-Terquem
cade677355 feat(db): add defaut_groupe_instructeur_id column to procedures 2023-04-13 10:36:42 +02:00
simon lehericey
c1f67499aa feat(routing): server side: prevent tdc deletion if used for routing 2023-04-13 10:28:52 +02:00