Commit graph

2764 commits

Author SHA1 Message Date
Paul Chavard
616188bfe3 feat(administrateur): when clone or preview procedure should use published revision if not the owned 2023-05-04 16:15:55 +02:00
Lisa Durand
c039414872 feedback PR review 2023-05-04 12:39:06 +02:00
Paul Chavard
88bb0cc532
Merge pull request #8989 from tchak/fix-presentation-filters
ETQ Instructeur, je ne veux pas d'erreurs quand les filtres ne sont pas trouvés
2023-05-04 08:45:56 +00:00
Colin Darie
93c08072ba fix(attestation): allow redirection to our static domain for attestation 2023-05-04 10:31:38 +02:00
Colin Darie
61ebb27e86
fix(redirect): allow other hosts when required 2023-05-03 11:35:31 +02:00
Nicolas Cavigneaux
940405cea8
fix: Avoid Brakeman warning about insecure redirect 2023-05-03 11:35:29 +02:00
Nicolas Cavigneaux
3aa6a5e28e
fix: url helper method calls for files 2023-05-03 11:35:28 +02:00
Martin
c8ab1e8e03 amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement 2023-05-03 07:36:42 +02:00
Lisa Durand
24eca40f66 add from_depose_at filter 2023-05-02 10:32:38 +02:00
Lisa Durand
21ed6abcad add from_created_at filter 2023-05-02 09:37:03 +02:00
Paul Chavard
fc391fb553 fix(instructeur): no crash when filters not found 2023-05-01 11:34:11 +02:00
Paul Chavard
909d726429 Revert "Merge pull request #8844 from demarches-simplifiees/feat/7739"
This reverts commit 04fbfa15b7, reversing
changes made to aac1cc7161.
2023-04-28 16:08:24 +02:00
Lisa Durand
39f534b3d7 add states filter for usager 2023-04-28 15:28:04 +02:00
Kara Diaby
04fbfa15b7
Merge pull request #8844 from demarches-simplifiees/feat/7739
Ajoute un compteur sur les champ texte
2023-04-27 13:53:20 +00:00
Lisa Durand
aac1cc7161
Merge pull request #8971 from demarches-simplifiees/add-filter-for-usagers
[fix] Pagination interface usager - onglets disparaissent si pas sur la page 1
2023-04-27 13:46:15 +00:00
Paul Chavard
f9b8dac024 feat(champ): use new data-turbo-focus-group to manage focus on multiple drop down 2023-04-27 10:40:14 +02:00
Kara Diaby
f3f49941b6 Ajoute un compteur sur les champ de type textarea sur l'interface usager 2023-04-27 10:28:43 +02:00
Paul Chavard
cb752d1857 fix(dossier): do not bypass depositaire check on modifier path 2023-04-27 09:52:10 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Lisa Durand
74b28a995f paginate only dossiers that we display to fix empty tabs when not on page 1 2023-04-26 11:42:29 +02:00
Lisa Durand
26ff82dbe4 Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier 2023-04-25 13:01:40 +02:00
Martin
b5e6c3d02a correctif(instructeurs.annotations): pour un champ de type choix simple, l'ordre des parametres value, value_other doit etre respecté sinon le 'setters' Champs::DropDownListChamp.value= passe après le setter Champs::DropDownListChamp.value_other=, ce qui a pour effet de supprimer la value 2023-04-21 09:57:23 +02:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
simon lehericey
e64ac79f05 tech(refactor): much nicer code, thx LeSim
root -> rooted_tree

depth_cach -> walk

smal refactor

comment

remove form for header_section

remove seen_at from header section

header_section: champ -> header_section

champ_subree: remove if not

remove root_depth use header_section_level_value instead

remove unused include

remove ChampTreeComponent

rename ChampsSubtreeComponent to SectionComponent

use TreeableConcern only in section component

remove fields_for_champ_component

champs -> tail

add split_section_champ helper

refactor(editable_champ::header_section): keep same interface everywhere

fix(repetition): add spec for SectionComponent on repetitions
2023-04-20 08:22:02 +02:00
Martin
ad77b9321b amelioration(formulaire-usager): groupes les champs suivant un titre de section dans une balise html de type <fieldset> de sorte a améliorer l'accessibilite de la plateforme 2023-04-20 08:22:02 +02:00
Martin
b9faa26560 amelioration(editeur-de-champs): permet de choisir un niveau de titre (de 1 à 3) pour les champs de type Champs::HeaderSectionChamp. Gère les erreurs dans le cas ou un administrateur supprimerait un HeaderSection qui casserait l'ordre des titre [ex: titre 1,2,3. et l'admin supprime le titre 1 et il reste que 2,3]. 2023-04-20 08:22:02 +02:00
Paul Chavard
39ba03783a
Merge pull request #8928 from tchak/feat-api-public-stats
ETQ citoyen, je voudrais avoir accès aux statistiques des démarches closes
2023-04-19 19:11:34 +00:00
Paul Chavard
418d3b55d0 feat(stats): give access to stats on closed procedures 2023-04-19 18:31:58 +02:00
Paul Chavard
63b7a83689 feat(graphql): log dossier and procedure id on dossier fetch endoint 2023-04-19 18:00:08 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
Eric Leroy-Terquem
aecd7559d2 feat(groupe instructeur): cannot disable default groupe instructeur 2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
09b05550ab feat(groupe instructeur): cannot delete defaut_groupe_instructeur 2023-04-19 13:52:42 +02:00
simon lehericey
3889bdac73 refactor(routing): remove unused routing_params 2023-04-19 13:52:42 +02:00
simon lehericey
b38470368b feat(routing): can change defaut groupe 2023-04-19 13:52:41 +02:00
Paul Chavard
8904516b85 chore(procedure): remove duplicate code 2023-04-19 13:00:37 +02:00
Colin Darie
bd8e8633e7
chore(rubocop): fix Rails/CompactBlank 2023-04-19 12:55:13 +02:00
Colin Darie
b273e7b67e
chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops 2023-04-19 12:55:13 +02:00
github-merge-queue[bot]
a286af8a70
Merge pull request #8918 from tchak/graphql-add-error-codes
ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis
2023-04-19 09:00:32 +00:00
github-merge-queue[bot]
c439a286a8
Merge pull request #8902 from demarches-simplifiees/bug-disable-select-all-actions-multiples
[bug] actions multiples > désactiver la checkbox select_all quand action en cours
2023-04-18 21:52:21 +00:00
Paul Chavard
fbae6d941d feat(graphql): add error codes to graphql errors 2023-04-18 15:22:11 +02:00
Lisa Durand
c565ed415b change scope and alert location after UI modification 2023-04-18 12:03:10 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
cb6875352e fix(dossier): désactiver la checkbox select_all quand action en cours 2023-04-14 17:41:22 +02:00
Lisa Durand
229ce67a5d
Add 'visible_by_user' - review PR
Co-authored-by: Paul Chavard <paul.chavard@beta.gouv.fr>
2023-04-14 10:10:22 +02:00
Paul Chavard
7054c2d9ef fix(demarche): always reset outside of transactions 2023-04-13 11:05:38 +02:00
simon lehericey
c02319aa56 feat(routing): reset value if target as changed 2023-04-13 10:28:53 +02:00
simon lehericey
e27e18fdaf refactor(routing): use selerialized logic in select value 2023-04-13 10:28:53 +02:00
simon lehericey
16565d099a refactor(routing): add groupe_instructeur helper 2023-04-13 10:28:52 +02:00
simon lehericey
8b832396a3 feat(routing): server side: prevent changing tdc type if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
c1f67499aa feat(routing): server side: prevent tdc deletion if used for routing 2023-04-13 10:28:52 +02:00
krichtof
78938b5a07 filter demarches by siret service 2023-04-12 18:53:57 +02:00
Lisa Durand
bc3e67ab94 add alert on user dashboard to edit last editable dossier 2023-04-11 15:50:17 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
a5733002ed feat(graphql): improuve logs 2023-04-05 13:56:26 +02:00
Paul Chavard
52c8b0b297 feat(dossier): use turbo to select linked dossier 2023-04-05 11:40:03 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
Lisa Durand
dde64415ae
Merge pull request #8845 from demarches-simplifiees/remove-dossiers-termines-from-avis-views
[bug] retirer les notifications + compteur des avis pour les dossiers terminés
2023-04-04 08:20:48 +00:00
Paul Chavard
0864666d0a fix(dossier): an invited user can remove (leave) a dossier 2023-04-03 20:10:44 +02:00
Lisa Durand
2f012578eb remove dossier termine from avis views 2023-04-03 18:20:17 +02:00
Paul Chavard
fce78bbf30 feat(dossier): multiselect without react 2023-04-03 16:54:50 +02:00
mfo
54d88e7dd0
Merge pull request #8699 from mfo/US/8661
a11y(bloc-repetable): amélioration des interactions avec les répétitions d'un bloc répétable
2023-03-31 14:39:23 +00:00
LeSim
b003fd8be8
Merge pull request #8774 from E-L-T/add-routing-to-groupe-instructeurs
Add routing rules to groupe instructeurs
2023-03-31 10:16:51 +00:00
Martin
d161a624c5 a11y(bloc-repetable): ETQ usager qui navigue au clavier, lorsque je supprime une repetition, le focus revient soit sur le premier champ de la derniere repetition, soit sur le bouton ajouter une repetition [si il y a pas de repetition presente] 2023-03-31 08:51:39 +02:00
Colin Darie
e60c92957d
fix(manager): don't break DS by sorting Dossier by created_at 2023-03-30 15:41:07 +02:00
Eric Leroy-Terquem
eca11686e2 feat(routing): parse value 2023-03-30 10:53:00 +02:00
Eric Leroy-Terquem
6f6bbd6ca1 feat(routing): put routing logic behind a feature flag 2023-03-30 10:52:53 +02:00
simon lehericey
3cede55d41 feat(routing): add routing engine 2023-03-30 10:51:20 +02:00
simon lehericey
b93e3776c4 feat(routing): add controller 2023-03-30 10:51:20 +02:00
mfo
8efd191e0f Merge pull request #8817 from mfo/US/fix-expert-export
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-29 15:42:33 +02:00
Martin
c6e9674de2 correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis 2023-03-28 17:16:34 +02:00
Paul Chavard
dc605015b3 feat(commune): chose commune by postal code 2023-03-28 16:34:19 +02:00
Kara Diaby
74e4e2a1ce controllers 2023-03-27 14:14:18 +02:00
Julie Salha
ed3b2cca6f
update content statement 2023-03-27 10:39:56 +02:00
Julie Salha
5a237333eb
add structure static page accessibility statement 2023-03-27 10:37:32 +02:00
Colin Darie
9a38da09ed
Merge pull request #8762 from demarches-simplifiees/8589-legal-notice
Accessibilité: internalise la page de mentions légales
2023-03-27 08:12:34 +00:00
Lisa Durand
d079f3ac98
Merge pull request #8770 from demarches-simplifiees/ask-question-in-avis-ux-part
[UX] améliorer UX de la demande d'avis
2023-03-24 10:50:33 +00:00
Paul Chavard
0eceed4126
Merge pull request #8793 from tchak/chore-update-dependencies
chore(npm): update dependencies
2023-03-22 10:19:22 +00:00
Paul Chavard
234846eb33 graphql(playground): build with vite 2023-03-22 10:19:56 +01:00
Lisa Durand
c1b5daadef remove unused view and routes from instructeurs avis 2023-03-22 09:30:26 +01:00
Lisa Durand
79552b496b add 3rd view for expert - form to ask avis to another expert 2023-03-22 09:30:26 +01:00
Lisa Durand
c51e6aa2e6 split form and avis answers in 2 views for experts and add sidemenu 2023-03-22 09:30:26 +01:00
Lisa Durand
603d66e020 split form and avis answers in 2 views for instructeurs 2023-03-22 09:30:26 +01:00
Colin Darie
08c68ef970
feat(manager): exports dashboard 2023-03-22 09:29:09 +01:00
Colin Darie
45eb53c26a chore(legal): rename legal notice controller to a StaticPages 2023-03-21 12:44:04 +01:00
Julie Salha
b5829cbc5a fix PR indentation(3) 2023-03-21 10:05:50 +01:00
Julie Salha
7897196302 fix PR indentation(2) 2023-03-21 10:05:50 +01:00
Julie Salha
cc6ceb580b fix PR indentation 2023-03-21 10:05:50 +01:00
Julie Salha
7af378688e add static page legal notices 2023-03-21 10:05:50 +01:00
Lisa Durand
893ee5801e
Merge pull request #8743 from demarches-simplifiees/ask-question-in-avis
[instructeurs] Je peux poser une question dans une demande d'avis
2023-03-17 15:10:51 +00:00
Colin Darie
83a3421537
Merge pull request #8769 from colinux/fix-annotations-privees-champ-type-mismatch
Fix: crash d'annotations privées à cause d'une incohérence avec leur type de champ
2023-03-16 15:55:56 +00:00
Lisa Durand
ee2f795dec pr feedbacks - add validation for yes/no answer - improve locales use 2023-03-16 11:32:05 +01:00
Lisa Durand
eddd7a2192 add flash alert if email field empty 2023-03-16 11:32:05 +01:00
Lisa Durand
a4a99a72ec first step to add question in experts avis 2023-03-16 11:32:05 +01:00
simon lehericey
8b5d493f12 clean: log current_user in api v2, when not using token_v3 2023-03-16 10:06:23 +01:00
simon lehericey
7a6658700e clean: log current_user in api v1 2023-03-16 10:06:23 +01:00
simon lehericey
c0ca9f156e clean: remove unused Current.instructeur 2023-03-15 21:51:02 +01:00
simon lehericey
a984c21f64 clean: remove unused Current.administrateur 2023-03-15 21:51:02 +01:00
Paul Chavard
42e74dfc76 feat(api_token): enable fin graned access rights on tokens 2023-03-15 19:09:49 +01:00
Paul Chavard
8ee13f1719 feat(api_token): add allowed_procedure_ids and write_access 2023-03-15 19:09:49 +01:00
Colin Darie
e2ec46a5ba
chore(sentry): set dossier scope for instructeurs as well 2023-03-15 18:59:44 +01:00
Paul Chavard
53e6ad135f Update app/controllers/concerns/turbo_champs_concern.rb
Co-authored-by: Colin Darie <colin@darie.eu>
2023-03-14 15:22:13 +01:00
Paul Chavard
cbaa77fca7 feat(annotations): activate autosave 2023-03-14 15:22:13 +01:00
Lisa Durand
6ba47b731b refacto destroy action and add spec for unauthorized user 2023-03-09 14:58:47 +01:00
Lisa Durand
3d5bf40c0f allow transfer sender to revoke a transfer 2023-03-09 14:57:59 +01:00
Eric Leroy-Terquem
9e0753a710 fix(groupe instructeur mailer): do not notify if no added instructeurs 2023-03-08 11:03:33 +01:00
Eric Leroy-Terquem
9f0f5b0dc5 feat(groupe instructeur): allow import of many groups when procedure is not routed yet 2023-03-08 10:48:02 +01:00
Kara Diaby
cb0417aad4 Possibilité de selectionner plusieurs tags dans la page toutes les demarches 2023-03-03 11:50:47 +01:00
Damien Le Thiec
687c05e6d1
Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue
Dossier prefill get without stored queries
2023-03-02 14:01:04 +00:00
Lisa Durand
54f17ad3c7
Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs
[instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier
2023-03-02 13:28:23 +00:00
Eric Leroy-Terquem
f6c4986e86 feat(groupe instructeur mailer): do not notify group when instructeurs removed 2023-03-02 09:46:58 +01:00
Damien Le Thiec
8a7cb3f1fe
Merge branch 'main' into fix/stored_query_issue 2023-03-01 10:22:40 +01:00
Damien Le Thiec
a6db8a6556 Remove prefill token expire at 2023-02-28 16:54:52 +01:00
Paul Chavard
294a5135ce feat(public/api): add dossier state api 2023-02-28 16:35:25 +01:00
krichtof
dee499d386
Merge pull request #8706 from demarches-simplifiees/all_demarches_even_without_zones
liste toutes les démarches, même celles non associées à des zones
2023-02-28 10:58:07 +00:00
Colin Darie
4d1a5f230c feat(a11y/i18n): inject user locale to chat / crisp 2023-02-27 17:23:43 +01:00
sebastiencarceles
0e3126cf83 review: readability 2023-02-27 14:35:11 +01:00
sebastiencarceles
39545671f3 refacto: better error management 2023-02-27 14:35:11 +01:00
sebastiencarceles
396ebbcf2b refactor rna controller to use that new ability 2023-02-27 14:31:58 +01:00
Sébastien Carceles
2ad4e4c01f refacto: better error management 2023-02-27 13:45:16 +01:00
Sébastien Carceles
88136daf14 refactor siret controller to use that new ability 2023-02-27 13:39:31 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible
Prefill repeatable
2023-02-27 09:58:53 +00:00
Damien Le Thiec
d7592afdd1 Draft session management Prefill get 2023-02-27 10:48:59 +01:00
Lisa Durand
6487e2c27e implement turbostream back for state change in dossier view 2023-02-24 17:54:53 +01:00
Christophe Robillard
1d6c2fd7eb display procedures without zones 2023-02-24 17:27:28 +01:00
Eric Leroy-Terquem
4ea1d7d33b feat(groupe instructeurs import): notify added instructeurs 2023-02-23 10:56:55 +01:00
Eric Leroy-Terquem
a6e01d98ea feat(instructeurs import): notify added instructeurs 2023-02-23 10:56:55 +01:00
Damien Le Thiec
731cd56594 Merge branch 'main' into feature/prefill_repetible 2023-02-22 19:49:06 +01:00
Paul Chavard
3c3629d151 refactor(instructeurs): add_instructeurs should add 2023-02-22 09:49:26 +01:00
Paul Chavard
fcd0f7c609 bring back find_or_create_instructeurs 2023-02-22 09:49:26 +01:00
Eric Leroy-Terquem
d0c432d939 refactor(groupe instructeur): move method to Instructeur model 2023-02-22 09:49:26 +01:00
Eric Leroy-Terquem
d45efa99bc refactor(groupe_instructeurs): extract method for flash message at import 2023-02-22 09:49:26 +01:00
Eric Leroy-Terquem
25df48f255 feat(groupe_instructeurs): import instructeurs in unrouted procedure with a proper CSV 2023-02-22 09:49:26 +01:00
Damien Le Thiec
2052bc7840 Remove dependency type_de_champ -> procedure 2023-02-21 16:00:58 +01:00
Christophe Robillard
9bab4f9d76 display dossiers count for each procedure 2023-02-21 10:06:07 +01:00
Eric Leroy-Terquem
343cb5fce6 feat(groupe instructeur mailer): add emailing to added instructeurs 2023-02-20 15:41:19 +01:00
Damien Le Thiec
deb51e3880 Manage GET prefill by creating a dossier 2023-02-20 15:35:14 +01:00
Damien Le Thiec
dce4c84f9a Merge branch 'main' into feature/prefill_repetible 2023-02-16 17:08:30 +01:00
Paul Chavard
c0ad7853cb fix(administrateur): procedure page n+1 2023-02-16 11:29:21 +01:00
Eric Leroy-Terquem
a46faf8cdf feat(groupe instructeur mailer): make two kind of notifications for removed instructeur 2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem
5be58c8223 refactor(groupe instructeur mailer): rename mailer methods 2023-02-16 10:37:04 +01:00
Eric Leroy-Terquem
cbf072961c feat(groupe instructeur mailer): add emailing to removed instructeurs 2023-02-16 10:37:04 +01:00
Paul Chavard
ade9811d10 Revert "Merge pull request #8635 from tchak/graphql-with-traces"
This reverts commit 76520ec77d, reversing
changes made to 2c729ff396.
2023-02-16 10:07:07 +01:00
Paul Chavard
74c6d45b74 feat(graphql): add tracing support for managers 2023-02-15 18:18:45 +01:00
Damien Le Thiec
2533ca50d4 Merge branch 'main' into feature/prefill_repetible 2023-02-15 11:07:56 +01:00
Lisa Durand
b7a5f8bf7f extract actions and info from dropdown 2023-02-14 17:57:50 +01:00
Damien Le Thiec
802a23057b Microtest dossier prefill get without stored queries 2023-02-13 18:15:24 +01:00
Sébastien Carceles
1a72b80f8f
fix: "remove" a champ to prefill (#8612)
* fix: "remove" a champ to prefill

Removing a champ to prefill on /preremplir used to fail, because of a
collusion (having the same form multiple times on un page looks like a
bad idea, when it comes to multiple input fields).

* fix specs
2023-02-13 08:17:22 +00:00
Damien Le Thiec
dbb92e7fd3 Merge branch 'main' into feature/prefill_repetible 2023-02-11 22:40:56 +01:00
sebastiencarceles
6c5b82ebbf filter out locale from stored query params
As 'locale' isn't a param we want to prefill a dossier, we ignore it
and remove it from the stored query params.
2023-02-09 13:51:52 +01:00
sebastiencarceles
e212055ef8 tell when query params have been stored 2023-02-09 13:51:52 +01:00