Commit graph

7455 commits

Author SHA1 Message Date
Paul Chavard
1c71355574 Better warnings in test mode 2019-04-30 11:03:24 +02:00
Paul Chavard
4f1a65cd14
Merge pull request #3810 from tchak/create-dropdown-with-default-item
Éviter les erreurs de validation a la création du champ menu déroulant
2019-04-30 11:02:21 +02:00
Paul Chavard
1d67005545 Add a default value for drop_down_list_value to avoid validation error on new type_de_champ 2019-04-30 10:39:27 +02:00
LeSim
66ad1c0961
Merge pull request #3829 from betagouv/fix_apientreprise
Fix API Entreprise call
2019-04-30 10:37:16 +02:00
simon lehericey
7deb228477 Fix API Entreprise call 2019-04-30 10:27:35 +02:00
Nicolas Bouilleaud
0c6b5c63d5
Merge pull request #3826 from betagouv/fix-form-header
sign_in: fix line breaks on form header
2019-04-30 10:17:17 +02:00
Pierre de La Morinerie
9c6aa209c9 sign_in: fix line breaks on form header 2019-04-29 17:59:11 +02:00
Pierre de La Morinerie
ae4d74daab
tasks: populate Procedure.administrateurs even for hidden procedures (#3822)
Migration des administrateurs des procédures masquées
2019-04-29 16:51:56 +02:00
Pierre de La Morinerie
8bd1064532 tasks: populate Procedure.administrateurs even for hidden procedures
The previous procedure migration (created in
f7af01e0dc) worked fine, but didn't run
on hidden procedures (due to the default scope).
2019-04-29 16:35:34 +02:00
LeSim
2425647fef
Merge pull request #3824 from betagouv/fix-nearing_end_of_retention-spec
Fix “nearing_end_of_retention” test
2019-04-29 15:49:54 +02:00
Nicolas Bouilleaud
1c2e93ed41 Fix “nearing_end_of_retention” test
The `nearing_end_of_retention` test creates a `just_expired_dossier` “six months ago”, which is 29 Oct 2018. The autumn DST change was on October 28; this is the first time this test runs under these conditions. We workaround the time offset by creating the dossier one hour earlier.

This is technically a workaround, not a fix: the date arithmetics in `nearing_end_of_retention` are probably wrong. It looks like it’s comparing intervals, which seems error-prone, while it should be comparing dates. For now, I’m just making the tests pass.
2019-04-29 15:41:52 +02:00
Paul Chavard
d0d8eb34c5
Merge pull request #3808 from betagouv/add_timeout_to_address_api
ApiAdresse: add timeout
2019-04-23 14:48:54 +02:00
simon lehericey
14c3686969 ApiAdresse: add timeout 2019-04-23 14:31:01 +02:00
LeSim
070ef13ea5
Merge pull request #3804 from tchak/missing-dossier_id-on-champs-inside-repetition
Fix missing dossier_id on champs inside repetition
2019-04-18 17:15:30 +02:00
Paul Chavard
8d093bd9ba Fix missing dossier_id on champs inside repetition 2019-04-18 16:55:35 +02:00
LeSim
7face5e971
Merge pull request #3801 from betagouv/fix_mail_notification
Email notification: use the right method for procedures
2019-04-18 15:19:38 +02:00
simon lehericey
e65e21a72f Email notification: use the right method for procedures 2019-04-18 15:07:01 +02:00
LeSim
176be142cc
Merge pull request #3764 from betagouv/fix-gestionnaire-follow
gestionnaire: ignore when the gestionnaire already follows the dossier
2019-04-18 13:16:31 +02:00
Pierre de La Morinerie
1f955db2c7 gestionnaire: ignore when the gestionnaire already follows the dossier
Fix #3720
2019-04-18 11:41:24 +02:00
LeSim
b83ef3cbb4
Merge pull request #3797 from betagouv/change_pj_in_manager
Change pj in manager
2019-04-18 11:20:11 +02:00
simon lehericey
1d051dc3ef Can change a piece_justificative_template on a type_de_champ 2019-04-18 11:13:35 +02:00
simon lehericey
11f8e7a3f9 Small refactor 2019-04-18 11:13:35 +02:00
LeSim
7ec83f414d
Merge pull request #3768 from betagouv/fix-signout-direction
Fix signout arrow direction
2019-04-18 11:13:04 +02:00
Nicolas Bouilleaud
562fe90d42 Fix signout arrow direction 2019-04-18 11:03:58 +02:00
LeSim
50b4bcdacb
Merge pull request #3783 from betagouv/philemon95-patch-1
Update _edit.html.haml Ajout rappel enregistrement nécessaire
2019-04-18 10:52:19 +02:00
Philémon
d533abedbc Ajout rappel enregistrement nécessaire 2019-04-18 10:25:16 +02:00
Mathieu Magnin
62082f585a
Merge pull request #3780 from betagouv/fix-missing-logo
Fix when missing logo on remote storage crash email sending
2019-04-11 15:49:49 +02:00
Mathieu Magnin
0770362fb4 Fix when missing logo on remote storage crash email sending 2019-04-11 15:32:52 +02:00
Paul Chavard
b7b2029490
Merge pull request #3772 from tchak/menu-deroulant-should-have-a-value
Always create menu deroulant type de champ with a value
2019-04-11 15:16:05 +02:00
Paul Chavard
9beff5ee9a Always create menu deroulant champs with a value 2019-04-11 14:38:21 +02:00
Mathieu Magnin
14aa4eafdd
Merge pull request #3778 from betagouv/fix-formatted-horaires
Fix missing helper in notification mailer
2019-04-11 12:40:48 +02:00
Mathieu Magnin
1a97cd42de Fix missing helper in notification mailer 2019-04-11 12:25:55 +02:00
Mathieu Magnin
22034730b0 Fix factory to avoid crash because of procedure is nil 2019-04-11 12:25:55 +02:00
Mathieu Magnin
e5966fda46
Merge pull request #3660 from betagouv/fix-3064
[A merger/proder le 11/04] Brander les emails transactionnels moins avec "DS", et plus avec la démarche
2019-04-11 11:09:15 +02:00
Mathieu Magnin
c550d40e3a [Fix #3064] Add preview test 2019-04-11 11:03:13 +02:00
Mathieu Magnin
28f9208ce8 When mail template is updated, stay on edit page to easily preview it 2019-04-11 11:03:13 +02:00
Mathieu Magnin
b3f3106888 [Fix #3064] Change logo size 2019-04-11 11:03:13 +02:00
Mathieu Magnin
9c6c11027c [Fix #3064] Add service footer on notification emails 2019-04-11 11:03:13 +02:00
Mathieu Magnin
60d66f0422 [Fix #3064] Add logo and cancel link on preview 2019-04-11 11:03:13 +02:00
Mathieu Magnin
7e551a9d8d [Fix #3064] If procedure has logo, then display it in emails 2019-04-11 11:03:13 +02:00
Mathieu Magnin
b3970a5e6f [Fix #3064] Change default signature 2019-04-11 11:03:13 +02:00
Mathieu Magnin
14c3fb7224 [Fix #3064] Add a preview button for state notifications emails 2019-04-11 11:03:13 +02:00
Mathieu Magnin
e91b412254 [Fix #3064] Use a different layout for state notifications emails 2019-04-11 11:03:12 +02:00
Pierre de La Morinerie
dda3dbd8ac
Merge pull request #3765 from betagouv/fix-3464-filter-by-followers_gestionnaires
Instructeur : permet de filtrer des dossiers par email de l’instructeur
2019-04-10 17:48:03 +02:00
Nicolas Bouilleaud
c5122ee7f5 Allow filtering ProcedurePresentation by followers_gestionnaires
fixes #3464
2019-04-10 14:32:51 +02:00
Nicolas Bouilleaud
988df15c6b Refactor ProcedurePresentation::sanitize_columns to use model reflection
The passed “table” is actually an association, and may not match the table name. Use model reflection instead of manually pluralizing.
2019-04-10 14:32:51 +02:00
Pierre de La Morinerie
fa15128bdb
Merge pull request #3769 from betagouv/fix-glitch-motivations-dropdown
Instructeur : masque les détails lors de l'alternance entre plusieurs motivations différentes
2019-04-10 11:53:00 +02:00
Nicolas Bouilleaud
2fb1b19e09 Hide other motivation fields when switching between states 2019-04-10 10:32:43 +02:00
Nicolas Bouilleaud
ca5f31e374
Merge pull request #3766 from tchak/fix-sentry-bug
Do not crash if element to remove is not found
2019-04-09 17:24:27 +02:00
Paul Chavard
833bafaba6 Align with behaviour on user dossier form 2019-04-09 17:16:18 +02:00