DGNum/demarches-normaliennes
14
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity
11932 commits 4 branches 1166 tags 84 MiB
Commit graph

11932 commits

This branch
This branch
All branches
Author SHA1 Message Date
Paul Chavard
1b43cfb678
Merge pull request #5912 from betagouv/dont-cache-classes-during-tests 
Don't cache classes during tests
 2021-02-16 16:47:02 +01:00
Pierre de La Morinerie
2ce3149d92 test: don't cache classes during tests 
When running several individual tests in succession using Spring,
we get an error message:

> zeitwerk error: reloading is disabled because config.cache_classes is true

Caching classes during tests used to be recommended – but Rails 6
now recommands to reload them:

- Spring takes care of the caching for us,
- It makes zeitwerk happy.

See discussion in 65344f254c

A potential downside used to be that when running system tests using
Capybara, each web request would reload the classes, which invalidated
the model objects of the test case. But it seems to be fixed now.
 2021-02-16 15:59:35 +01:00
Pierre de La Morinerie
6ba58baf30
Merge pull request #5904 from betagouv/5812-expert-notifiable 
Technique : préparation du mécanisme pour rendre les instructeurs notifiables (ou non) de la décision finale sur un dossier (#5904)
 2021-02-16 11:04:48 +01:00
kara Diaby
8310dc48bf tests 2021-02-16 09:46:18 +00:00
kara Diaby
3817210649 layout 2021-02-16 09:46:18 +00:00
kara Diaby
9492b09f85 make and expert notifiable (controller and routes) 2021-02-16 09:46:18 +00:00
kara Diaby
7b4ec486ec change active record request to get expert list 2021-02-16 09:46:18 +00:00
Pierre de La Morinerie
7b79fb2500
Merge pull request #5906 from tchak/adjuste-sentry-sampling 
Sentry : ajustement du taux d'échantillonnage des traces
 2021-02-16 10:37:19 +01:00
Paul Chavard
cfa80578a7 Adjust sentry sample rate 2021-02-12 11:35:58 +01:00
Paul Chavard
cb2a93a605
Merge pull request #5767 from tchak/graphql-modifier-annotation-privee 
[GraphQL] modifier annotation
 2021-02-11 18:40:54 +01:00
Paul Chavard
9ce07be1ee [GraphQL] modifier annotation 2021-02-11 17:45:14 +01:00
Paul Chavard
e0f7f1f20c Do not hide graphql controller errors in test env 2021-02-11 17:45:14 +01:00
Pierre de La Morinerie
6bc6fdf734
Merge pull request #5902 from betagouv/update-sentry-workflow 
CI : mise à jour de l'action Github utilisée pour publier les releases sur Sentry
 2021-02-11 17:29:28 +01:00
Pierre de La Morinerie
485c496b76 ci: update Github Action used to publish Sentry versions 
Attempts to fix the Sentry action failing after a deploy.
 2021-02-11 16:07:17 +00:00
Pierre de La Morinerie
e5a2fc8511
Merge pull request #5901 from betagouv/remove-deploy-notes-from-readme 
README : mise à jour des informations techniques sur le déploiement de l'application
 2021-02-11 17:06:35 +01:00
Pierre de La Morinerie
2ddaa23290 README: update deployment informations 2021-02-11 15:48:33 +01:00
Pierre de La Morinerie
3530f4ef6a
Merge pull request #5899 from betagouv/zeitwerk 
Utilisation de zeitwerk, l'auto-loader de Rails 6 (#5887, #5899)
 2021-02-11 12:57:15 +01:00
Pierre de La Morinerie
211ddeda45 config: enable zeitwerk 
Check that everything works using
bin/rails zeitwerk:check
 2021-02-11 12:30:43 +01:00
Pierre de La Morinerie
819325c761 zeitwerk: move our Array extension to initializers/core_ext 2021-02-11 12:30:43 +01:00
Pierre de La Morinerie
465e3576c6
Merge pull request #5897 from betagouv/fix-super-admin-otp 
SuperAdmin : correction de la génération initiale du code OTP (#5897)
 2021-02-11 11:32:57 +01:00
Pierre de La Morinerie
12cd996af9 super_admin: fix OTP generation 2021-02-11 11:14:14 +01:00
krichtof
ed8f0d4634
Merge pull request #5875 from betagouv/5867-fc-only-4-user 
5867-authorize-france-connect-only-for-user
 2021-02-10 19:56:54 +01:00
Christophe Robillard
966ee33529 ignore when FranceConnect calls callback 2 times 2021-02-10 18:13:47 +01:00
Christophe Robillard
a288a13805 disable france connect authentication for admin and instructeurs 2021-02-10 18:13:47 +01:00
Paul Chavard
86a3ecb0be
Merge pull request #5894 from tchak/update-sentry 
Update sentry
 2021-02-10 18:04:02 +01:00
Paul Chavard
0697e50b7c lower sentry sampling to 1% 2021-02-10 17:52:18 +01:00
Paul Chavard
753d0478ef update sentry gems 2021-02-10 17:52:04 +01:00
Paul Chavard
ef9fe9e53a
Merge pull request #5892 from tchak/fix-print-css 
fix print css
 2021-02-10 17:20:14 +01:00
Paul Chavard
434e99bf4f fix print css 2021-02-10 17:10:58 +01:00
Paul Chavard
eba645976d
Merge pull request #5890 from tchak/sentry-tracing 
Add sentry traces (20% for now)
 2021-02-10 16:22:50 +01:00
Paul Chavard
eac967f84e Add sentry traces (20% for now) 2021-02-10 15:35:21 +01:00
LeSim
48bc15a932
Merge pull request #5889 from betagouv/add_throttling_for_api_entreprise 
Add throttling for api entreprise
 2021-02-10 13:59:08 +01:00
simon lehericey
f7ae974f29 Add throttling for api entreprise 2021-02-10 12:40:14 +01:00
LeSim
b6d8409c9f
Merge pull request #5888 from tchak/fix-unstable-tests 
Fix unstable tests
 2021-02-09 17:06:55 +01:00
Paul Chavard
00e1d88a75 clean up download helper data before test run 2021-02-09 15:13:13 +01:00
Paul Chavard
c04077ca34 fix flaky test by imposing a stable sort order 2021-02-09 15:13:04 +01:00
Paul Chavard
2c089f53dd
Merge pull request #5887 from betagouv/zeitwerk-renaming 
Renommage des constantes pour Zeitwerk
 2021-02-09 14:57:00 +01:00
Pierre de La Morinerie
0af7188d8c zeitwerk: add inflections 2021-02-09 13:09:10 +01:00
Pierre de La Morinerie
7d1c79bf4b zeitwerk: Url -> URL 2021-02-09 13:07:30 +01:00
Pierre de La Morinerie
150ddab660 zeitwerk: Api -> API 2021-02-09 13:07:30 +01:00
Pierre de La Morinerie
482f990594
Merge pull request #5879 from betagouv/stats-css 
Statistiques : correction de l'affichage visuel du nombre de dossiers (#5879)
 2021-02-09 11:02:48 +01:00
Pierre de La Morinerie
29ded36e86 stylesheets: fix the dossiers number wrapping on two lines 2021-02-09 11:01:52 +01:00
Pierre de La Morinerie
73f61bae2d
Merge pull request #5880 from betagouv/fix-tests-warnings 
Tests : correction d'un avertissement Rspec sur l'assertion des exceptions (#5880)
 2021-02-09 11:01:40 +01:00
Pierre de La Morinerie
88ffa10a56 spec: fix rspec raise_error warning 
Rspec warns that if there is for example a SyntaxError, the test will
pass (an error was raised, but it wasn't an ArgumentError, so this is
fine).

Instead check that no error occurs whatsoever.
 2021-02-09 10:12:32 +01:00
Pierre de La Morinerie
d090091540
Merge pull request #5874 from adullact/5873_configure_email_footer_logo 
Permet au logo dans le pied-de-page des emails d'être configuré par une variable d'environnement (#5874)
 2021-02-09 10:12:16 +01:00
Fabrice Gangler
229f495753 allow email footer logo to be configured in .env file 
Refs: #5873
 2021-02-09 09:39:02 +01:00
Pierre de La Morinerie
08a588614f
Merge pull request #5881 from betagouv/ruby-2.7-keyword-arguments 2021-02-09 09:38:14 +01:00
Pierre de La Morinerie
2d1c50917f mailers: fix Ruby 2.7 arguments passing 2021-02-09 09:20:46 +01:00
Pierre de La Morinerie
4ad9adc510 models: fix Ruby 2.7 arguments passing 
Arguments to an ActiveRecord scope will always been passed as a
Dictionnary. Thus
`Dossier.with_notifiable_procedure(notify_on_closed: true)` will trigger
a Ruby 2.7 warning:

> /ruby/2.7.0/gems/activerecord-6.0.3.4/lib/active_record/relation.rb:412: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

Fix the issue by always expecting a Dictionary (rather than keyword
arguments).
 2021-02-09 09:20:46 +01:00
Pierre de La Morinerie
0d94eacf32 spec: fix Ruby 2.7 arguments passing 2021-02-09 09:20:46 +01:00