Commit graph

13891 commits

Author SHA1 Message Date
Pierre de La Morinerie
062f52feb9 Fix ProcedureAdministrateursController#destroy
- The "no remove oneself" rule wasn't actually enforced
- `flash.error` is not a flash category
2022-01-07 15:39:58 +01:00
Pierre de La Morinerie
fb75a55b89 Add specs for Administrateurs::ProcedureAdministrateursController 2022-01-07 15:39:58 +01:00
mfo
154a7daf1c
Merge pull request #6805 from betagouv/US/typhoneus-and-raise
fix(parallel_download_queue): typhoeus does not like raise from a request handler [crash straight to first frame]
2022-01-07 14:28:25 +01:00
Martin
383a92bcd9 fix(parallel_download_queue): tophoeus does not like raise from a request handler [crash straight to first frame] 2022-01-07 14:24:37 +01:00
Pierre de La Morinerie
e4755c5433
Merge pull request #6804 from betagouv/fix-invisible-captcha-flash
Correction d'une erreur dans le formulaire de contact
2022-01-06 14:27:04 +01:00
Pierre de La Morinerie
2e1a3c32cb helpers: handle flash[:error]
Errors generated by the `invisible-catcha` gem are reported as
`flash[:error]` (which differs from Rail's usual `flash[:alert]`).

We probably shouldn't use flash[:error] in our own codebase; but we can
handle its use in third-party libraries.
2022-01-06 14:09:31 +01:00
Pierre de La Morinerie
68b112e00a helpers: don't crash on unknown flash level
Errors generated by the `invisible-catcha` gem are reported as
`flash[:error]` (which differs from Rail's usual `flash[:alert]`).

Avoid crashing when the flash level passed to this helper is not known.
2022-01-06 14:09:26 +01:00
mfo
ad91ed362c
Merge pull request #6802 from betagouv/US/fix_notifications_regarding_update_champs_piece_justificative
fix(users/champs/piece_justificative#update): ensure to bump dossier.last_champ_updated_at otherwise instructeurs are not notified when user update their piece_justificative
2022-01-06 13:14:06 +01:00
Martin
f770ac4907 fix(users/champs/piece_justificative#update): ensure to bump dossier.last_champ_updated_at otherwise instructeurs are not notified when user update their piece_justificative 2022-01-06 13:09:57 +01:00
Pierre de La Morinerie
dbfb08a052
Merge pull request #6795 from betagouv/US/6690-etq-admin-je-veux-pouvoir-desactiver-une-attestation-une-fois-la-demarche-publiee
Administrateur : possibilité de désactiver une attestation même une fois la démarche publiée
2022-01-06 12:15:45 +01:00
Martin
a9ffaf942e feat(attestation): can enable/disable attestation no matter the state of the procedure 2022-01-05 18:20:11 +01:00
Paul Chavard
7eddbd5238
Merge pull request #6796 from tchak/refactor-champs-hidden-fields
a11y(champs): fix champs labels and descriptions
2022-01-05 17:12:46 +01:00
Paul Chavard
cb66348916 a11y(select): cleanup select helpers in specs 2022-01-05 12:33:40 +01:00
Paul Chavard
968384952a a11y(capybara): enable use of aria-label in spec 2022-01-05 12:33:40 +01:00
Paul Chavard
28c1763701 a11y(champs): generalize describedby and update to use new Combo props 2022-01-05 12:33:40 +01:00
Paul Chavard
3513182e7c a11y(select): use new ComboMultiple component 2022-01-05 12:33:40 +01:00
Paul Chavard
d6b6bb0f2a a11y(combobox): add support for describedby and labelledby and improuve external fields handling 2022-01-05 12:33:40 +01:00
Paul Chavard
fc058f721d a11y(champs): expose ids for UI on champ 2022-01-05 12:33:40 +01:00
LeSim
5f179676c8
Merge pull request #6799 from betagouv/bump_rails
mise a jour de rails de 6.1.4.1 vers 6.1.4.4
2022-01-05 12:31:06 +01:00
simon lehericey
7839067bcd bump rails to 6.4.4 2022-01-05 12:25:23 +01:00
LeSim
a009871ec1
Merge pull request #6798 from betagouv/make_ping_work_again
Corrige le controller ping (health check)
2022-01-05 12:24:18 +01:00
simon lehericey
00871cfe13 Fix ping controller in dev
For an unknown reason, ActiveRecord::Base.connected? does not work anymore in dev. It returns false negative.

This simple workaround can timeout. The caller has to monitor the response time.
2022-01-05 11:44:32 +01:00
mfo
f9f2bd8bce
Merge pull request #6750 from betagouv/US/download_parallel
6688-ETQ instructeur mes archives sont lentes à générer
2022-01-04 16:52:45 +01:00
Martin
3eb1c1a421 feat(async_backend): switch to typhoeus 2022-01-04 16:27:23 +01:00
Martin
ce1b189dcd refactor(DownloadManager): extract parallel download in dedicated class. move error management in custom class for procedure exports using the didicated class 2022-01-04 16:17:03 +01:00
Martin
2ed9cccba0 extract download all attachments in dedicated class using async/async-http for better perf 2022-01-04 16:17:03 +01:00
mfo
441d730b8e
Merge pull request #6786 from betagouv/US/anti-spam-contact-form
feat(support#create): block with invisible captcha [avoid painful captcha]
2022-01-04 14:55:50 +01:00
Martin
252eee272b feat(support#create): block with invisible captcha [avoid painful captcha] 2022-01-04 14:49:00 +01:00
Paul Chavard
ec6c71beea
Merge pull request #6785 from tchak/fix-a11y-current-page
fix(a11y): add aria to tabs
2022-01-04 09:48:37 +01:00
Paul Chavard
7f0dde9be4 fix(a11y): add aria to tabs 2022-01-04 09:44:32 +01:00
LeSim
d15b85633a
Merge pull request #6791 from tchak/fix-react-register-component
fix(react): remove register component cache
2022-01-04 09:32:05 +01:00
Paul Chavard
6776a5e05a fix(react): remove register component cache 2022-01-03 19:41:23 +01:00
Kara Diaby
f295b5b2da
Merge pull request #6716 from betagouv/feat/6706
ETQ Instructeur, je veux pouvoir cacher un dossier terminé de mon interface
2022-01-03 14:30:08 +01:00
Kara Diaby
1ca553e088 rename hidden_by_instructeur by hidden_by_administration 2022-01-03 11:51:25 +01:00
Paul Chavard
ad4be3c482 refactor(dossier): handle discard by admin and super admin 2022-01-03 11:51:25 +01:00
Kara Diaby
b408811c5a l'expert ne voit pas les dossiers supprimés par l'instructeur 2022-01-03 11:51:25 +01:00
Kara Diaby
051d7b2028 change dossier method 2021-12-29 17:37:58 +01:00
Kara Diaby
598cb09c6d tests 2021-12-29 17:37:58 +01:00
Kara Diaby
37e991ccb8 User : delete the folder if the instructeur has hide it 2021-12-29 17:37:58 +01:00
Kara Diaby
7d7b847437 Instructeur : delete the folder if the user has hide it 2021-12-29 17:37:58 +01:00
Kara Diaby
22ac853815 add hidden_by_instructeur scope 2021-12-29 17:37:58 +01:00
Kara Diaby
f239d46a45 add hide_dossier method to instructeurs 2021-12-29 17:37:57 +01:00
Kara Diaby
cd95b730e0 add hidden_by_instructeur_at on dossiers 2021-12-29 17:37:57 +01:00
mfo
a416a5ae33
Merge pull request #6774 from betagouv/US/merge-with-same-email-fail
fix(profil_controller#update_email): changing email from current_user.email to current_user.email destroy current user. whoops ☠️'
2021-12-29 14:16:48 +01:00
Martin
d0ab1711ff fix(profil_controller#update_email): ensure we are not merging same account
fix(profil_controller#update_email): changing email from current_user.email to current_user.email destroy current user. whoops ☠️'

Update config/locales/en.yml

Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>

Update config/locales/fr.yml

Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>

Update spec/controllers/users/profil_controller_spec.rb

Update config/locales/fr.yml

Co-authored-by: Pierre de La Morinerie <pierre.de_la_morinerie@beta.gouv.fr>

Update spec/controllers/users/profil_controller_spec.rb

fix(spec): broken due to typo
2021-12-29 13:36:47 +01:00
krichtof
15f01149df
Merge pull request #6779 from betagouv/show-procedure-zones
Permet de voir les zones des procédures dans le manager
2021-12-23 19:51:05 +01:00
Christophe Robillard
6e36fee7b3 superadmin can display list of procedures without zone 2021-12-23 19:18:46 +01:00
Christophe Robillard
9a38d5e049 superadmin can only index and show zones 2021-12-23 19:07:42 +01:00
Christophe Robillard
90c971567d superadmin can show zone for a procedure 2021-12-23 19:07:42 +01:00
Christophe Robillard
c7b5e57d2a superadmin can get procedures from zone 2021-12-23 19:07:42 +01:00