Commit graph

2276 commits

Author SHA1 Message Date
Eric Leroy-Terquem
6203b1fd05
Merge pull request #9879 from demarches-simplifiees/cleaning-conditional-and-routing-code
Tech : nettoyage du code conditionnel et routage
2024-01-29 13:43:52 +00:00
Colin Darie
a582fef1e5
Merge pull request #9934 from colinux/fix-export-link-witout-file
ETQ instructeur, n'affiche pas encore de lien vers un export quand le fichier n'est pas encore disponible
2024-01-29 10:11:33 +00:00
simon lehericey
5eaa957c31 can edit api_token to change networks and name 2024-01-29 10:09:55 +01:00
Colin Darie
b64a32444c
Merge pull request #9935 from colinux/transfer-empty-no-fail
Tech: plus d'erreur lorsque l'email de transfert n'a plus de dossier associé
2024-01-29 08:43:50 +00:00
Colin Darie
50b9813b4d
Merge pull request #9932 from colinux/lock-submit-fork
Correctif: ETQ usager, je ne peux pas soumettre 2x mes modifications en parallèle
2024-01-25 11:37:56 +00:00
Colin Darie
4aa1306536
feat(transfer): make it silent in case dossier had been destroyed between queuing and processing
Co-authored-by: mfo <mfo@users.noreply.github.com>
2024-01-25 11:31:12 +01:00
simon lehericey
588e58195c move api_tokens to admin module 2024-01-25 11:27:15 +01:00
simon lehericey
9a0dd45385 feat(api): add invalid ip addr error 2024-01-25 11:17:44 +01:00
simon lehericey
852eedbc50 refactor(api): create api_token with validity and network filtering 2024-01-25 11:17:44 +01:00
simon lehericey
7e8555923f feature(api): add ensure_token_is_not_expired to api_controller v1 and v2 2024-01-25 10:51:58 +01:00
simon lehericey
d8bc38bc69 feature(api): add ensure_authorized_network for api_controller v1 and v2 2024-01-25 10:51:58 +01:00
Colin Darie
520a7c4402
fix(exports): don't try to link to an export when file is not yet attached 2024-01-24 13:36:25 +01:00
Kara Diaby
ac29cfbfdb Envoie un email à l'expert en cas de nouveau commentaire de l'usager dans la messagerie 2024-01-24 10:48:17 +00:00
Colin Darie
56f8b61866
feat(dossiers): lock submit en construction to avoid merge collisions with double submits 2024-01-24 10:58:40 +01:00
Martin
2952987ad8 refactor(spec): stop using procedure type de champs traits as :with_datetime, :with_xxx in favor of :types_de_champ_public which keeps position in check 2024-01-23 17:30:22 +01:00
seb-by-ouidou
a6ca4b668e feat: answer message to administrateur as gestionnaire 2024-01-22 14:36:38 +01:00
seb-by-ouidou
8d8feedff0 fix: group "it" test 2024-01-22 14:36:38 +01:00
seb-by-ouidou
e6474f0d14 feat: US4.3.9 children management 2024-01-22 14:36:38 +01:00
seb-by-ouidou
96dd6bec52 feat: US4.3 update and delete groupe gestionnaire 2024-01-22 14:36:38 +01:00
Colin Darie
a4db911585
perf(admin): remove 2 useless zones queries on each admin page due to navigation 2024-01-16 19:43:58 +01:00
mfo
0328446bee
Merge pull request #9861 from demarches-simplifiees/US/move-type-de-champ-with-select
ETQ administrateur, je peux deplacer un champ via un select
2024-01-15 13:09:56 +00:00
Colin Darie
8a83fd2ce0
fix(recherche): show notification indicator for instructeurs 2024-01-12 10:09:34 +01:00
simon lehericey
e12dbe7aad use email_merge_token in email merge 2024-01-11 11:33:38 +01:00
simon lehericey
fca28a3ebd use email_merge_token in mail_merge_with_existing_account route 2024-01-11 11:33:38 +01:00
simon lehericey
65aa07ecbe the merge_token issued for password check can be reused for the confirmation by email route
Thus by passing the password check or the email possession check
2024-01-11 11:33:38 +01:00
seb-by-ouidou
c45e2eaccc feat: write message to gestionnaires as administrateur 2024-01-09 13:25:04 +01:00
mfo
9df978f6fa
Merge pull request #9887 from mfo/US/fix-fci-missing-device-callback
Correctif: ETQ usager invité, lorsque je crée mon compte via FC, je ne retrouve pas mes invitations
2024-01-04 06:15:14 +00:00
Martin
4073804b00 feat(administrateurs/types_de_champ_controller#move_and_morph): add action to move and morph fields between two coordinates 2024-01-03 11:08:53 +01:00
Martin
92730e266b fix(FranceConnect): missing after_confirmation callback, leading to invalites invitations when user france connect 2023-12-26 15:00:15 +01:00
Eric Leroy-Terquem
24563a3c18 fix(personnes impliquees): display reaffectations block only if procedure is routed 2023-12-22 10:57:53 +01:00
seb-by-ouidou
c253e7dd65 feat: US5.1 US5.2 administrateur in admin 2023-12-21 18:40:36 +01:00
Lisa Durand
e52bd9d6bf
Merge pull request #9855 from demarches-simplifiees/display-last-export-in-same-page-ldu
ETQ instructeur, j'ai besoin d'un accès très facile à mondernier export
2023-12-20 10:02:08 +00:00
Eric Leroy-Terquem
954facdaff
Merge pull request #9798 from demarches-simplifiees/add-new-operators-to-conditional
Etq admin je peux conditionner/router avec les opérateurs "est dans mon département",  "n'est pas dans mon département",  "est dans ma région" et   "n'est pas dans ma région".
2023-12-19 16:10:59 +00:00
Lisa Durand
e6a4459633 refacto 2023-12-19 16:54:23 +01:00
mfo
e75c4456e8
Merge pull request #9871 from mfo/US/add-pj-to-explication
ETQ administrateur, je peux ajouter une notice explicative a un champs explication
2023-12-19 10:44:03 +00:00
Martin
37e8772eab feat(type_de_champ_editor.explication): add a Attached::One to TypeDeChamp.explication, named notice_explicative [cf, cerfa wording] 2023-12-19 09:52:27 +01:00
Lisa Durand
53f9f3cbdb add trad if export failed 2023-12-18 14:09:47 +01:00
Lisa Durand
a9ab1daf3a display alert only for instructeur who generated the export and if recent 2023-12-18 11:25:52 +01:00
simon lehericey
9bb89f7e3e fix(print): missing dossier var 2023-12-18 09:51:41 +01:00
Colin Darie
9a5d908851
Merge pull request #9853 from mfo/US/fix-expert-link-to-dossiers
ETQ expert: lorsque je me connecte, je suis redirigé vers la page des avis, non pas vers la page de mes dossiers
2023-12-14 19:52:32 +00:00
Eric Leroy-Terquem
2e547cd46f chore(routing): cannot create simple_routing with champs communes or epcis 2023-12-14 17:48:14 +01:00
Martin
6def2609f1 amelioration(liens-suivis): persiste la page a laquelle il doit etre redirigé apres une connexion 2023-12-14 10:47:04 +01:00
Martin
4380fecd73 amelioration(expert.sign-in): ETQ expert, je suis redirigé vers la page listant les avis a donner ap connexion 2023-12-14 10:47:04 +01:00
Kara Diaby
303230dd1d Add new testss 2023-12-12 22:35:11 +00:00
Lisa Durand
d0e2f281cc fix tests 2023-12-12 22:35:11 +00:00
Lisa Durand
f6f18e9c86 send email to tiers if notification by email is set 2023-12-12 22:35:11 +00:00
krichtof
246d53fa99
Merge pull request #9754 from demarches-simplifiees/9435-transfer-dossier
En tant que superadmin, je peux transférer un dossier d'un utilistateur à un autre
2023-12-12 14:44:39 +00:00
Christophe Robillard
122a6b6f5b revoke superadmin dossier transfer 2023-12-12 15:25:39 +01:00
Colin Darie
f9c4846fde
Merge pull request #9571 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_administrateur_management
Feature ouidou/admin creation delegation gestionnaire page group administrateur management
2023-12-12 10:41:28 +00:00
Colin Darie
accd7864ff feat(correction): deleting a comment resolves the related correction
Cf #9731
2023-12-07 15:41:50 +01:00
seb-by-ouidou
e34307b50c fix: fixes after review 2023-12-06 14:47:39 +01:00
seb-by-ouidou
564c3c04fa feat: US4.3.8 administrateur management 2023-12-06 14:47:39 +01:00
Paul Chavard
3de0367ed9 fix(email_template): less magic - less bugs ! 2023-11-29 20:36:44 +00:00
Christophe Robillard
332570bfba superadmin can transfer dossier from a user to another user 2023-11-28 15:48:39 +01:00
Colin Darie
ba076357c5
feat(dossier): submit en construction resolve automatically correction except for sva 2023-11-22 12:35:42 +01:00
Colin Darie
49cd10458c feat(announces): show Nouveautés link in main navigation 2023-11-20 15:07:20 +01:00
Colin Darie
f972d36f2f test: fix when using timestamps not yet limited by postgresql precision
Sur des colonnes dont le schema ne connait pas le niveau de précision
(créées avant rails 7), rails créé un timestamp avec la précision système
(par exemple 9 décimales sur linux) alors que pg va l'arrondir
a posteriori à 6.

Ce n'est généralement pas un problème en production,
mais se révèle dans les tests typiquement avec des objets crées
par des factories: si un test dépend de ces timestamps,
il faut récupérer la valeur limitée par pg (d'où le reload),
plutôt que celle directement issue de Time.now à la création de l'objet.

Une alternative aurait été de créer une migration pour ces colonnes pour
forcer la précision à 6 et que le schema en aurait pris connaissance:
rails limiterait la précision de lui même dès la création de l'objet.
2023-11-20 11:22:28 +01:00
Martin
14b2fc30b2 tech(user.expiration): ne perds pas de vue qu'il faut mettre a jour le users.last_sign_in_at 2023-11-17 11:33:14 +01:00
Martin
3186b0aa68 tech(refactor): centralise/documente les constantes de duree de retentions dans le ns dedié à l'expiration 2023-11-17 11:33:14 +01:00
krichtof
39bdb5f145
Merge pull request #9701 from demarches-simplifiees/carte
Afficher une carte de déploiement de DS par département
2023-11-16 13:18:16 +00:00
Christophe Robillard
ba876f5085 show france map with stats for each departement 2023-11-16 13:27:12 +01:00
Lisa Durand
b782bcdd2b
Merge pull request #9672 from demarches-simplifiees/add-confirmation-page-for-procedure-publication-ldu
[admin] Ajout d'une page de confirmation après la publication d'une procédure - mise en avant de l'URL à partager
2023-11-16 11:08:54 +00:00
Paul Chavard
a2ed35d44e spec(dossier): improuve dossier with state factories 2023-11-14 23:59:45 +01:00
Colin Darie
610b808d32
test: fix deprecated any_instance and stub old syntax 2023-11-10 14:19:56 +01:00
mfo
b61fa88fe0
Merge pull request #9621 from mfo/US/type-de-champs-ej
amelioration(chorus): ETQ admin, je peux ajouter un type de champ EngagementJuridique
2023-11-09 14:40:49 +00:00
mfo
87c3615774 review(tech): utilise un code unique pr les elements de l'autocomplete, corrections de typos, amelioration du code
Co-authored-by: LeSim <mail@simon.lehericey.net>
2023-11-09 11:10:17 +01:00
Martin
d2657d83ac amelioration(chorus.update): oriente l'admin a remplir tous les champs du cadre budgetaire. une fois le cadre budgetaire renseigné, oriente l'admin a ajouter un champ EJ 2023-11-09 10:09:14 +01:00
Colin Darie
7a4456efeb
Merge pull request #9638 from colinux/poc-release-notes
ETQ super-admin je peux informer les administrateurs, instructeurs et experts des évolutions du site
2023-11-09 09:00:01 +00:00
Colin Darie
e49436aa5d
feat(announce): can destroy a note and add at the same date 2023-11-08 18:23:16 +01:00
Colin Darie
e4c37758d4
feat(announces): anyone can read announces 2023-11-08 18:22:14 +01:00
Colin Darie
ff8ed6016e
feat(announce): super admin can create announce 2023-11-08 18:22:11 +01:00
simon lehericey
8c0d2bb8cb refactor: add request_logs methods
it avoids having to change lograge.rb for adding an entry
2023-11-08 17:49:09 +01:00
krichtof
a6ea607e7a
Merge pull request #9566 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_children_management
Feature ouidou/admin creation delegation gestionnaire page children management
2023-11-08 15:13:10 +00:00
Lisa Durand
ac834b0c0a add confirmation page after publishing procedure for admin 2023-11-08 12:07:32 +01:00
Paul Chavard
a611852ebc
Merge pull request #9663 from tchak/legacy-browsers
feat(traitement): add browser information
2023-11-08 10:23:31 +00:00
Paul Chavard
d93c624164 feat(traitement): add browser information 2023-11-08 00:09:38 +01:00
Eric Leroy-Terquem
3e2e5a01f9 fix(test): update routing tests 2023-11-06 15:25:45 +01:00
Eric Leroy-Terquem
4d95f49c82 chore(conditions): update controllers and routes 2023-11-06 15:25:45 +01:00
Paul Chavard
99e22a8cbe log(graphql): log deprecated order argument usage 2023-11-02 15:01:34 +00:00
Paul Chavard
869d83dda9 feat(dossier): validate on change and revalidate on input 2023-10-31 17:52:00 +00:00
Christophe Robillard
ef4113f8f9 filter all demarches by departement 2023-10-27 14:15:03 +02:00
seb-by-ouidou
528c51cb5e feat: US4.3.9 children management 2023-10-26 10:46:18 +00:00
Paul Chavard
bd5356c9b6
Merge pull request #9565 from adullact/feature-ouidou/admin_creation_delegation_gestionnaire_page_group_gestionnaire_management
Feature ouidou/admin creation delegation gestionnaire page group gestionnaire management
2023-10-26 09:51:44 +00:00
Paul Chavard
33f5a553b6 fix(graphql): fix pagination with order desc 2023-10-26 10:52:18 +02:00
mfo
ebea269f79
Merge pull request #9420 from mfo/US/chorus-tile
amelioration(tuile.chorus): ETQ admin, je peux saisir le cadre budgetaire d'une demarche de subvention pour faciliter le rapprochement d'un export DS a un export Chorus
2023-10-24 12:57:26 +00:00
Colin Darie
befb875318
Merge pull request #9618 from tchak/fix-search-deleted-dossiers
fix(search): show a message if searching for deleted dossier
2023-10-19 08:37:06 +00:00
Martin
857c1f0c21 amelioration(ChorusComponent): ameliore le rendu de la tuile si celle ci n'est que partiellement rempli 2023-10-19 07:31:14 +02:00
Martin
ecb3909e99 chorus(autocomplete): autocomplete sur le centre de cout, domaine fonctionnel, referentiel de programmation 2023-10-19 07:14:27 +02:00
Martin
87f435d2d3 amelioration(procedure.chorus): ajoute le form component pour le 'crud' du ChorusConfiguration 2023-10-19 07:14:27 +02:00
Martin
fea0cb1c60 amelioration(procedure.chorus): connecte la tuile a un controller basique ayant les ACL 2023-10-19 07:14:27 +02:00
Paul Chavard
71d5470100 fix(graphql): implement real cursor pagination 2023-10-18 13:01:07 +02:00
Paul Chavard
29980ab130 fix(search): show a message if searching for deleted dossier 2023-10-18 12:55:10 +02:00
seb-by-ouidou
3c5e76e705 feat: US4.3 update and delete groupe gestionnaire 2023-10-18 09:51:04 +02:00
seb-by-ouidou
ea7a5e6761 feat: US4.3.7.1 init manage gestionnaires of a group 2023-10-11 13:13:23 +00:00
seb-by-ouidou
d5637ac7aa feat: remove_gestionnaire 2023-10-11 09:38:42 +02:00
seb-by-ouidou
b100c8380e FEAT: init admins group 2023-10-11 09:38:42 +02:00
Christophe Robillard
ba56c79325 admin can't reactivate procedure if auto archive on past 2023-10-03 11:11:17 +02:00
krichtof
428ae4a45a
Merge pull request #9507 from demarches-simplifiees/9449-signature-groupe-instructeur
9449 ETQ instructeur ou admin, je peux apposer sur une attestation un tampon dédié à un groupe instructeur
2023-09-29 14:20:46 +00:00
Colin Darie
f942610d32
Merge pull request #9473 from demarches-simplifiees/create-export-page-V2-ldu
[Export] Créer une page d'export et sortir les liens des dropdowns
2023-09-28 17:15:31 +00:00
mfo
e1fe1188de
Merge pull request #9491 from mfo/US/better-error-summary
amelioration(usagers.dossiers.erreurs): ETQ usager, lorsque je soumets un dossier avec des erreurs, le format des erreurs est au format du DSFR
2023-09-28 17:01:09 +00:00
Martin
d8220395c8 amelioration(usagers.dossiers.erreurs): ETQ usager, lorsque je soumets un dossier avec des erreurs, le format des erreurs est au format du DSFR
Update app/components/dossiers/errors_full_messages.rb
Update app/components/dossiers/errors_full_messages/errors_full_messages.html.haml

Co-authored-by: Colin Darie <colin@darie.eu>
2023-09-28 17:50:47 +02:00
Colin Darie
2cec44109d
Merge pull request #9516 from colinux/fix-invalid-facultative-evaporation
ETQ usager je ne veux pas pouvoir saisir un nombre invalide sans feedback
2023-09-28 13:50:08 +00:00
Colin Darie
75bf30bed2
feat(champ-numbers): format value in input to a backend compatible value 2023-09-28 15:26:35 +02:00
mfo
00a6d02d21
fix(exports): block exports page to super admins so they can't download exports 2023-09-28 12:35:23 +02:00
Colin Darie
a867c9a998
feat(instructeurs): notification badge when a new export has been generated
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:13 +02:00
Colin Darie
edb030bb4c
refactor(exports): regenerating exports redirect (back) to exports page
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:11 +02:00
Colin Darie
82dd05c189
chore(exports): finders by groupe instructeurs compatible across exports components
Co-Authored-By: Lisa Durand <lisa.c.durand@gmail.com>
2023-09-28 12:35:07 +02:00
Lisa Durand
78802712f4
add controller specs 2023-09-28 12:35:06 +02:00
simon lehericey
a3a46d3bba spec: use match_array 2023-09-28 11:19:06 +02:00
Lisa Durand
a559bf54eb
Merge pull request #9517 from demarches-simplifiees/change-tabs-for-instructeur-dashboard-ldu
[instructeur] Mettre en avant les démarches closes avec des dossiers à traiter
2023-09-28 07:32:07 +00:00
Lisa Durand
a4c79e953b change 'published' tabs by 'en cours' to highlight closed procedure with 'en cours' files 2023-09-25 15:34:37 +02:00
Christophe Robillard
c02e6f2a77 feat(groupe-instructeur): instructeur can add signature in attestation 2023-09-22 10:24:16 +02:00
Christophe Robillard
c121a8b2dc admin can add groupe_instructeur signature 2023-09-22 10:24:16 +02:00
Christophe Robillard
5482863eea add signature to groupe_instructeur 2023-09-22 10:24:16 +02:00
seb-by-ouidou
d29bbf6d4f
Merge branch 'main' into feature-ouidou/existing_procedure_hidden_as_template 2023-09-21 15:53:38 +02:00
simon lehericey
4be682145c spec: speed up by 3 2023-09-20 14:11:10 +02:00
simon lehericey
4a17dec87b refactor procedure_controller 2023-09-20 14:11:10 +02:00
simon lehericey
40a15b9be4 refactor dossier_controller 2023-09-20 14:11:10 +02:00
simon lehericey
118242dbd2 refactor api_controller 2023-09-20 14:11:09 +02:00
simon lehericey
c7afad2a88 refacto: spec 2023-09-20 14:11:09 +02:00
seb-by-ouidou
0d2cd0fe5d feat(procedure): hide as template 2023-09-19 11:21:27 +00:00
LeSim
e6f8400cfd
Merge pull request #9477 from demarches-simplifiees/can-route-from-epci-champ
ETQ admin je peux router par département depuis le champ EPCI
2023-09-19 08:21:26 +00:00
Martin
aa10f23b43 correctif(expert.invite-autre-expert): ETQ expert, je ne pouvais pas demander d'autres avis d'expert 2023-09-18 16:23:42 +02:00
Eric Leroy-Terquem
67703c94e7 test(routing): test simple routing with epci type de champ 2023-09-18 09:32:07 +02:00
Paul Chavard
21b9a491cb fix(graphql): improuve sort for pending deleted dossiers 2023-09-15 16:15:43 +02:00
Eric Leroy-Terquem
ccc932f924 test(routing): test simple routing with communes type de champ 2023-09-13 10:45:21 +02:00
Eric Leroy-Terquem
cebeffb195 test(routing): test simple routing with regions type de champ 2023-09-13 10:22:01 +02:00
krichtof
5aabce488b
Merge pull request #9425 from demarches-simplifiees/9356-service-gi
ETQ Usager, je veux voir dans mon dossier les informations de contact de mon groupe instructeur
2023-09-11 07:38:34 +00:00
Christophe Robillard
5b9fbf40ed fix: admin is redirected to admin groupe instructeur page
after creating or editing groupe instructeur service
2023-09-11 08:58:04 +02:00
Christophe Robillard
e9ff4292fa instructeur can destroy groupe instructeur service 2023-09-11 08:58:04 +02:00
Christophe Robillard
41b2c9355b instructeur can update contact information for groupe instructeur 2023-09-11 08:58:04 +02:00
Christophe Robillard
ba0d3fa678 instructeur can create contact information for groupe instructeur 2023-09-11 08:58:03 +02:00
simon lehericey
894b91ed52 spec: fix due to activestorage bump 2023-09-07 15:57:39 +02:00
simon lehericey
d319385d17 Add tests for prefill identity 2023-09-07 10:17:19 +02:00
Eric Leroy-Terquem
6f7aaef132 test(routing): test routing controller with not_eq operator 2023-09-05 15:59:11 +02:00
Eric Leroy-Terquem
d0da808325 feat(routing): can add a routing rule with not_eq operator 2023-09-05 15:57:31 +02:00
Christian Lautier
db278e83ed add a constant for the most used test password 2023-08-31 13:40:05 +02:00
LeSim
3e193675aa
Merge pull request #9392 from demarches-simplifiees/move-groupe-instructeur-validation-to-model
Tech : déplace une validation sur le groupe d'instructeurs défaut du controleur au modèle
2023-08-31 09:45:03 +00:00
Eric Leroy-Terquem
9978908195 fix(dossier): exclude brouillons from recherche 2023-08-30 14:12:19 +02:00
Martin
4974962abd amelioration(instructeur.connexion): ETQ instructeur, je peux redemander un lien de connexion securisé 2023-08-30 13:40:51 +02:00
Eric Leroy-Terquem
b1c28e1818 test(routing): test simple routing with departements type de champ 2023-08-29 15:50:42 +02:00
Eric Leroy-Terquem
fc2c196cfa chore(groupe instructeur): move closed validation for defaut groupe to model 2023-08-21 16:31:54 +02:00
mfo
28de1a7453
Merge pull request #9396 from tchak/remove-piepdrive
chore(pipedrive): remove pipedrive
2023-08-14 09:26:50 +00:00
Martin
425d8867be amelioration(bulk_messages): ETQ instructeur, je peux envoyer un message aux usagers ayant un dossier en brouillon 2023-08-14 10:17:23 +02:00
Paul Chavard
ca4066939c chore(pipedrive): remove pipedrive 2023-08-10 10:29:25 +02:00
Christian Lautier
5ce42afe28 Fix datetime_champ validation with negative time zone 2023-08-02 14:40:47 +02:00
Paul Chavard
0ca72492e3 feat(graphql): use camelize with inflection 2023-08-01 14:55:08 +02:00
Paul Chavard
e28e31c23a fix: update spec with correct locales 2023-07-27 10:08:30 +02:00
Christophe Robillard
ef7b0c7377 alert admin with procedures without service 2023-07-27 10:08:30 +02:00
Christophe Robillard
beaf5751bb alert admin with service without siret 2023-07-27 10:08:30 +02:00
Paul Chavard
03da5725d4
Merge pull request #9310 from demarches-simplifiees/feat-graphql-dossier-corrections
API graphql: expose les demandes de corrections
2023-07-21 22:00:42 +00:00
Colin Darie
caf41a82e6 feat(graphql): can flag pending correction with "dossier envoyer message"
Co-authored-by: Paul Chavard <github@paul.chavard.net>
2023-07-21 16:45:47 +02:00
Colin Darie
5998cfe31f refactor(correction): rename kind => reason with default correction => incorrect 2023-07-21 16:45:47 +02:00
Christophe Robillard
20d0585e31 rend plus actionnable message d'erreur 2023-07-19 18:16:04 +02:00
Eric Leroy-Terquem
e8e9857dda style(reaffectation): apply dsfr to buttons 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
0e58e10b82 refactor(DossierAssignment): move create_assignment to assign_to_groupe_instructeur 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
96d17d03ec feat(DossierAssignment): create assignments when admin reaffect all dossiers 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
082db0ed02 feat(DossierAssignment): create Assignment when admin reaffect dossiers 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
f619fdfb19 feat(DossierAssignment): add reaffectations to presonnes impliquees view 2023-07-18 16:54:00 +02:00
Eric Leroy-Terquem
ac2043e920 feat(DossierAssignment): create assignment when manual assignment by instructeur 2023-07-18 16:54:00 +02:00
Martin
ce9dbed663 amelioration(NotificationMailer): sort la creation des commentaire sur la messagerie du mailer [trop de prob possible sinon: au retry on dupliquait les commenaitres, si le mail foirait, on commentait pas etc...] 2023-07-11 15:11:40 +02:00
Colin Darie
6ce8428ac6
feat(sva): instructeur can flag a dossier as incomplete 2023-07-11 10:01:48 +02:00
Colin Darie
30df476791
fix(sva): ensure "en construction" + "en instruction" notifications when submitting at submission
Pour le moment on conserve les 2 emails car l'email en construction
contient des informations spécifiques :
- l'attestation de dépôt
- potentiellement un contenu spécifique car il provient d'un template

Même remarque pour les démarches déclaratives.
2023-07-11 10:01:47 +02:00
Colin Darie
afe373c6b4
feat(sva): transition to en_instruction when (re-)submitting a dossier 2023-07-11 10:01:46 +02:00
Eric Leroy-Terquem
f959450477
Merge pull request #9244 from demarches-simplifiees/refactor-routing-update
Tech : mise à jour du routage sans callback
2023-07-04 09:39:00 +00:00
Eric Leroy-Terquem
0c3426228f feat(routing): to_configure include invalid_rule and non_unic_rule 2023-07-04 10:04:35 +02:00
Eric Leroy-Terquem
7598b0a513 remove previous routing sytem code 2023-07-03 14:58:45 +02:00
Eric Leroy-Terquem
a2c636d784 fix(tests): create groupe instructeurs with factory 2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
d6fea4ed95 refactor(routing): toggle routing when custom routing 2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
520050933e refactor(routing): toggle routing when simple routing 2023-07-03 14:47:56 +02:00
Eric Leroy-Terquem
97949fc168 fix(typo) adresse électronique 2023-06-28 10:24:37 +02:00
Eric Leroy-Terquem
3f55c71bc8
Merge pull request #8658 from E-L-T/notify-instructeur-when-added-or-removed-from-api
feat(API): notify instructeurs when added or removed from procedure
2023-06-26 09:37:15 +00:00
Paul Chavard
e509ff1717 fix(dossier): do not send notifcations to deleted users 2023-06-21 09:52:38 +01:00
Eric Leroy-Terquem
18054fe346 feat(routing): add view for dossier a reaffecter 2023-06-15 14:34:02 +02:00
Eric Leroy-Terquem
e7e702a574 feat(routing): add reaffecter_un_dossier 2023-06-15 14:34:01 +02:00
Paul Chavard
c1afc985e4 fix(prefill): allow private annotations prefill 2023-06-15 10:07:25 +01:00
Paul Chavard
10524643fb fix(hack): fix and test hack for procedures using groupe instructeur api 2023-06-14 19:24:58 +01:00
Colin Darie
f675d2d1a7
Merge pull request #9196 from colinux/fix-admin-publication-errors
ETQ admin je veux voir les erreurs lorsque la (re-)publication échoue
2023-06-14 09:56:46 +00:00
Paul Chavard
b3aeb46c1b fix(prefill): it should be possible to prefill a dossier on a test procedure 2023-06-14 09:14:12 +01:00
Colin Darie
889940af2a fix(administrateur): renders errors when publication fails 2023-06-13 19:11:59 +02:00
Eric Leroy-Terquem
0164b5f008 fix tests after typos corrections 2023-06-12 15:13:25 +02:00
simon lehericey
44859b8217 fix(user dossiers index): do not crash with a deleted dossier and a discarded procedure 2023-06-12 13:57:28 +02:00
Paul Chavard
c4432b1b47 perf(carto): use json schema to validate geojson instead of rgeo 2023-06-06 15:43:56 +02:00
Colin Darie
52c8553576
fix(dossier_correction): don't allow to save with a missing (invalid) commentaire 2023-06-02 16:18:33 +02:00
Colin Darie
734d88d80d
fix(pending-correction): wording alignement 2023-06-02 16:16:14 +02:00
Colin Darie
a32014d4fd
feat(correction): user can mark dossier en_construction as resolved 2023-06-02 16:16:14 +02:00
Colin Darie
8839ac7f76
fix(instructeur): pending_correction flag does not make messagerie unseen 2023-06-02 16:16:14 +02:00
Colin Darie
5ab44fc7a9
chore: rename dossier_resolution => dossier_correction 2023-06-02 16:16:14 +02:00
Colin Darie
9565267170
feat(dossier): notify user by email about pending corrections 2023-06-02 16:16:13 +02:00
Colin Darie
ca3b127942
feat(instructeur): can flag a dossier as "pending corrections" 2023-06-02 16:16:12 +02:00
mfo
c2f2b4ef2a
Merge pull request #9106 from mfo/api-entreprise.etablissement_adapter
API Entreprise: migration "Etablissement"
2023-06-01 11:45:47 +00:00
mfo
1a6dc10548
Merge pull request #9102 from demarches-simplifiees/8472-migrate-rna
API Entreprise: migration RNA (associations)
2023-06-01 11:37:57 +00:00
Martin
c90175f121 tech(api-entreprise.etablissement): passage du endpoint ETABLISSEMENT_RESOURCE_NAME en v3 2023-06-01 09:06:36 +02:00
Martin
0d3deb01be tech(rna_controller#show): corrige les specs et recupère uniquement les informations utilisé par l'app 2023-05-31 16:11:12 +02:00
Eric Leroy-Terquem
50abf496fd add warning in gi pages in rule does not match tdc 2023-05-31 11:38:16 +02:00
Eric Leroy-Terquem
6e88c49470 remove old logic test 2023-05-31 11:38:16 +02:00
simon lehericey
97aac5d588 update tests for rules based routing 2023-05-31 11:38:16 +02:00
simon lehericey
142ac9173d add groupes_search_component 2023-05-31 11:38:16 +02:00
Christophe Robillard
ba281d53cf migrate entreprise adapter to v3 2023-05-26 13:37:20 +02:00
Paul Chavard
c06a4113b3 fix(graphql): gracefully handle change state errors 2023-05-24 12:04:04 +02:00
Paul Chavard
bca08c8e6c feat(graphql): expose user connection type 2023-05-23 18:18:21 +02:00
Martin
0213ad018a bug(expert/avis#index): ETQ expert, je veux retrouver mes avis donnés sur des dossiers traités 2023-05-23 09:34:30 +02:00
Martin
af19bbe8f5 correctif(users/dossiers/brouillon#submit): ETQ usager, je souhaite que chaque lien pointant vers une erreur de champ m'oriente sur le champ 2023-05-20 08:27:55 +02:00
Paul Chavard
a2e98f9065
Merge pull request #9051 from demarches-simplifiees/fix-bug-procedure-clone-validations
[fix] Vider les champs invalides pour permettre de cloner une procedure
2023-05-17 07:44:39 +00:00
Lisa Durand
7e39e8113b feedback PR Colin 2023-05-16 17:54:37 +02:00
Lisa Durand
f2cf3188d7 empty invalid fields to allow clone procedure 2023-05-16 10:59:17 +02:00
Colin Darie
493e8dc9de
Merge pull request #9036 from colinux/fix-fork-ui
ETQ Usager: correctifs pour les modifications en construction
2023-05-15 11:38:01 +00:00
Colin Darie
059dabb5ac fix(fork): don't fail when user submit twice en_construction (from 2 tabs) 2023-05-15 13:08:42 +02:00
simon lehericey
35866cf860 fix graphql_stored_queries_spec 2023-05-11 16:56:56 +02:00
Colin Darie
b626714610
fix(dossier): submit en_construction render views in error with dossier origin 2023-05-09 18:49:53 +02:00
Paul Chavard
08a2a2c9aa
feat(dossier): fork dossier when editing en construction 2023-05-09 17:16:47 +02:00
mfo
2374ced5d2
Merge pull request #8987 from mfo/US/link-to-errored-champs
amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement
2023-05-09 07:06:36 +00:00
Colin Darie
ae88c1de6b
fix(devise): default config for devise and turbo stream as navigational format 2023-05-03 11:35:32 +02:00
Colin Darie
61ebb27e86
fix(redirect): allow other hosts when required 2023-05-03 11:35:31 +02:00
Nicolas Cavigneaux
7e0fbcf672
fix: ensure procedure used in remove_instructeur spec has routing_enabled set to true 2023-05-03 11:35:29 +02:00
Martin
c8ab1e8e03 amelioration(dossier#submit_brouillon): ETQ usager, je souhaite pouvoir acceder aux champs en erreur facilement 2023-05-03 07:36:42 +02:00
Paul Chavard
99abdf45e7 fix(api-entreprise): use new status endpoint 2023-04-27 22:39:44 +02:00
Paul Chavard
cb752d1857 fix(dossier): do not bypass depositaire check on modifier path 2023-04-27 09:52:10 +02:00
LeSim
4c5e903673
Merge pull request #8887 from demarches-simplifiees/8839-filter-by-siret
Filtrer les démarches par service
2023-04-26 19:44:08 +00:00
Martin
6a2d2ae0a7 bug(instructeurs/avis_controller#remind): ETQ instructeur, je peux relancer une demande d'avis meme si celui ci contient une question 2023-04-26 07:46:21 +02:00
Lisa Durand
26ff82dbe4 Merge branch 'main' of github.com:betagouv/demarches-simplifiees.fr into user-dashboard/add-alert-WIP-last-dossier 2023-04-25 13:01:40 +02:00
Martin
6739bfc665 bug(instructeurs.annotations): ETQ instructeurs, lorsque je saisie une autre valeur dans un champ de type choix simple, celle ci n'est pas sauvegardé 2023-04-21 09:35:16 +02:00
Paul Chavard
586286cb08
Merge pull request #8916 from demarches-simplifiees/can-update-defaut-groupe-instructeur-2
feat(routage): permet de changer le groupe par défaut
2023-04-20 08:28:46 +00:00
Paul Chavard
418d3b55d0 feat(stats): give access to stats on closed procedures 2023-04-19 18:31:58 +02:00
Colin Darie
9728493bda
Merge pull request #8924 from colinux/rubocop-upgrades
Tech: update rubocop, active nouveaux cops Rails/*
2023-04-19 13:37:10 +00:00
Eric Leroy-Terquem
aecd7559d2 feat(groupe instructeur): cannot disable default groupe instructeur 2023-04-19 13:52:42 +02:00
Eric Leroy-Terquem
09b05550ab feat(groupe instructeur): cannot delete defaut_groupe_instructeur 2023-04-19 13:52:42 +02:00
simon lehericey
b38470368b feat(routing): can change defaut groupe 2023-04-19 13:52:41 +02:00
Colin Darie
999f06075b
chore(rubocop): fix Rails/ResponseParsedBody 2023-04-19 12:55:13 +02:00
Colin Darie
b273e7b67e
chore(rubocop): fix Rails/RootPathnameMethods and assimiled cops 2023-04-19 12:55:13 +02:00
Paul Chavard
05cfb4055d fix(dossier): improuve dossier state display 2023-04-19 12:27:16 +02:00
github-merge-queue[bot]
a286af8a70
Merge pull request #8918 from tchak/graphql-add-error-codes
ETQ intégrateur API, je voudrais avoir des codes d'erreur plus précis
2023-04-19 09:00:32 +00:00
Paul Chavard
ae1ec87397 feat(graphql): add code to timeout errors 2023-04-18 15:22:11 +02:00
Paul Chavard
f70532a844 feat(graphql): global not found error handling 2023-04-18 15:22:11 +02:00
Paul Chavard
fbae6d941d feat(graphql): add error codes to graphql errors 2023-04-18 15:22:11 +02:00
Lisa Durand
c565ed415b change scope and alert location after UI modification 2023-04-18 12:03:10 +02:00
Paul Chavard
bf6cc25063 feat(graphql): expose pendingDeletedDossiers on groupe instructeur 2023-04-17 18:43:00 +02:00
LeSim
c252748833
Merge pull request #8836 from demarches-simplifiees/improve-routing-rules-ux
feat(routing): nicer and safer ?
2023-04-17 08:23:15 +00:00
Paul Chavard
5abb6a8f12 chore(spec): remove memory store cache from tests 2023-04-13 13:10:23 +02:00
simon lehericey
c02319aa56 feat(routing): reset value if target as changed 2023-04-13 10:28:53 +02:00
simon lehericey
8b832396a3 feat(routing): server side: prevent changing tdc type if used for routing 2023-04-13 10:28:52 +02:00
simon lehericey
c1f67499aa feat(routing): server side: prevent tdc deletion if used for routing 2023-04-13 10:28:52 +02:00
krichtof
78938b5a07 filter demarches by siret service 2023-04-12 18:53:57 +02:00
Lisa Durand
bc3e67ab94 add alert on user dashboard to edit last editable dossier 2023-04-11 15:50:17 +02:00
Paul Chavard
0b95a912c6
Merge pull request #8858 from tchak/feat-refactor-dossier-link-champ
feat(dossier): use turbo to select linked dossier
2023-04-07 08:49:11 +00:00
Paul Chavard
a2f7d1df72 fix(graphql): pendingDeletedSince should not crash 2023-04-06 15:07:48 +02:00
Paul Chavard
a5733002ed feat(graphql): improuve logs 2023-04-05 13:56:26 +02:00
Paul Chavard
52c8b0b297 feat(dossier): use turbo to select linked dossier 2023-04-05 11:40:03 +02:00
Paul Chavard
dee0952b2a fix(graphql): demandeur personne morale can be in degraded mode 2023-04-05 11:20:18 +02:00
Paul Chavard
a778e1083b fix(graphql): return better errors when dossiers cannot change state 2023-04-04 17:24:30 +02:00
Paul Chavard
2a48228552 fix(dossier): improuve commune champ rendering in pdf 2023-04-04 16:01:16 +02:00
Paul Chavard
12f0c03bac
Merge pull request #8847 from tchak/feat-improuve-dossier-remove
fix(dossier): an invited user can remove (leave) a dossier
2023-04-04 13:10:18 +00:00
Paul Chavard
0864666d0a fix(dossier): an invited user can remove (leave) a dossier 2023-04-03 20:10:44 +02:00
Paul Chavard
fce78bbf30 feat(dossier): multiselect without react 2023-04-03 16:54:50 +02:00
simon lehericey
b93e3776c4 feat(routing): add controller 2023-03-30 10:51:20 +02:00
mfo
60d41029de
Merge pull request #8817 from mfo/US/fix-expert-export
correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis
2023-03-29 12:00:14 +00:00
Martin
c6e9674de2 correctif(export.pdf): ETQ expert, lorsque j'exporte un dossier au format PDF, celui ci contenient les avis non confidentiels ainsi que mes avis 2023-03-28 17:16:34 +02:00
Martin
4f9c45c489 bug(export.pdf): ETQ expert, lorsque j'exporte un dossier, celui ci devrait contenir les avis non confidentiels ainsi que mes avis 2023-03-28 16:55:12 +02:00
Kara Diaby
4a13c64b38 tests 2023-03-27 14:14:18 +02:00
Lisa Durand
d079f3ac98
Merge pull request #8770 from demarches-simplifiees/ask-question-in-avis-ux-part
[UX] améliorer UX de la demande d'avis
2023-03-24 10:50:33 +00:00
Paul Chavard
275150d727 feat(graphql): expose pendingDeletedDossiers
fix #8785
2023-03-22 19:40:43 +01:00
Lisa Durand
4a2982dc37 fix tests and linter 2023-03-22 09:30:26 +01:00
Colin Darie
954652fcf5
fix(champ): may fix pg deadlocks: autosave already saves value at the same time 2023-03-20 14:32:14 +01:00
Lisa Durand
ee2f795dec pr feedbacks - add validation for yes/no answer - improve locales use 2023-03-16 11:32:05 +01:00
Lisa Durand
eddd7a2192 add flash alert if email field empty 2023-03-16 11:32:05 +01:00
Lisa Durand
01afa998b6 add specs 2023-03-16 11:32:05 +01:00
Paul Chavard
8ee13f1719 feat(api_token): add allowed_procedure_ids and write_access 2023-03-15 19:09:49 +01:00
Paul Chavard
cbaa77fca7 feat(annotations): activate autosave 2023-03-14 15:22:13 +01:00
Lisa Durand
6ba47b731b refacto destroy action and add spec for unauthorized user 2023-03-09 14:58:47 +01:00
Lisa Durand
3d5bf40c0f allow transfer sender to revoke a transfer 2023-03-09 14:57:59 +01:00
Eric Leroy-Terquem
72b6dacfbd fix(API): remove notification to group when instructeurs removed 2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
a150aa33ef feat(GroupeInstructeurSupprimerInstructeurs): add notification for removed instructeurs via API 2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
ac0d7a67a1 feat(GroupeInstructeurAjouterInstructeurs): add notification for added instructeurs via API 2023-03-08 11:59:58 +01:00
Eric Leroy-Terquem
b2f3a7af4c feat(GroupeInstructeurSupprimerInstructeurs): enable emailing for unrouted procedures 2023-03-08 11:59:55 +01:00
Eric Leroy-Terquem
9e0753a710 fix(groupe instructeur mailer): do not notify if no added instructeurs 2023-03-08 11:03:33 +01:00
Eric Leroy-Terquem
f317f28ff5 test(groupe instructeurs): use right data (a routed procedure has at
least two active groups)
2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
e1906febcc feat(groupe instructeur): can enable routing from import 2023-03-08 10:48:02 +01:00
Eric Leroy-Terquem
9f0f5b0dc5 feat(groupe instructeur): allow import of many groups when procedure is not routed yet 2023-03-08 10:48:02 +01:00
Kara Diaby
4ea7bb2f1c tests 2023-03-03 11:50:47 +01:00
Damien Le Thiec
687c05e6d1
Merge pull request #8622 from demarches-simplifiees/fix/stored_query_issue
Dossier prefill get without stored queries
2023-03-02 14:01:04 +00:00
Lisa Durand
54f17ad3c7
Merge pull request #8630 from demarches-simplifiees/harmonize-actions-for-instructeurs
[instructeurs] Uniformiser les actions pour les instructeurs sur la page tableau et dossier
2023-03-02 13:28:23 +00:00
Damien Le Thiec
8a7cb3f1fe
Merge branch 'main' into fix/stored_query_issue 2023-03-01 10:22:40 +01:00
Damien Le Thiec
01f142183e Add and correct tests 2023-03-01 10:21:22 +01:00
Paul Chavard
d8ee4cb360 fix(test): dossiers_controller_spec 2023-02-28 17:28:17 +01:00
Paul Chavard
294a5135ce feat(public/api): add dossier state api 2023-02-28 16:35:25 +01:00
Colin Darie
7e13d58db2
Merge pull request #8703 from govpf/feature/fix-dossier-controller-spec
Fix dossier controller spec
2023-02-28 12:11:30 +00:00
krichtof
dee499d386
Merge pull request #8706 from demarches-simplifiees/all_demarches_even_without_zones
liste toutes les démarches, même celles non associées à des zones
2023-02-28 10:58:07 +00:00
Paul Chavard
7076d6d99e fix(turbo): rerender only top part of the header 2023-02-27 16:06:11 +01:00
sebastiencarceles
39545671f3 refacto: better error management 2023-02-27 14:35:11 +01:00
sebastiencarceles
33fa40eda2 don't clean the rna champ value
Cleaning the value is useless, when fetching the association,
as the value will be re-written by the dossier update, when the user
fills in the dossier.

Furthermore we need the value to persist when prefilling the champ.
2023-02-27 14:35:11 +01:00
Lisa Durand
636e6aa6cb fix broken tabs with turbostream 2023-02-27 14:30:10 +01:00
sebastiencarceles
becf4da70a fix raison social fetch 2023-02-27 13:54:35 +01:00
sebastiencarceles
30eef3e128 review: detailled error message 2023-02-27 13:45:16 +01:00
Sébastien Carceles
df2eaa9542 don't clean the siret champ value
Cleaning the value is useless, when fetching the etablissement,
as the value will be re-written by the dossier update, when the user
fills in the dossier.
2023-02-27 13:45:16 +01:00
Damien Le Thiec
67bbacbb05
Merge pull request #8513 from demarches-simplifiees/feature/prefill_repetible
Prefill repeatable
2023-02-27 09:58:53 +00:00
Christian Lautier
704dbf94db Fix dossier controller spec 2023-02-25 08:32:21 -10:00
Lisa Durand
6487e2c27e implement turbostream back for state change in dossier view 2023-02-24 17:54:53 +01:00
Christophe Robillard
1d6c2fd7eb display procedures without zones 2023-02-24 17:27:28 +01:00
Eric Leroy-Terquem
4ea1d7d33b feat(groupe instructeurs import): notify added instructeurs 2023-02-23 10:56:55 +01:00
Eric Leroy-Terquem
a6e01d98ea feat(instructeurs import): notify added instructeurs 2023-02-23 10:56:55 +01:00