DGNum/demarches-normaliennes
13
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

france_connect: fix for params entirely missing from the callback

Browse source 
Fix a Sentry exception encountered in production.
This commit is contained in:
Pierre de La Morinerie 2019-05-09 13:54:50 +02:00
parent d7828e9a1e
commit f5f7dfba40
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
app/controllers/france_connect/particulier_controller.rb
View file

@ -30,7 +30,7 @@ class FranceConnect::ParticulierController < ApplicationController
private private
def redirect_to_login_if_fc_aborted def redirect_to_login_if_fc_aborted
if params[:code].empty? if params[:code].blank?
redirect_to new_user_session_path redirect_to new_user_session_path
end end
end end

6
spec/controllers/france_connect/particulier_controller_spec.rb
View file

@ -25,6 +25,12 @@ describe FranceConnect::ParticulierController, type: :controller do
subject { get :callback, params: { code: code } } subject { get :callback, params: { code: code } }
context 'when params are missing' do
subject { get :callback }
it { is_expected.to redirect_to(new_user_session_path) }
end
context 'when param code is missing' do context 'when param code is missing' do
let(:code) { nil } let(:code) { nil }