DGNum/demarches-normaliennes
15
1
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity

redirect to same path after use signup (#3849)

Browse source 
La page d'inscription résiste mieux à la possibilité de vérifier si une adresse email est déjà enregistrée comme compte
This commit is contained in:
Pierre de La Morinerie 2019-05-13 15:44:24 +02:00 committed by GitHub
commit d7828e9a1e
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
2 changed files with 15 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/controllers/users/registrations_controller.rb
View file

@ -26,12 +26,10 @@ class Users::RegistrationsController < Devise::RegistrationsController
if existing_user.present?
if existing_user.confirmed?
UserMailer.new_account_warning(existing_user).deliver_later
flash.notice = t('devise.registrations.signed_up_but_unconfirmed')
return redirect_to root_path
else
existing_user.resend_confirmation_instructions
return redirect_to after_inactive_sign_up_path_for(existing_user)
end
return redirect_to after_inactive_sign_up_path_for(existing_user)
end
super

19
spec/controllers/users/registrations_controller_spec.rb
View file

@ -74,9 +74,13 @@ describe Users::RegistrationsController, type: :controller do
before { subject }
it { expect(response).to redirect_to(root_path) }
it { expect(flash.notice).to eq(I18n.t('devise.registrations.signed_up_but_unconfirmed')) }
it { expect(UserMailer).to have_received(:new_account_warning) }
it 'sends an email to the user, stating that the account already exists' do
expect(UserMailer).to have_received(:new_account_warning)
end
it 'avoids leaking information about the account existence, by redirecting to the same page than normal signup' do
expect(response).to redirect_to(new_user_confirmation_path(user: { email: user[:email] }))
end
end
context 'and the user is not confirmed' do
@ -87,8 +91,13 @@ describe Users::RegistrationsController, type: :controller do
subject
end
it { expect(response).to redirect_to(new_user_confirmation_path(user: { email: user[:email] })) }
it { expect(UserMailer).not_to have_received(:new_account_warning) }
it 'does not send a warning email' do
expect(UserMailer).not_to have_received(:new_account_warning)
end
it 'avoids leaking information about the account existence, by redirecting to the same page than normal signup' do
expect(response).to redirect_to(new_user_confirmation_path(user: { email: user[:email] }))
end
end
end
end