specs: remove unused wait-for-ajax helper

This helper is:
- no longer used;
- buggy (not all requests increment it);
- discouraged (we should instead match an UI change that signals the end
of an ajax request).

Good riddance.
This commit is contained in:
Pierre de La Morinerie 2020-03-30 14:20:23 +00:00
parent 34dc554748
commit 7a27e78452
2 changed files with 1 additions and 23 deletions

View file

@ -62,7 +62,6 @@ export function ajax(options) {
} }
export function getJSON(url, data, method = 'get') { export function getJSON(url, data, method = 'get') {
incrementActiveRequestsCount();
data = method !== 'get' ? JSON.stringify(data) : data; data = method !== 'get' ? JSON.stringify(data) : data;
return Promise.resolve( return Promise.resolve(
$.ajax({ $.ajax({
@ -72,7 +71,7 @@ export function getJSON(url, data, method = 'get') {
contentType: 'application/json', contentType: 'application/json',
dataType: 'json' dataType: 'json'
}) })
).finally(decrementActiveRequestsCount); );
} }
export function scrollTo(container, scrollTo) { export function scrollTo(container, scrollTo) {
@ -115,15 +114,3 @@ export function timeoutable(promise, timeoutDelay) {
}); });
return Promise.race([promise, timeoutPromise]); return Promise.race([promise, timeoutPromise]);
} }
const DATA_ACTIVE_REQUESTS_COUNT = 'data-active-requests-count';
function incrementActiveRequestsCount() {
const count = document.body.getAttribute(DATA_ACTIVE_REQUESTS_COUNT) || '0';
document.body.setAttribute(DATA_ACTIVE_REQUESTS_COUNT, parseInt(count) + 1);
}
function decrementActiveRequestsCount() {
const count = document.body.getAttribute(DATA_ACTIVE_REQUESTS_COUNT) || '0';
document.body.setAttribute(DATA_ACTIVE_REQUESTS_COUNT, parseInt(count) - 1);
}

View file

@ -1,9 +0,0 @@
module WaitForAjax
def wait_for_ajax
expect(page).to have_selector('body[data-active-requests-count="0"]')
end
end
RSpec.configure do |config|
config.include WaitForAjax, type: :feature
end