fix(rubocop): Rails/FindEach

This commit is contained in:
Colin Darie 2024-02-05 11:20:55 +01:00
parent e85e026361
commit 0da2843f26
No known key found for this signature in database
GPG key ID: 8C76CADD40253590
6 changed files with 8 additions and 6 deletions

View file

@ -803,6 +803,8 @@ Rails/FindById:
Rails/FindEach: Rails/FindEach:
Enabled: true Enabled: true
Exclude:
- spec/**/*
Rails/FreezeTime: Rails/FreezeTime:
Enabled: true Enabled: true

View file

@ -6,6 +6,6 @@ class Cron::AdministrateurActivateBeforeExpirationJob < Cron::CronJob
.includes(:user) .includes(:user)
.inactive .inactive
.where(created_at: 3.days.ago.all_day) .where(created_at: 3.days.ago.all_day)
.each { |a| a.user.remind_invitation! } .find_each { |a| a.user.remind_invitation! }
end end
end end

View file

@ -1,6 +1,6 @@
class Migrations::BatchUpdateDatetimeValuesJob < ApplicationJob class Migrations::BatchUpdateDatetimeValuesJob < ApplicationJob
def perform(ids) def perform(ids)
Champs::DatetimeChamp.where(id: ids).each do |datetime_champ| Champs::DatetimeChamp.where(id: ids).find_each do |datetime_champ|
current_value_in_time = Time.zone.parse(datetime_champ.value) current_value_in_time = Time.zone.parse(datetime_champ.value)
if current_value_in_time.present? if current_value_in_time.present?

View file

@ -1,7 +1,7 @@
class BackfillProceduresZones < ActiveRecord::Migration[6.1] class BackfillProceduresZones < ActiveRecord::Migration[6.1]
def up def up
# rubocop:disable DS/Unscoped # rubocop:disable DS/Unscoped
Procedure.unscoped.each do |procedure| Procedure.unscoped.find_each do |procedure|
procedure.zones << procedure.zone if procedure.zone procedure.zones << procedure.zone if procedure.zone
end end
# rubocop:enable DS/Unscoped # rubocop:enable DS/Unscoped
@ -9,7 +9,7 @@ class BackfillProceduresZones < ActiveRecord::Migration[6.1]
def down def down
# rubocop:disable DS/Unscoped # rubocop:disable DS/Unscoped
Procedure.unscoped.each do |procedure| Procedure.unscoped.find_each do |procedure|
procedure.zones.destroy_all procedure.zones.destroy_all
end end
# rubocop:enable DS/Unscoped # rubocop:enable DS/Unscoped

View file

@ -20,7 +20,7 @@ namespace :after_party do
user.reload user.reload
# rubocop:enable DS/Unscoped # rubocop:enable DS/Unscoped
# rubocop:enable Rails/PluckInWhere # rubocop:enable Rails/PluckInWhere
Avis.where(claimant: instructeur).each do |avis| Avis.where(claimant: instructeur).find_each do |avis|
experts_procedure = ExpertsProcedure.find_or_create_by(expert: user.expert, procedure: avis.procedure) experts_procedure = ExpertsProcedure.find_or_create_by(expert: user.expert, procedure: avis.procedure)
avis.update_column(:experts_procedure_id, experts_procedure.id) avis.update_column(:experts_procedure_id, experts_procedure.id)
end end

View file

@ -28,7 +28,7 @@ namespace :support do
fail "Must specify a USER_EMAIL" if user_email.nil? fail "Must specify a USER_EMAIL" if user_email.nil?
administrateur = Administrateur.joins(:user).where(user: { email: user_email }).first administrateur = Administrateur.joins(:user).where(user: { email: user_email }).first
AdministrateursProcedure.where(administrateur: administrateur).each do |administrateur_procedure| AdministrateursProcedure.where(administrateur: administrateur).find_each do |administrateur_procedure|
procedure = administrateur_procedure.procedure procedure = administrateur_procedure.procedure
if procedure.administrateurs.count > 1 if procedure.administrateurs.count > 1
begin begin