From 0da2843f2611dd2a7d9583c4878536f75ca9b3a4 Mon Sep 17 00:00:00 2001
From: Colin Darie <colin@darie.eu>
Date: Mon, 5 Feb 2024 11:20:55 +0100
Subject: [PATCH] fix(rubocop): Rails/FindEach

---
 .rubocop.yml                                                  | 2 ++
 .../cron/administrateur_activate_before_expiration_job.rb     | 2 +-
 app/jobs/migrations/batch_update_datetime_values_job.rb       | 2 +-
 db/migrate/20221006193737_backfill_procedures_zones.rb        | 4 ++--
 ...118142539_backfill_experts_procedure_id_on_avis_table.rake | 2 +-
 lib/tasks/support.rake                                        | 2 +-
 6 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/.rubocop.yml b/.rubocop.yml
index a999a79d2..40984b5dc 100644
--- a/.rubocop.yml
+++ b/.rubocop.yml
@@ -803,6 +803,8 @@ Rails/FindById:
 
 Rails/FindEach:
   Enabled: true
+  Exclude:
+    - spec/**/*
 
 Rails/FreezeTime:
   Enabled: true
diff --git a/app/jobs/cron/administrateur_activate_before_expiration_job.rb b/app/jobs/cron/administrateur_activate_before_expiration_job.rb
index 4c5c518e8..0c5779e16 100644
--- a/app/jobs/cron/administrateur_activate_before_expiration_job.rb
+++ b/app/jobs/cron/administrateur_activate_before_expiration_job.rb
@@ -6,6 +6,6 @@ class Cron::AdministrateurActivateBeforeExpirationJob < Cron::CronJob
       .includes(:user)
       .inactive
       .where(created_at: 3.days.ago.all_day)
-      .each { |a| a.user.remind_invitation! }
+      .find_each { |a| a.user.remind_invitation! }
   end
 end
diff --git a/app/jobs/migrations/batch_update_datetime_values_job.rb b/app/jobs/migrations/batch_update_datetime_values_job.rb
index 3818a3b58..5ef4207aa 100644
--- a/app/jobs/migrations/batch_update_datetime_values_job.rb
+++ b/app/jobs/migrations/batch_update_datetime_values_job.rb
@@ -1,6 +1,6 @@
 class Migrations::BatchUpdateDatetimeValuesJob < ApplicationJob
   def perform(ids)
-    Champs::DatetimeChamp.where(id: ids).each do |datetime_champ|
+    Champs::DatetimeChamp.where(id: ids).find_each do |datetime_champ|
       current_value_in_time = Time.zone.parse(datetime_champ.value)
 
       if current_value_in_time.present?
diff --git a/db/migrate/20221006193737_backfill_procedures_zones.rb b/db/migrate/20221006193737_backfill_procedures_zones.rb
index 9564cb51b..fbb2987fb 100644
--- a/db/migrate/20221006193737_backfill_procedures_zones.rb
+++ b/db/migrate/20221006193737_backfill_procedures_zones.rb
@@ -1,7 +1,7 @@
 class BackfillProceduresZones < ActiveRecord::Migration[6.1]
   def up
     # rubocop:disable DS/Unscoped
-    Procedure.unscoped.each do |procedure|
+    Procedure.unscoped.find_each do |procedure|
       procedure.zones << procedure.zone if procedure.zone
     end
     # rubocop:enable DS/Unscoped
@@ -9,7 +9,7 @@ class BackfillProceduresZones < ActiveRecord::Migration[6.1]
 
   def down
     # rubocop:disable DS/Unscoped
-    Procedure.unscoped.each do |procedure|
+    Procedure.unscoped.find_each do |procedure|
       procedure.zones.destroy_all
     end
     # rubocop:enable DS/Unscoped
diff --git a/lib/tasks/deployment/20210118142539_backfill_experts_procedure_id_on_avis_table.rake b/lib/tasks/deployment/20210118142539_backfill_experts_procedure_id_on_avis_table.rake
index 8d33500f3..281c4bb04 100644
--- a/lib/tasks/deployment/20210118142539_backfill_experts_procedure_id_on_avis_table.rake
+++ b/lib/tasks/deployment/20210118142539_backfill_experts_procedure_id_on_avis_table.rake
@@ -20,7 +20,7 @@ namespace :after_party do
       user.reload
       # rubocop:enable DS/Unscoped
       # rubocop:enable Rails/PluckInWhere
-      Avis.where(claimant: instructeur).each do |avis|
+      Avis.where(claimant: instructeur).find_each do |avis|
         experts_procedure = ExpertsProcedure.find_or_create_by(expert: user.expert, procedure: avis.procedure)
         avis.update_column(:experts_procedure_id, experts_procedure.id)
       end
diff --git a/lib/tasks/support.rake b/lib/tasks/support.rake
index add80e5d5..ff712c1cf 100644
--- a/lib/tasks/support.rake
+++ b/lib/tasks/support.rake
@@ -28,7 +28,7 @@ namespace :support do
     fail "Must specify a USER_EMAIL" if user_email.nil?
 
     administrateur = Administrateur.joins(:user).where(user: { email: user_email }).first
-    AdministrateursProcedure.where(administrateur: administrateur).each do |administrateur_procedure|
+    AdministrateursProcedure.where(administrateur: administrateur).find_each do |administrateur_procedure|
       procedure = administrateur_procedure.procedure
       if procedure.administrateurs.count > 1
         begin